Re: [musl] [PATCH 1/2] V3 resubmitting old statx patch with changes

[Rich Felker <dalias@libc.org>]

On Sun, Apr 28, 2024 at 12:13:56PM -0400, Rich Felker wrote:
> On Sat, Apr 27, 2024 at 10:29:35PM -0400, lolzery wowzery wrote:
> > 4. Zero all extraneous fields like __pad1 for future proofing.
> 
> This is probably a good idea, but it should be done via
> zero-initializing the whole structure before filling it, not referring
> to those fields by name. The names are not a public or even
> libc-internal-private interface, but placeholders, and shouldn't be
> used.
> 
> > 5. The stx_rdev_major and stx_rdev_minor fields were not correctly filled in
> 
> Another thing I missed on the initial review. Thanks for catching it.
> 
> > Please do not make these 5 changes yourself yet as I might find more and
> > I have some great comments I want to add to explain why things are.
> 
> If you'd like to submit the fixes, please do them as individual
> changes with commit messages that explain what was wrong and what
> specifically is being fixed, not a big combined "fix statx fallback"
> patch.

Ping. I'd like to get the uninitialized-field bugs fixed and ping
distros to backport those fixes quickly so that folks don't continue
generating binaries that would malfunction on older kernels.

I don't really care if these are separate fixes for missing rdev,
attrs, and padding, or a combined "fix uninitialized output fields in
statx fallback" patch.

The other things in your mails are separate and can be discussed (if
there is anything wrong to begin with) without holding these
known-needed fixes up.

Rich