From: Rich Felker <dalias@libc.org>
To: lolzery wowzery <wowzeryest@gmail.com>
Cc: musl@lists.openwall.com, Duncan Bellamy <dunk@denkimushi.com>,
info@bnoordhuis.nl, tony.ambardar@gmail.co
Subject: Re: [musl] [PATCH 1/2] V3 resubmitting old statx patch with changes
Date: Sat, 27 Apr 2024 12:40:50 -0400 [thread overview]
Message-ID: <20240427164050.GA10433@brightrain.aerifal.cx> (raw)
In-Reply-To: <CADeg5Su-+k8SH3EFpwL4iJ5A-LAnckJeQ6Qgaw1azd4dujTqgA@mail.gmail.com>
On Wed, Apr 24, 2024 at 07:55:32PM -0400, lolzery wowzery wrote:
> Hi all! I'm new to git over email, new to musl, and I want to really
> get into contributing to musl. So, I'd really appreciate any
> tips/comments/info for a newbie like me!
>
> Please do not merge these changes yet. There's numerous problems with
> this code above and beyond the issues you pointed out, and each of
> those issues led me down successive rabbit holes all over the musl
> source code and I've ended up opening a sizable can of worms,
> including io race condition bugs in fallback conditions, symbol
> weakness problems, header/struct misorganization, and bugs in syscall
> support detection making musl silently/unexpectedly fail under certain
> seccomp configurations.
>
> Also, let me cite the earlier patch from tony.ambardar@gmail.com about
> renameat2. My patch will include a full proper renameat2
> implementation with validation and fallback and will compile on
> systems where SYS_renameat2 is undefined (using exclusively the
> fallback.)
>
> I recognize I probably sound like an over-eager-beaver fussing over
> fools-gold as I'm new and none of you know me. (That's the assumption
> I myself would make if a new guy showed up claiming to have lots of
> bug fixes and stuff.) So, please suspend your disbelief for a short
> while until I can give my full report and all fixes tomorrow for
> everyone to review. Give me a chance to prove my commitment to musl
> and watch as I uphold my pledge to maintain my areas of the code in
> musl and keep them ship-shape.
>
> Have a great day everyone and really looking forwards to sharing my
> full report tomorrow!,
Ping. Any updates?
next prev parent reply other threads:[~2024-04-27 16:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 12:12 [musl] [PATCH] add statx Ben Noordhuis
2020-01-24 8:38 ` [musl] " Ben Noordhuis
2020-01-24 14:01 ` Rich Felker
2020-01-28 8:59 ` Ben Noordhuis
2020-01-28 13:39 ` Rich Felker
2020-01-24 14:00 ` [musl] " Rich Felker
2020-01-24 15:27 ` Florian Weimer
2020-01-24 15:54 ` Rich Felker
2020-01-24 16:12 ` Florian Weimer
2020-01-24 16:29 ` Rich Felker
2020-01-28 10:41 ` Florian Weimer
2020-01-28 13:18 ` Rich Felker
2020-02-17 9:10 ` Florian Weimer
2020-02-17 15:29 ` Rich Felker
2022-08-27 14:57 ` [musl] [PATCH 0/1] " Duncan Bellamy
2022-08-27 14:57 ` [musl] [PATCH 1/1] resubmitting old statx patch with changes Duncan Bellamy
2022-08-27 18:10 ` Rich Felker
2022-08-27 23:11 ` Dunk
2022-08-27 23:11 ` [musl] [PATCH 0/2] V2 Duncan Bellamy
2022-08-27 23:11 ` [musl] [PATCH 1/2] V2 resubmitting old statx patch with changes Duncan Bellamy
2022-08-29 13:50 ` [musl] " Dunk
2022-08-27 23:11 ` [musl] [PATCH 2/2] V2 src/stat/fstatat.c use new statx define Duncan Bellamy
2022-08-31 19:07 ` [musl] [PATCH 0/2] V3 Duncan Bellamy
2022-08-31 19:07 ` [musl] [PATCH 1/2] V3 resubmitting old statx patch with changes Duncan Bellamy
2024-02-24 16:56 ` Rich Felker
2024-04-24 19:30 ` Rich Felker
2024-04-24 23:55 ` lolzery wowzery
2024-04-25 3:21 ` Markus Wichmann
2024-04-25 12:25 ` Rich Felker
2024-04-28 2:29 ` lolzery wowzery
2024-04-28 16:13 ` Rich Felker
2024-05-06 14:57 ` Rich Felker
2024-04-27 16:40 ` Rich Felker [this message]
2022-08-31 19:07 ` [musl] [PATCH 2/2] V3 src/stat/fstatat.c use new statx define Duncan Bellamy
2024-02-24 16:57 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240427164050.GA10433@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=dunk@denkimushi.com \
--cc=info@bnoordhuis.nl \
--cc=musl@lists.openwall.com \
--cc=tony.ambardar@gmail.co \
--cc=wowzeryest@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).