[PR PATCH] New package: dino-0.1.0

[PR PATCH] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

There is a new pull request by anjandev against master on the void-packages repository

https://github.com/anjandev/void-packages dino
https://github.com/void-linux/void-packages/pull/18648

New package: dino-0.1.0


A patch file from https://github.com/void-linux/void-packages/pull/18648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dino-18648.patch --]
[-- Type: text/x-diff, Size: 1850 bytes --]

From cbac36b3fdcf44f55ccbe7fdf52f38ec0bd806b2 Mon Sep 17 00:00:00 2001
From: Ogromny <ogromnycoding@gmail.com>
Date: Thu, 21 Nov 2019 13:07:38 +0100
Subject: [PATCH] New package: dino-0.1.0

---
 common/shlibs         |  3 +++
 srcpkgs/dino/template | 25 +++++++++++++++++++++++++
 2 files changed, 28 insertions(+)
 create mode 100644 srcpkgs/dino/template

diff --git a/common/shlibs b/common/shlibs
index 23d0a6a3c8e..e9a640e7148 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3745,3 +3745,6 @@ libigdgmm.so.11 intel-gmmlib-19.4.1_1
 libgtk-layer-shell.so.0 wf-shell-0.3_1
 librdkafka.so.1 librdkafka-1.3.0_1
 librdkafka++.so.1 librdkafka-1.3.0_1
+libxmpp-vala.so.0 dino-0.1.0_1
+libqlite.so.0 dino-0.1.0_1
+libdino.so.0 dino-0.1.0_1
diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
new file mode 100644
index 00000000000..67648ceb197
--- /dev/null
+++ b/srcpkgs/dino/template
@@ -0,0 +1,25 @@
+# Template file for 'dino'
+pkgname=dino
+version=0.1.0
+revision=1
+build_style=cmake
+make_build_target=dino
+hostmakedepends="gettext"
+makedepends="cmake glib-devel pkg-config unzip qrencode-devel gtk+3-devel gpgme-devel libgee08-devel libgcrypt-devel libsoup-devel ninja vala libsignal-protocol-c sqlite sqlite-devel"
+depends="gettext glib glib-networking qrencode gtk+3 gpgme libgee08 libgcrypt libqrencode libsoup"
+short_desc="Modern XMPP (\"Jabber\") Chat Client using GTK+/Vala"
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/dino/dino"
+distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
+checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"
+
+do_install() {
+	vbin build/dino
+
+	vinstall build/libdino.so.0 755 /usr/lib
+	vinstall build/libqlite.so.0 755 /usr/lib
+	vinstall build/libxmpp-vala.so.0 755 /usr/lib
+
+	ldconfig
+}

Re: [PR PATCH] [Updated] [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

There is an updated pull request by anjandev against master on the void-packages repository

https://github.com/anjandev/void-packages dino
https://github.com/void-linux/void-packages/pull/18648

[WIP] New package: dino-0.1.0


A patch file from https://github.com/void-linux/void-packages/pull/18648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dino-18648.patch --]
[-- Type: text/x-diff, Size: 1873 bytes --]

From 62f2e5707276dd49d126d1a66b1654c7f56a2386 Mon Sep 17 00:00:00 2001
From: Ogromny <ogromnycoding@gmail.com>
Date: Thu, 21 Nov 2019 13:07:38 +0100
Subject: [PATCH] New package: dino-0.1.0

---
 common/shlibs         |  3 +++
 srcpkgs/dino/template | 26 ++++++++++++++++++++++++++
 2 files changed, 29 insertions(+)
 create mode 100644 srcpkgs/dino/template

diff --git a/common/shlibs b/common/shlibs
index 23d0a6a3c8e..e9a640e7148 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3745,3 +3745,6 @@ libigdgmm.so.11 intel-gmmlib-19.4.1_1
 libgtk-layer-shell.so.0 wf-shell-0.3_1
 librdkafka.so.1 librdkafka-1.3.0_1
 librdkafka++.so.1 librdkafka-1.3.0_1
+libxmpp-vala.so.0 dino-0.1.0_1
+libqlite.so.0 dino-0.1.0_1
+libdino.so.0 dino-0.1.0_1
diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
new file mode 100644
index 00000000000..ea32337c428
--- /dev/null
+++ b/srcpkgs/dino/template
@@ -0,0 +1,26 @@
+# Template file for 'dino'
+pkgname=dino
+version=0.1.0
+revision=1
+build_style=cmake
+configure_args=--with-tests
+make_build_target=dino
+hostmakedepends="gettext unzip pkg-config ninja vala"
+makedepends="cmake glib-devel qrencode-devel gtk+3-devel gpgme-devel libgee08-devel libgcrypt-devel libsoup-devel libsignal-protocol-c sqlite-devel"
+depends="gettext glib glib-networking qrencode gtk+3 gpgme libgee08 libgcrypt libqrencode libsoup"
+short_desc="Modern XMPP (\"Jabber\") Chat Client using GTK+/Vala"
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/dino/dino"
+distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
+checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"
+
+do_install() {
+	vbin build/dino
+
+	vinstall build/libdino.so.0 755 /usr/lib
+	vinstall build/libqlite.so.0 755 /usr/lib
+	vinstall build/libxmpp-vala.so.0 755 /usr/lib
+
+	ldconfig
+}

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

New comment by anjandev on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-580065379

Comment:
As discussed in irc, dino's configure script is not portable. Also, `makedepends=cmake` is required because the ./configure script requires it

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-580071109

Comment:
Ignore the configure script and use cmake directly.

Re: [PR PATCH] [Updated] [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

There is an updated pull request by anjandev against master on the void-packages repository

https://github.com/anjandev/void-packages dino
https://github.com/void-linux/void-packages/pull/18648

[WIP] New package: dino-0.1.0


A patch file from https://github.com/void-linux/void-packages/pull/18648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dino-18648.patch --]
[-- Type: text/x-diff, Size: 1846 bytes --]

From bdf8f74421758905cc099dcee526707424a3a267 Mon Sep 17 00:00:00 2001
From: Ogromny <ogromnycoding@gmail.com>
Date: Thu, 21 Nov 2019 13:07:38 +0100
Subject: [PATCH] New package: dino-0.1.0

---
 common/shlibs         |  3 +++
 srcpkgs/dino/template | 29 +++++++++++++++++++++++++++++
 2 files changed, 32 insertions(+)
 create mode 100644 srcpkgs/dino/template

diff --git a/common/shlibs b/common/shlibs
index 23d0a6a3c8e..e9a640e7148 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3745,3 +3745,6 @@ libigdgmm.so.11 intel-gmmlib-19.4.1_1
 libgtk-layer-shell.so.0 wf-shell-0.3_1
 librdkafka.so.1 librdkafka-1.3.0_1
 librdkafka++.so.1 librdkafka-1.3.0_1
+libxmpp-vala.so.0 dino-0.1.0_1
+libqlite.so.0 dino-0.1.0_1
+libdino.so.0 dino-0.1.0_1
diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
new file mode 100644
index 00000000000..256a0eeea4d
--- /dev/null
+++ b/srcpkgs/dino/template
@@ -0,0 +1,29 @@
+# Template file for 'dino'
+pkgname=dino
+version=0.1.0
+revision=1
+make_build_target=dino
+hostmakedepends="gettext unzip pkg-config ninja vala"
+makedepends="cmake glib-devel qrencode-devel gtk+3-devel gpgme-devel libgee08-devel libgcrypt-devel libsoup-devel libsignal-protocol-c sqlite-devel"
+depends="gettext glib glib-networking qrencode gtk+3 gpgme libgee08 libgcrypt libqrencode libsoup"
+short_desc="Modern XMPP (\"Jabber\") Chat Client using GTK+/Vala"
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/dino/dino"
+distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
+checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"
+
+do_build() {
+    cmake .
+    make
+}
+
+do_install() {
+	vbin dino
+
+	vinstall libdino.so.0 755 /usr/lib
+	vinstall libqlite.so.0 755 /usr/lib
+	vinstall libxmpp-vala.so.0 755 /usr/lib
+
+	ldconfig
+}

Re: [PR PATCH] [Updated] [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

There is an updated pull request by anjandev against master on the void-packages repository

https://github.com/anjandev/void-packages dino
https://github.com/void-linux/void-packages/pull/18648

[WIP] New package: dino-0.1.0


A patch file from https://github.com/void-linux/void-packages/pull/18648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dino-18648.patch --]
[-- Type: text/x-diff, Size: 1840 bytes --]

From 6d23a1c3a6c2c38887b42070153aaf9eb321829b Mon Sep 17 00:00:00 2001
From: Ogromny <ogromnycoding@gmail.com>
Date: Thu, 21 Nov 2019 13:07:38 +0100
Subject: [PATCH] New package: dino-0.1.0

---
 common/shlibs         |  3 +++
 srcpkgs/dino/template | 29 +++++++++++++++++++++++++++++
 2 files changed, 32 insertions(+)
 create mode 100644 srcpkgs/dino/template

diff --git a/common/shlibs b/common/shlibs
index 23d0a6a3c8e..e9a640e7148 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3745,3 +3745,6 @@ libigdgmm.so.11 intel-gmmlib-19.4.1_1
 libgtk-layer-shell.so.0 wf-shell-0.3_1
 librdkafka.so.1 librdkafka-1.3.0_1
 librdkafka++.so.1 librdkafka-1.3.0_1
+libxmpp-vala.so.0 dino-0.1.0_1
+libqlite.so.0 dino-0.1.0_1
+libdino.so.0 dino-0.1.0_1
diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
new file mode 100644
index 00000000000..70447e12506
--- /dev/null
+++ b/srcpkgs/dino/template
@@ -0,0 +1,29 @@
+# Template file for 'dino'
+pkgname=dino
+version=0.1.0
+revision=1
+make_build_target=dino
+hostmakedepends="gettext unzip pkg-config ninja vala"
+makedepends="cmake glib-devel qrencode-devel gtk+3-devel gpgme-devel libgee08-devel libgcrypt-devel libsoup-devel libsignal-protocol-c sqlite-devel"
+depends="gettext glib glib-networking qrencode gtk+3 gpgme libgee08 libgcrypt libqrencode libsoup"
+short_desc="Modern XMPP (\"Jabber\") Chat Client using GTK+/Vala"
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/dino/dino"
+distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
+checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"
+
+do_build() {
+	cmake .
+	make
+}
+
+do_install() {
+	vbin dino
+
+	vinstall libdino.so.0 755 /usr/lib
+	vinstall libqlite.so.0 755 /usr/lib
+	vinstall libxmpp-vala.so.0 755 /usr/lib
+
+	ldconfig
+}

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]

New comment by anjandev on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-580094432

Comment:
@Johnnynator This advice fixed alot of the issues I was getting but I still have the following error:

```
/usr/bin/ld: /usr/lib/gcc/x86_64-unknown-linux-gnu/9.2.0/../../../../lib/libsignal-protocol-c.a(curve.c.o): relocation R_X86_64_PC32 against symbol `ec_public_key_destroy' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: bad value
collect2: error: ld returned 1 exit status
make[2]: *** [plugins/omemo/CMakeFiles/omemo.dir/build.make:626: plugins/omemo.so] Error 1
make[2]: Leaving directory '/builddir/dino-0.1.0'
make[1]: *** [CMakeFiles/Makefile2:731: plugins/omemo/CMakeFiles/omemo.dir/all] Error 2
make[1]: Leaving directory '/builddir/dino-0.1.0'
make: *** [Makefile:130: all] Error 2
=> ERROR: dino-0.1.0_1: do_build: 'make' exited with 2
=> ERROR:   in do_build() at srcpkgs/dino/template:18
The command "if [ -z "$XLINT" ]; then docker exec -t void hostrepo/common/travis/build.sh $BOOTSTRAP $ARCH; fi" exited with 1.
```

Any ideas?

Re: [PR PATCH] [Updated] [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

There is an updated pull request by anjandev against master on the void-packages repository

https://github.com/anjandev/void-packages dino
https://github.com/void-linux/void-packages/pull/18648

[WIP] New package: dino-0.1.0


A patch file from https://github.com/void-linux/void-packages/pull/18648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dino-18648.patch --]
[-- Type: text/x-diff, Size: 1885 bytes --]

From bad5328ec52fea8ca4b05c4bc3518a70ea85bf74 Mon Sep 17 00:00:00 2001
From: Ogromny <ogromnycoding@gmail.com>
Date: Thu, 21 Nov 2019 13:07:38 +0100
Subject: [PATCH] New package: dino-0.1.0

---
 common/shlibs         |  3 +++
 srcpkgs/dino/template | 31 +++++++++++++++++++++++++++++++
 2 files changed, 34 insertions(+)
 create mode 100644 srcpkgs/dino/template

diff --git a/common/shlibs b/common/shlibs
index 23d0a6a3c8e..e9a640e7148 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3745,3 +3745,6 @@ libigdgmm.so.11 intel-gmmlib-19.4.1_1
 libgtk-layer-shell.so.0 wf-shell-0.3_1
 librdkafka.so.1 librdkafka-1.3.0_1
 librdkafka++.so.1 librdkafka-1.3.0_1
+libxmpp-vala.so.0 dino-0.1.0_1
+libqlite.so.0 dino-0.1.0_1
+libdino.so.0 dino-0.1.0_1
diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
new file mode 100644
index 00000000000..d88d39547b1
--- /dev/null
+++ b/srcpkgs/dino/template
@@ -0,0 +1,31 @@
+# Template file for 'dino'
+pkgname=dino
+version=0.1.0
+revision=1
+build_style=cmake
+hostmakedepends="gettext unzip pkg-config vala"
+makedepends="glib-devel qrencode-devel gtk+3-devel gpgme-devel 
+             libgee08-devel libgcrypt-devel libsoup-devel 
+             libsignal-protocol-c sqlite-devel"
+# depends="gettext glib glib-networking qrencode gtk+3 gpgme libgee08 libgcrypt libqrencode libsoup"
+short_desc="Modern XMPP (\"Jabber\") Chat Client using GTK+/Vala"
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/dino/dino"
+distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
+checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"
+
+# do_build() {
+# 	cmake .
+# 	make
+# }
+# 
+# do_install() {
+# 	vbin dino
+# 
+# 	vinstall libdino.so.0 755 /usr/lib
+# 	vinstall libqlite.so.0 755 /usr/lib
+# 	vinstall libxmpp-vala.so.0 755 /usr/lib
+# 
+# 	ldconfig
+# }

Re: [PR PATCH] [Updated] [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

There is an updated pull request by anjandev against master on the void-packages repository

https://github.com/anjandev/void-packages dino
https://github.com/void-linux/void-packages/pull/18648

[WIP] New package: dino-0.1.0


A patch file from https://github.com/void-linux/void-packages/pull/18648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dino-18648.patch --]
[-- Type: text/x-diff, Size: 1619 bytes --]

From 33e7620a4828f9922e34aa6631c9c0d49f63db69 Mon Sep 17 00:00:00 2001
From: Ogromny <ogromnycoding@gmail.com>
Date: Thu, 21 Nov 2019 13:07:38 +0100
Subject: [PATCH] New package: dino-0.1.0

---
 common/shlibs         |  3 +++
 srcpkgs/dino/template | 16 ++++++++++++++++
 2 files changed, 19 insertions(+)
 create mode 100644 srcpkgs/dino/template

diff --git a/common/shlibs b/common/shlibs
index 23d0a6a3c8e..e9a640e7148 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3745,3 +3745,6 @@ libigdgmm.so.11 intel-gmmlib-19.4.1_1
 libgtk-layer-shell.so.0 wf-shell-0.3_1
 librdkafka.so.1 librdkafka-1.3.0_1
 librdkafka++.so.1 librdkafka-1.3.0_1
+libxmpp-vala.so.0 dino-0.1.0_1
+libqlite.so.0 dino-0.1.0_1
+libdino.so.0 dino-0.1.0_1
diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
new file mode 100644
index 00000000000..b497ce5ee6d
--- /dev/null
+++ b/srcpkgs/dino/template
@@ -0,0 +1,16 @@
+# Template file for 'dino'
+pkgname=dino
+version=0.1.0
+revision=1
+build_style=cmake
+hostmakedepends="gettext unzip pkg-config vala"
+makedepends="glib-devel qrencode-devel gtk+3-devel gpgme-devel
+			libgee08-devel libgcrypt-devel libsoup-devel
+			libsignal-protocol-c sqlite-devel"
+# depends="gettext glib glib-networking qrencode gtk+3 gpgme libgee08 libgcrypt libqrencode libsoup"
+short_desc="Modern XMPP (\"Jabber\") Chat Client using GTK+/Vala"
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/dino/dino"
+distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
+checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"

Re: [PR PATCH] [Updated] [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

There is an updated pull request by anjandev against master on the void-packages repository

https://github.com/anjandev/void-packages dino
https://github.com/void-linux/void-packages/pull/18648

[WIP] New package: dino-0.1.0


A patch file from https://github.com/void-linux/void-packages/pull/18648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dino-18648.patch --]
[-- Type: text/x-diff, Size: 1516 bytes --]

From c170535e7aaed24c1e08c937de8f16b1f055ac00 Mon Sep 17 00:00:00 2001
From: Ogromny <ogromnycoding@gmail.com>
Date: Thu, 21 Nov 2019 13:07:38 +0100
Subject: [PATCH] New package: dino-0.1.0

---
 common/shlibs         |  3 +++
 srcpkgs/dino/template | 15 +++++++++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 srcpkgs/dino/template

diff --git a/common/shlibs b/common/shlibs
index 23d0a6a3c8e..e9a640e7148 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3745,3 +3745,6 @@ libigdgmm.so.11 intel-gmmlib-19.4.1_1
 libgtk-layer-shell.so.0 wf-shell-0.3_1
 librdkafka.so.1 librdkafka-1.3.0_1
 librdkafka++.so.1 librdkafka-1.3.0_1
+libxmpp-vala.so.0 dino-0.1.0_1
+libqlite.so.0 dino-0.1.0_1
+libdino.so.0 dino-0.1.0_1
diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
new file mode 100644
index 00000000000..40a78725939
--- /dev/null
+++ b/srcpkgs/dino/template
@@ -0,0 +1,15 @@
+# Template file for 'dino'
+pkgname=dino
+version=0.1.0
+revision=1
+build_style=cmake
+hostmakedepends="gettext unzip pkg-config vala"
+makedepends="glib-devel qrencode-devel gtk+3-devel gpgme-devel
+			libgee08-devel libgcrypt-devel libsoup-devel
+			libsignal-protocol-c sqlite-devel"
+short_desc="Modern XMPP (\"Jabber\") Chat Client using GTK+/Vala"
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/dino/dino"
+distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
+checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

New comment by faulesocke on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-580469426

Comment:
I once tried packaging it with this, don't know if it worked:

```
# Template file for 'dino'
pkgname=dino
version=0.0git
revision=1
wrksrc=$pkgname
build_style=gnu-configure
configure_args="--enable-plugin=gpgme-vala --enable-plugin=http-files --enable-plugin=notification-sound --enable-plugin=omemo --enable-plugin=openpgp --enable-plugin=signal-protocol"
hostmakedepends="git"
makedepends="cmake pkg-config gettext ninja vala glib-devel gtk+3-devel gpgme-devel libgee08-devel libgcrypt-devel qrencode-devel libsoup-devel sqlite-devel libcanberra-devel"
short_desc="Modern XMPP/Jabber Chat Client using GTK+/Vala"
maintainer="Urs Schulz <voidpkgs@ursschulz.de>"
license="GPL-3.0-or-later"
homepage="https://dino.im/"


do_fetch() {
	git clone "https://github.com/dino/dino"
	cd dino
	version="${version}$(git rev-parse --short HEAD)"
}

do_extract() {
	true
}
```

Maybe this helps.

Re: [PR PATCH] [Updated] [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

There is an updated pull request by anjandev against master on the void-packages repository

https://github.com/anjandev/void-packages dino
https://github.com/void-linux/void-packages/pull/18648

[WIP] New package: dino-0.1.0


A patch file from https://github.com/void-linux/void-packages/pull/18648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dino-18648.patch --]
[-- Type: text/x-diff, Size: 1702 bytes --]

From 7cb7d2494f9573548242ee86a62a159603740340 Mon Sep 17 00:00:00 2001
From: Ogromny <ogromnycoding@gmail.com>
Date: Thu, 21 Nov 2019 13:07:38 +0100
Subject: [PATCH] New package: dino-0.1.0

---
 common/shlibs         |  3 +++
 srcpkgs/dino/template | 16 ++++++++++++++++
 2 files changed, 19 insertions(+)
 create mode 100644 srcpkgs/dino/template

diff --git a/common/shlibs b/common/shlibs
index 23d0a6a3c8e..e9a640e7148 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3745,3 +3745,6 @@ libigdgmm.so.11 intel-gmmlib-19.4.1_1
 libgtk-layer-shell.so.0 wf-shell-0.3_1
 librdkafka.so.1 librdkafka-1.3.0_1
 librdkafka++.so.1 librdkafka-1.3.0_1
+libxmpp-vala.so.0 dino-0.1.0_1
+libqlite.so.0 dino-0.1.0_1
+libdino.so.0 dino-0.1.0_1
diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
new file mode 100644
index 00000000000..2a71b317416
--- /dev/null
+++ b/srcpkgs/dino/template
@@ -0,0 +1,16 @@
+# Template file for 'dino'
+pkgname=dino
+version=0.1.0
+revision=1
+build_style=cmake
+hostmakedepends="gettext unzip pkg-config vala"
+makedepends="glib-devel qrencode-devel gtk+3-devel gpgme-devel
+			libgee08-devel libgcrypt-devel libsoup-devel
+			libsignal-protocol-c sqlite-devel"
+short_desc="Modern XMPP (\"Jabber\") Chat Client using GTK+/Vala"
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/dino/dino"
+distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
+checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"
+configure_args="--enable-plugin=gpgme-vala --enable-plugin=http-files --enable-plugin=notification-sound --enable-plugin=omemo --enable-plugin=openpgp --enable-plugin=signal-protocol"

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New comment by v0idifier on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-580780655

Comment:
@anjandev doing `./configure --with-libsignal-in-tree` worked for me, but i suppose it doesn't make sense in a package

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 2169 bytes --]

New comment by anjandev on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-580983812

Comment:
> @anjandev doing `./configure --with-libsignal-in-tree` worked for me, but i suppose it doesn't make sense in a package

Im sorry, that didnt work for me. Would you mind posting the full template? Also, what are the implications of `--with-libsignal-in-tree`?

@faulesocke 
I tried running this template and it didnt work.

The main issue with my template is the make file breaks at 

```
[ 11%] Built target xmpp-vala-vapi
make[2]: Leaving directory '/builddir/dino-0.1.0/build'
make[1]: *** [CMakeFiles/Makefile2:511: main/CMakeFiles/dino.dir/rule] Error 2
make[1]: Leaving directory '/builddir/dino-0.1.0/build'
make: *** [Makefile:255: dino] Error 2
=> ERROR: dino-0.1.0_1: do_build: '${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}' exited with 2
=> ERROR:   in do_build() at common/build-style/cmake.sh:73
```

If I run `./xbps-src pkg dino` again after it fails at 11%, my template will compile dino completely but fail at 100%.

```
[100%] Linking C shared library ../omemo.so
/usr/bin/ld: /usr/lib/gcc/x86_64-unknown-linux-gnu/9.2.0/../../../../lib/libsignal-protocol-c.a(curve.c.o): relocation R_X86_64_PC32 against symbol `ec_public_key_destroy' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: bad value
collect2: error: ld returned 1 exit status
make[2]: *** [plugins/omemo/CMakeFiles/omemo.dir/build.make:626: plugins/omemo.so] Error 1
make[2]: Leaving directory '/builddir/dino-0.1.0/build'
make[1]: *** [CMakeFiles/Makefile2:731: plugins/omemo/CMakeFiles/omemo.dir/all] Error 2
make[1]: Leaving directory '/builddir/dino-0.1.0/build'
make: *** [Makefile:130: all] Error 2
=> ERROR: dino-0.1.0_1: do_install: '${make_cmd} DESTDIR=${DESTDIR} ${make_install_args} ${make_install_target}' exited with 2
=> ERROR:   in do_install() at common/build-style/cmake.sh:101
```

There is a `dino` binary in `masterdir/builddir/dino-0.1.0/build/` that runs but I have no idea why xbps-src fails to get to the install phase.

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

New comment by v0idifier on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-581076539

Comment:
> Im sorry, that didnt work for me. Would you mind posting the full template? Also, what are the implications of `--with-libsignal-in-tree`?

i had that exact error and it was solved by that flag. it compiles `libsignal-protocol-c` by itself instead of using the system one (void's might be the wrong version). i don't have a template, i compiled it myself. 

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

New comment by v0idifier on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-581076539

Comment:
> Im sorry, that didnt work for me. Would you mind posting the full template? Also, what are the implications of `--with-libsignal-in-tree`?

i had that exact error and it was solved by that flag. it compiles `libsignal-protocol-c` by itself instead of using the system one (void's might be the wrong version). i don't have a template, i compiled it myself. see https://github.com/dino/dino/wiki/Build#libsignal-protocol-c

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New comment by v0idifier on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-581077707

Comment:
i made a post (in spanish, but the commands are in english :) about how i compiled it: https://void.partidopirata.com.ar/2020/01/30/instalar-dino-en-void-linux/

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]

New comment by toogley on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-581333668

Comment:
Maybe https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/dino helps?

```
# Maintainer: Bruno Pagani <archange@archlinux.org>

pkgname=dino
pkgver=0.1.0
pkgrel=2
pkgdesc="Modern XMPP (Jabber) chat client written in Vala"
arch=(x86_64)
url="https://github.com/dino/dino"
license=(GPL3)
depends=(glib2 glib-networking gtk3 gpgme libgee libgcrypt libsignal-protocol-c
         libsoup sqlite qrencode libcanberra)
makedepends=(git cmake vala ninja)
source=(${url}/releases/download/v${pkgver}/${pkgname}-${pkgver}.tar.gz{,.asc})
sha256sums=('100542fcf05781f37f5a871489affe0a82f205cd15e3d0d3cdfd717fa1149835' 'SKIP')
validpgpkeys=(A32134DD19952FB12EC43E4501FABCC83FEA225E)

build() {
    cmake -G Ninja -B build -S ${pkgname}-${pkgver} \
        -DCMAKE_INSTALL_PREFIX=/usr \
        -DDINO_PLUGIN_ENABLED_notification-sound=ON
    ninja -C build
}

package() {
    DESTDIR="${pkgdir}" ninja -C build install
}

```

i think it would make sense to first try to package the easiest possible way. so without plugins, packaging seems easier. That means, try first to get the plain dino package working and when that works, try to get omemo and other plugins working in another PR. 

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

New comment by v0idifier on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-581508563

Comment:
personally i agree with the plugins thing but it's very important that by the time it's on the repos it has the plugins, as without them users will be confused as to why omemo isn't working.

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by anjandev on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-581689025

Comment:
Thanks for the feedback guys. I have half an evening free so I'll see what I can do.

Re: [PR PATCH] [Updated] [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

There is an updated pull request by anjandev against master on the void-packages repository

https://github.com/anjandev/void-packages dino
https://github.com/void-linux/void-packages/pull/18648

[WIP] New package: dino-0.1.0


A patch file from https://github.com/void-linux/void-packages/pull/18648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dino-18648.patch --]
[-- Type: text/x-diff, Size: 1366 bytes --]

From 01e48022ce199a9c0f824ef6718b3d236b090afc Mon Sep 17 00:00:00 2001
From: Ogromny <ogromnycoding@gmail.com>
Date: Thu, 21 Nov 2019 13:07:38 +0100
Subject: [PATCH] New package: dino-0.1.0

---
 srcpkgs/dino/template | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 srcpkgs/dino/template

diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
new file mode 100644
index 00000000000..6a0a70a1043
--- /dev/null
+++ b/srcpkgs/dino/template
@@ -0,0 +1,26 @@
+# Template file for 'dino'
+pkgname=dino
+version=0.1.0
+revision=1
+hostmakedepends="cmake ninja gettext unzip pkg-config vala"
+makedepends="cmake glib-devel qrencode-devel gtk+3-devel gpgme-devel
+			libgee08-devel libgcrypt-devel libsoup-devel
+			libsignal-protocol-c sqlite-devel libcanberra-devel"
+short_desc="Modern XMPP (\"Jabber\") Chat Client using GTK+/Vala"
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/dino/dino"
+distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
+checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"
+
+do_build() {
+		cmake -G Ninja -B build -S . \
+					-DCMAKE_INSTALL_PREFIX=/usr \
+					-DDINO_PLUGIN_ENABLED_notification-sound=ON \
+					-DDINO_PLUGIN_ENABLED_omemo=OFF
+		ninja -C build
+}
+
+do_install() {
+		vbin build/dino
+}

Re: [PR PATCH] [Updated] [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

There is an updated pull request by anjandev against master on the void-packages repository

https://github.com/anjandev/void-packages dino
https://github.com/void-linux/void-packages/pull/18648

[WIP] New package: dino-0.1.0


A patch file from https://github.com/void-linux/void-packages/pull/18648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dino-18648.patch --]
[-- Type: text/x-diff, Size: 1804 bytes --]

From 549c65ba9ce1a64410f01823a5b11aaf4c67e0f5 Mon Sep 17 00:00:00 2001
From: Ogromny <ogromnycoding@gmail.com>
Date: Thu, 21 Nov 2019 13:07:38 +0100
Subject: [PATCH] New package: dino-0.1.0

---
 common/shlibs         |  3 +++
 srcpkgs/dino/template | 26 ++++++++++++++++++++++++++
 2 files changed, 29 insertions(+)
 create mode 100644 srcpkgs/dino/template

diff --git a/common/shlibs b/common/shlibs
index 23d0a6a3c8e..4bfe73bb6fb 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3745,3 +3745,6 @@ libigdgmm.so.11 intel-gmmlib-19.4.1_1
 libgtk-layer-shell.so.0 wf-shell-0.3_1
 librdkafka.so.1 librdkafka-1.3.0_1
 librdkafka++.so.1 librdkafka-1.3.0_1
+libxmpp-vala.so.0 dino-0.1.0_1
+libqlite.so.0 dino-0.1.0_1
+libdino.so.0 dino-0.1.0_1 
\ No newline at end of file
diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
new file mode 100644
index 00000000000..763e0b05ddb
--- /dev/null
+++ b/srcpkgs/dino/template
@@ -0,0 +1,26 @@
+# Template file for 'dino'
+pkgname=dino
+version=0.1.0
+revision=1
+hostmakedepends="cmake ninja gettext unzip pkg-config vala"
+makedepends="glib-devel qrencode-devel gtk+3-devel gpgme-devel
+			libgee08-devel libgcrypt-devel libsoup-devel
+			libsignal-protocol-c sqlite-devel libcanberra-devel"
+short_desc="Modern XMPP (\"Jabber\") Chat Client using GTK+/Vala"
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/dino/dino"
+distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
+checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"
+
+do_build() {
+		cmake -G Ninja -B build -S . \
+					-DCMAKE_INSTALL_PREFIX=/usr \
+					-DDINO_PLUGIN_ENABLED_notification-sound=ON \
+					-DDINO_PLUGIN_ENABLED_omemo=OFF
+		ninja -C build
+}
+
+do_install() {
+		vbin build/dino
+}

Re: [PR PATCH] [Updated] [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

There is an updated pull request by anjandev against master on the void-packages repository

https://github.com/anjandev/void-packages dino
https://github.com/void-linux/void-packages/pull/18648

[WIP] New package: dino-0.1.0


A patch file from https://github.com/void-linux/void-packages/pull/18648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dino-18648.patch --]
[-- Type: text/x-diff, Size: 1784 bytes --]

From 6bbccf475b7d53a960dc84f2ab1418812dcbada7 Mon Sep 17 00:00:00 2001
From: Ogromny <ogromnycoding@gmail.com>
Date: Thu, 21 Nov 2019 13:07:38 +0100
Subject: [PATCH] New package: dino-0.1.0

---
 common/shlibs         |  3 +++
 srcpkgs/dino/template | 26 ++++++++++++++++++++++++++
 2 files changed, 29 insertions(+)
 create mode 100644 srcpkgs/dino/template

diff --git a/common/shlibs b/common/shlibs
index 78e1d178642..06c583e5b89 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3798,3 +3798,6 @@ libmdnsd.so.0 libmdnsd-0.8_1
 libPtex.so ptex-2.3.2_1
 libosdGPU.so.3.4.0 OpenSubdiv-3.4.0_1
 libosdCPU.so.3.4.0 OpenSubdiv-3.4.0_1
+libxmpp-vala.so.0 dino-0.1.0_1
+libqlite.so.0 dino-0.1.0_1
+libdino.so.0 dino-0.1.0_1 
\ No newline at end of file
diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
new file mode 100644
index 00000000000..763e0b05ddb
--- /dev/null
+++ b/srcpkgs/dino/template
@@ -0,0 +1,26 @@
+# Template file for 'dino'
+pkgname=dino
+version=0.1.0
+revision=1
+hostmakedepends="cmake ninja gettext unzip pkg-config vala"
+makedepends="glib-devel qrencode-devel gtk+3-devel gpgme-devel
+			libgee08-devel libgcrypt-devel libsoup-devel
+			libsignal-protocol-c sqlite-devel libcanberra-devel"
+short_desc="Modern XMPP (\"Jabber\") Chat Client using GTK+/Vala"
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/dino/dino"
+distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
+checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"
+
+do_build() {
+		cmake -G Ninja -B build -S . \
+					-DCMAKE_INSTALL_PREFIX=/usr \
+					-DDINO_PLUGIN_ENABLED_notification-sound=ON \
+					-DDINO_PLUGIN_ENABLED_omemo=OFF
+		ninja -C build
+}
+
+do_install() {
+		vbin build/dino
+}

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

New comment by anjandev on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-581720281

Comment:
@toogley thank you for the example build script. The current commit in this PR compiles dino to completion without plugins. I referenced your build script and `libcanberra-devel` was added but might not be needed - I need to do some testing on whether this dependency is needed.

Enabling the omemo plugin causes a linking error. Getting dino to compile without plugins is a good stepping stone but as @v0idifier has stated, dino was created to make encrypted communication easy and the default. I need fix omemo before this package can be merged with void repos. Any suggestions or help is much appreciated!

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 3467 bytes --]

New comment by toogley on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-581838791

Comment:
I think i have managed to build dino directly some weeks ago (that means: not as void linux package and instead as a binary directly from the dino repository).

I think i have used this command at that time: `./configure --enable-plugin=omemo && make`
However, that fails at the moment with this error:

```
FAILED: plugins/omemo.so 
: && /bin/cc -fPIC -fdiagnostics-color -Wall -Wextra -Werror=format-security -Wno-duplicate-decl-specifier -g -O2 -g -DNDEBUG   -shared -Wl,-soname,omemo.so -o plugins/omemo.so plugins/omemo/CMakeFiles/omemo.dir/src/plugin.c.o plugins/omemo/CMakeFiles/omemo.dir/src/register_plugin.c.o plugins/omemo/CMakeFiles/omemo.dir/src/trust_level.c.o plugins/omemo/CMakeFiles/omemo.dir/src/file_transfer/file_decryptor.c.o plugins/omemo/CMakeFiles/omemo.dir/src/file_transfer/file_encryptor.c.o plugins/omemo/CMakeFiles/omemo.dir/src/jingle/jingle_helper.c.o plugins/omemo/CMakeFiles/omemo.dir/src/jingle/jet_omemo.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/database.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/encrypt_state.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/manager.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/pre_key_store.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/session_store.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/signed_pre_key_store.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/trust_manager.c.o plugins/omemo/CMakeFiles/omemo.dir/src/protocol/bundle.c.o plugins/omemo/CMakeFiles/omemo.dir/src/protocol/message_flag.c.o plugins/omemo/CMakeFiles/omemo.dir/src/protocol/stream_module.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/account_settings_entry.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/account_settings_widget.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/contact_details_provider.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/contact_details_dialog.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/device_notification_populator.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/own_notifications.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/encryption_list_entry.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/manage_key_dialog.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/util.c.o plugins/omemo/CMakeFiles/omemo.dir/resources/resources.c.o  -Wl,-rpath,/home/toogley/src/dino/build:  libdino.so.0.0  plugins/signal-protocol/libsignal-protocol-vala.a  plugins/crypto-vala/libcrypto-vala.a  libxmpp-vala.so.0.1  /usr/lib/libicuuc.so  /usr/lib/libicudata.so  libqlite.so.0.1  /usr/lib/libsqlite3.so  -lsignal-protocol-c  -lm  -lgcrypt  /usr/lib/libgee-0.8.so  /usr/lib/libgmodule-2.0.so  /usr/lib/libgtk-3.so  /usr/lib/libgdk-3.so  /usr/lib/libpangocairo-1.0.so  /usr/lib/libpango-1.0.so  /usr/lib/libatk-1.0.so  /usr/lib/libcairo-gobject.so  /usr/lib/libcairo.so  /usr/lib/libgdk_pixbuf-2.0.so  /usr/lib/libsoup-2.4.so  /usr/lib/libgio-2.0.so  /usr/lib/libgobject-2.0.so  /usr/lib/libglib-2.0.so  /usr/lib/libqrencode.so && :
/bin/ld: /usr/lib/gcc/x86_64-unknown-linux-gnu/9.2.0/../../../../lib/libsignal-protocol-c.a(curve.c.o): relocation R_X86_64_PC32 against symbol `ec_public_key_destroy' can not be used when making a shared object; recompile with -fPIC
/bin/ld: final link failed: bad value
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
make: *** [Makefile:2: default] Error 1
```

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 3644 bytes --]

New comment by toogley on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-581838791

Comment:
I think i have managed to build dino directly some weeks ago (that means: not as void linux package and instead as a binary directly from the dino repository).

I think i have used this command at that time: `./configure --enable-plugin=omemo && make`
However, that fails at the moment with this error:

```
FAILED: plugins/omemo.so 
: && /bin/cc -fPIC -fdiagnostics-color -Wall -Wextra -Werror=format-security -Wno-duplicate-decl-specifier -g -O2 -g -DNDEBUG   -shared -Wl,-soname,omemo.so -o plugins/omemo.so plugins/omemo/CMakeFiles/omemo.dir/src/plugin.c.o plugins/omemo/CMakeFiles/omemo.dir/src/register_plugin.c.o plugins/omemo/CMakeFiles/omemo.dir/src/trust_level.c.o plugins/omemo/CMakeFiles/omemo.dir/src/file_transfer/file_decryptor.c.o plugins/omemo/CMakeFiles/omemo.dir/src/file_transfer/file_encryptor.c.o plugins/omemo/CMakeFiles/omemo.dir/src/jingle/jingle_helper.c.o plugins/omemo/CMakeFiles/omemo.dir/src/jingle/jet_omemo.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/database.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/encrypt_state.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/manager.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/pre_key_store.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/session_store.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/signed_pre_key_store.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/trust_manager.c.o plugins/omemo/CMakeFiles/omemo.dir/src/protocol/bundle.c.o plugins/omemo/CMakeFiles/omemo.dir/src/protocol/message_flag.c.o plugins/omemo/CMakeFiles/omemo.dir/src/protocol/stream_module.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/account_settings_entry.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/account_settings_widget.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/contact_details_provider.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/contact_details_dialog.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/device_notification_populator.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/own_notifications.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/encryption_list_entry.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/manage_key_dialog.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/util.c.o plugins/omemo/CMakeFiles/omemo.dir/resources/resources.c.o  -Wl,-rpath,/home/toogley/src/dino/build:  libdino.so.0.0  plugins/signal-protocol/libsignal-protocol-vala.a  plugins/crypto-vala/libcrypto-vala.a  libxmpp-vala.so.0.1  /usr/lib/libicuuc.so  /usr/lib/libicudata.so  libqlite.so.0.1  /usr/lib/libsqlite3.so  -lsignal-protocol-c  -lm  -lgcrypt  /usr/lib/libgee-0.8.so  /usr/lib/libgmodule-2.0.so  /usr/lib/libgtk-3.so  /usr/lib/libgdk-3.so  /usr/lib/libpangocairo-1.0.so  /usr/lib/libpango-1.0.so  /usr/lib/libatk-1.0.so  /usr/lib/libcairo-gobject.so  /usr/lib/libcairo.so  /usr/lib/libgdk_pixbuf-2.0.so  /usr/lib/libsoup-2.4.so  /usr/lib/libgio-2.0.so  /usr/lib/libgobject-2.0.so  /usr/lib/libglib-2.0.so  /usr/lib/libqrencode.so && :
/bin/ld: /usr/lib/gcc/x86_64-unknown-linux-gnu/9.2.0/../../../../lib/libsignal-protocol-c.a(curve.c.o): relocation R_X86_64_PC32 against symbol `ec_public_key_destroy' can not be used when making a shared object; recompile with -fPIC
/bin/ld: final link failed: bad value
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
make: *** [Makefile:2: default] Error 1
```

I tought it would make sense to get dino working that way before packaging it into void to understand how the build script has to look inside voidlinux. Still investigating.

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 14059 bytes --]

New comment by toogley on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-581838791

Comment:
I think i have managed to build dino directly some weeks ago (that means: not as void linux package and instead as a binary directly from the dino repository).

I think i have used this command at that time: `./configure --enable-plugin=omemo && make`
However, that fails at the moment with this error:

```
FAILED: plugins/omemo.so 
: && /bin/cc -fPIC -fdiagnostics-color -Wall -Wextra -Werror=format-security -Wno-duplicate-decl-specifier -g -O2 -g -DNDEBUG   -shared -Wl,-soname,omemo.so -o plugins/omemo.so plugins/omemo/CMakeFiles/omemo.dir/src/plugin.c.o plugins/omemo/CMakeFiles/omemo.dir/src/register_plugin.c.o plugins/omemo/CMakeFiles/omemo.dir/src/trust_level.c.o plugins/omemo/CMakeFiles/omemo.dir/src/file_transfer/file_decryptor.c.o plugins/omemo/CMakeFiles/omemo.dir/src/file_transfer/file_encryptor.c.o plugins/omemo/CMakeFiles/omemo.dir/src/jingle/jingle_helper.c.o plugins/omemo/CMakeFiles/omemo.dir/src/jingle/jet_omemo.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/database.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/encrypt_state.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/manager.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/pre_key_store.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/session_store.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/signed_pre_key_store.c.o plugins/omemo/CMakeFiles/omemo.dir/src/logic/trust_manager.c.o plugins/omemo/CMakeFiles/omemo.dir/src/protocol/bundle.c.o plugins/omemo/CMakeFiles/omemo.dir/src/protocol/message_flag.c.o plugins/omemo/CMakeFiles/omemo.dir/src/protocol/stream_module.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/account_settings_entry.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/account_settings_widget.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/contact_details_provider.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/contact_details_dialog.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/device_notification_populator.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/own_notifications.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/encryption_list_entry.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/manage_key_dialog.c.o plugins/omemo/CMakeFiles/omemo.dir/src/ui/util.c.o plugins/omemo/CMakeFiles/omemo.dir/resources/resources.c.o  -Wl,-rpath,/home/toogley/src/dino/build:  libdino.so.0.0  plugins/signal-protocol/libsignal-protocol-vala.a  plugins/crypto-vala/libcrypto-vala.a  libxmpp-vala.so.0.1  /usr/lib/libicuuc.so  /usr/lib/libicudata.so  libqlite.so.0.1  /usr/lib/libsqlite3.so  -lsignal-protocol-c  -lm  -lgcrypt  /usr/lib/libgee-0.8.so  /usr/lib/libgmodule-2.0.so  /usr/lib/libgtk-3.so  /usr/lib/libgdk-3.so  /usr/lib/libpangocairo-1.0.so  /usr/lib/libpango-1.0.so  /usr/lib/libatk-1.0.so  /usr/lib/libcairo-gobject.so  /usr/lib/libcairo.so  /usr/lib/libgdk_pixbuf-2.0.so  /usr/lib/libsoup-2.4.so  /usr/lib/libgio-2.0.so  /usr/lib/libgobject-2.0.so  /usr/lib/libglib-2.0.so  /usr/lib/libqrencode.so && :
/bin/ld: /usr/lib/gcc/x86_64-unknown-linux-gnu/9.2.0/../../../../lib/libsignal-protocol-c.a(curve.c.o): relocation R_X86_64_PC32 against symbol `ec_public_key_destroy' can not be used when making a shared object; recompile with -fPIC
/bin/ld: final link failed: bad value
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
make: *** [Makefile:2: default] Error 1
```

I tought it would make sense to get dino working that way before packaging it into void to understand how the build script has to look inside voidlinux. Still investigating.


Also using `./configure --enable-plugin=omemo --with-libsignal-in-tree && make` fails:

```
[238/364] Building C object plugins/signal-protocol/CMakeFiles/signal-protocol-vala.dir/src/util.c.o
util.c: In function 'signal_calculate_agreement':
util.c:225:7: warning: variable '_res_size_' set but not used [-Wunused-but-set-variable]
util.c: In function 'signal_carr_to_string':
util.c:361:7: warning: variable '_nu_size_' set but not used [-Wunused-but-set-variable]
[239/364] Building C object plugins/signal-protocol/libsignal...MakeFiles/signal-protocol-c.dir/LocalStorageProtocol.pb-c.c.o
FAILED: plugins/signal-protocol/libsignal-protocol-c/src/CMakeFiles/signal-protocol-c.dir/LocalStorageProtocol.pb-c.c.o 
/bin/cc  -Iplugins/signal-protocol -Iexports -I../plugins/signal-protocol/libsignal-protocol-c/src/. -I../plugins/signal-protocol/libsignal-protocol-c/src/curve25519/ed25519/nacl_includes -I../plugins/signal-protocol/libsignal-protocol-c/src/curve25519/ed25519/additions -I../plugins/signal-protocol/libsignal-protocol-c/src/curve25519/ed25519/sha512 -I../plugins/signal-protocol/libsignal-protocol-c/src/curve25519/ed25519 -I../plugins/signal-protocol/libsignal-protocol-c/src/curve25519 -fdiagnostics-color -Wall -Wextra -Werror=format-security -Wno-duplicate-decl-specifier -g -fmessage-length=0 -Wall -Wmissing-field-initializers -Wno-missing-braces -Wparentheses -Wswitch -Wunused-variable -Wunused-value -Wshadow -Wint-conversion -Wpointer-sign -Wprotocol -Wshorten-64-to-32 -g -fPIC -MD -MT plugins/signal-protocol/libsignal-protocol-c/src/CMakeFiles/signal-protocol-c.dir/LocalStorageProtocol.pb-c.c.o -MF plugins/signal-protocol/libsignal-protocol-c/src/CMakeFiles/signal-protocol-c.dir/LocalStorageProtocol.pb-c.c.o.d -o plugins/signal-protocol/libsignal-protocol-c/src/CMakeFiles/signal-protocol-c.dir/LocalStorageProtocol.pb-c.c.o   -c ../plugins/signal-protocol/libsignal-protocol-c/src/LocalStorageProtocol.pb-c.c
cc: error: unrecognized command line option '-Wshorten-64-to-32'
[240/364] Building C object plugins/signal-protocol/libsignal...CMakeFiles/signal-protocol-c.dir/WhisperTextProtocol.pb-c.c.o
FAILED: plugins/signal-protocol/libsignal-protocol-c/src/CMakeFiles/signal-protocol-c.dir/WhisperTextProtocol.pb-c.c.o 
/bin/cc  -Iplugins/signal-protocol -Iexports -I../plugins/signal-protocol/libsignal-protocol-c/src/. -I../plugins/signal-protocol/libsignal-protocol-c/src/curve25519/ed25519/nacl_includes -I../plugins/signal-protocol/libsignal-protocol-c/src/curve25519/ed25519/additions -I../plugins/signal-protocol/libsignal-protocol-c/src/curve25519/ed25519/sha512 -I../plugins/signal-protocol/libsignal-protocol-c/src/curve25519/ed25519 -I../plugins/signal-protocol/libsignal-protocol-c/src/curve25519 -fdiagnostics-color -Wall -Wextra -Werror=format-security -Wno-duplicate-decl-specifier -g -fmessage-length=0 -Wall -Wmissing-field-initializers -Wno-missing-braces -Wparentheses -Wswitch -Wunused-variable -Wunused-value -Wshadow -Wint-conversion -Wpointer-sign -Wprotocol -Wshorten-64-to-32 -g -fPIC -MD -MT plugins/signal-protocol/libsignal-protocol-c/src/CMakeFiles/signal-protocol-c.dir/WhisperTextProtocol.pb-c.c.o -MF plugins/signal-protocol/libsignal-protocol-c/src/CMakeFiles/signal-protocol-c.dir/WhisperTextProtocol.pb-c.c.o.d -o plugins/signal-protocol/libsignal-protocol-c/src/CMakeFiles/signal-protocol-c.dir/WhisperTextProtocol.pb-c.c.o   -c ../plugins/signal-protocol/libsignal-protocol-c/src/WhisperTextProtocol.pb-c.c
cc: error: unrecognized command line option '-Wshorten-64-to-32'
[241/364] Building C object plugins/signal-protocol/CMakeFiles/signal-protocol-vala.dir/src/store.c.o
store.c: In function '_vala_signal_identity_key_store_get_property':
store.c:1836:27: warning: variable 'self' set but not used [-Wunused-but-set-variable]
store.c: In function '_vala_signal_identity_key_store_set_property':
store.c:1856:27: warning: variable 'self' set but not used [-Wunused-but-set-variable]
/home/toogley/src/dino/plugins/signal-protocol/src/store.vala: In function 'signal_store_iks_get_identity_key_pair':
/home/toogley/src/dino/plugins/signal-protocol/src/store.vala:115:9: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  115 |         public_data = new Buffer.from(store.identity_key_store.identity_key_public.get_data());
      |         ^
/home/toogley/src/dino/plugins/signal-protocol/src/store.vala:116:10: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  116 |         private_data = new Buffer.from(store.identity_key_store.identity_key_private.get_data());
      |          ^
store.c: In function 'signal_store_ss_load_session_func':
store.c:4003:8: warning: variable '__tmp1__size_' set but not used [-Wunused-but-set-variable]
store.c:3972:7: warning: variable '_tmp9__length1' set but not used [-Wunused-but-set-variable]
store.c:3970:7: warning: variable '_res_size_' set but not used [-Wunused-but-set-variable]
store.c: In function 'signal_store_pks_load_pre_key':
store.c:4796:8: warning: variable '__tmp1__size_' set but not used [-Wunused-but-set-variable]
store.c:4771:7: warning: variable '_tmp9__length1' set but not used [-Wunused-but-set-variable]
store.c:4769:7: warning: variable '_res_size_' set but not used [-Wunused-but-set-variable]
store.c: In function 'signal_store_spks_load_signed_pre_key':
store.c:5315:8: warning: variable '__tmp1__size_' set but not used [-Wunused-but-set-variable]
store.c:5290:7: warning: variable '_tmp9__length1' set but not used [-Wunused-but-set-variable]
store.c:5288:7: warning: variable '_res_size_' set but not used [-Wunused-but-set-variable]
/home/toogley/src/dino/plugins/signal-protocol/src/store.vala: In function 'signal_store_construct':
/home/toogley/src/dino/plugins/signal-protocol/src/store.vala:301:23: warning: assignment to 'int (*)(const signal_protocol_address *, uint8_t *, size_t,  void *)' {aka 'int (*)(const struct signal_protocol_address *, unsigned char *, long unsigned int,  void *)'} from incompatible pointer type 'gint (*)(signal_protocol_address *, guint8 *, size_t,  void *)' {aka 'int (*)(struct signal_protocol_address *, unsigned char *, long unsigned int,  void *)'} [-Wincompatible-pointer-types]
  301 |         NativeIdentityKeyStore iks = NativeIdentityKeyStore() {
      |                       ^
/home/toogley/src/dino/plugins/signal-protocol/src/store.vala:301:29: warning: assignment to 'int (*)(const signal_protocol_address *, uint8_t *, size_t,  void *)' {aka 'int (*)(const struct signal_protocol_address *, unsigned char *, long unsigned int,  void *)'} from incompatible pointer type 'gint (*)(signal_protocol_address *, guint8 *, size_t,  void *)' {aka 'int (*)(struct signal_protocol_address *, unsigned char *, long unsigned int,  void *)'} [-Wincompatible-pointer-types]
  301 |         NativeIdentityKeyStore iks = NativeIdentityKeyStore() {
      |                             ^
/home/toogley/src/dino/plugins/signal-protocol/src/store.vala:311:27: warning: assignment to 'int (*)(signal_buffer **, signal_buffer **, const signal_protocol_address *, void *)' {aka 'int (*)(struct signal_buffer **, struct signal_buffer **, const struct signal_protocol_address *, void *)'} from incompatible pointer type 'gint (*)(signal_buffer **, signal_buffer **, signal_protocol_address *, void *)' {aka 'int (*)(struct signal_buffer **, struct signal_buffer **, struct signal_protocol_address *, void *)'} [-Wincompatible-pointer-types]
  311 |         NativeSessionStore ss = NativeSessionStore() {
      |                           ^
/home/toogley/src/dino/plugins/signal-protocol/src/store.vala:311:38: warning: assignment to 'int (*)(signal_int_list **, const char *, size_t,  void *)' {aka 'int (*)(struct signal_int_list **, const char *, long unsigned int,  void *)'} from incompatible pointer type 'gint (*)(signal_int_list **, gchar *, size_t,  void *)' {aka 'int (*)(struct signal_int_list **, char *, long unsigned int,  void *)'} [-Wincompatible-pointer-types]
  311 |         NativeSessionStore ss = NativeSessionStore() {
      |                                      ^
/home/toogley/src/dino/plugins/signal-protocol/src/store.vala:311:28: warning: assignment to 'int (*)(const signal_protocol_address *, uint8_t *, size_t,  uint8_t *, size_t,  void *)' {aka 'int (*)(const struct signal_protocol_address *, unsigned char *, long unsigned int,  unsigned char *, long unsigned int,  void *)'} from incompatible pointer type 'gint (*)(signal_protocol_address *, guint8 *, size_t,  guint8 *, size_t,  void *)' {aka 'int (*)(struct signal_protocol_address *, unsigned char *, long unsigned int,  unsigned char *, long unsigned int,  void *)'} [-Wincompatible-pointer-types]
  311 |         NativeSessionStore ss = NativeSessionStore() {
      |                            ^
/home/toogley/src/dino/plugins/signal-protocol/src/store.vala:311:31: warning: assignment to 'int (*)(const signal_protocol_address *, void *)' {aka 'int (*)(const struct signal_protocol_address *, void *)'} from incompatible pointer type 'gint (*)(signal_protocol_address *, void *)' {aka 'int (*)(struct signal_protocol_address *, void *)'} [-Wincompatible-pointer-types]
  311 |         NativeSessionStore ss = NativeSessionStore() {
      |                               ^
/home/toogley/src/dino/plugins/signal-protocol/src/store.vala:311:29: warning: assignment to 'int (*)(const signal_protocol_address *, void *)' {aka 'int (*)(const struct signal_protocol_address *, void *)'} from incompatible pointer type 'gint (*)(signal_protocol_address *, void *)' {aka 'int (*)(struct signal_protocol_address *, void *)'} [-Wincompatible-pointer-types]
  311 |         NativeSessionStore ss = NativeSessionStore() {
      |                             ^
/home/toogley/src/dino/plugins/signal-protocol/src/store.vala:311:34: warning: assignment to 'int (*)(const char *, size_t,  void *)' {aka 'int (*)(const char *, long unsigned int,  void *)'} from incompatible pointer type 'gint (*)(gchar *, size_t,  void *)' {aka 'int (*)(char *, long unsigned int,  void *)'} [-Wincompatible-pointer-types]
  311 |         NativeSessionStore ss = NativeSessionStore() {
      |                                  ^
ninja: build stopped: subcommand failed.
make: *** [Makefile:2: default] Error 1
```

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New comment by toogley on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-581840834

Comment:
I noticed that the arch linux person also has omemo not made available in their archlinux pkg. Maybe the build also fails for them?

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

New comment by toogley on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-581840834

Comment:
I noticed that the arch linux person also has omemo not made available in their archlinux pkg. Maybe the build also fails for them, when used with omemo?

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

New comment by v0idifier on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-582105428

Comment:
I ran `make clean` and then
```
./configure --with-libsignal-in-tree
make
```
and it still works for me. check out the deps i installed at https://void.partidopirata.com.ar/2020/01/30/instalar-dino-en-void-linux/

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 1899 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-582613682

Comment:
So I did take a quick look at it. First for indentation use 1 tab in e.g. functions and 1 space for a newline inside a variable. Secondly as I said USE the build style, it seems like the cmake script generates a not fully working Makefile, but the Ninja one seems to work. Pls apply these changes ontop of what the current PR and work from there.
```diff
diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
index 763e0b05dd..ed6f81e33c 100644
--- a/srcpkgs/dino/template
+++ b/srcpkgs/dino/template
@@ -2,10 +2,14 @@
 pkgname=dino
 version=0.1.0
 revision=1
-hostmakedepends="cmake ninja gettext unzip pkg-config vala"
+build_style=cmake
+configure_args="-G Ninja -DDINO_PLUGIN_ENABLED_notification-sound=ON
+ -DDINO_PLUGIN_ENABLED_omemo=OFF"
+make_cmd=ninja
+hostmakedepends="cmake ninja gettext unzip pkg-config vala glib-devel"
 makedepends="glib-devel qrencode-devel gtk+3-devel gpgme-devel
-			libgee08-devel libgcrypt-devel libsoup-devel
-			libsignal-protocol-c sqlite-devel libcanberra-devel"
+ libgee08-devel libgcrypt-devel libsoup-devel
+ libsignal-protocol-c sqlite-devel libcanberra-devel"
 short_desc="Modern XMPP (\"Jabber\") Chat Client using GTK+/Vala"
 maintainer="Anjandev Momi <anjan@momi.ca>"
 license="GPL-3.0-or-later"
@@ -13,14 +17,6 @@ homepage="https://github.com/dino/dino"
 distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
 checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"
 
-do_build() {
-		cmake -G Ninja -B build -S . \
-					-DCMAKE_INSTALL_PREFIX=/usr \
-					-DDINO_PLUGIN_ENABLED_notification-sound=ON \
-					-DDINO_PLUGIN_ENABLED_omemo=OFF
-		ninja -C build
-}
-
 do_install() {
-		vbin build/dino
+	vbin build/dino
 }
```

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 1899 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-582747063

Comment:
So I did take a quick look at it. First for indentation use 1 tab in e.g. functions and 1 space for a newline inside a variable. Secondly as I said USE the build style, it seems like the cmake script generates a not fully working Makefile, but the Ninja one seems to work. Pls apply these changes ontop of what the current PR and work from there.
```diff
diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
index 763e0b05dd..ed6f81e33c 100644
--- a/srcpkgs/dino/template
+++ b/srcpkgs/dino/template
@@ -2,10 +2,14 @@
 pkgname=dino
 version=0.1.0
 revision=1
-hostmakedepends="cmake ninja gettext unzip pkg-config vala"
+build_style=cmake
+configure_args="-G Ninja -DDINO_PLUGIN_ENABLED_notification-sound=ON
+ -DDINO_PLUGIN_ENABLED_omemo=OFF"
+make_cmd=ninja
+hostmakedepends="cmake ninja gettext unzip pkg-config vala glib-devel"
 makedepends="glib-devel qrencode-devel gtk+3-devel gpgme-devel
-			libgee08-devel libgcrypt-devel libsoup-devel
-			libsignal-protocol-c sqlite-devel libcanberra-devel"
+ libgee08-devel libgcrypt-devel libsoup-devel
+ libsignal-protocol-c sqlite-devel libcanberra-devel"
 short_desc="Modern XMPP (\"Jabber\") Chat Client using GTK+/Vala"
 maintainer="Anjandev Momi <anjan@momi.ca>"
 license="GPL-3.0-or-later"
@@ -13,14 +17,6 @@ homepage="https://github.com/dino/dino"
 distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
 checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"
 
-do_build() {
-		cmake -G Ninja -B build -S . \
-					-DCMAKE_INSTALL_PREFIX=/usr \
-					-DDINO_PLUGIN_ENABLED_notification-sound=ON \
-					-DDINO_PLUGIN_ENABLED_omemo=OFF
-		ninja -C build
-}
-
 do_install() {
-		vbin build/dino
+	vbin build/dino
 }
```

Re: [PR PATCH] [Closed]: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

There's a closed pull request on the void-packages repository

[WIP] New package: dino-0.1.0
https://github.com/void-linux/void-packages/pull/18648

Description:

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 1899 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-582747063

Comment:
So I did take a quick look at it. First for indentation use 1 tab in e.g. functions and 1 space for a newline inside a variable. Secondly as I said USE the build style, it seems like the cmake script generates a not fully working Makefile, but the Ninja one seems to work. Pls apply these changes ontop of what the current PR and work from there.
```diff
diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
index 763e0b05dd..ed6f81e33c 100644
--- a/srcpkgs/dino/template
+++ b/srcpkgs/dino/template
@@ -2,10 +2,14 @@
 pkgname=dino
 version=0.1.0
 revision=1
-hostmakedepends="cmake ninja gettext unzip pkg-config vala"
+build_style=cmake
+configure_args="-G Ninja -DDINO_PLUGIN_ENABLED_notification-sound=ON
+ -DDINO_PLUGIN_ENABLED_omemo=OFF"
+make_cmd=ninja
+hostmakedepends="cmake ninja gettext unzip pkg-config vala glib-devel"
 makedepends="glib-devel qrencode-devel gtk+3-devel gpgme-devel
-			libgee08-devel libgcrypt-devel libsoup-devel
-			libsignal-protocol-c sqlite-devel libcanberra-devel"
+ libgee08-devel libgcrypt-devel libsoup-devel
+ libsignal-protocol-c sqlite-devel libcanberra-devel"
 short_desc="Modern XMPP (\"Jabber\") Chat Client using GTK+/Vala"
 maintainer="Anjandev Momi <anjan@momi.ca>"
 license="GPL-3.0-or-later"
@@ -13,14 +17,6 @@ homepage="https://github.com/dino/dino"
 distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
 checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"
 
-do_build() {
-		cmake -G Ninja -B build -S . \
-					-DCMAKE_INSTALL_PREFIX=/usr \
-					-DDINO_PLUGIN_ENABLED_notification-sound=ON \
-					-DDINO_PLUGIN_ENABLED_omemo=OFF
-		ninja -C build
-}
-
 do_install() {
-		vbin build/dino
+	vbin build/dino
 }
```

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 2270 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-582804348

Comment:
Patch for this template:
```
From cce12f4afecd58b8c41065f7d16a4dab3fe6511f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Thu, 6 Feb 2020 16:04:18 +0700
Subject: [PATCH] New package: dino-0.1.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
---
 common/shlibs         |  3 +++
 srcpkgs/dino/template | 25 +++++++++++++++++++++++++
 2 files changed, 28 insertions(+)
 create mode 100644 srcpkgs/dino/template

diff --git a/common/shlibs b/common/shlibs
index 78e1d17864..16c430e695 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3798,3 +3798,6 @@ libmdnsd.so.0 libmdnsd-0.8_1
 libPtex.so ptex-2.3.2_1
 libosdGPU.so.3.4.0 OpenSubdiv-3.4.0_1
 libosdCPU.so.3.4.0 OpenSubdiv-3.4.0_1
+libdino.so.0 dino-0.1.0_1
+libxmpp-vala.so.0 dino-0.1.0_1
+libqlite.so.0 dino-0.1.0_1
diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
new file mode 100644
index 0000000000..582c12d5af
--- /dev/null
+++ b/srcpkgs/dino/template
@@ -0,0 +1,25 @@
+# Template file for 'dino'
+pkgname=dino
+version=0.1.0
+revision=1
+build_style=cmake
+configure_args="-G Ninja -DDINO_PLUGIN_ENABLED_notification-sound=ON
+ -DDINO_PLUGIN_ENABLED_omemo=OFF"
+make_cmd=ninja
+hostmakedepends="cmake ninja gettext unzip pkg-config vala glib-devel"
+makedepends="glib-devel qrencode-devel gtk+3-devel gpgme-devel
+ libgee08-devel libgcrypt-devel libsoup-devel
+ libsignal-protocol-c sqlite-devel libcanberra-devel"
+short_desc='Modern XMPP ("Jabber") Chat Client using GTK+/Vala'
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/dino/dino"
+distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
+checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"
+
+do_install() {
+	cd ${cmake_builddir:=build}
+	DESTDIR=${DESTDIR} ninja install
+	rm -rf ${DESTDIR}/usr/include
+	rm -rf ${DESTDIR}/usr/lib/*.so
+}
-- 
2.25.0.191.gde93cc14ab
```

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 2355 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-582804348

Comment:
https://github.com/sgn/void-packages/commit/120864e809e69502f2d402730e73022ee7addc80
Patch for this package:
```
From cce12f4afecd58b8c41065f7d16a4dab3fe6511f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Thu, 6 Feb 2020 16:04:18 +0700
Subject: [PATCH] New package: dino-0.1.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
---
 common/shlibs         |  3 +++
 srcpkgs/dino/template | 25 +++++++++++++++++++++++++
 2 files changed, 28 insertions(+)
 create mode 100644 srcpkgs/dino/template

diff --git a/common/shlibs b/common/shlibs
index 78e1d17864..16c430e695 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3798,3 +3798,6 @@ libmdnsd.so.0 libmdnsd-0.8_1
 libPtex.so ptex-2.3.2_1
 libosdGPU.so.3.4.0 OpenSubdiv-3.4.0_1
 libosdCPU.so.3.4.0 OpenSubdiv-3.4.0_1
+libdino.so.0 dino-0.1.0_1
+libxmpp-vala.so.0 dino-0.1.0_1
+libqlite.so.0 dino-0.1.0_1
diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
new file mode 100644
index 0000000000..582c12d5af
--- /dev/null
+++ b/srcpkgs/dino/template
@@ -0,0 +1,25 @@
+# Template file for 'dino'
+pkgname=dino
+version=0.1.0
+revision=1
+build_style=cmake
+configure_args="-G Ninja -DDINO_PLUGIN_ENABLED_notification-sound=ON
+ -DDINO_PLUGIN_ENABLED_omemo=OFF"
+make_cmd=ninja
+hostmakedepends="cmake ninja gettext unzip pkg-config vala glib-devel"
+makedepends="glib-devel qrencode-devel gtk+3-devel gpgme-devel
+ libgee08-devel libgcrypt-devel libsoup-devel
+ libsignal-protocol-c sqlite-devel libcanberra-devel"
+short_desc='Modern XMPP ("Jabber") Chat Client using GTK+/Vala'
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/dino/dino"
+distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
+checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"
+
+do_install() {
+	cd ${cmake_builddir:=build}
+	DESTDIR=${DESTDIR} ninja install
+	rm -rf ${DESTDIR}/usr/include
+	rm -rf ${DESTDIR}/usr/lib/*.so
+}
-- 
2.25.0.191.gde93cc14ab
```

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-582816627

Comment:
b089612565088e7e5e8798ff1ebcd15d459af399 You should be able to enable omemo now.

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 2293 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-582804348

Comment:
https://github.com/sgn/void-packages/commit/120864e809e69502f2d402730e73022ee7addc80
Patch for this package:
```diff
From ea2458baae15c6e560a499c8072c8066f1e801e8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Thu, 6 Feb 2020 16:04:18 +0700
Subject: [PATCH] New package: dino-0.1.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
---
 common/shlibs         |  3 +++
 srcpkgs/dino/template | 23 +++++++++++++++++++++++
 2 files changed, 26 insertions(+)
 create mode 100644 srcpkgs/dino/template

diff --git a/common/shlibs b/common/shlibs
index 78e1d17864..16c430e695 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3798,3 +3798,6 @@ libmdnsd.so.0 libmdnsd-0.8_1
 libPtex.so ptex-2.3.2_1
 libosdGPU.so.3.4.0 OpenSubdiv-3.4.0_1
 libosdCPU.so.3.4.0 OpenSubdiv-3.4.0_1
+libdino.so.0 dino-0.1.0_1
+libxmpp-vala.so.0 dino-0.1.0_1
+libqlite.so.0 dino-0.1.0_1
diff --git a/srcpkgs/dino/template b/srcpkgs/dino/template
new file mode 100644
index 0000000000..14f1804fa7
--- /dev/null
+++ b/srcpkgs/dino/template
@@ -0,0 +1,23 @@
+# Template file for 'dino'
+pkgname=dino
+version=0.1.0
+revision=1
+build_style=cmake
+configure_args="-GNinja -DDINO_PLUGIN_ENABLED_notification-sound=ON
+ -DDINO_PLUGIN_ENABLED_omemo=OFF"
+make_cmd=ninja
+hostmakedepends="cmake ninja gettext unzip pkg-config vala glib-devel"
+makedepends="glib-devel qrencode-devel gtk+3-devel gpgme-devel
+ libgee08-devel libgcrypt-devel libsoup-devel
+ libsignal-protocol-c sqlite-devel libcanberra-devel"
+short_desc='Modern XMPP ("Jabber") Chat Client using GTK+/Vala'
+maintainer="Anjandev Momi <anjan@momi.ca>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/dino/dino"
+distfiles="https://github.com/dino/dino/archive/v${version}.tar.gz"
+checksum="202b7db322d85389b0bebc3c38976e7f7beaceddd1fc46b8123e50c6c7c07b8d"
+
+post_install() {
+	rm -rf ${DESTDIR}/usr/include
+	rm -rf ${DESTDIR}/usr/lib/*.so
+}
-- 
2.25.0.191.gde93cc14ab

```

Re: [WIP] New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

New comment by anjandev on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-583072589

Comment:
I enabled omemo and merged @sgn's changes. I just sent my first omemo message using dino on void! This PR should be ready to be merged. Thanks for helping me everyone.

Re: New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-583641953

Comment:
Doing a build now, let's see.

Re: New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/18648#issuecomment-583645271

Comment:
Built, tested. Works even on a big endian powermac g5 :P

Re: [PR PATCH] [Merged]: New package: dino-0.1.0

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

There's a merged pull request on the void-packages repository

New package: dino-0.1.0
https://github.com/void-linux/void-packages/pull/18648

Description: