Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: font-jetbrainsmono-1.0.2
@ 2020-01-30 21:35 voidlinux-github
  2020-02-26 17:48 ` gcat432
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: voidlinux-github @ 2020-01-30 21:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

There is a new pull request by RinsedSloth against master on the void-packages repository

https://github.com/RinsedSloth/void-packages master
https://github.com/void-linux/void-packages/pull/18671

New package: font-jetbrainsmono-1.0.2
New free TrueType font with ligatures by the JetBrains team for their IDEs but also available standalone.

A patch file from https://github.com/void-linux/void-packages/pull/18671.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-18671.patch --]
[-- Type: text/x-diff, Size: 1324 bytes --]

From 7b9dff5d539b5a501e43483117c2f749d732b5ad Mon Sep 17 00:00:00 2001
From: RinsedSloth <afernandezh@protonmail.com>
Date: Thu, 30 Jan 2020 22:25:15 +0100
Subject: [PATCH] New package: font-jetbrainsmono-1.0.2

---
 srcpkgs/font-jetbrainsmono/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/font-jetbrainsmono/template

diff --git a/srcpkgs/font-jetbrainsmono/template b/srcpkgs/font-jetbrainsmono/template
new file mode 100644
index 00000000000..cc04c35671a
--- /dev/null
+++ b/srcpkgs/font-jetbrainsmono/template
@@ -0,0 +1,20 @@
+# Template file for 'font-jetbrainsmono'
+pkgname=font-jetbrainsmono
+version=1.0.2
+revision=1
+archs=noarch
+create_wrksrc=yes
+hostmakedepends="unzip"
+depends="font-util"
+short_desc="JetbrainsMono: Typeface font with ligatures for programming"
+maintainer="RinsedSloth <afernandezh@protonmail.com>"
+license="Apache-2.0"
+homepage="https://github.com/JetBrains/JetBrainsMono"
+distfiles="https://github.com/JetBrains/JetBrainsMono/releases/download/v${version}/JetBrainsMono-${version}.zip"
+checksum=59f9b9762d5625eb438eedf034dbbcdcf09ed18ded994540b466872840229762
+font_dirs="/usr/share/fonts/TTF"
+
+do_install() {
+	mkdir -p usr/share/fonts/TTF
+	find . -type f -name '*.ttf' -exec install -Dm644 '{}' ${DESTDIR}/${font_dirs} \;
+}

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New package: font-jetbrainsmono-1.0.2
  2020-01-30 21:35 [PR PATCH] New package: font-jetbrainsmono-1.0.2 voidlinux-github
@ 2020-02-26 17:48 ` gcat432
  2020-02-26 17:49 ` gcat432
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: gcat432 @ 2020-02-26 17:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]

New comment by gcat432 on void-packages repository

https://github.com/void-linux/void-packages/pull/18671#issuecomment-591555084

Comment:
Thank you for your contribution. I would suggest some modifications as I was not able to install this package using your template.

```
# Template file for 'font-jetbrainsmono'
pkgname=font-jetbrainsmono
version=1.0.3
revision=1
wrksrc="JetBrainsMono-${version}"
archs=noarch
short_desc="JetbrainsMono: Typeface font with ligatures for programming"
maintainer="RinsedSloth <afernandezh@protonmail.com>"
license="Apache-2.0"
homepage="https://github.com/JetBrains/JetBrainsMono"
distfiles="https://github.com/JetBrains/JetBrainsMono/archive/v${version}.tar.gz"
checksum=24b423336d702e209a7181873300f855078d2c47e1a519c63ce57755ea7569ea

font_dirs="/usr/share/fonts/TTF"

do_install() {
	vmkdir usr/share/fonts/TTF
  
  cd ttf
	for f in *.ttf; do
		vinstall $f 0644 /usr/share/fonts/TTF
	done
}
```

Furthermore, packages seems to be names with `ttf` like for example `font-hack-ttf`, so maybe it is to be reconsidered but it would be better to ask someone from the team for a confirmation.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New package: font-jetbrainsmono-1.0.2
  2020-01-30 21:35 [PR PATCH] New package: font-jetbrainsmono-1.0.2 voidlinux-github
  2020-02-26 17:48 ` gcat432
@ 2020-02-26 17:49 ` gcat432
  2020-02-26 17:49 ` gcat432
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: gcat432 @ 2020-02-26 17:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]

New comment by gcat432 on void-packages repository

https://github.com/void-linux/void-packages/pull/18671#issuecomment-591555084

Comment:
Thank you for your contribution. I would suggest some modifications as I was not able to install this package using your template.

```
# Template file for 'font-jetbrainsmono'
pkgname=font-jetbrainsmono
version=1.0.3
revision=1
wrksrc="JetBrainsMono-${version}"
archs=noarch
short_desc="JetbrainsMono: Typeface font with ligatures for programming"
maintainer="RinsedSloth <afernandezh@protonmail.com>"
license="Apache-2.0"
homepage="https://github.com/JetBrains/JetBrainsMono"
distfiles="https://github.com/JetBrains/JetBrainsMono/archive/v${version}.tar.gz"
checksum=24b423336d702e209a7181873300f855078d2c47e1a519c63ce57755ea7569ea

font_dirs="/usr/share/fonts/TTF"

do_install() {
	vmkdir usr/share/fonts/TTF

	cd ttf
		for f in *.ttf; do
			vinstall $f 0644 /usr/share/fonts/TTF
		done
}
```

Furthermore, packages seems to be names with `ttf` like for example `font-hack-ttf`, so maybe it is to be reconsidered but it would be better to ask someone from the team for a confirmation.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New package: font-jetbrainsmono-1.0.2
  2020-01-30 21:35 [PR PATCH] New package: font-jetbrainsmono-1.0.2 voidlinux-github
  2020-02-26 17:48 ` gcat432
  2020-02-26 17:49 ` gcat432
@ 2020-02-26 17:49 ` gcat432
  2020-02-26 17:50 ` gcat432
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: gcat432 @ 2020-02-26 17:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]

New comment by gcat432 on void-packages repository

https://github.com/void-linux/void-packages/pull/18671#issuecomment-591555084

Comment:
Thank you for your contribution. I would suggest some modifications as I was not able to install this package using your template.

```
# Template file for 'font-jetbrainsmono'
pkgname=font-jetbrainsmono
version=1.0.3
revision=1
wrksrc="JetBrainsMono-${version}"
archs=noarch
short_desc="JetbrainsMono: Typeface font with ligatures for programming"
maintainer="RinsedSloth <afernandezh@protonmail.com>"
license="Apache-2.0"
homepage="https://github.com/JetBrains/JetBrainsMono"
distfiles="https://github.com/JetBrains/JetBrainsMono/archive/v${version}.tar.gz"
checksum=24b423336d702e209a7181873300f855078d2c47e1a519c63ce57755ea7569ea

font_dirs="/usr/share/fonts/TTF"

do_install() {
	vmkdir usr/share/fonts/TTF

	cd ttf
	for f in *.ttf; do
		vinstall $f 0644 /usr/share/fonts/TTF
	done
}
```

Furthermore, packages seems to be names with `ttf` like for example `font-hack-ttf`, so maybe it is to be reconsidered but it would be better to ask someone from the team for a confirmation.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New package: font-jetbrainsmono-1.0.2
  2020-01-30 21:35 [PR PATCH] New package: font-jetbrainsmono-1.0.2 voidlinux-github
                   ` (2 preceding siblings ...)
  2020-02-26 17:49 ` gcat432
@ 2020-02-26 17:50 ` gcat432
  2020-03-04 18:40 ` alferguet
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: gcat432 @ 2020-02-26 17:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]

New comment by gcat432 on void-packages repository

https://github.com/void-linux/void-packages/pull/18671#issuecomment-591555084

Comment:
Thank you for your contribution. I would suggest some modifications as I was not able to install this package using your template.

```
# Template file for 'font-jetbrainsmono'
pkgname=font-jetbrainsmono
version=1.0.3
revision=1
wrksrc="JetBrainsMono-${version}"
archs=noarch
short_desc="JetbrainsMono: Typeface font with ligatures for programming"
maintainer="RinsedSloth <afernandezh@protonmail.com>"
license="Apache-2.0"
homepage="https://github.com/JetBrains/JetBrainsMono"
distfiles="https://github.com/JetBrains/JetBrainsMono/archive/v${version}.tar.gz"
checksum=24b423336d702e209a7181873300f855078d2c47e1a519c63ce57755ea7569ea

font_dirs="/usr/share/fonts/TTF"

do_install() {
	vmkdir usr/share/fonts/TTF

	cd ttf
	for f in *.ttf; do
		vinstall $f 0644 /usr/share/fonts/TTF
	done
}
```

Furthermore, TTF fonts packages seem to be named with `ttf` like for example `font-hack-ttf`, so maybe it is to be reconsidered but it would be better to ask someone from the team for a confirmation.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New package: font-jetbrainsmono-1.0.2
  2020-01-30 21:35 [PR PATCH] New package: font-jetbrainsmono-1.0.2 voidlinux-github
                   ` (3 preceding siblings ...)
  2020-02-26 17:50 ` gcat432
@ 2020-03-04 18:40 ` alferguet
  2020-03-05  3:53 ` gcat432
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: alferguet @ 2020-03-04 18:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

New comment by alferguet on void-packages repository

https://github.com/void-linux/void-packages/pull/18671#issuecomment-594739287

Comment:
Sorry for the late response @gcat432, been quite busy extinguishing some fires at work . I appreciate your input for the package, as installed manually the font before packaging it could be why it didn't work for you as at least packaged without trouble for me.

Your template looks much cleaner and it is great that you use vinstall as opposed to me that didn't know the use of it at the time of the creation. I took the firacode template as inspiration.

I think it is a good idea to include the type of the font in the name.

In fact, I do not longer have access to the fork where I did create this PR so don't know if it is possible to modify it so with the pardon of the mantainers I am going to create a new one with this template that I have checked it works if it is fine for you. As it is your work want to give you credit for the template but if you wish to be the mantainer I think it is fair.




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New package: font-jetbrainsmono-1.0.2
  2020-01-30 21:35 [PR PATCH] New package: font-jetbrainsmono-1.0.2 voidlinux-github
                   ` (4 preceding siblings ...)
  2020-03-04 18:40 ` alferguet
@ 2020-03-05  3:53 ` gcat432
  2020-03-05  3:54 ` gcat432
  2020-03-05  5:45 ` [PR PATCH] [Closed]: " alferguet
  7 siblings, 0 replies; 9+ messages in thread
From: gcat432 @ 2020-03-05  3:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by gcat432 on void-packages repository

https://github.com/void-linux/void-packages/pull/18671#issuecomment-595015235

Comment:
That is fine, you can freely use it and be the maintainer :)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New package: font-jetbrainsmono-1.0.2
  2020-01-30 21:35 [PR PATCH] New package: font-jetbrainsmono-1.0.2 voidlinux-github
                   ` (5 preceding siblings ...)
  2020-03-05  3:53 ` gcat432
@ 2020-03-05  3:54 ` gcat432
  2020-03-05  5:45 ` [PR PATCH] [Closed]: " alferguet
  7 siblings, 0 replies; 9+ messages in thread
From: gcat432 @ 2020-03-05  3:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by gcat432 on void-packages repository

https://github.com/void-linux/void-packages/pull/18671#issuecomment-595015235

Comment:
That is fine, you can freely use and modify it and be the maintainer :grin:

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Closed]: New package: font-jetbrainsmono-1.0.2
  2020-01-30 21:35 [PR PATCH] New package: font-jetbrainsmono-1.0.2 voidlinux-github
                   ` (6 preceding siblings ...)
  2020-03-05  3:54 ` gcat432
@ 2020-03-05  5:45 ` alferguet
  7 siblings, 0 replies; 9+ messages in thread
From: alferguet @ 2020-03-05  5:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

There's a closed pull request on the void-packages repository

New package: font-jetbrainsmono-1.0.2
https://github.com/void-linux/void-packages/pull/18671

Description:
New free TrueType font with ligatures by the JetBrains team for their IDEs but also available standalone.

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-03-05  5:45 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-30 21:35 [PR PATCH] New package: font-jetbrainsmono-1.0.2 voidlinux-github
2020-02-26 17:48 ` gcat432
2020-02-26 17:49 ` gcat432
2020-02-26 17:49 ` gcat432
2020-02-26 17:50 ` gcat432
2020-03-04 18:40 ` alferguet
2020-03-05  3:53 ` gcat432
2020-03-05  3:54 ` gcat432
2020-03-05  5:45 ` [PR PATCH] [Closed]: " alferguet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).