* [PR PATCH] 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines
@ 2020-04-24 0:26 sirikid
2020-04-24 0:29 ` Vaelatern
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: sirikid @ 2020-04-24 0:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
There is a new pull request by sirikid against master on the void-packages repository
https://github.com/sirikid/void-packages don't-strip-unknown-binaries
https://github.com/void-linux/void-packages/pull/21288
06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines
Because most likely these files are not executables, but some kind of bytecode. And strip doesn't know how to strip them anyway.
A patch file from https://github.com/void-linux/void-packages/pull/21288.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-don't-strip-unknown-binaries-21288.patch --]
[-- Type: text/x-diff, Size: 920 bytes --]
From 0c9e4688447228e7d6434870893b8eb5b3ab1e54 Mon Sep 17 00:00:00 2001
From: a <a@a.a>
Date: Fri, 24 Apr 2020 03:16:18 +0300
Subject: [PATCH] 06-strip-and-debug-pkgs.sh: ignore binaries for unknown
machines
Because most likely these files are not executables, but some kind of
bytecode. And strip doesn't know how to strip them anyway.
---
common/hooks/post-install/06-strip-and-debug-pkgs.sh | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/common/hooks/post-install/06-strip-and-debug-pkgs.sh b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
index a15dd1a96c3..44d8a51fe93 100644
--- a/common/hooks/post-install/06-strip-and-debug-pkgs.sh
+++ b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
@@ -70,6 +70,10 @@ hook() {
continue
fi
+ if [[ $(file -b "$f") =~ "no machine" ]]; then
+ continue
+ fi
+
fname=${f##*/}
for x in ${nostrip_files}; do
if [ "$x" = "$fname" ]; then
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines
2020-04-24 0:26 [PR PATCH] 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines sirikid
@ 2020-04-24 0:29 ` Vaelatern
2020-04-24 0:35 ` sirikid
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Vaelatern @ 2020-04-24 0:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
New comment by Vaelatern on void-packages repository
https://github.com/void-linux/void-packages/pull/21288#issuecomment-618737867
Comment:
Can you give an example of an affected package?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines
2020-04-24 0:26 [PR PATCH] 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines sirikid
2020-04-24 0:29 ` Vaelatern
@ 2020-04-24 0:35 ` sirikid
2020-04-24 0:42 ` Vaelatern
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: sirikid @ 2020-04-24 0:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 340 bytes --]
New comment by sirikid on void-packages repository
https://github.com/void-linux/void-packages/pull/21288#issuecomment-618739247
Comment:
Guile uses ELF as a container for bytecode, so each package with it must be marked as nostrip or list all bytecode files in nostrip_files. This can be quite annoying and feels completely unnecessary.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines
2020-04-24 0:26 [PR PATCH] 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines sirikid
2020-04-24 0:29 ` Vaelatern
2020-04-24 0:35 ` sirikid
@ 2020-04-24 0:42 ` Vaelatern
2020-04-24 0:53 ` sirikid
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Vaelatern @ 2020-04-24 0:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 250 bytes --]
New comment by Vaelatern on void-packages repository
https://github.com/void-linux/void-packages/pull/21288#issuecomment-618740979
Comment:
I can't verify that right now, but would love to see a build log, got a travis link handy to a guile build?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines
2020-04-24 0:26 [PR PATCH] 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines sirikid
` (2 preceding siblings ...)
2020-04-24 0:42 ` Vaelatern
@ 2020-04-24 0:53 ` sirikid
2020-04-24 1:22 ` sirikid
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: sirikid @ 2020-04-24 0:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 307 bytes --]
New comment by sirikid on void-packages repository
https://github.com/void-linux/void-packages/pull/21288#issuecomment-618743447
Comment:
I will add the build log later. Here is [a mention of ELF][1] in the Guile manual.
[1]: https://www.gnu.org/software/guile/manual/html_node/Object-File-Format.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines
2020-04-24 0:26 [PR PATCH] 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines sirikid
` (3 preceding siblings ...)
2020-04-24 0:53 ` sirikid
@ 2020-04-24 1:22 ` sirikid
2020-04-24 3:00 ` Vaelatern
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: sirikid @ 2020-04-24 1:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 236 bytes --]
New comment by sirikid on void-packages repository
https://github.com/void-linux/void-packages/pull/21288#issuecomment-618750655
Comment:
[Build log][1]
[1]: https://travis-ci.org/github/sirikid/void-packages/jobs/678846086#L10007
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines
2020-04-24 0:26 [PR PATCH] 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines sirikid
` (4 preceding siblings ...)
2020-04-24 1:22 ` sirikid
@ 2020-04-24 3:00 ` Vaelatern
2020-04-24 3:01 ` [PR PATCH] [Merged]: " Vaelatern
2020-04-25 0:06 ` sirikid
7 siblings, 0 replies; 9+ messages in thread
From: Vaelatern @ 2020-04-24 3:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 298 bytes --]
New comment by Vaelatern on void-packages repository
https://github.com/void-linux/void-packages/pull/21288#issuecomment-618774854
Comment:
This looks like a reasonable modification to me. I'm merging, if it's a bad idea then that will be noted in the commit logs when someone tears it back out.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Merged]: 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines
2020-04-24 0:26 [PR PATCH] 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines sirikid
` (5 preceding siblings ...)
2020-04-24 3:00 ` Vaelatern
@ 2020-04-24 3:01 ` Vaelatern
2020-04-25 0:06 ` sirikid
7 siblings, 0 replies; 9+ messages in thread
From: Vaelatern @ 2020-04-24 3:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 326 bytes --]
There's a merged pull request on the void-packages repository
06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines
https://github.com/void-linux/void-packages/pull/21288
Description:
Because most likely these files are not executables, but some kind of bytecode. And strip doesn't know how to strip them anyway.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines
2020-04-24 0:26 [PR PATCH] 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines sirikid
` (6 preceding siblings ...)
2020-04-24 3:01 ` [PR PATCH] [Merged]: " Vaelatern
@ 2020-04-25 0:06 ` sirikid
7 siblings, 0 replies; 9+ messages in thread
From: sirikid @ 2020-04-25 0:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
New comment by sirikid on void-packages repository
https://github.com/void-linux/void-packages/pull/21288#issuecomment-619286805
Comment:
A better approach would be to identify bytecode files and strip them, but right now I don't know how to do this.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-04-25 0:06 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 0:26 [PR PATCH] 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines sirikid
2020-04-24 0:29 ` Vaelatern
2020-04-24 0:35 ` sirikid
2020-04-24 0:42 ` Vaelatern
2020-04-24 0:53 ` sirikid
2020-04-24 1:22 ` sirikid
2020-04-24 3:00 ` Vaelatern
2020-04-24 3:01 ` [PR PATCH] [Merged]: " Vaelatern
2020-04-25 0:06 ` sirikid
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).