[PR PATCH] 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines

[PR PATCH] 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines

[sirikid]

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

There is a new pull request by sirikid against master on the void-packages repository

https://github.com/sirikid/void-packages don't-strip-unknown-binaries
https://github.com/void-linux/void-packages/pull/21288

06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines
Because most likely these files are not executables, but some kind of bytecode. And strip doesn't know how to strip them anyway.

A patch file from https://github.com/void-linux/void-packages/pull/21288.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-don't-strip-unknown-binaries-21288.patch --]
[-- Type: text/x-diff, Size: 920 bytes --]

From 0c9e4688447228e7d6434870893b8eb5b3ab1e54 Mon Sep 17 00:00:00 2001
From: a <a@a.a>
Date: Fri, 24 Apr 2020 03:16:18 +0300
Subject: [PATCH] 06-strip-and-debug-pkgs.sh: ignore binaries for unknown
 machines

Because most likely these files are not executables, but some kind of
bytecode. And strip doesn't know how to strip them anyway.
---
 common/hooks/post-install/06-strip-and-debug-pkgs.sh | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/common/hooks/post-install/06-strip-and-debug-pkgs.sh b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
index a15dd1a96c3..44d8a51fe93 100644
--- a/common/hooks/post-install/06-strip-and-debug-pkgs.sh
+++ b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
@@ -70,6 +70,10 @@ hook() {
 			continue
 		fi
 
+		if [[ $(file -b "$f") =~ "no machine" ]]; then
+			continue
+		fi
+
 		fname=${f##*/}
 		for x in ${nostrip_files}; do
 			if [ "$x" = "$fname" ]; then

Re: 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/21288#issuecomment-618737867

Comment:
Can you give an example of an affected package?

Re: 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines

[sirikid]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

New comment by sirikid on void-packages repository

https://github.com/void-linux/void-packages/pull/21288#issuecomment-618739247

Comment:
Guile uses ELF as a container for bytecode, so each package with it must be marked as nostrip or list all bytecode files in nostrip_files. This can be quite annoying and feels completely unnecessary.

Re: 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/21288#issuecomment-618740979

Comment:
I can't verify that right now, but would love to see a build log, got a travis link handy to a guile build?

Re: 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines

[sirikid]

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

New comment by sirikid on void-packages repository

https://github.com/void-linux/void-packages/pull/21288#issuecomment-618743447

Comment:
I will add the build log later. Here is [a mention of ELF][1] in the Guile manual.

[1]: https://www.gnu.org/software/guile/manual/html_node/Object-File-Format.html

Re: 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines

[sirikid]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New comment by sirikid on void-packages repository

https://github.com/void-linux/void-packages/pull/21288#issuecomment-618750655

Comment:
[Build log][1]

[1]: https://travis-ci.org/github/sirikid/void-packages/jobs/678846086#L10007

Re: 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/21288#issuecomment-618774854

Comment:
This looks like a reasonable modification to me. I'm merging, if it's a bad idea then that will be noted in the commit logs when someone tears it back out.

Re: [PR PATCH] [Merged]: 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

There's a merged pull request on the void-packages repository

06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines
https://github.com/void-linux/void-packages/pull/21288

Description:
Because most likely these files are not executables, but some kind of bytecode. And strip doesn't know how to strip them anyway.

Re: 06-strip-and-debug-pkgs.sh: ignore binaries for unknown machines

[sirikid]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New comment by sirikid on void-packages repository

https://github.com/void-linux/void-packages/pull/21288#issuecomment-619286805

Comment:
A better approach would be to identify bytecode files and strip them, but right now I don't know how to do this.