Re: Improve consistency of relative paths in kernel hooks

[ahesford <ahesford@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1917 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24079#issuecomment-669474162

Comment:
On 2020-08-05 at 15:28 (UTC -0400), Érico Nogueira Rolim wrote:
> @ericonr commented on this pull request.
> 
> 
> 
> >  version=0.141
> -revision=1
> +revision=2
> 
> Why not increase `base-files` version directly?

Before the last bump there was a long history of revbumping, and a
version bump seems a bit "heavy" for a minor fix.

> > +if [ ! -x usr/bin/dracut ]; then
>  	exit 0
>  fi
> 
> I don't like this, because the hook should only be there if dracut itself is installed. @sgn and I didn't include it in the `dracut-uefi` hook.

That's not unreasonable, but there are many hooks (including in
`kernel-uefi-postinst`) that follow this pattern.

> > @@ -7,7 +7,5 @@
>  PKGNAME="$1"
>  VERSION="$2"
>  
> -if [ -f boot/initramfs-${VERSION}.img ]; then
> -	rm -f boot/initramfs-${VERSION}.img
> -fi
> +rm -f boot/initramfs-${VERSION}.img
> 
> Perhaps make this one verbose as well?

I object to verbose removes even in your UEFI hook. There is no need to
clutter output with messages that an initramfs is being removed when
that's the expected action.

> >  	msg "failed to sign kernel"
>  	exit 1
>  fi
>  
> -if ! sbverify -c "${EFI_CERT_FILE}" "/boot/vmlinuz-${VERSION}.signed"; then
> +if ! sbverify -c "${EFI_CERT_FILE}" "boot/vmlinuz-${VERSION}.signed"; then
> 
> Why not use `usr/bin/sbverify` here as well?
> 
> > @@ -38,17 +38,17 @@ if [ "x${EFI_SIGN_ENGINE}" != x ]; then
>  fi
>  
>  if ! sbsign $options -k "${EFI_KEY_FILE}" -c "${EFI_CERT_FILE}" \
> 
> Same here.

Good points, fixed.

> -- 
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub:
> https://github.com/void-linux/void-packages/pull/24079#pullrequestreview-461955666

-- 
Andrew J. Hesford
ajh@sideband.org
(Personal communication)