From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Improve consistency of relative paths in kernel hooks
Date: Thu, 06 Aug 2020 05:18:28 +0200 [thread overview]
Message-ID: <20200806031828.Of4nXYNV9Bqe0KvIbzMbBog9okdildryw9-LQKOU5N0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24079@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/24079#issuecomment-669658973
Comment:
On 2020-08-05 at 22:09 (UTC -0400), Danh Doan wrote:
>
> The complicated logic below it to ensure if we don't have
> `boot/EFI/refind/refind.conf`, we'll create it.
>
> So, `exit 0` isn't a right choice.
`readlink -m [...]` should always resolve a path because it doesn't
require any of the components to exist. In practice, `$REFIND_CONF` will
*never* be empty, but just in case something goes unexpectedly wrong
(suppose `readlink` is not found or executable, for example), we just
want to give up.
> for sbsigntool, please use the commit from #23688
I'll pull in the commit.
--
Andrew J. Hesford
ajh@sideband.org
(Personal communication)
next prev parent reply other threads:[~2020-08-06 3:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 16:34 [PR PATCH] " ahesford
2020-08-05 19:27 ` [PR REVIEW] " ericonr
2020-08-05 19:27 ` ericonr
2020-08-05 19:27 ` ericonr
2020-08-05 19:27 ` ericonr
2020-08-05 19:27 ` ericonr
2020-08-05 20:06 ` [PR PATCH] [Updated] " ahesford
2020-08-05 20:06 ` ahesford
2020-08-05 20:26 ` ericonr
2020-08-06 1:09 ` [PR REVIEW] " sgn
2020-08-06 1:12 ` sgn
2020-08-06 1:49 ` ahesford
2020-08-06 2:09 ` sgn
2020-08-06 3:18 ` ahesford [this message]
2020-08-06 3:31 ` [PR PATCH] [Updated] " ahesford
2020-08-06 3:32 ` ahesford
2020-08-06 11:42 ` sgn
2020-08-06 11:52 ` sgn
2020-08-06 12:05 ` sgn
2020-08-06 12:10 ` sgn
2020-08-06 12:14 ` sgn
2020-08-06 12:41 ` sgn
2020-08-07 2:43 ` [PR PATCH] [Updated] " ahesford
2020-08-07 2:45 ` ahesford
2020-08-07 5:49 ` [PR REVIEW] " ericonr
2020-08-07 11:12 ` sgn
2020-08-07 13:05 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806031828.Of4nXYNV9Bqe0KvIbzMbBog9okdildryw9-LQKOU5N0@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).