From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Improve consistency of relative paths in kernel hooks
Date: Thu, 06 Aug 2020 14:41:21 +0200 [thread overview]
Message-ID: <20200806124121.cwKZ2nn82BWo0T7br5RJdAgo8TXUSN-RgZUYv64mR18@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24079@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/24079#issuecomment-669887298
Comment:
Simplified refind, no complicated logic, what do you think?
For your convenience, that patch can be taken from here: https://github.com/void-linux/void-packages/pull/23688/commits/53bdcc8d3e0f41f29ed5dccaa0496ed1052bd7de
```sh
#!/bin/sh
#
# Kernel hook for refind.
#
# Arguments passed to this script: $1 pkgname, $2 version.
#
PKGNAME="$1"
VERSION="$2"
. "${ROOTDIR}/etc/default/refind-kernel-hook.conf"
if [ "z$UPDATE_REFIND_CONF" != "z1" ]; then
exit 0;
fi
# Default refind.conf
: "${REFIND_CONF:=boot/EFI/refind/refind.conf}"
REFIND_CONF=${REFIND_CONF#/}
[ -n "${REFIND_CONF}" ] || exit 0
# refind-install only supports those two paths
refind_dir=
case "$REFIND_CONF" in
*/EFI/[Bb][Oo][Oo][Tt]/refind.conf)
refind_dir="/EFI/BOOT" ;;
*/EFI/refind/refind.conf)
refind_dir="/EFI/refind" ;;
*)
echo >&2 "unsupported \$REFIND_CONF: $REFIND_CONF"
exit 1 ;;
esac
tmpfile=$(mktemp /tmp/refind.XXXXXXX)
zversion=$(echo "$VERSION" | sed 's/[.]/[.]/g')
(
cat <<EOF
menuentry "Void Linux $VERSION" {
icon $refind_dir/icons/os_void.png
volume "Void Linux"
loader /vmlinuz-$VERSION
initrd /initramfs-$VERSION.img
options "$OPTIONS"
}
EOF
# Clean itself if this is force reconfigure
sed "/^menuentry \"Void Linux $zversion\" [{]\$/,/[}]/d" <"$REFIND_CONF"
) >"$tmpfile"
mv "$tmpfile" "$REFIND_CONF"
exit 0
```
---
EDIT: `cat` first, `sed` later, keep old conf layout.
next prev parent reply other threads:[~2020-08-06 12:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 16:34 [PR PATCH] " ahesford
2020-08-05 19:27 ` [PR REVIEW] " ericonr
2020-08-05 19:27 ` ericonr
2020-08-05 19:27 ` ericonr
2020-08-05 19:27 ` ericonr
2020-08-05 19:27 ` ericonr
2020-08-05 20:06 ` [PR PATCH] [Updated] " ahesford
2020-08-05 20:06 ` ahesford
2020-08-05 20:26 ` ericonr
2020-08-06 1:09 ` [PR REVIEW] " sgn
2020-08-06 1:12 ` sgn
2020-08-06 1:49 ` ahesford
2020-08-06 2:09 ` sgn
2020-08-06 3:18 ` ahesford
2020-08-06 3:31 ` [PR PATCH] [Updated] " ahesford
2020-08-06 3:32 ` ahesford
2020-08-06 11:42 ` sgn
2020-08-06 11:52 ` sgn
2020-08-06 12:05 ` sgn
2020-08-06 12:10 ` sgn
2020-08-06 12:14 ` sgn
2020-08-06 12:41 ` sgn [this message]
2020-08-07 2:43 ` [PR PATCH] [Updated] " ahesford
2020-08-07 2:45 ` ahesford
2020-08-07 5:49 ` [PR REVIEW] " ericonr
2020-08-07 11:12 ` sgn
2020-08-07 13:05 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806124121.cwKZ2nn82BWo0T7br5RJdAgo8TXUSN-RgZUYv64mR18@z \
--to=sgn@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).