From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Improve consistency of relative paths in kernel hooks
Date: Thu, 06 Aug 2020 03:12:16 +0200 [thread overview]
Message-ID: <20200806011216.7mrm1kubCw_FL4Dtgp0s1w6RTILFCsizyCs4Zu2j-98@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24079@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/24079#discussion_r466088097
Comment:
This is not correct.
It'll break if user has changed their configuration.
And this will break the path relative to <esp> mountpoint.
Maybe something like this?
```diff
diff --git a/srcpkgs/refind/files/kernel.post-install b/srcpkgs/refind/files/kernel.post-install
index 88b261aaac..70f26936c0 100755
--- a/srcpkgs/refind/files/kernel.post-install
+++ b/srcpkgs/refind/files/kernel.post-install
@@ -15,7 +15,14 @@ fi
# Default refind.conf
: "${REFIND_CONF:=/boot/EFI/refind/refind.conf}"
+abs_rootdir="$(cd "${ROOTDIR}" && pwd)"
+if [ "$abs_rootdir" != "/" ]; then
+ abs_rootdir="$abs_rootdir/"
+fi
+
+REFIND_CONF="${abs_rootdir}${REFIND_CONF#/}"
zrefind_dir="${REFIND_CONF%/*}"
+
mkdir -p "$zrefind_dir"
touch "$REFIND_CONF"
diff --git a/srcpkgs/refind/files/kernel.post-remove b/srcpkgs/refind/files/kernel.post-remove
index efb3786396..b50f19680b 100755
--- a/srcpkgs/refind/files/kernel.post-remove
+++ b/srcpkgs/refind/files/kernel.post-remove
@@ -13,7 +13,8 @@ if [ "z$UPDATE_REFIND_CONF" != "z1" ]; then
fi
# Default refind.conf
-: "${REFIND_CONF:=/boot/EFI/refind/refind.conf}"
+: "${REFIND_CONF:=boot/EFI/refind/refind.conf}"
+REFIND_CONF="${REFIND_CONF#/}"
[ -f "$REFIND_CONF" ] || exit 0
```
next prev parent reply other threads:[~2020-08-06 1:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 16:34 [PR PATCH] " ahesford
2020-08-05 19:27 ` [PR REVIEW] " ericonr
2020-08-05 19:27 ` ericonr
2020-08-05 19:27 ` ericonr
2020-08-05 19:27 ` ericonr
2020-08-05 19:27 ` ericonr
2020-08-05 20:06 ` [PR PATCH] [Updated] " ahesford
2020-08-05 20:06 ` ahesford
2020-08-05 20:26 ` ericonr
2020-08-06 1:09 ` [PR REVIEW] " sgn
2020-08-06 1:12 ` sgn [this message]
2020-08-06 1:49 ` ahesford
2020-08-06 2:09 ` sgn
2020-08-06 3:18 ` ahesford
2020-08-06 3:31 ` [PR PATCH] [Updated] " ahesford
2020-08-06 3:32 ` ahesford
2020-08-06 11:42 ` sgn
2020-08-06 11:52 ` sgn
2020-08-06 12:05 ` sgn
2020-08-06 12:10 ` sgn
2020-08-06 12:14 ` sgn
2020-08-06 12:41 ` sgn
2020-08-07 2:43 ` [PR PATCH] [Updated] " ahesford
2020-08-07 2:45 ` ahesford
2020-08-07 5:49 ` [PR REVIEW] " ericonr
2020-08-07 11:12 ` sgn
2020-08-07 13:05 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806011216.7mrm1kubCw_FL4Dtgp0s1w6RTILFCsizyCs4Zu2j-98@z \
--to=sgn@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).