* Re: [PR REVIEW] freexl: update to 1.0.6.
2020-08-05 9:44 [PR PATCH] freexl: update to 1.0.6 fosslinux
@ 2020-08-10 11:38 ` Piraty
2020-08-10 11:38 ` Piraty
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Piraty @ 2020-08-10 11:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 172 bytes --]
New review comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/24067#discussion_r467845655
Comment:
`makedepends` is not set??
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] freexl: update to 1.0.6.
2020-08-05 9:44 [PR PATCH] freexl: update to 1.0.6 fosslinux
2020-08-10 11:38 ` [PR REVIEW] " Piraty
@ 2020-08-10 11:38 ` Piraty
2020-08-15 21:59 ` [PR PATCH] [Updated] " fosslinux
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Piraty @ 2020-08-10 11:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 177 bytes --]
New review comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/24067#discussion_r467845786
Comment:
fix license, according to xlint
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] freexl: update to 1.0.6.
2020-08-05 9:44 [PR PATCH] freexl: update to 1.0.6 fosslinux
2020-08-10 11:38 ` [PR REVIEW] " Piraty
2020-08-10 11:38 ` Piraty
@ 2020-08-15 21:59 ` fosslinux
2020-08-15 21:59 ` fosslinux
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: fosslinux @ 2020-08-15 21:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 323 bytes --]
There is an updated pull request by fosslinux against master on the void-packages repository
https://github.com/fosslinux/void-packages freexl-1.0.6
https://github.com/void-linux/void-packages/pull/24067
freexl: update to 1.0.6.
A patch file from https://github.com/void-linux/void-packages/pull/24067.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-freexl-1.0.6-24067.patch --]
[-- Type: text/x-diff, Size: 1295 bytes --]
From f41e9d0651dc743364ad9febbfef3a96dcfd2887 Mon Sep 17 00:00:00 2001
From: fosslinux <fosslinux@aussies.space>
Date: Wed, 5 Aug 2020 19:44:03 +1000
Subject: [PATCH] freexl: update to 1.0.6.
---
srcpkgs/freexl/template | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/freexl/template b/srcpkgs/freexl/template
index 0c3d7305238..33fb3e1f82e 100644
--- a/srcpkgs/freexl/template
+++ b/srcpkgs/freexl/template
@@ -1,17 +1,17 @@
# Template file for 'freexl'
pkgname=freexl
-version=1.0.5
+version=1.0.6
revision=1
build_style=gnu-configure
short_desc="Library to extract valid data from within an Excel (.xls) spreadsheet"
maintainer="Giuseppe Fierro <gspe@ae-design.ws>"
-license="MPL-1.1,GPL-2,LGPL-2.1"
+license="MPL-1.1,GPL-2-or-later,LGPL-2.1-or-later"
homepage="https://www.gaia-gis.it/fossil/freexl/index"
distfiles="http://www.gaia-gis.it/gaia-sins/${pkgname}-${version}.tar.gz"
-checksum=3dc9b150d218b0e280a3d6a41d93c1e45f4d7155829d75f1e5bf3e0b0de6750d
+checksum=3de8b57a3d130cb2881ea52d3aa9ce1feedb1b57b7daa4eb37f751404f90fc22
freexl-devel_package() {
- depends="${makedepends} ${sourcepkg}-${version}_${revision}"
+ depends="${sourcepkg}-${version}_${revision}"
short_desc+=" - development files"
pkg_install() {
vmove usr/include
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: freexl: update to 1.0.6.
2020-08-05 9:44 [PR PATCH] freexl: update to 1.0.6 fosslinux
` (2 preceding siblings ...)
2020-08-15 21:59 ` [PR PATCH] [Updated] " fosslinux
@ 2020-08-15 21:59 ` fosslinux
2020-08-15 22:02 ` [PR REVIEW] " ericonr
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: fosslinux @ 2020-08-15 21:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 153 bytes --]
New comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/24067#issuecomment-674451247
Comment:
Addressed.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] freexl: update to 1.0.6.
2020-08-05 9:44 [PR PATCH] freexl: update to 1.0.6 fosslinux
` (3 preceding siblings ...)
2020-08-15 21:59 ` fosslinux
@ 2020-08-15 22:02 ` ericonr
2020-08-16 0:17 ` fosslinux
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2020-08-15 22:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 169 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/24067#discussion_r471038044
Comment:
Shouldn't it be `>=` ?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] freexl: update to 1.0.6.
2020-08-05 9:44 [PR PATCH] freexl: update to 1.0.6 fosslinux
` (4 preceding siblings ...)
2020-08-15 22:02 ` [PR REVIEW] " ericonr
@ 2020-08-16 0:17 ` fosslinux
2020-08-16 8:06 ` [PR PATCH] [Updated] " fosslinux
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: fosslinux @ 2020-08-16 0:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 219 bytes --]
New review comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/24067#discussion_r471047165
Comment:
shlib bumps would make `>=` wrong, I think. Not completely sure though
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] freexl: update to 1.0.6.
2020-08-05 9:44 [PR PATCH] freexl: update to 1.0.6 fosslinux
` (5 preceding siblings ...)
2020-08-16 0:17 ` fosslinux
@ 2020-08-16 8:06 ` fosslinux
2020-08-16 9:43 ` [PR REVIEW] " Piraty
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: fosslinux @ 2020-08-16 8:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 323 bytes --]
There is an updated pull request by fosslinux against master on the void-packages repository
https://github.com/fosslinux/void-packages freexl-1.0.6
https://github.com/void-linux/void-packages/pull/24067
freexl: update to 1.0.6.
A patch file from https://github.com/void-linux/void-packages/pull/24067.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-freexl-1.0.6-24067.patch --]
[-- Type: text/x-diff, Size: 1297 bytes --]
From 79fcc5bb5ac05f5bd39ab16dc2971640e820e059 Mon Sep 17 00:00:00 2001
From: fosslinux <fosslinux@aussies.space>
Date: Wed, 5 Aug 2020 19:44:03 +1000
Subject: [PATCH] freexl: update to 1.0.6.
---
srcpkgs/freexl/template | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/freexl/template b/srcpkgs/freexl/template
index 0c3d7305238..4bb6099a097 100644
--- a/srcpkgs/freexl/template
+++ b/srcpkgs/freexl/template
@@ -1,17 +1,17 @@
# Template file for 'freexl'
pkgname=freexl
-version=1.0.5
+version=1.0.6
revision=1
build_style=gnu-configure
short_desc="Library to extract valid data from within an Excel (.xls) spreadsheet"
maintainer="Giuseppe Fierro <gspe@ae-design.ws>"
-license="MPL-1.1,GPL-2,LGPL-2.1"
+license="MPL-1.1,GPL-2.0-or-later,LGPL-2.1-or-later"
homepage="https://www.gaia-gis.it/fossil/freexl/index"
distfiles="http://www.gaia-gis.it/gaia-sins/${pkgname}-${version}.tar.gz"
-checksum=3dc9b150d218b0e280a3d6a41d93c1e45f4d7155829d75f1e5bf3e0b0de6750d
+checksum=3de8b57a3d130cb2881ea52d3aa9ce1feedb1b57b7daa4eb37f751404f90fc22
freexl-devel_package() {
- depends="${makedepends} ${sourcepkg}-${version}_${revision}"
+ depends="${sourcepkg}-${version}_${revision}"
short_desc+=" - development files"
pkg_install() {
vmove usr/include
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] freexl: update to 1.0.6.
2020-08-05 9:44 [PR PATCH] freexl: update to 1.0.6 fosslinux
` (6 preceding siblings ...)
2020-08-16 8:06 ` [PR PATCH] [Updated] " fosslinux
@ 2020-08-16 9:43 ` Piraty
2020-08-16 23:48 ` ahesford
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Piraty @ 2020-08-16 9:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 165 bytes --]
New review comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/24067#discussion_r471090559
Comment:
Manual.md says `>=`
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] freexl: update to 1.0.6.
2020-08-05 9:44 [PR PATCH] freexl: update to 1.0.6 fosslinux
` (7 preceding siblings ...)
2020-08-16 9:43 ` [PR REVIEW] " Piraty
@ 2020-08-16 23:48 ` ahesford
2020-08-17 23:23 ` fosslinux
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ahesford @ 2020-08-16 23:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/24067#discussion_r471174962
Comment:
In practice it probably doesn't matter much, but `>=` is best practice.
Holding the `-devel` package while still upgrading `${sourcepkg}` will, for example, still allow local static linking against an old version without risking breakage of dependants of `${sourceppkg}`. Sure, this is a contrived example, but why prohibit this behavior for no real benefit?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] freexl: update to 1.0.6.
2020-08-05 9:44 [PR PATCH] freexl: update to 1.0.6 fosslinux
` (8 preceding siblings ...)
2020-08-16 23:48 ` ahesford
@ 2020-08-17 23:23 ` fosslinux
2020-08-17 23:23 ` fosslinux
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: fosslinux @ 2020-08-17 23:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 174 bytes --]
New review comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/24067#discussion_r471827267
Comment:
Ok, fair points, I get it
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] freexl: update to 1.0.6.
2020-08-05 9:44 [PR PATCH] freexl: update to 1.0.6 fosslinux
` (9 preceding siblings ...)
2020-08-17 23:23 ` fosslinux
@ 2020-08-17 23:23 ` fosslinux
2020-08-19 6:06 ` [PR PATCH] [Updated] " fosslinux
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: fosslinux @ 2020-08-17 23:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 193 bytes --]
New review comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/24067#discussion_r471827267
Comment:
Ok, fair points, I get it.
I'll change it
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] freexl: update to 1.0.6.
2020-08-05 9:44 [PR PATCH] freexl: update to 1.0.6 fosslinux
` (10 preceding siblings ...)
2020-08-17 23:23 ` fosslinux
@ 2020-08-19 6:06 ` fosslinux
2020-08-19 6:07 ` [PR REVIEW] " fosslinux
2020-08-19 11:11 ` [PR PATCH] [Merged]: " ahesford
13 siblings, 0 replies; 15+ messages in thread
From: fosslinux @ 2020-08-19 6:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 323 bytes --]
There is an updated pull request by fosslinux against master on the void-packages repository
https://github.com/fosslinux/void-packages freexl-1.0.6
https://github.com/void-linux/void-packages/pull/24067
freexl: update to 1.0.6.
A patch file from https://github.com/void-linux/void-packages/pull/24067.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-freexl-1.0.6-24067.patch --]
[-- Type: text/x-diff, Size: 1298 bytes --]
From d95462e2fd67c25af0501dcdf5472b3ba131ce2f Mon Sep 17 00:00:00 2001
From: fosslinux <fosslinux@aussies.space>
Date: Wed, 5 Aug 2020 19:44:03 +1000
Subject: [PATCH] freexl: update to 1.0.6.
---
srcpkgs/freexl/template | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/freexl/template b/srcpkgs/freexl/template
index 0c3d7305238..08d87bb7f3a 100644
--- a/srcpkgs/freexl/template
+++ b/srcpkgs/freexl/template
@@ -1,17 +1,17 @@
# Template file for 'freexl'
pkgname=freexl
-version=1.0.5
+version=1.0.6
revision=1
build_style=gnu-configure
short_desc="Library to extract valid data from within an Excel (.xls) spreadsheet"
maintainer="Giuseppe Fierro <gspe@ae-design.ws>"
-license="MPL-1.1,GPL-2,LGPL-2.1"
+license="MPL-1.1,GPL-2.0-or-later,LGPL-2.1-or-later"
homepage="https://www.gaia-gis.it/fossil/freexl/index"
distfiles="http://www.gaia-gis.it/gaia-sins/${pkgname}-${version}.tar.gz"
-checksum=3dc9b150d218b0e280a3d6a41d93c1e45f4d7155829d75f1e5bf3e0b0de6750d
+checksum=3de8b57a3d130cb2881ea52d3aa9ce1feedb1b57b7daa4eb37f751404f90fc22
freexl-devel_package() {
- depends="${makedepends} ${sourcepkg}-${version}_${revision}"
+ depends="${sourcepkg}>=${version}_${revision}"
short_desc+=" - development files"
pkg_install() {
vmove usr/include
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] freexl: update to 1.0.6.
2020-08-05 9:44 [PR PATCH] freexl: update to 1.0.6 fosslinux
` (11 preceding siblings ...)
2020-08-19 6:06 ` [PR PATCH] [Updated] " fosslinux
@ 2020-08-19 6:07 ` fosslinux
2020-08-19 11:11 ` [PR PATCH] [Merged]: " ahesford
13 siblings, 0 replies; 15+ messages in thread
From: fosslinux @ 2020-08-19 6:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 153 bytes --]
New review comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/24067#discussion_r472740158
Comment:
Done
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Merged]: freexl: update to 1.0.6.
2020-08-05 9:44 [PR PATCH] freexl: update to 1.0.6 fosslinux
` (12 preceding siblings ...)
2020-08-19 6:07 ` [PR REVIEW] " fosslinux
@ 2020-08-19 11:11 ` ahesford
13 siblings, 0 replies; 15+ messages in thread
From: ahesford @ 2020-08-19 11:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 158 bytes --]
There's a merged pull request on the void-packages repository
freexl: update to 1.0.6.
https://github.com/void-linux/void-packages/pull/24067
Description:
^ permalink raw reply [flat|nested] 15+ messages in thread