[PR PATCH] freexl: update to 1.0.6.

[PR PATCH] freexl: update to 1.0.6.

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

There is a new pull request by fosslinux against master on the void-packages repository

https://github.com/fosslinux/void-packages freexl-1.0.6
https://github.com/void-linux/void-packages/pull/24067

freexl: update to 1.0.6.


A patch file from https://github.com/void-linux/void-packages/pull/24067.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-freexl-1.0.6-24067.patch --]
[-- Type: text/x-diff, Size: 1128 bytes --]

From 7743a0c8fc183fe3b4678d24c5828f8e4b4c9496 Mon Sep 17 00:00:00 2001
From: fosslinux <fosslinux@aussies.space>
Date: Wed, 5 Aug 2020 19:44:03 +1000
Subject: [PATCH] freexl: update to 1.0.6.

---
 srcpkgs/freexl/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/freexl/template b/srcpkgs/freexl/template
index 0c3d7305238..d157cc92a90 100644
--- a/srcpkgs/freexl/template
+++ b/srcpkgs/freexl/template
@@ -1,6 +1,6 @@
 # Template file for 'freexl'
 pkgname=freexl
-version=1.0.5
+version=1.0.6
 revision=1
 build_style=gnu-configure
 short_desc="Library to extract valid data from within an Excel (.xls) spreadsheet"
@@ -8,7 +8,7 @@ maintainer="Giuseppe Fierro <gspe@ae-design.ws>"
 license="MPL-1.1,GPL-2,LGPL-2.1"
 homepage="https://www.gaia-gis.it/fossil/freexl/index"
 distfiles="http://www.gaia-gis.it/gaia-sins/${pkgname}-${version}.tar.gz"
-checksum=3dc9b150d218b0e280a3d6a41d93c1e45f4d7155829d75f1e5bf3e0b0de6750d
+checksum=3de8b57a3d130cb2881ea52d3aa9ce1feedb1b57b7daa4eb37f751404f90fc22
 
 freexl-devel_package() {
 	depends="${makedepends} ${sourcepkg}-${version}_${revision}"

Re: [PR REVIEW] freexl: update to 1.0.6.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/24067#discussion_r467845655

Comment:
`makedepends` is not set??

Re: [PR REVIEW] freexl: update to 1.0.6.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/24067#discussion_r467845786

Comment:
fix license, according to xlint

Re: [PR PATCH] [Updated] freexl: update to 1.0.6.

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

There is an updated pull request by fosslinux against master on the void-packages repository

https://github.com/fosslinux/void-packages freexl-1.0.6
https://github.com/void-linux/void-packages/pull/24067

freexl: update to 1.0.6.


A patch file from https://github.com/void-linux/void-packages/pull/24067.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-freexl-1.0.6-24067.patch --]
[-- Type: text/x-diff, Size: 1295 bytes --]

From f41e9d0651dc743364ad9febbfef3a96dcfd2887 Mon Sep 17 00:00:00 2001
From: fosslinux <fosslinux@aussies.space>
Date: Wed, 5 Aug 2020 19:44:03 +1000
Subject: [PATCH] freexl: update to 1.0.6.

---
 srcpkgs/freexl/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/freexl/template b/srcpkgs/freexl/template
index 0c3d7305238..33fb3e1f82e 100644
--- a/srcpkgs/freexl/template
+++ b/srcpkgs/freexl/template
@@ -1,17 +1,17 @@
 # Template file for 'freexl'
 pkgname=freexl
-version=1.0.5
+version=1.0.6
 revision=1
 build_style=gnu-configure
 short_desc="Library to extract valid data from within an Excel (.xls) spreadsheet"
 maintainer="Giuseppe Fierro <gspe@ae-design.ws>"
-license="MPL-1.1,GPL-2,LGPL-2.1"
+license="MPL-1.1,GPL-2-or-later,LGPL-2.1-or-later"
 homepage="https://www.gaia-gis.it/fossil/freexl/index"
 distfiles="http://www.gaia-gis.it/gaia-sins/${pkgname}-${version}.tar.gz"
-checksum=3dc9b150d218b0e280a3d6a41d93c1e45f4d7155829d75f1e5bf3e0b0de6750d
+checksum=3de8b57a3d130cb2881ea52d3aa9ce1feedb1b57b7daa4eb37f751404f90fc22
 
 freexl-devel_package() {
-	depends="${makedepends} ${sourcepkg}-${version}_${revision}"
+	depends="${sourcepkg}-${version}_${revision}"
 	short_desc+=" - development files"
 	pkg_install() {
 		vmove usr/include

Re: freexl: update to 1.0.6.

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24067#issuecomment-674451247

Comment:
Addressed.

Re: [PR REVIEW] freexl: update to 1.0.6.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24067#discussion_r471038044

Comment:
Shouldn't it be `>=` ?

Re: [PR REVIEW] freexl: update to 1.0.6.

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New review comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24067#discussion_r471047165

Comment:
shlib bumps would make `>=` wrong, I think. Not completely sure though

Re: [PR PATCH] [Updated] freexl: update to 1.0.6.

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

There is an updated pull request by fosslinux against master on the void-packages repository

https://github.com/fosslinux/void-packages freexl-1.0.6
https://github.com/void-linux/void-packages/pull/24067

freexl: update to 1.0.6.


A patch file from https://github.com/void-linux/void-packages/pull/24067.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-freexl-1.0.6-24067.patch --]
[-- Type: text/x-diff, Size: 1297 bytes --]

From 79fcc5bb5ac05f5bd39ab16dc2971640e820e059 Mon Sep 17 00:00:00 2001
From: fosslinux <fosslinux@aussies.space>
Date: Wed, 5 Aug 2020 19:44:03 +1000
Subject: [PATCH] freexl: update to 1.0.6.

---
 srcpkgs/freexl/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/freexl/template b/srcpkgs/freexl/template
index 0c3d7305238..4bb6099a097 100644
--- a/srcpkgs/freexl/template
+++ b/srcpkgs/freexl/template
@@ -1,17 +1,17 @@
 # Template file for 'freexl'
 pkgname=freexl
-version=1.0.5
+version=1.0.6
 revision=1
 build_style=gnu-configure
 short_desc="Library to extract valid data from within an Excel (.xls) spreadsheet"
 maintainer="Giuseppe Fierro <gspe@ae-design.ws>"
-license="MPL-1.1,GPL-2,LGPL-2.1"
+license="MPL-1.1,GPL-2.0-or-later,LGPL-2.1-or-later"
 homepage="https://www.gaia-gis.it/fossil/freexl/index"
 distfiles="http://www.gaia-gis.it/gaia-sins/${pkgname}-${version}.tar.gz"
-checksum=3dc9b150d218b0e280a3d6a41d93c1e45f4d7155829d75f1e5bf3e0b0de6750d
+checksum=3de8b57a3d130cb2881ea52d3aa9ce1feedb1b57b7daa4eb37f751404f90fc22
 
 freexl-devel_package() {
-	depends="${makedepends} ${sourcepkg}-${version}_${revision}"
+	depends="${sourcepkg}-${version}_${revision}"
 	short_desc+=" - development files"
 	pkg_install() {
 		vmove usr/include

Re: [PR REVIEW] freexl: update to 1.0.6.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/24067#discussion_r471090559

Comment:
Manual.md says `>=`

Re: [PR REVIEW] freexl: update to 1.0.6.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24067#discussion_r471174962

Comment:
In practice it probably doesn't matter much, but `>=` is best practice.

Holding the `-devel` package while still upgrading `${sourcepkg}` will, for example, still allow local static linking against an old version without risking breakage of dependants of `${sourceppkg}`. Sure, this is a contrived example, but why prohibit this behavior for no real benefit?

Re: [PR REVIEW] freexl: update to 1.0.6.

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24067#discussion_r471827267

Comment:
Ok, fair points, I get it

Re: [PR REVIEW] freexl: update to 1.0.6.

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24067#discussion_r471827267

Comment:
Ok, fair points, I get it.

I'll change it

Re: [PR PATCH] [Updated] freexl: update to 1.0.6.

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

There is an updated pull request by fosslinux against master on the void-packages repository

https://github.com/fosslinux/void-packages freexl-1.0.6
https://github.com/void-linux/void-packages/pull/24067

freexl: update to 1.0.6.


A patch file from https://github.com/void-linux/void-packages/pull/24067.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-freexl-1.0.6-24067.patch --]
[-- Type: text/x-diff, Size: 1298 bytes --]

From d95462e2fd67c25af0501dcdf5472b3ba131ce2f Mon Sep 17 00:00:00 2001
From: fosslinux <fosslinux@aussies.space>
Date: Wed, 5 Aug 2020 19:44:03 +1000
Subject: [PATCH] freexl: update to 1.0.6.

---
 srcpkgs/freexl/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/freexl/template b/srcpkgs/freexl/template
index 0c3d7305238..08d87bb7f3a 100644
--- a/srcpkgs/freexl/template
+++ b/srcpkgs/freexl/template
@@ -1,17 +1,17 @@
 # Template file for 'freexl'
 pkgname=freexl
-version=1.0.5
+version=1.0.6
 revision=1
 build_style=gnu-configure
 short_desc="Library to extract valid data from within an Excel (.xls) spreadsheet"
 maintainer="Giuseppe Fierro <gspe@ae-design.ws>"
-license="MPL-1.1,GPL-2,LGPL-2.1"
+license="MPL-1.1,GPL-2.0-or-later,LGPL-2.1-or-later"
 homepage="https://www.gaia-gis.it/fossil/freexl/index"
 distfiles="http://www.gaia-gis.it/gaia-sins/${pkgname}-${version}.tar.gz"
-checksum=3dc9b150d218b0e280a3d6a41d93c1e45f4d7155829d75f1e5bf3e0b0de6750d
+checksum=3de8b57a3d130cb2881ea52d3aa9ce1feedb1b57b7daa4eb37f751404f90fc22
 
 freexl-devel_package() {
-	depends="${makedepends} ${sourcepkg}-${version}_${revision}"
+	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"
 	pkg_install() {
 		vmove usr/include

Re: [PR REVIEW] freexl: update to 1.0.6.

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New review comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24067#discussion_r472740158

Comment:
Done

Re: [PR PATCH] [Merged]: freexl: update to 1.0.6.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

There's a merged pull request on the void-packages repository

freexl: update to 1.0.6.
https://github.com/void-linux/void-packages/pull/24067

Description: