* Re: Komikku: update dependencies
2020-08-25 13:30 [PR PATCH] Komikku: update dependencies not-chicken
@ 2020-08-25 13:43 ` sgn
2020-08-25 13:46 ` not-chicken
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2020-08-25 13:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 207 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/24463#issuecomment-680033319
Comment:
Sorry, why does `Komikku` needs `python3-keyring`? I run it just fine.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Komikku: update dependencies
2020-08-25 13:30 [PR PATCH] Komikku: update dependencies not-chicken
2020-08-25 13:43 ` sgn
@ 2020-08-25 13:46 ` not-chicken
2020-08-25 13:59 ` sgn
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: not-chicken @ 2020-08-25 13:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]
New comment by not-chicken on void-packages repository
https://github.com/void-linux/void-packages/pull/24463#issuecomment-680035277
Comment:
> Sorry, why does `Komikku` needs `python3-keyring`? I run it just fine.
Doesn't work without it for me :(
```[~]$ komikku
Traceback (most recent call last):
File "/usr/bin/komikku", line 69, in <module>
from komikku.application import Application
File "/usr/lib/python3.8/site-packages/komikku/application.py", line 24, in <module>
from komikku.add_dialog import AddDialog
File "/usr/lib/python3.8/site-packages/komikku/add_dialog.py", line 17, in <module>
from komikku.models import create_db_connection
File "/usr/lib/python3.8/site-packages/komikku/models/__init__.py", line 5, in <module>
from .database import backup_db
File "/usr/lib/python3.8/site-packages/komikku/models/database.py", line 15, in <module>
from komikku.servers import convert_webp_buffer
File "/usr/lib/python3.8/site-packages/komikku/servers/__init__.py", line 23, in <module>
from komikku.utils import get_cache_dir
File "/usr/lib/python3.8/site-packages/komikku/utils.py", line 12, in <module>
import keyring
ModuleNotFoundError: No module named 'keyring'
```
Thanks for the update btw, I didn't notice new libhandy coming in.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Komikku: update dependencies
2020-08-25 13:30 [PR PATCH] Komikku: update dependencies not-chicken
2020-08-25 13:43 ` sgn
2020-08-25 13:46 ` not-chicken
@ 2020-08-25 13:59 ` sgn
2020-08-25 14:14 ` not-chicken
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2020-08-25 13:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 278 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/24463#issuecomment-680042663
Comment:
I guess you're reading from some servers that requires logging in.
I tried with mangadex. So, `python3-keyring` is an optional dependencies.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Komikku: update dependencies
2020-08-25 13:30 [PR PATCH] Komikku: update dependencies not-chicken
` (2 preceding siblings ...)
2020-08-25 13:59 ` sgn
@ 2020-08-25 14:14 ` not-chicken
2020-08-25 14:35 ` sgn
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: not-chicken @ 2020-08-25 14:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 298 bytes --]
New comment by not-chicken on void-packages repository
https://github.com/void-linux/void-packages/pull/24463#issuecomment-680051726
Comment:
Ah, crunchyroll :3.
I'd still vote for adding it tho, as [upstream](https://gitlab.com/valos/Komikku/-/blob/master/README.md) lists it as a dependency.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Komikku: update dependencies
2020-08-25 13:30 [PR PATCH] Komikku: update dependencies not-chicken
` (3 preceding siblings ...)
2020-08-25 14:14 ` not-chicken
@ 2020-08-25 14:35 ` sgn
2020-08-27 14:14 ` [PR PATCH] [Merged]: " ahesford
2020-08-27 14:15 ` ahesford
6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2020-08-25 14:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 439 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/24463#issuecomment-680063893
Comment:
On 2020-08-25 07:14:59-0700, Lorem <notifications@github.com> wrote:
> Ah, crunchyroll :3.
> I'd still vote for adding it tho, as
> [upstream](https://gitlab.com/valos/Komikku/-/blob/master/README.md)
> lists it as a dependency.
Fair enough, but I'll it to other people to make the call.
--
Danh
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR PATCH] [Merged]: Komikku: update dependencies
2020-08-25 13:30 [PR PATCH] Komikku: update dependencies not-chicken
` (4 preceding siblings ...)
2020-08-25 14:35 ` sgn
@ 2020-08-27 14:14 ` ahesford
2020-08-27 14:15 ` ahesford
6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2020-08-27 14:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
There's a merged pull request on the void-packages repository
Komikku: update dependencies
https://github.com/void-linux/void-packages/pull/24463
Description:
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Komikku: update dependencies
2020-08-25 13:30 [PR PATCH] Komikku: update dependencies not-chicken
` (5 preceding siblings ...)
2020-08-27 14:14 ` [PR PATCH] [Merged]: " ahesford
@ 2020-08-27 14:15 ` ahesford
6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2020-08-27 14:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 456 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/24463#issuecomment-681976441
Comment:
I don't use Komikku, but I'll note that the `komikku.servers` module does an unguarded `import keyring` and there are a lot of `komikku.servers` imports, so it looks like this is would be a minefield without `python3-keyring`. Also, the upstream flatpak pulls in `python3-keyring`. This seems to be the right call.
^ permalink raw reply [flat|nested] 8+ messages in thread