[PR PATCH] Komikku: update dependencies

[PR PATCH] Komikku: update dependencies

[not-chicken]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

There is a new pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages komikku
https://github.com/void-linux/void-packages/pull/24463

Komikku: update dependencies
 

A patch file from https://github.com/void-linux/void-packages/pull/24463.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-komikku-24463.patch --]
[-- Type: text/x-diff, Size: 1372 bytes --]

From 5b1e5589de2a5a1f8544ca322d7c04c309744637 Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Tue, 25 Aug 2020 14:06:25 +0530
Subject: [PATCH] Komikku: update dependencies

 - Add python3-keyring as runtime dependency.
 - Add checkdepends.
---
 srcpkgs/Komikku/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/Komikku/template b/srcpkgs/Komikku/template
index 59504a4c087..330d7f8cbf8 100644
--- a/srcpkgs/Komikku/template
+++ b/srcpkgs/Komikku/template
@@ -1,16 +1,16 @@
 # Template file for 'Komikku'
 pkgname=Komikku
 version=0.19.0
-revision=1
+revision=2
 archs=noarch
 wrksrc=Komikku-v${version}
 build_style=meson
-hostmakedepends="appstream-glib desktop-file-utils glib-devel gettext
- gobject-introspection pkg-config"
+hostmakedepends="gettext glib-devel gobject-introspection pkg-config"
 makedepends="gtk+3-devel libhandy1-devel"
 depends="gtk+3 python3-BeautifulSoup4 python3-cloudscraper python3-dateparser
  python3-gobject python3-lxml python3-magic python3-Pillow python3-pure-protobuf
- libhandy1 libnotify libsecret python3-Unidecode"
+ libhandy1 libnotify libsecret python3-Unidecode python3-keyring"
+checkdepends="appstream-glib desktop-file-utils"
 short_desc="Online/offline manga reader for GNOME"
 maintainer="Lorem <notloremipsum@protonmail.com>"
 license="GPL-3.0-or-later"

Re: Komikku: update dependencies

[sgn]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/24463#issuecomment-680033319

Comment:
Sorry, why does `Komikku` needs `python3-keyring`? I run it just fine.

Re: Komikku: update dependencies

[not-chicken]

[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/24463#issuecomment-680035277

Comment:
> Sorry, why does `Komikku` needs `python3-keyring`? I run it just fine.

Doesn't work without it for me :(
```[~]$ komikku
Traceback (most recent call last):
  File "/usr/bin/komikku", line 69, in <module>
    from komikku.application import Application
  File "/usr/lib/python3.8/site-packages/komikku/application.py", line 24, in <module>
    from komikku.add_dialog import AddDialog
  File "/usr/lib/python3.8/site-packages/komikku/add_dialog.py", line 17, in <module>
    from komikku.models import create_db_connection
  File "/usr/lib/python3.8/site-packages/komikku/models/__init__.py", line 5, in <module>
    from .database import backup_db
  File "/usr/lib/python3.8/site-packages/komikku/models/database.py", line 15, in <module>
    from komikku.servers import convert_webp_buffer
  File "/usr/lib/python3.8/site-packages/komikku/servers/__init__.py", line 23, in <module>
    from komikku.utils import get_cache_dir
  File "/usr/lib/python3.8/site-packages/komikku/utils.py", line 12, in <module>
    import keyring
ModuleNotFoundError: No module named 'keyring'
```
Thanks for the update btw, I didn't notice new libhandy coming in.

Re: Komikku: update dependencies

[sgn]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/24463#issuecomment-680042663

Comment:
I guess you're reading from some servers that requires logging in.
I tried with mangadex. So, `python3-keyring` is an optional dependencies.

Re: Komikku: update dependencies

[not-chicken]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/24463#issuecomment-680051726

Comment:
Ah, crunchyroll :3.
 I'd still vote for adding it tho, as [upstream](https://gitlab.com/valos/Komikku/-/blob/master/README.md) lists it as a dependency.

Re: Komikku: update dependencies

[sgn]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/24463#issuecomment-680063893

Comment:
On 2020-08-25 07:14:59-0700, Lorem <notifications@github.com> wrote:
> Ah, crunchyroll :3.
>  I'd still vote for adding it tho, as
>  [upstream](https://gitlab.com/valos/Komikku/-/blob/master/README.md)
>  lists it as a dependency.

Fair enough, but I'll it to other people to make the call.

-- 
Danh

Re: [PR PATCH] [Merged]: Komikku: update dependencies

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

There's a merged pull request on the void-packages repository

Komikku: update dependencies
https://github.com/void-linux/void-packages/pull/24463

Description:
 

Re: Komikku: update dependencies

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24463#issuecomment-681976441

Comment:
I don't use Komikku, but I'll note that the `komikku.servers` module does an unguarded `import keyring` and there are a lot of `komikku.servers` imports, so it looks like this is would be a minefield without `python3-keyring`. Also, the upstream flatpak pulls in `python3-keyring`. This seems to be the right call.