[PR PATCH] New package: trident-automount-2020.09.02

[PR PATCH] New package: trident-automount-2020.09.02

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

There is a new pull request by beanpole135 against master on the void-packages repository

https://github.com/beanpole135/void-packages trident-automount
https://github.com/void-linux/void-packages/pull/24607

New package: trident-automount-2020.09.02
This is a background service which monitors udev events for removable media and optical drives in order to create and maintain interaction shortcuts in the /media directory. This also configures and uses autofs for on-demand access to filesystems on removable devices.

Sponsored by: Project Trident

A patch file from https://github.com/void-linux/void-packages/pull/24607.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-trident-automount-24607.patch --]
[-- Type: text/x-diff, Size: 1589 bytes --]

From eac169f063368761d6d7eee6df307a8538e1ddfc Mon Sep 17 00:00:00 2001
From: Ken Moore <moorekou@gmail.com>
Date: Wed, 2 Sep 2020 09:19:16 -0400
Subject: [PATCH] New package: trident-automount-2020.09.02

This is a background service which monitors udev events for removable media and optical drives in order to create and maintain interaction shortcuts in the /media directory. This also configures and uses autofs for on-demand access to filesystems on removable devices.

Sponsored by: Project Trident
---
 srcpkgs/trident-automount/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/trident-automount/template

diff --git a/srcpkgs/trident-automount/template b/srcpkgs/trident-automount/template
new file mode 100644
index 00000000000..fe57630a21d
--- /dev/null
+++ b/srcpkgs/trident-automount/template
@@ -0,0 +1,21 @@
+# Template file for 'trident-automount'
+pkgname=trident-automount
+version=2020.09.02
+revision=1
+wrksrc="trident-utilities-${version}"
+build_wrksrc="src-go/automount"
+makedepends="go"
+depends="autofs"
+short_desc="Automounting daemon from Project Trident utilizing autofs"
+maintainer="Ken Moore <ken@project-trident.org>"
+license="BSD-2-Clause"
+homepage="https://github.com/project-trident/trident-utilities"
+distfiles="https://github.com/project-trident/trident-utilities/archive/v${version}.tar.gz"
+checksum=0bf0991c815b56b0143106e29ff2ab952416fd63d1810a6aa51fd95a0de4c48d
+
+do_install() {
+	make
+	vbin trident-automount
+	vinstall sv/run 0755 /etc/sv/trident-automount
+	vlicense ${wrksrc}/LICENSE
+}

Re: New package: trident-automount-2020.09.02

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-685746735

Comment:
Could this use `build_style=go`? With possibly some custom `post_build` or `post_install` step?

Re: New package: trident-automount-2020.09.02

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-685748847

Comment:
Also, could this instead be made into a subpackage of `trident-networkmgr` ? I see they use the same distfiles.

Re: [PR REVIEW] New package: trident-automount-2020.09.02

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#discussion_r482083144

Comment:
You need to setup the `supervise` link as well.

Re: [PR REVIEW] New package: trident-automount-2020.09.02

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

New review comment by beanpole135 on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#discussion_r482086521

Comment:
From what I have seen, the "supervise" link is auto-created by runit the first time the service is created. This service does not need anything special, and that auto-link works perfectly.

Re: New package: trident-automount-2020.09.02

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

New comment by beanpole135 on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-685753209

Comment:
> Also, could this instead be made into a subpackage of `trident-networkmgr` ? I see they use the same distfiles.

Project Trident uses a single repo (project-trident/trident-utilities) for a number of tools. trident-networkmgr and trident-automount are the main ones at the moment, but they are unrelated to each other otherwise.

Re: [PR REVIEW] New package: trident-automount-2020.09.02

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#discussion_r482090907

Comment:
`runsv` will create the `supervise` directory inside the service folder, but void uses links to `/run/runit/supervise.<service_name>` instead, because this allows runit to run with `/etc` mounted read only.

Re: New package: trident-automount-2020.09.02

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

New comment by beanpole135 on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-685756187

Comment:
> Could this use `build_style=go`? With possibly some custom `post_build` or `post_install` step?

I am open to that - but I could not find any working examples of this type of build style. The "go" build style seems to interact more with using the go-packages or go-modules frameworks, which this tool does not utilize.

Re: New package: trident-automount-2020.09.02

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-685757671

Comment:
> Project Trident uses a single repo (project-trident/trident-utilities) for a number of tools. trident-networkmgr and trident-automount are the main ones at the moment, but they are unrelated to each other otherwise.

That's not an issue! It's mostly that this would allow updates to happen in a single template, instead of having to track down multiple ones.

Re: [PR REVIEW] New package: trident-automount-2020.09.02

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New review comment by beanpole135 on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#discussion_r482096884

Comment:
ok, so basically just a symlink from /etc/sv/[servicename]/supervise to /run/runit/supervise.[servicename] is all I need to add?

Re: [PR REVIEW] New package: trident-automount-2020.09.02

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#discussion_r482101345

Comment:
Yup! The `qemuconf` template does it.

Re: [PR REVIEW] New package: trident-automount-2020.09.02

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New review comment by beanpole135 on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#discussion_r482102562

Comment:
Thanks! I will get that updated here shortly.

Re: [PR REVIEW] New package: trident-automount-2020.09.02

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#discussion_r482125700

Comment:
You should be using `vsv` instead to do all of the service copy-and-symlink work.

Re: [PR PATCH] [Updated] New package: trident-automount-2020.09.02

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

There is an updated pull request by beanpole135 against master on the void-packages repository

https://github.com/beanpole135/void-packages trident-automount
https://github.com/void-linux/void-packages/pull/24607

New package: trident-automount-2020.09.02
This is a background service which monitors udev events for removable media and optical drives in order to create and maintain interaction shortcuts in the /media directory. This also configures and uses autofs for on-demand access to filesystems on removable devices.

Sponsored by: Project Trident

A patch file from https://github.com/void-linux/void-packages/pull/24607.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-trident-automount-24607.patch --]
[-- Type: text/x-diff, Size: 1678 bytes --]

From bb00938a13f3c0f8bb413660cba948e5feb61de2 Mon Sep 17 00:00:00 2001
From: Ken Moore <moorekou@gmail.com>
Date: Wed, 2 Sep 2020 09:19:16 -0400
Subject: [PATCH] New package: trident-automount-2020.09.02

This is a background service which monitors udev events for removable media and optical drives in order to create and maintain interaction shortcuts in the /media directory. This also configures and uses autofs for on-demand access to filesystems on removable devices.

Sponsored by: Project Trident

Amendment 1: Switch to "go" build style, and create "supervise" link for runit service.
---
 srcpkgs/trident-automount/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/trident-automount/template

diff --git a/srcpkgs/trident-automount/template b/srcpkgs/trident-automount/template
new file mode 100644
index 00000000000..fe57630a21d
--- /dev/null
+++ b/srcpkgs/trident-automount/template
@@ -0,0 +1,21 @@
+# Template file for 'trident-automount'
+pkgname=trident-automount
+version=2020.09.02
+revision=1
+wrksrc="trident-utilities-${version}"
+build_wrksrc="src-go/automount"
+makedepends="go"
+depends="autofs"
+short_desc="Automounting daemon from Project Trident utilizing autofs"
+maintainer="Ken Moore <ken@project-trident.org>"
+license="BSD-2-Clause"
+homepage="https://github.com/project-trident/trident-utilities"
+distfiles="https://github.com/project-trident/trident-utilities/archive/v${version}.tar.gz"
+checksum=0bf0991c815b56b0143106e29ff2ab952416fd63d1810a6aa51fd95a0de4c48d
+
+do_install() {
+	make
+	vbin trident-automount
+	vinstall sv/run 0755 /etc/sv/trident-automount
+	vlicense ${wrksrc}/LICENSE
+}

Re: New package: trident-automount-2020.09.02

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New comment by beanpole135 on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-685784810

Comment:
ok, Package template updated with the following:
1. Switched to "go" build_style
2. "supervise" service link created by default

Re: [PR REVIEW] New package: trident-automount-2020.09.02

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#discussion_r482127044

Comment:
`vsv` works for services in `srcpkgs/<package>/files/<service_name>`, not for package provided services.

Re: New package: trident-automount-2020.09.02

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by beanpole135 on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-685785773

Comment:
Sorry - looks like that commit did not update the file - just a moment.

Re: [PR REVIEW] New package: trident-automount-2020.09.02

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#discussion_r482131196

Comment:
Good point, I overlooked that

Re: [PR PATCH] [Updated] New package: trident-automount-2020.09.02

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

There is an updated pull request by beanpole135 against master on the void-packages repository

https://github.com/beanpole135/void-packages trident-automount
https://github.com/void-linux/void-packages/pull/24607

New package: trident-automount-2020.09.02
This is a background service which monitors udev events for removable media and optical drives in order to create and maintain interaction shortcuts in the /media directory. This also configures and uses autofs for on-demand access to filesystems on removable devices.

Sponsored by: Project Trident

A patch file from https://github.com/void-linux/void-packages/pull/24607.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-trident-automount-24607.patch --]
[-- Type: text/x-diff, Size: 1819 bytes --]

From 6f5d050ec294180cc26a00386a558a66ca72015e Mon Sep 17 00:00:00 2001
From: Ken Moore <moorekou@gmail.com>
Date: Wed, 2 Sep 2020 09:19:16 -0400
Subject: [PATCH] New package: trident-automount-2020.09.02

This is a background service which monitors udev events for removable media and optical drives in order to create and maintain interaction shortcuts in the /media directory. This also configures and uses autofs for on-demand access to filesystems on removable devices.

Sponsored by: Project Trident

Amendment 1: Switch to "go" build style, and create "supervise" link for runit service.
---
 srcpkgs/trident-automount/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/trident-automount/template

diff --git a/srcpkgs/trident-automount/template b/srcpkgs/trident-automount/template
new file mode 100644
index 00000000000..d5955aab883
--- /dev/null
+++ b/srcpkgs/trident-automount/template
@@ -0,0 +1,22 @@
+# Template file for 'trident-automount'
+pkgname=trident-automount
+version=2020.09.02
+revision=1
+wrksrc="trident-utilities-${version}"
+build_wrksrc="src-go/automount"
+build_style=go
+go_import_path="github.com/project-trident/trident-automount"
+makedepends="go"
+depends="autofs"
+short_desc="Automounting daemon from Project Trident utilizing autofs"
+maintainer="Ken Moore <ken@project-trident.org>"
+license="BSD-2-Clause"
+homepage="https://github.com/project-trident/trident-utilities"
+distfiles="https://github.com/project-trident/trident-utilities/archive/v${version}.tar.gz"
+checksum=0bf0991c815b56b0143106e29ff2ab952416fd63d1810a6aa51fd95a0de4c48d
+
+post_install() {
+	vinstall sv/run 0755 /etc/sv/trident-automount
+	ln -s /run/runit/supervise.trident-automount $DESTDIR/etc/sv/trident-automount/supervise
+	vlicense ${wrksrc}/LICENSE
+}

Re: [PR REVIEW] New package: trident-automount-2020.09.02

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New review comment by beanpole135 on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#discussion_r482151058

Comment:
Ok, this is all set now in the latest version of the PR.

Re: New package: trident-automount-2020.09.02

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

New comment by beanpole135 on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-685809995

Comment:
The current state of the PR seems to resolve all the raised-issues except for the idea to make it a subpackage. 
Since that subpackage change will also need to impact the trident-networkmgr template, I am willing to combine that change into a separate PR that updates both templates at the same time. There are a couple other trident-utilities-based utilities coming down the pike soon too, so I will want to get that worked out sooner anyway so the next tools are subpackages by default..

Re: New package: trident-automount-2020.09.02

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-685883143

Comment:
Given that these tools use different build styles, I think it is better to keep them in separate templates, not subpackages.

Re: New package: trident-automount-2020.09.02

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-685936238

Comment:
I agree that keeping the templates separate makes the most sense. Subpackages are really intended to separate by-products of a common build, rather than separate builds of different subsets of a common archive.

Re: New package: trident-automount-2020.09.02

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

New comment by beanpole135 on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-685939599

Comment:
Sounds good to me - I will just continue making templates like I have been then, instead of trying to figure out this whole subpackage thing.

Re: New package: trident-automount-2020.09.02

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New comment by beanpole135 on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-687119700

Comment:
Is somebody willing to commit this into the repo now?
It is all set and ready to go.

Re: New package: trident-automount-2020.09.02

[sgn]

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-687138398

Comment:
On 2020-09-04 05:43:38-0700, Ken Moore <notifications@github.com> wrote:
> Is somebody willing to commit this into the repo now?
> It is all set and ready to go.

I think the consensus is waiting for
https://github.com/void-linux/void-packages/pull/24612?

-- 
Danh

Re: New package: trident-automount-2020.09.02

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

New comment by beanpole135 on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-687143925

Comment:
oh? This template does not use vsv, but I am willing to adapt it later once the vsv tool is updated. That should not be a blocker to this package in it's current state though.

Re: [PR PATCH] [Closed]: New package: trident-automount-2020.09.02

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

There's a closed pull request on the void-packages repository

New package: trident-automount-2020.09.02
https://github.com/void-linux/void-packages/pull/24607

Description:
This is a background service which monitors udev events for removable media and optical drives in order to create and maintain interaction shortcuts in the /media directory. This also configures and uses autofs for on-demand access to filesystems on removable devices.

Sponsored by: Project Trident

Re: New package: trident-automount-2020.09.02

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-687166752

Comment:
There's some debate about the utility of the `vsv` change, so we'll pull this as-is. If I merge the `vsv` change, I will update this template as well.

Re: New package: trident-automount-2020.09.02

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by beanpole135 on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-687171075

Comment:
um, you closed it without pulling/merging it first...

Re: New package: trident-automount-2020.09.02

[sgn]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-687172715

Comment:
On 2020-09-04 07:13:25-0700, Ken Moore <notifications@github.com> wrote:
> um, you closed it without pulling/merging it first...

Merged in by ahesford:
https://build.voidlinux.org/builders/x86_64-musl_builder/builds/30621

Re: New package: trident-automount-2020.09.02

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-687172849

Comment:
No, I merged it from an external tool. Note the "closed this in 3413e26" message in this timeline.

Re: New package: trident-automount-2020.09.02

[beanpole135]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New comment by beanpole135 on void-packages repository

https://github.com/void-linux/void-packages/pull/24607#issuecomment-687173009

Comment:
ah, I missed that one. Thanks!