* [PR PATCH] python3-lazy-object-proxy: update to 1.5.1.
@ 2020-10-14 3:02 pbui
2020-10-15 2:36 ` [PR REVIEW] " ahesford
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: pbui @ 2020-10-14 3:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
There is a new pull request by pbui against master on the void-packages repository
https://github.com/pbui/void-packages python3-lazy-object-proxy
https://github.com/void-linux/void-packages/pull/25586
python3-lazy-object-proxy: update to 1.5.1.
Also remove unnecessary post_patch which produced broken package (ie.
the egg version was set to 0.0.0 rather than the actual version causing
programs like pylint to break).
A patch file from https://github.com/void-linux/void-packages/pull/25586.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-lazy-object-proxy-25586.patch --]
[-- Type: text/x-diff, Size: 1481 bytes --]
From bbe5c54c806611adf756496c01175c3aabc0ff92 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Tue, 13 Oct 2020 23:00:11 -0400
Subject: [PATCH] python3-lazy-object-proxy: update to 1.5.1.
Also remove unnecessary post_patch which produced broken package (ie.
the egg version was set to 0.0.0 rather than the actual version causing
programs like pylint to break).
---
srcpkgs/python3-lazy-object-proxy/template | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/srcpkgs/python3-lazy-object-proxy/template b/srcpkgs/python3-lazy-object-proxy/template
index cf606a1869f..a14aa916633 100644
--- a/srcpkgs/python3-lazy-object-proxy/template
+++ b/srcpkgs/python3-lazy-object-proxy/template
@@ -1,7 +1,7 @@
# Template file for 'python3-lazy-object-proxy'
pkgname=python3-lazy-object-proxy
-version=1.4.3
-revision=4
+version=1.5.1
+revision=1
wrksrc="lazy-object-proxy-${version}"
build_style=python3-module
hostmakedepends="python3-setuptools"
@@ -11,11 +11,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
license="BSD-2-Clause"
homepage="https://github.com/ionelmc/python-lazy-object-proxy"
distfiles="${PYPI_SITE}/l/lazy-object-proxy/lazy-object-proxy-${version}.tar.gz"
-checksum=f3900e8a5de27447acbf900b4750b0ddfd7ec1ea7fbaf11dfa911141bc522af0
-
-post_patch() {
- vsed -i '/setuptools_scm/d' setup.cfg
-}
+checksum=9723364577b79ad9958a68851fe2acb94da6fd25170c595516a8289e6a129043
post_install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] python3-lazy-object-proxy: update to 1.5.1.
2020-10-14 3:02 [PR PATCH] python3-lazy-object-proxy: update to 1.5.1 pbui
@ 2020-10-15 2:36 ` ahesford
2020-10-15 3:14 ` [PR PATCH] [Updated] " pbui
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: ahesford @ 2020-10-15 2:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/25586#discussion_r505129103
Comment:
This was an attempt to stop `setuptools` from fetching dependencies at build time (see https://travis-ci.org/github/void-linux/void-packages/jobs/735601759#L570), but I missed the bad versioning in the `egg-info`. When you drop this patch, please replace the `python3-setuptools` in `hostmakedepends` with `python3-setuptools_scm`, which I added to address this problem. (That package depends on `python3-setuptools`.)
Also, it's a good idea to check whether `${wrksrc}/.eggs` exists after `xbps-src build` and, if so, what its contents are. These are eggs fetched by `setuptools` during build. This is bad, because it diminishes reproducibility, makes the build process more fragile, and is deprecated.
A couple of packages that use `setuptools_scm` also use `setuptools_scm_git_archive`, which doesn't seem to be useful in versioning. That can probably be patched out without breaking the package; see [`srcpkgs/python3-Cheroot/template`](https://github.com/void-linux/void-packages/tree/master/srcpkgs/python3-Cheroot/template).
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Updated] python3-lazy-object-proxy: update to 1.5.1.
2020-10-14 3:02 [PR PATCH] python3-lazy-object-proxy: update to 1.5.1 pbui
2020-10-15 2:36 ` [PR REVIEW] " ahesford
@ 2020-10-15 3:14 ` pbui
2020-10-15 3:15 ` [PR REVIEW] " pbui
2020-10-15 4:07 ` [PR PATCH] [Closed]: " ahesford
3 siblings, 0 replies; 5+ messages in thread
From: pbui @ 2020-10-15 3:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
There is an updated pull request by pbui against master on the void-packages repository
https://github.com/pbui/void-packages python3-lazy-object-proxy
https://github.com/void-linux/void-packages/pull/25586
python3-lazy-object-proxy: update to 1.5.1.
Also remove unnecessary post_patch which produced broken package (ie.
the egg version was set to 0.0.0 rather than the actual version causing
programs like pylint to break).
A patch file from https://github.com/void-linux/void-packages/pull/25586.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-lazy-object-proxy-25586.patch --]
[-- Type: text/x-diff, Size: 1598 bytes --]
From 4da6166c5a37ceb88f67b34eeab3ceaf3964d9e3 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Tue, 13 Oct 2020 23:00:11 -0400
Subject: [PATCH] python3-lazy-object-proxy: update to 1.5.1.
Also remove unnecessary post_patch which produced broken package (ie.
the egg version was set to 0.0.0 rather than the actual version causing
programs like pylint to break).
---
srcpkgs/python3-lazy-object-proxy/template | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/srcpkgs/python3-lazy-object-proxy/template b/srcpkgs/python3-lazy-object-proxy/template
index cf606a1869f..9ad5a7ed0db 100644
--- a/srcpkgs/python3-lazy-object-proxy/template
+++ b/srcpkgs/python3-lazy-object-proxy/template
@@ -1,21 +1,17 @@
# Template file for 'python3-lazy-object-proxy'
pkgname=python3-lazy-object-proxy
-version=1.4.3
-revision=4
+version=1.5.1
+revision=1
wrksrc="lazy-object-proxy-${version}"
build_style=python3-module
-hostmakedepends="python3-setuptools"
+hostmakedepends="python3-setuptools_scm"
makedepends="python3-devel"
short_desc="Fast and thorough lazy object proxy (Python3)"
maintainer="Orphaned <orphan@voidlinux.org>"
license="BSD-2-Clause"
homepage="https://github.com/ionelmc/python-lazy-object-proxy"
distfiles="${PYPI_SITE}/l/lazy-object-proxy/lazy-object-proxy-${version}.tar.gz"
-checksum=f3900e8a5de27447acbf900b4750b0ddfd7ec1ea7fbaf11dfa911141bc522af0
-
-post_patch() {
- vsed -i '/setuptools_scm/d' setup.cfg
-}
+checksum=9723364577b79ad9958a68851fe2acb94da6fd25170c595516a8289e6a129043
post_install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] python3-lazy-object-proxy: update to 1.5.1.
2020-10-14 3:02 [PR PATCH] python3-lazy-object-proxy: update to 1.5.1 pbui
2020-10-15 2:36 ` [PR REVIEW] " ahesford
2020-10-15 3:14 ` [PR PATCH] [Updated] " pbui
@ 2020-10-15 3:15 ` pbui
2020-10-15 4:07 ` [PR PATCH] [Closed]: " ahesford
3 siblings, 0 replies; 5+ messages in thread
From: pbui @ 2020-10-15 3:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 297 bytes --]
New review comment by pbui on void-packages repository
https://github.com/void-linux/void-packages/pull/25586#discussion_r505139619
Comment:
Thanks for the detailed response and explanation. I have made the change to `hostmakedepends` and will look out for the `${wrksrc}/.eggs` in the future.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Closed]: python3-lazy-object-proxy: update to 1.5.1.
2020-10-14 3:02 [PR PATCH] python3-lazy-object-proxy: update to 1.5.1 pbui
` (2 preceding siblings ...)
2020-10-15 3:15 ` [PR REVIEW] " pbui
@ 2020-10-15 4:07 ` ahesford
3 siblings, 0 replies; 5+ messages in thread
From: ahesford @ 2020-10-15 4:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
There's a closed pull request on the void-packages repository
python3-lazy-object-proxy: update to 1.5.1.
https://github.com/void-linux/void-packages/pull/25586
Description:
Also remove unnecessary post_patch which produced broken package (ie.
the egg version was set to 0.0.0 rather than the actual version causing
programs like pylint to break).
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-15 4:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14 3:02 [PR PATCH] python3-lazy-object-proxy: update to 1.5.1 pbui
2020-10-15 2:36 ` [PR REVIEW] " ahesford
2020-10-15 3:14 ` [PR PATCH] [Updated] " pbui
2020-10-15 3:15 ` [PR REVIEW] " pbui
2020-10-15 4:07 ` [PR PATCH] [Closed]: " ahesford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).