Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] nethack: fix SYSCF_FILE location
@ 2020-12-08 17:54 ashpooljh
  2020-12-08 18:51 ` [PR PATCH] [Updated] " ashpooljh
                   ` (22 more replies)
  0 siblings, 23 replies; 24+ messages in thread
From: ashpooljh @ 2020-12-08 17:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 832 bytes --]

There is a new pull request by ashpooljh against master on the void-packages repository

https://github.com/ashpooljh/void-packages nethack
https://github.com/void-linux/void-packages/pull/27036

nethack: fix SYSCF_FILE location
I wasn't able to enter the wizard mode, even as root, e.g. `sudo nethack -D -u wizard` just printed 
```
Entering explore/discovery mode instead
```
Then I found out that `SYSCF_FILE` in the template was pointing to the directory `/usr/lib/nethack` instead of the file itself `/usr/lib/nethack/sysconf`, and used `gdb` to verify that this had lead to `src/files.c:parse_conf_file` silently failing. Updating the value fixed the issue, and now the sysconf file is read and I'm able to access the wizard mode.

A patch file from https://github.com/void-linux/void-packages/pull/27036.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nethack-27036.patch --]
[-- Type: text/x-diff, Size: 993 bytes --]

From b11df05a9057c1a8c7b1b10591ac13b11170c087 Mon Sep 17 00:00:00 2001
From: Artem Zhurikhin <ashpool@xecut.net>
Date: Tue, 8 Dec 2020 20:45:29 +0300
Subject: [PATCH] nethack: fix SYSCF_FILE location

---
 srcpkgs/nethack/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/nethack/template b/srcpkgs/nethack/template
index b7ec4c30753..9a982e41ce6 100644
--- a/srcpkgs/nethack/template
+++ b/srcpkgs/nethack/template
@@ -1,7 +1,7 @@
 # Template file for 'nethack'
 pkgname=nethack
 version=3.6.6
-revision=1
+revision=2
 make_dirs="/var/games/nethack/save 0775 nethack nethack"
 hostmakedepends="ncurses-devel flex"
 depends="gzip"
@@ -29,7 +29,7 @@ do_build() {
 		CC="$CC" LINK="$CC" LFLAGS="$LDFLAGS" \
 		LEX=flex WINTTYLIB=-lncurses \
 		CFLAGS="$CFLAGS -DLINUX -DTIMED_DELAY -DDLB \
-			-DSYSCF -DSYSCF_FILE='\"/usr/lib/nethack\"' \
+			-DSYSCF -DSYSCF_FILE='\"/usr/lib/nethack/sysconf\"' \
 			-DHACKDIR='\"/var/games/nethack\"' -I../include"
 }
 

^ permalink raw reply	[flat|nested] 24+ messages in thread
end of thread, other threads:[~2020-12-16  1:26 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-08 17:54 [PR PATCH] nethack: fix SYSCF_FILE location ashpooljh
2020-12-08 18:51 ` [PR PATCH] [Updated] " ashpooljh
2020-12-08 18:52 ` ashpooljh
2020-12-08 19:08 ` ashpooljh
2020-12-08 19:10 ` ashpooljh
2020-12-08 19:13 ` leahneukirchen
2020-12-08 19:16 ` leahneukirchen
2020-12-10  9:55 ` [PR PATCH] [Updated] " ashpooljh
2020-12-10 10:02 ` ashpooljh
2020-12-10 10:04 ` ashpooljh
2020-12-11 15:10 ` [PR REVIEW] " ericonr
2020-12-11 16:05 ` ashpooljh
2020-12-11 16:06 ` ashpooljh
2020-12-11 16:16 ` ericonr
2020-12-11 23:26 ` [PR PATCH] [Updated] " ashpooljh
2020-12-11 23:40 ` ashpooljh
2020-12-11 23:41 ` ashpooljh
2020-12-11 23:43 ` ashpooljh
2020-12-11 23:49 ` ashpooljh
2020-12-12  1:44 ` ericonr
2020-12-12  9:32 ` [PR PATCH] [Updated] " ashpooljh
2020-12-12  9:48 ` ashpooljh
2020-12-16  1:26 ` ericonr
2020-12-16  1:26 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).