* [PR PATCH] Fixed i2pd for older processors
@ 2020-11-16 16:53 qorg11
2020-11-16 17:17 ` ericonr
` (14 more replies)
0 siblings, 15 replies; 16+ messages in thread
From: qorg11 @ 2020-11-16 16:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
There is a new pull request by qorg11 against master on the void-packages repository
https://github.com/qorg11/void-packages fix-i2pd
https://github.com/void-linux/void-packages/pull/26436
Fixed i2pd for older processors
Some processors have not the AES instructions set
(https://en.wikipedia.org/wiki/AES_instruction_set) and if you try to
run i2pd in a processor without that, it will simply give "Illegal instruction"
This can be fixed by removing the `USE_AESNI=1` make
flag. (https://i2pd.readthedocs.io/en/latest/devs/building/windows/#aes-ni)
A patch file from https://github.com/void-linux/void-packages/pull/26436.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-i2pd-26436.patch --]
[-- Type: text/x-diff, Size: 1218 bytes --]
From 5cbb634a2c48ab1a8a73bb2de6fa3731af7de249 Mon Sep 17 00:00:00 2001
From: qorg11 <qorg@vxempire.xyz>
Date: Mon, 16 Nov 2020 17:52:29 +0100
Subject: [PATCH] Fixed i2pd for older processors
Some processors have not the AES instructions set
(https://en.wikipedia.org/wiki/AES_instruction_set) and if you try to
run i2pd in a processor without that, it will simply give "Illegal instruction"
This can be fixed by removing the `USE_AESNI=1` make
flag. (https://i2pd.readthedocs.io/en/latest/devs/building/windows/#aes-ni)
---
srcpkgs/i2pd/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/i2pd/template b/srcpkgs/i2pd/template
index 6a93f6f94c5..3128848b14e 100644
--- a/srcpkgs/i2pd/template
+++ b/srcpkgs/i2pd/template
@@ -1,7 +1,7 @@
# Template file for 'i2pd'
pkgname=i2pd
version=2.33.0
-revision=1
+revision=2
build_style=gnu-makefile
make_build_args="USE_UPNP=yes"
makedepends="zlib-devel boost-devel libressl-devel miniupnpc-devel
@@ -24,7 +24,7 @@ make_dirs="/var/lib/i2pd 0700 _i2pd _i2pd"
case "${XBPS_TARGET_MACHINE}" in
x86_64*|i686*) ;;
- *) make_build_args+=" USE_AESNI=no USE_AVX=no" ;;
+ *) make_build_args+=" USE_AVX=no" ;;
esac
pre_install() {
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Fixed i2pd for older processors
2020-11-16 16:53 [PR PATCH] Fixed i2pd for older processors qorg11
@ 2020-11-16 17:17 ` ericonr
2020-11-16 18:23 ` qorg11
` (13 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2020-11-16 17:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 427 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26436#issuecomment-728203551
Comment:
What older processors are you thinking of? Also, please fix the commit message to something like `i2pd: fix for older processors`.
That said, from https://github.com/PurpleI2P/i2pd/blob/openssl/Makefile.linux it seems that `USE_AESNI=no` (which is what the template has) should work.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Fixed i2pd for older processors
2020-11-16 16:53 [PR PATCH] Fixed i2pd for older processors qorg11
2020-11-16 17:17 ` ericonr
@ 2020-11-16 18:23 ` qorg11
2020-11-16 18:24 ` [PR PATCH] [Updated] " qorg11
` (12 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: qorg11 @ 2020-11-16 18:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
New comment by qorg11 on void-packages repository
https://github.com/void-linux/void-packages/pull/26436#issuecomment-728240722
Comment:
the i2pd version in the repos doesn't work in my Intel(R) Core(TM)2 Duo CPU P8600 @ 2.40GHz.
I compiled i2pd with just running "make" and it worked as it should. I'll fix the commit message
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR PATCH] [Updated] Fixed i2pd for older processors
2020-11-16 16:53 [PR PATCH] Fixed i2pd for older processors qorg11
2020-11-16 17:17 ` ericonr
2020-11-16 18:23 ` qorg11
@ 2020-11-16 18:24 ` qorg11
2020-11-16 18:30 ` [PR REVIEW] " ericonr
` (11 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: qorg11 @ 2020-11-16 18:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
There is an updated pull request by qorg11 against master on the void-packages repository
https://github.com/qorg11/void-packages fix-i2pd
https://github.com/void-linux/void-packages/pull/26436
Fixed i2pd for older processors
Some processors have not the AES instructions set
(https://en.wikipedia.org/wiki/AES_instruction_set) and if you try to
run i2pd in a processor without that, it will simply give "Illegal instruction"
This can be fixed by removing the `USE_AESNI=1` make
flag. (https://i2pd.readthedocs.io/en/latest/devs/building/windows/#aes-ni)
A patch file from https://github.com/void-linux/void-packages/pull/26436.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-i2pd-26436.patch --]
[-- Type: text/x-diff, Size: 1217 bytes --]
From 84ba398e64d5a7cdf7d3ae90605af0b115a33e5c Mon Sep 17 00:00:00 2001
From: qorg11 <qorg@vxempire.xyz>
Date: Mon, 16 Nov 2020 19:24:01 +0100
Subject: [PATCH] i2pd: fix for older processors
Some processors have not the AES instructions set
(https://en.wikipedia.org/wiki/AES_instruction_set) and if you try to
run i2pd in a processor without that, it will simply give "Illegal instruction"
This can be fixed by removing the `USE_AESNI=1` make
flag. (https://i2pd.readthedocs.io/en/latest/devs/building/windows/#aes-ni)
---
srcpkgs/i2pd/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/i2pd/template b/srcpkgs/i2pd/template
index 6a93f6f94c5..3128848b14e 100644
--- a/srcpkgs/i2pd/template
+++ b/srcpkgs/i2pd/template
@@ -1,7 +1,7 @@
# Template file for 'i2pd'
pkgname=i2pd
version=2.33.0
-revision=1
+revision=2
build_style=gnu-makefile
make_build_args="USE_UPNP=yes"
makedepends="zlib-devel boost-devel libressl-devel miniupnpc-devel
@@ -24,7 +24,7 @@ make_dirs="/var/lib/i2pd 0700 _i2pd _i2pd"
case "${XBPS_TARGET_MACHINE}" in
x86_64*|i686*) ;;
- *) make_build_args+=" USE_AESNI=no USE_AVX=no" ;;
+ *) make_build_args+=" USE_AVX=no" ;;
esac
pre_install() {
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] Fixed i2pd for older processors
2020-11-16 16:53 [PR PATCH] Fixed i2pd for older processors qorg11
` (2 preceding siblings ...)
2020-11-16 18:24 ` [PR PATCH] [Updated] " qorg11
@ 2020-11-16 18:30 ` ericonr
2020-11-16 18:51 ` qorg11
` (10 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2020-11-16 18:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26436#discussion_r524484647
Comment:
This only affects archs other than `x86_64` and `i686`. You should instead make a separate case for `i686`. If you test the package you just created, you'll see that you still get that error.
Furthermore, the current template has `USE_AESNI=no`, not `USE_AESNI=1`. And that should be left as it, otherwise it breaks the build for arm targets.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Fixed i2pd for older processors
2020-11-16 16:53 [PR PATCH] Fixed i2pd for older processors qorg11
` (3 preceding siblings ...)
2020-11-16 18:30 ` [PR REVIEW] " ericonr
@ 2020-11-16 18:51 ` qorg11
2020-11-16 20:02 ` ericonr
` (9 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: qorg11 @ 2020-11-16 18:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 419 bytes --]
New comment by qorg11 on void-packages repository
https://github.com/void-linux/void-packages/pull/26436#issuecomment-728255708
Comment:
> Furthermore, the current template has `USE_AESNI=no`, not `USE_AESNI=1`. And that should be left as it, otherwise it breaks the build for arm targets.
Mmh, then any idea of why i get the "Illegal instruction" error while
running i2pd if apparently it wasn't compiled with it?
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Fixed i2pd for older processors
2020-11-16 16:53 [PR PATCH] Fixed i2pd for older processors qorg11
` (4 preceding siblings ...)
2020-11-16 18:51 ` qorg11
@ 2020-11-16 20:02 ` ericonr
2020-11-17 23:52 ` [PR REVIEW] " sgn
` (8 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2020-11-16 20:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26436#issuecomment-728292979
Comment:
You should make it something like `i686*|*) make_build_args+=" USE_AESNI=no USE_AVX=no"`
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] Fixed i2pd for older processors
2020-11-16 16:53 [PR PATCH] Fixed i2pd for older processors qorg11
` (5 preceding siblings ...)
2020-11-16 20:02 ` ericonr
@ 2020-11-17 23:52 ` sgn
2020-11-17 23:53 ` sgn
` (7 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: sgn @ 2020-11-17 23:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 378 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/26436#discussion_r525602537
Comment:
I think there're some x86_64 CPU that doesn't speak `AESNI`, too. And there're i686 and armv8-a CPU that speaks AESNI. So, either disable them unconditionally, or make another package for `USE_AESNI=no` is better IMO.
I don't know :-p
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] Fixed i2pd for older processors
2020-11-16 16:53 [PR PATCH] Fixed i2pd for older processors qorg11
` (6 preceding siblings ...)
2020-11-17 23:52 ` [PR REVIEW] " sgn
@ 2020-11-17 23:53 ` sgn
2020-11-17 23:53 ` sgn
` (6 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: sgn @ 2020-11-17 23:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 381 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/26436#discussion_r525602537
Comment:
I think there're some x86_64 CPU that doesn't speak `AESNI`, either. And there're i686 and armv8-a CPU that speaks AESNI. So, either disable them unconditionally, or make another package for `USE_AESNI=no` is better IMO.
I don't know :-p
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] Fixed i2pd for older processors
2020-11-16 16:53 [PR PATCH] Fixed i2pd for older processors qorg11
` (7 preceding siblings ...)
2020-11-17 23:53 ` sgn
@ 2020-11-17 23:53 ` sgn
2020-11-18 0:13 ` ericonr
` (5 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: sgn @ 2020-11-17 23:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/26436#discussion_r525602765
Comment:
Or build_options :shrug:
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] Fixed i2pd for older processors
2020-11-16 16:53 [PR PATCH] Fixed i2pd for older processors qorg11
` (8 preceding siblings ...)
2020-11-17 23:53 ` sgn
@ 2020-11-18 0:13 ` ericonr
2021-01-07 0:20 ` sgn
` (4 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2020-11-18 0:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26436#discussion_r525609850
Comment:
One of our ARM crosscompilers didn't understand `-maes`, which the build system tries to use. I don't remember which, unfortunately.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] Fixed i2pd for older processors
2020-11-16 16:53 [PR PATCH] Fixed i2pd for older processors qorg11
` (9 preceding siblings ...)
2020-11-18 0:13 ` ericonr
@ 2021-01-07 0:20 ` sgn
2021-01-07 0:21 ` sgn
` (3 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: sgn @ 2021-01-07 0:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 282 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/26436#discussion_r553031063
Comment:
I think it should be:
```sh
case "${XBPS_TARGET_MACHINE}" in
x86_64*) ;;
*) make_build_args+=" USE_AESNI=no USE_AVX=no" ;;
esac
```
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] Fixed i2pd for older processors
2020-11-16 16:53 [PR PATCH] Fixed i2pd for older processors qorg11
` (10 preceding siblings ...)
2021-01-07 0:20 ` sgn
@ 2021-01-07 0:21 ` sgn
2021-01-07 0:46 ` [PR PATCH] [Closed]: " qorg11
` (2 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: sgn @ 2021-01-07 0:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/26436#discussion_r553031063
Comment:
I think it should be:
```sh
case "${XBPS_TARGET_MACHINE}" in
x86_64*) make_build_args+=" USE_AESNI=yes USE_AVX=yes" ;;
*) make_build_args+=" USE_AESNI=no USE_AVX=no" ;;
esac
```
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR PATCH] [Closed]: Fixed i2pd for older processors
2020-11-16 16:53 [PR PATCH] Fixed i2pd for older processors qorg11
` (11 preceding siblings ...)
2021-01-07 0:21 ` sgn
@ 2021-01-07 0:46 ` qorg11
2021-01-07 0:47 ` [PR REVIEW] " qorg11
2021-04-18 4:40 ` ericonr
14 siblings, 0 replies; 16+ messages in thread
From: qorg11 @ 2021-01-07 0:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
There's a closed pull request on the void-packages repository
Fixed i2pd for older processors
https://github.com/void-linux/void-packages/pull/26436
Description:
Some processors have not the AES instructions set
(https://en.wikipedia.org/wiki/AES_instruction_set) and if you try to
run i2pd in a processor without that, it will simply give "Illegal instruction"
This can be fixed by removing the `USE_AESNI=1` make
flag. (https://i2pd.readthedocs.io/en/latest/devs/building/windows/#aes-ni)
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] Fixed i2pd for older processors
2020-11-16 16:53 [PR PATCH] Fixed i2pd for older processors qorg11
` (12 preceding siblings ...)
2021-01-07 0:46 ` [PR PATCH] [Closed]: " qorg11
@ 2021-01-07 0:47 ` qorg11
2021-04-18 4:40 ` ericonr
14 siblings, 0 replies; 16+ messages in thread
From: qorg11 @ 2021-01-07 0:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 205 bytes --]
New review comment by qorg11 on void-packages repository
https://github.com/void-linux/void-packages/pull/26436#discussion_r553046843
Comment:
Not sure what to do with this. So I closed the pull request
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Fixed i2pd for older processors
2020-11-16 16:53 [PR PATCH] Fixed i2pd for older processors qorg11
` (13 preceding siblings ...)
2021-01-07 0:47 ` [PR REVIEW] " qorg11
@ 2021-04-18 4:40 ` ericonr
14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-04-18 4:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26436#issuecomment-821931433
Comment:
Fixed in 614576e956aba2f0e9b689d78527e51559c27c0d
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2021-04-18 4:40 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 16:53 [PR PATCH] Fixed i2pd for older processors qorg11
2020-11-16 17:17 ` ericonr
2020-11-16 18:23 ` qorg11
2020-11-16 18:24 ` [PR PATCH] [Updated] " qorg11
2020-11-16 18:30 ` [PR REVIEW] " ericonr
2020-11-16 18:51 ` qorg11
2020-11-16 20:02 ` ericonr
2020-11-17 23:52 ` [PR REVIEW] " sgn
2020-11-17 23:53 ` sgn
2020-11-17 23:53 ` sgn
2020-11-18 0:13 ` ericonr
2021-01-07 0:20 ` sgn
2021-01-07 0:21 ` sgn
2021-01-07 0:46 ` [PR PATCH] [Closed]: " qorg11
2021-01-07 0:47 ` [PR REVIEW] " qorg11
2021-04-18 4:40 ` ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).