* Re: [PR PATCH] [Updated] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
2021-01-27 23:49 [PR PATCH] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh ericonr
@ 2021-01-28 0:00 ` ericonr
2021-01-28 0:01 ` ericonr
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-28 0:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1961 bytes --]
There is an updated pull request by ericonr against master on the void-packages repository
https://github.com/ericonr/void-packages hooks
https://github.com/void-linux/void-packages/pull/28277
[WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
Files under /usr/share can't be stripped at all, since they shouldn't be
ELFs (if they are ELFs, they are unlikely to be ELFs for the target and
suitable for being stripped / debugged).
Since some big data packages have a lot of files /usr/share, this can
considerably speed up the hook, for no change in the package output.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28277.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hooks-28277.patch --]
[-- Type: text/x-diff, Size: 1446 bytes --]
From 7df45accb9c83758d23e16753af02091c8a37469 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Wed, 27 Jan 2021 20:39:28 -0300
Subject: [PATCH] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
Files under /usr/share can't be stripped at all, since they shouldn't be
ELFs (if they are ELFs, they are unlikely to be ELFs for the target and
suitable for being stripped / debugged).
Since some big data packages have a lot of files /usr/share, this can
considerably speed up the hook, for no change in the package output.
Add further filtering for at least one of the executable bits to be set.
---
common/hooks/post-install/06-strip-and-debug-pkgs.sh | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/common/hooks/post-install/06-strip-and-debug-pkgs.sh b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
index b59dde5ab3c..8294c97c0bf 100644
--- a/common/hooks/post-install/06-strip-and-debug-pkgs.sh
+++ b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
@@ -65,11 +65,10 @@ hook() {
STRIPCMD=/usr/bin/$STRIP
- find ${PKGDESTDIR} -type f | while read f; do
- if [[ $f =~ ^${PKGDESTDIR}/usr/lib/debug/ ]]; then
- continue
- fi
-
+ find ${PKGDESTDIR} \
+ -path ${PKGDESTDIR}/usr/share/ -prune -path ${PKGDESTDIR}/usr/lib/debug/ -prune \
+ -type f -perm /111 |
+ while read f; do
if [[ $(file -b "$f") =~ "no machine" ]]; then
continue
fi
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
2021-01-27 23:49 [PR PATCH] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh ericonr
2021-01-28 0:00 ` [PR PATCH] [Updated] " ericonr
@ 2021-01-28 0:01 ` ericonr
2021-01-28 0:07 ` [PR REVIEW] " sgn
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-28 0:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1961 bytes --]
There is an updated pull request by ericonr against master on the void-packages repository
https://github.com/ericonr/void-packages hooks
https://github.com/void-linux/void-packages/pull/28277
[WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
Files under /usr/share can't be stripped at all, since they shouldn't be
ELFs (if they are ELFs, they are unlikely to be ELFs for the target and
suitable for being stripped / debugged).
Since some big data packages have a lot of files /usr/share, this can
considerably speed up the hook, for no change in the package output.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28277.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hooks-28277.patch --]
[-- Type: text/x-diff, Size: 1361 bytes --]
From c3c51646b189ece2c5324bd9bf70111416790477 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Wed, 27 Jan 2021 20:39:28 -0300
Subject: [PATCH] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
Files under /usr/share can't be stripped at all, since they shouldn't be
ELFs (if they are ELFs, they are unlikely to be ELFs for the target and
suitable for being stripped / debugged).
Since some big data packages have a lot of files /usr/share, this can
considerably speed up the hook, for no change in the package output.
---
common/hooks/post-install/06-strip-and-debug-pkgs.sh | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/common/hooks/post-install/06-strip-and-debug-pkgs.sh b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
index b59dde5ab3c..af76b5e4d8b 100644
--- a/common/hooks/post-install/06-strip-and-debug-pkgs.sh
+++ b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
@@ -65,11 +65,10 @@ hook() {
STRIPCMD=/usr/bin/$STRIP
- find ${PKGDESTDIR} -type f | while read f; do
- if [[ $f =~ ^${PKGDESTDIR}/usr/lib/debug/ ]]; then
- continue
- fi
-
+ find ${PKGDESTDIR} \
+ -path ${PKGDESTDIR}/usr/share/ -prune -path ${PKGDESTDIR}/usr/lib/debug/ -prune \
+ -type f |
+ while read f; do
if [[ $(file -b "$f") =~ "no machine" ]]; then
continue
fi
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
2021-01-27 23:49 [PR PATCH] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh ericonr
2021-01-28 0:00 ` [PR PATCH] [Updated] " ericonr
2021-01-28 0:01 ` ericonr
@ 2021-01-28 0:07 ` sgn
2021-01-28 0:11 ` ericonr
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: sgn @ 2021-01-28 0:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/28277#discussion_r565727719
Comment:
IMO, we should only consider files inside `/usr/bin` `/usr/lib` and `/usr/libexec`
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
2021-01-27 23:49 [PR PATCH] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh ericonr
` (2 preceding siblings ...)
2021-01-28 0:07 ` [PR REVIEW] " sgn
@ 2021-01-28 0:11 ` ericonr
2021-01-28 0:12 ` ericonr
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-28 0:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28277#discussion_r565729333
Comment:
There's also `/opt` and the directories for all the cross toolchains.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
2021-01-27 23:49 [PR PATCH] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh ericonr
` (3 preceding siblings ...)
2021-01-28 0:11 ` ericonr
@ 2021-01-28 0:12 ` ericonr
2021-01-28 0:29 ` sgn
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-28 0:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 255 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28277#discussion_r565729513
Comment:
Since the only place where we guarantee no ELFs can be found is `/usr/share`, that's the only one I excluded
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
2021-01-27 23:49 [PR PATCH] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh ericonr
` (4 preceding siblings ...)
2021-01-28 0:12 ` ericonr
@ 2021-01-28 0:29 ` sgn
2021-01-28 1:02 ` ericonr
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: sgn @ 2021-01-28 0:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/28277#discussion_r565736966
Comment:
binaries in /etc would be incorrect, too, but /etc contains very few files, so that's fine. I don't think we should strip `/opt`.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
2021-01-27 23:49 [PR PATCH] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh ericonr
` (5 preceding siblings ...)
2021-01-28 0:29 ` sgn
@ 2021-01-28 1:02 ` ericonr
2021-01-28 3:34 ` ericonr
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-28 1:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 377 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28277#discussion_r565748833
Comment:
We could maybe expand elf-in-usrshare to other directories, including `/etc`.
On the matter of `/opt`, it's fair to assume most third party stuff will be stripped already, but maybe stuff liked `rpi-userland` still needs to be?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
2021-01-27 23:49 [PR PATCH] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh ericonr
` (6 preceding siblings ...)
2021-01-28 1:02 ` ericonr
@ 2021-01-28 3:34 ` ericonr
2021-01-28 3:34 ` ericonr
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-28 3:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 194 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28277#discussion_r565797745
Comment:
Confirmed, we have a `rpi-userland-dbg` packge.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
2021-01-27 23:49 [PR PATCH] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh ericonr
` (7 preceding siblings ...)
2021-01-28 3:34 ` ericonr
@ 2021-01-28 3:34 ` ericonr
2021-02-09 2:30 ` [PR PATCH] [Updated] " ericonr
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-28 3:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 195 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28277#discussion_r565797745
Comment:
Confirmed, we have a `rpi-userland-dbg` package.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
2021-01-27 23:49 [PR PATCH] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh ericonr
` (8 preceding siblings ...)
2021-01-28 3:34 ` ericonr
@ 2021-02-09 2:30 ` ericonr
2021-02-09 2:30 ` [PR REVIEW] " ericonr
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-02-09 2:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1961 bytes --]
There is an updated pull request by ericonr against master on the void-packages repository
https://github.com/ericonr/void-packages hooks
https://github.com/void-linux/void-packages/pull/28277
[WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
Files under /usr/share can't be stripped at all, since they shouldn't be
ELFs (if they are ELFs, they are unlikely to be ELFs for the target and
suitable for being stripped / debugged).
Since some big data packages have a lot of files /usr/share, this can
considerably speed up the hook, for no change in the package output.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28277.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hooks-28277.patch --]
[-- Type: text/x-diff, Size: 1342 bytes --]
From 411d20f0c028233932f8e140f64d8d496fbd9628 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Wed, 27 Jan 2021 20:39:28 -0300
Subject: [PATCH] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
Files under /usr/share can't be stripped at all, since they shouldn't be
ELFs (if they are ELFs, they are unlikely to be ELFs for the target and
suitable for being stripped / debugged).
Since some big data packages have a lot of files /usr/share, this can
considerably speed up the hook, for no change in the package output.
---
common/hooks/post-install/06-strip-and-debug-pkgs.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/common/hooks/post-install/06-strip-and-debug-pkgs.sh b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
index 52591c38b31..25fceb1394b 100644
--- a/common/hooks/post-install/06-strip-and-debug-pkgs.sh
+++ b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
@@ -65,10 +65,10 @@ hook() {
STRIPCMD=/usr/bin/$STRIP
- find ${PKGDESTDIR} -type f | while read f; do
- if [[ $f =~ ^${PKGDESTDIR}/usr/lib/debug/ ]]; then
- continue
- fi
+ find ${PKGDESTDIR} \
+ -path ${PKGDESTDIR}/usr/share/ -prune -path ${PKGDESTDIR}/usr/lib/debug/ -prune \
+ -type f |
+ while read f; do
fname=${f##*/}
for x in ${nostrip_files}; do
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
2021-01-27 23:49 [PR PATCH] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh ericonr
` (9 preceding siblings ...)
2021-02-09 2:30 ` [PR PATCH] [Updated] " ericonr
@ 2021-02-09 2:30 ` ericonr
2021-02-09 2:55 ` [PR PATCH] [Updated] " ericonr
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-02-09 2:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28277#discussion_r572522688
Comment:
I will leave the decision regarding where we can have binaries for later. For now, this will just keep the old behavior.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
2021-01-27 23:49 [PR PATCH] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh ericonr
` (10 preceding siblings ...)
2021-02-09 2:30 ` [PR REVIEW] " ericonr
@ 2021-02-09 2:55 ` ericonr
2022-05-02 2:16 ` github-actions
2022-05-17 2:14 ` [PR PATCH] [Closed]: " github-actions
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-02-09 2:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1961 bytes --]
There is an updated pull request by ericonr against master on the void-packages repository
https://github.com/ericonr/void-packages hooks
https://github.com/void-linux/void-packages/pull/28277
[WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
Files under /usr/share can't be stripped at all, since they shouldn't be
ELFs (if they are ELFs, they are unlikely to be ELFs for the target and
suitable for being stripped / debugged).
Since some big data packages have a lot of files /usr/share, this can
considerably speed up the hook, for no change in the package output.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28277.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hooks-28277.patch --]
[-- Type: text/x-diff, Size: 1352 bytes --]
From 6d1e1e62231a6f6dafa19fbc1e81f2f3a39b95b7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Wed, 27 Jan 2021 20:39:28 -0300
Subject: [PATCH] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
Files under /usr/share can't be stripped at all, since they shouldn't be
ELFs (if they are ELFs, they are unlikely to be ELFs for the target and
suitable for being stripped / debugged).
Since some big data packages have a lot of files /usr/share, this can
considerably speed up the hook, for no change in the package output.
---
common/hooks/post-install/06-strip-and-debug-pkgs.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/common/hooks/post-install/06-strip-and-debug-pkgs.sh b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
index 52591c38b31..1c03c5b8130 100644
--- a/common/hooks/post-install/06-strip-and-debug-pkgs.sh
+++ b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
@@ -65,10 +65,10 @@ hook() {
STRIPCMD=/usr/bin/$STRIP
- find ${PKGDESTDIR} -type f | while read f; do
- if [[ $f =~ ^${PKGDESTDIR}/usr/lib/debug/ ]]; then
- continue
- fi
+ find ${PKGDESTDIR} \
+ \( -path ${PKGDESTDIR}/usr/share -o -path ${PKGDESTDIR}/usr/lib/debug \) -prune \
+ -false -o -type f |
+ while read f; do
fname=${f##*/}
for x in ${nostrip_files}; do
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
2021-01-27 23:49 [PR PATCH] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh ericonr
` (11 preceding siblings ...)
2021-02-09 2:55 ` [PR PATCH] [Updated] " ericonr
@ 2022-05-02 2:16 ` github-actions
2022-05-17 2:14 ` [PR PATCH] [Closed]: " github-actions
13 siblings, 0 replies; 15+ messages in thread
From: github-actions @ 2022-05-02 2:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/28277#issuecomment-1114433440
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Closed]: [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
2021-01-27 23:49 [PR PATCH] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh ericonr
` (12 preceding siblings ...)
2022-05-02 2:16 ` github-actions
@ 2022-05-17 2:14 ` github-actions
13 siblings, 0 replies; 15+ messages in thread
From: github-actions @ 2022-05-17 2:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1807 bytes --]
There's a closed pull request on the void-packages repository
[WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
https://github.com/void-linux/void-packages/pull/28277
Description:
Files under /usr/share can't be stripped at all, since they shouldn't be
ELFs (if they are ELFs, they are unlikely to be ELFs for the target and
suitable for being stripped / debugged).
Since some big data packages have a lot of files /usr/share, this can
considerably speed up the hook, for no change in the package output.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 15+ messages in thread