Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] uim: disable non-utf-8 anthy backend
@ 2021-04-03 20:15 Gorggg
  2021-04-03 22:01 ` ericonr
                   ` (16 more replies)
  0 siblings, 17 replies; 18+ messages in thread
From: Gorggg @ 2021-04-03 20:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2480 bytes --]

There is a new pull request by Gorggg against master on the void-packages repository

https://github.com/Gorggg/void-packages master
https://github.com/void-linux/void-packages/pull/29981

uim: disable non-utf-8 anthy backend
After the recent upgrade of anthy to 0.4 in [https://github.com/void-linux/void-packages/commit/700c49292eccc0cd96372e45027e2a929229e060](https://github.com/void-linux/void-packages/commit/700c49292eccc0cd96372e45027e2a929229e060), the anthy input method in uim will no longer work with the anthy available in the repository, instead requiring the anthy-utf8 input method to interface and convert kanji correctly. In order to prevent broken configurations, this change disables the build of the old anthy input method.

In order to avoid installing the new build of uim-anthy when the old anthy is present, I set uim-anthy to conflict with older versions of anthy that use EUC-JP instead of UTF-8. If there is a better way of ensuring this is not installed in a way that introduces incompatibility, I would very much like to know.

Thank you for reading this and for any reply.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29981.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-29981.patch --]
[-- Type: text/x-diff, Size: 1685 bytes --]

From dfc4f246aaca38d9e903e88e4048b65229ec69f2 Mon Sep 17 00:00:00 2001
From: George Matsumura <gmmatsumura01@bvsd.org>
Date: Sat, 3 Apr 2021 03:22:39 -0600
Subject: [PATCH] uim: disable non-utf-8 anthy backend

The version of anthy (0.4) that is now in the repository will not
work correctly with uim's conventional anthy input method, failing
to convert kanji. It will only with the anthy-utf-8 input method,
which accounts for the substitution of the EUC-JP encoding with
UTF-8 in newer anthy versions. In order to prevent broken
configurations, this change disables the build of the old anthy
input method.
---
 srcpkgs/uim/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/uim/template b/srcpkgs/uim/template
index 12df0eddb067..3d3c33087fe8 100644
--- a/srcpkgs/uim/template
+++ b/srcpkgs/uim/template
@@ -1,12 +1,12 @@
 # Template file for 'uim'
 pkgname=uim
 version=1.8.8
-revision=4
+revision=5
 build_style=gnu-configure
 build_helper=qmake
 configure_args="--enable-pref --enable-fep --with-gtk2 --with-gtk3
- --with-libgcroots=installed
- --with-qt5 --with-qt5-immodule --with-x --with-anthy-utf8 --with-skk"
+ --with-libgcroots=installed --with-qt5 --with-qt5-immodule --with-x
+ --with-anthy-utf8 --without-anthy --with-skk"
 hostmakedepends="pkg-config intltool qt5-host-tools qt5-qmake automake
  libtool gettext-devel"
 makedepends="gtk+-devel gtk+3-devel qt5-devel ncurses-devel anthy-devel
@@ -61,6 +61,7 @@ uim-qt_package() {
 
 uim-anthy_package() {
 	short_desc+=" - Anthy IME"
+	conflicts="anthy-9100h_1 anthy-9100h_2"
 	pkg_install() {
 		vmove "usr/lib/uim/plugin/libuim-anthy*.so"
 		vmove "usr/share/uim/anthy*.scm"

^ permalink raw reply	[flat|nested] 18+ messages in thread
end of thread, other threads:[~2021-04-15 14:39 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-03 20:15 [PR PATCH] uim: disable non-utf-8 anthy backend Gorggg
2021-04-03 22:01 ` ericonr
2021-04-04 15:45 ` sgn
2021-04-04 19:47 ` Gorggg
2021-04-04 19:49 ` [PR PATCH] [Updated] " Gorggg
2021-04-04 19:50 ` Gorggg
2021-04-05  0:55 ` sgn
2021-04-05  0:55 ` sgn
2021-04-05  0:56 ` sgn
2021-04-05  2:04 ` Gorggg
2021-04-05  2:04 ` Gorggg
2021-04-05  2:05 ` Gorggg
2021-04-05  2:25 ` Gorggg
2021-04-06 12:23 ` sgn
2021-04-06 16:02 ` Gorggg
2021-04-07  0:15 ` sgn
2021-04-14 23:47 ` sgn
2021-04-15 14:39 ` [PR PATCH] [Closed]: " sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).