* Re: [PR REVIEW] xrdb: update to 1.2.1
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33143@inbox.vuxu.org>
@ 2021-09-27 1:05 ` mtboehlke
2021-09-29 22:25 ` ericonr
` (2 subsequent siblings)
3 siblings, 0 replies; 4+ messages in thread
From: mtboehlke @ 2021-09-27 1:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 223 bytes --]
New review comment by mtboehlke on void-packages repository
https://github.com/void-linux/void-packages/pull/33143#discussion_r716295671
Comment:
```suggestion
configure_args="--with-cpp=/usr/bin/cpp,/usr/bin/mcpp"
```
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PR REVIEW] xrdb: update to 1.2.1
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33143@inbox.vuxu.org>
2021-09-27 1:05 ` [PR REVIEW] xrdb: update to 1.2.1 mtboehlke
@ 2021-09-29 22:25 ` ericonr
2021-09-30 1:39 ` mtboehlke
2021-09-30 1:39 ` mtboehlke
3 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-09-29 22:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 256 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/33143#discussion_r718926539
Comment:
I like your suggestion. Idk if it works, but `clang-cpp` could also be added if you want to cover everything.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PR REVIEW] xrdb: update to 1.2.1
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33143@inbox.vuxu.org>
2021-09-27 1:05 ` [PR REVIEW] xrdb: update to 1.2.1 mtboehlke
2021-09-29 22:25 ` ericonr
@ 2021-09-30 1:39 ` mtboehlke
2021-09-30 1:39 ` mtboehlke
3 siblings, 0 replies; 4+ messages in thread
From: mtboehlke @ 2021-09-30 1:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 471 bytes --]
New review comment by mtboehlke on void-packages repository
https://github.com/void-linux/void-packages/pull/33143#discussion_r718995285
Comment:
I like the idea of including clang-cpp. I did some minimal testing with some `#include` and `#ifdef` directives, and made sure the `-I` and `-D` flags work, but as far as I can tell clang-cpp works too. I have cpp preferred first, since it is probably the expected default, then clang-cpp, and then use mcpp as fallback.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PR REVIEW] xrdb: update to 1.2.1
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33143@inbox.vuxu.org>
` (2 preceding siblings ...)
2021-09-30 1:39 ` mtboehlke
@ 2021-09-30 1:39 ` mtboehlke
3 siblings, 0 replies; 4+ messages in thread
From: mtboehlke @ 2021-09-30 1:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 463 bytes --]
New review comment by mtboehlke on void-packages repository
https://github.com/void-linux/void-packages/pull/33143#discussion_r718995285
Comment:
I like the idea of including clang-cpp. I did some testing with some `#include` and `#ifdef` directives, and made sure the `-I` and `-D` flags work, and as far as I can tell clang-cpp works too. I have cpp preferred first, since it is probably the expected default, then clang-cpp, and then use mcpp as fallback.
^ permalink raw reply [flat|nested] 4+ messages in thread