Re: [PR REVIEW] xrdb: update to 1.2.1

Re: [PR REVIEW] xrdb: update to 1.2.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33143#discussion_r718926539

Comment:
I like your suggestion. Idk if it works, but `clang-cpp` could also be added if you want to cover everything.

Re: [PR PATCH] [Updated] xrdb: update to 1.2.1

[mtboehlke]

[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]

There is an updated pull request by mtboehlke against master on the void-packages repository

https://github.com/mtboehlke/void-packages xrdb
https://github.com/void-linux/void-packages/pull/33143

xrdb: update to 1.2.1
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33143.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xrdb-33143.patch --]
[-- Type: text/x-diff, Size: 1200 bytes --]

From dc1fa2c511344053a68b5871e203ed9d9c7bafa6 Mon Sep 17 00:00:00 2001
From: Mat Boehlke <mtboehlke@gmail.com>
Date: Sun, 26 Sep 2021 19:03:49 -0500
Subject: [PATCH] xrdb: update to 1.2.1

Prefer cpp or clang-cpp for preprocessing if installed
---
 srcpkgs/xrdb/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/xrdb/template b/srcpkgs/xrdb/template
index 6d849ba0571b..e786702c8d80 100644
--- a/srcpkgs/xrdb/template
+++ b/srcpkgs/xrdb/template
@@ -1,9 +1,9 @@
 # Template file for 'xrdb'
 pkgname=xrdb
-version=1.2.0
-revision=2
+version=1.2.1
+revision=1
 build_style=gnu-configure
-configure_args="--with-cpp=/usr/bin/mcpp"
+configure_args="--with-cpp=/usr/bin/cpp,/usr/bin/clang-cpp,/usr/bin/mcpp"
 hostmakedepends="pkg-config"
 makedepends="libX11-devel libXmu-devel"
 depends="mcpp"
@@ -12,7 +12,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"
 homepage="http://xorg.freedesktop.org"
 distfiles="${XORG_SITE}/app/${pkgname}-${version}.tar.bz2"
-checksum=f23a65cfa1f7126040d68b6cf1e4567523edac10f8dc06f23d840d330c7c6946
+checksum=4f5d031c214ffb88a42ae7528492abde1178f5146351ceb3c05f3b8d5abee8b4
 
 post_install() {
 	vlicense COPYING

Re: [PR REVIEW] xrdb: update to 1.2.1

[mtboehlke]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

New review comment by mtboehlke on void-packages repository

https://github.com/void-linux/void-packages/pull/33143#discussion_r718995285

Comment:
I like the idea of including clang-cpp.  I did some minimal testing with some `#include` and `#ifdef` directives, and made sure the `-I` and `-D` flags work, but as far as I can tell clang-cpp works too.  I have cpp preferred first, since it is probably the expected default, then clang-cpp, and then use mcpp as fallback.

Re: [PR REVIEW] xrdb: update to 1.2.1

[mtboehlke]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

New review comment by mtboehlke on void-packages repository

https://github.com/void-linux/void-packages/pull/33143#discussion_r718995285

Comment:
I like the idea of including clang-cpp.  I did some testing with some `#include` and `#ifdef` directives, and made sure the `-I` and `-D` flags work, and as far as I can tell clang-cpp works too.  I have cpp preferred first, since it is probably the expected default, then clang-cpp, and then use mcpp as fallback.

Re: xrdb: update to 1.2.1

[mtboehlke]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New comment by mtboehlke on void-packages repository

https://github.com/void-linux/void-packages/pull/33143#issuecomment-930681219

Comment:
I have included the change for using cpp by default if it is available.  Per suggestion from @ericonr I have included clang-cpp as well, so mcpp is only used if neither of those are installed.

Re: xrdb: update to 1.2.1

[mtboehlke]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

New comment by mtboehlke on void-packages repository

https://github.com/void-linux/void-packages/pull/33143#issuecomment-930681219

Comment:
I have included the change for using cpp by default if it is available.  Per suggestion from @ericonr I have included clang-cpp as well, so mcpp is only used if neither of those are installed.  And of course, this can be overrode on the command line.

Re: [PR PATCH] [Merged]: xrdb: update to 1.2.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]

There's a merged pull request on the void-packages repository

xrdb: update to 1.2.1
https://github.com/void-linux/void-packages/pull/33143

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Re: [PR REVIEW] xrdb: update to 1.2.1

[mtboehlke]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New review comment by mtboehlke on void-packages repository

https://github.com/void-linux/void-packages/pull/33143#discussion_r716295671

Comment:
```suggestion
configure_args="--with-cpp=/usr/bin/cpp,/usr/bin/mcpp"
```