Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: pcem-17
@ 2021-03-07  0:43 ajshell1
  2021-03-07  0:44 ` [PR PATCH] [Updated] " ajshell1
                   ` (9 more replies)
  0 siblings, 10 replies; 12+ messages in thread
From: ajshell1 @ 2021-03-07  0:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]

There is a new pull request by ajshell1 against master on the void-packages repository

https://github.com/ajshell1/void-packages pcem
https://github.com/void-linux/void-packages/pull/29285

New package: pcem-17
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29285.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pcem-29285.patch --]
[-- Type: text/x-diff, Size: 1612 bytes --]

From 78a74aed26d7ee5f03f9e76f2b36541e15ab5efc Mon Sep 17 00:00:00 2001
From: ajshell1 <11084981+ajshell1@users.noreply.github.com>
Date: Sun, 7 Mar 2021 00:41:30 +0000
Subject: [PATCH] New package: pcem-17

---
 srcpkgs/pcem/INSTALL.msg |  2 ++
 srcpkgs/pcem/template    | 22 ++++++++++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100644 srcpkgs/pcem/INSTALL.msg
 create mode 100644 srcpkgs/pcem/template

diff --git a/srcpkgs/pcem/INSTALL.msg b/srcpkgs/pcem/INSTALL.msg
new file mode 100644
index 00000000000..84bdf736fd1
--- /dev/null
+++ b/srcpkgs/pcem/INSTALL.msg
@@ -0,0 +1,2 @@
+pcem stores BIOS ROM images (not included),
+configuration files, and other data in ~/.pcem.
diff --git a/srcpkgs/pcem/template b/srcpkgs/pcem/template
new file mode 100644
index 00000000000..cd22e808958
--- /dev/null
+++ b/srcpkgs/pcem/template
@@ -0,0 +1,22 @@
+# Template file for 'pcem'
+pkgname=pcem
+version=17
+revision=1
+wrksrc="${pkgname}-${version}"
+create_wrksrc=yes
+build_style=gnu-configure
+#configure_script="./configure"
+configure_args="--enable-alsa --enable-release-build --enable-networking --prefix=/usr"
+hostmakedepends="automake pkg-config"
+makedepends="SDL2-devel alsa-lib-devel libopenal-devel wxWidgets-devel"
+depends=""
+short_desc="Emulator for old x86 PCs"
+maintainer="ajshell1 <11084981+ajshell1@users.noreply.github.com>"
+license="GPL-2.0-only"
+homepage="https://pcem-emulator.co.uk/"
+distfiles="https://pcem-emulator.co.uk/files/PCemV${version}Linux.tar.gz"
+checksum=5b24cb5ce886ed53232385f46594146ba3f7d7eecda90f82892b2dce1cb2f1a4
+
+pre_configure() {
+autoreconf
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] New package: pcem-17
  2021-03-07  0:43 [PR PATCH] New package: pcem-17 ajshell1
@ 2021-03-07  0:44 ` ajshell1
  2021-03-07  3:19 ` ajshell1
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 12+ messages in thread
From: ajshell1 @ 2021-03-07  0:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]

There is an updated pull request by ajshell1 against master on the void-packages repository

https://github.com/ajshell1/void-packages pcem
https://github.com/void-linux/void-packages/pull/29285

New package: pcem-17
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29285.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pcem-29285.patch --]
[-- Type: text/x-diff, Size: 1565 bytes --]

From 74683f16da72cf10627ab45bfa450863b98d963c Mon Sep 17 00:00:00 2001
From: ajshell1 <11084981+ajshell1@users.noreply.github.com>
Date: Sun, 7 Mar 2021 00:41:30 +0000
Subject: [PATCH] New package: pcem-17

---
 srcpkgs/pcem/INSTALL.msg |  2 ++
 srcpkgs/pcem/template    | 20 ++++++++++++++++++++
 2 files changed, 22 insertions(+)
 create mode 100644 srcpkgs/pcem/INSTALL.msg
 create mode 100644 srcpkgs/pcem/template

diff --git a/srcpkgs/pcem/INSTALL.msg b/srcpkgs/pcem/INSTALL.msg
new file mode 100644
index 00000000000..84bdf736fd1
--- /dev/null
+++ b/srcpkgs/pcem/INSTALL.msg
@@ -0,0 +1,2 @@
+pcem stores BIOS ROM images (not included),
+configuration files, and other data in ~/.pcem.
diff --git a/srcpkgs/pcem/template b/srcpkgs/pcem/template
new file mode 100644
index 00000000000..f21df0c9b24
--- /dev/null
+++ b/srcpkgs/pcem/template
@@ -0,0 +1,20 @@
+# Template file for 'pcem'
+pkgname=pcem
+version=17
+revision=1
+wrksrc="${pkgname}-${version}"
+create_wrksrc=yes
+build_style=gnu-configure
+configure_args="--enable-alsa --enable-release-build --enable-networking --prefix=/usr"
+hostmakedepends="automake pkg-config"
+makedepends="SDL2-devel alsa-lib-devel libopenal-devel wxWidgets-devel"
+short_desc="Emulator for old x86 PCs"
+maintainer="ajshell1 <11084981+ajshell1@users.noreply.github.com>"
+license="GPL-2.0-only"
+homepage="https://pcem-emulator.co.uk/"
+distfiles="https://pcem-emulator.co.uk/files/PCemV${version}Linux.tar.gz"
+checksum=5b24cb5ce886ed53232385f46594146ba3f7d7eecda90f82892b2dce1cb2f1a4
+
+pre_configure() {
+autoreconf
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] New package: pcem-17
  2021-03-07  0:43 [PR PATCH] New package: pcem-17 ajshell1
  2021-03-07  0:44 ` [PR PATCH] [Updated] " ajshell1
@ 2021-03-07  3:19 ` ajshell1
  2021-03-13 16:07 ` ajshell1
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 12+ messages in thread
From: ajshell1 @ 2021-03-07  3:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]

There is an updated pull request by ajshell1 against master on the void-packages repository

https://github.com/ajshell1/void-packages pcem
https://github.com/void-linux/void-packages/pull/29285

New package: pcem-17
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29285.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pcem-29285.patch --]
[-- Type: text/x-diff, Size: 1546 bytes --]

From e2f1d64ecc30da18173ee6384c8922ba73db8223 Mon Sep 17 00:00:00 2001
From: ajshell1 <11084981+ajshell1@users.noreply.github.com>
Date: Sun, 7 Mar 2021 00:41:30 +0000
Subject: [PATCH] New package: pcem-17

---
 srcpkgs/pcem/INSTALL.msg |  2 ++
 srcpkgs/pcem/template    | 20 ++++++++++++++++++++
 2 files changed, 22 insertions(+)
 create mode 100644 srcpkgs/pcem/INSTALL.msg
 create mode 100644 srcpkgs/pcem/template

diff --git a/srcpkgs/pcem/INSTALL.msg b/srcpkgs/pcem/INSTALL.msg
new file mode 100644
index 00000000000..84bdf736fd1
--- /dev/null
+++ b/srcpkgs/pcem/INSTALL.msg
@@ -0,0 +1,2 @@
+pcem stores BIOS ROM images (not included),
+configuration files, and other data in ~/.pcem.
diff --git a/srcpkgs/pcem/template b/srcpkgs/pcem/template
new file mode 100644
index 00000000000..e91821e6e46
--- /dev/null
+++ b/srcpkgs/pcem/template
@@ -0,0 +1,20 @@
+# Template file for 'pcem'
+pkgname=pcem
+version=17
+revision=1
+wrksrc="${pkgname}-${version}"
+create_wrksrc=yes
+build_style=gnu-configure
+configure_args="--enable-alsa --enable-release-build --enable-networking --prefix=/usr"
+hostmakedepends="automake pkg-config"
+makedepends="SDL2-devel alsa-lib-devel libopenal-devel wxWidgets-devel"
+short_desc="Emulator for old x86 PCs"
+maintainer="ajshell1 <ajshell1@protonmail.com>"
+license="GPL-2.0-only"
+homepage="https://pcem-emulator.co.uk/"
+distfiles="https://pcem-emulator.co.uk/files/PCemV${version}Linux.tar.gz"
+checksum=5b24cb5ce886ed53232385f46594146ba3f7d7eecda90f82892b2dce1cb2f1a4
+
+pre_configure() {
+autoreconf
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] New package: pcem-17
  2021-03-07  0:43 [PR PATCH] New package: pcem-17 ajshell1
  2021-03-07  0:44 ` [PR PATCH] [Updated] " ajshell1
  2021-03-07  3:19 ` ajshell1
@ 2021-03-13 16:07 ` ajshell1
  2021-03-13 17:25 ` ajshell1
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 12+ messages in thread
From: ajshell1 @ 2021-03-13 16:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]

There is an updated pull request by ajshell1 against master on the void-packages repository

https://github.com/ajshell1/void-packages pcem
https://github.com/void-linux/void-packages/pull/29285

New package: pcem-17
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29285.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pcem-29285.patch --]
[-- Type: text/x-diff, Size: 1151 bytes --]

From aa493fe6d18805918de0ef92855a8cb7c8ce35d6 Mon Sep 17 00:00:00 2001
From: ajshell1 <11084981+ajshell1@users.noreply.github.com>
Date: Sun, 7 Mar 2021 00:41:30 +0000
Subject: [PATCH] New package: pcem-17

---
 srcpkgs/pcem/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/pcem/template

diff --git a/srcpkgs/pcem/template b/srcpkgs/pcem/template
new file mode 100644
index 000000000000..48864bc5a50b
--- /dev/null
+++ b/srcpkgs/pcem/template
@@ -0,0 +1,19 @@
+# Template file for 'pcem'
+pkgname=pcem
+version=17
+revision=1
+create_wrksrc=yes
+build_style=gnu-configure
+configure_args="--enable-alsa --enable-release-build --enable-networking"
+hostmakedepends="automake pkg-config"
+makedepends="SDL2-devel alsa-lib-devel libopenal-devel wxWidgets-devel"
+short_desc="Emulator for old x86 PCs"
+maintainer="ajshell1 <ajshell1@protonmail.com>"
+license="GPL-2.0-only"
+homepage="https://pcem-emulator.co.uk/"
+distfiles="https://pcem-emulator.co.uk/files/PCemV${version}Linux.tar.gz"
+checksum=5b24cb5ce886ed53232385f46594146ba3f7d7eecda90f82892b2dce1cb2f1a4
+
+pre_configure() {
+	autoreconf -fi
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] New package: pcem-17
  2021-03-07  0:43 [PR PATCH] New package: pcem-17 ajshell1
                   ` (2 preceding siblings ...)
  2021-03-13 16:07 ` ajshell1
@ 2021-03-13 17:25 ` ajshell1
  2021-03-13 17:38 ` [PR REVIEW] " ajshell1
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 12+ messages in thread
From: ajshell1 @ 2021-03-13 17:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]

There is an updated pull request by ajshell1 against master on the void-packages repository

https://github.com/ajshell1/void-packages pcem
https://github.com/void-linux/void-packages/pull/29285

New package: pcem-17
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29285.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pcem-29285.patch --]
[-- Type: text/x-diff, Size: 1113 bytes --]

From 735bcd7e4fd7e887e94ee08f99974b3363de65b3 Mon Sep 17 00:00:00 2001
From: ajshell1 <11084981+ajshell1@users.noreply.github.com>
Date: Sun, 7 Mar 2021 00:41:30 +0000
Subject: [PATCH] New package: pcem-17

---
 srcpkgs/pcem/template | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 srcpkgs/pcem/template

diff --git a/srcpkgs/pcem/template b/srcpkgs/pcem/template
new file mode 100644
index 00000000000..83fa0891c5a
--- /dev/null
+++ b/srcpkgs/pcem/template
@@ -0,0 +1,15 @@
+# Template file for 'pcem'
+pkgname=pcem
+version=17
+revision=1
+create_wrksrc=yes
+build_style=gnu-configure
+configure_args="--enable-alsa --enable-release-build --enable-networking"
+hostmakedepends="autoconf automake pkg-config"
+makedepends="SDL2-devel alsa-lib-devel libopenal-devel wxWidgets-devel"
+short_desc="Emulator for old x86 PCs"
+maintainer="ajshell1 <ajshell1@protonmail.com>"
+license="GPL-2.0-only"
+homepage="https://pcem-emulator.co.uk/"
+distfiles="https://pcem-emulator.co.uk/files/PCemV${version}Linux.tar.gz"
+checksum=5b24cb5ce886ed53232385f46594146ba3f7d7eecda90f82892b2dce1cb2f1a4

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] New package: pcem-17
  2021-03-07  0:43 [PR PATCH] New package: pcem-17 ajshell1
                   ` (3 preceding siblings ...)
  2021-03-13 17:25 ` ajshell1
@ 2021-03-13 17:38 ` ajshell1
  2021-03-13 17:55 ` [PR PATCH] [Updated] " ajshell1
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 12+ messages in thread
From: ajshell1 @ 2021-03-13 17:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

New review comment by ajshell1 on void-packages repository

https://github.com/void-linux/void-packages/pull/29285#discussion_r593778997

Comment:
I've discovered that removing this section entirely fixes the compilation on most ARM platforms, so I've chosen to remove it entirely.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] New package: pcem-17
  2021-03-07  0:43 [PR PATCH] New package: pcem-17 ajshell1
                   ` (4 preceding siblings ...)
  2021-03-13 17:38 ` [PR REVIEW] " ajshell1
@ 2021-03-13 17:55 ` ajshell1
  2021-03-13 18:05 ` ajshell1
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 12+ messages in thread
From: ajshell1 @ 2021-03-13 17:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]

There is an updated pull request by ajshell1 against master on the void-packages repository

https://github.com/ajshell1/void-packages pcem
https://github.com/void-linux/void-packages/pull/29285

New package: pcem-17
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29285.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pcem-29285.patch --]
[-- Type: text/x-diff, Size: 1156 bytes --]

From 7e5b2d34106b370a9fa6432d8ce0bc6505800a50 Mon Sep 17 00:00:00 2001
From: ajshell1 <11084981+ajshell1@users.noreply.github.com>
Date: Sun, 7 Mar 2021 00:41:30 +0000
Subject: [PATCH] New package: pcem-17

---
 srcpkgs/pcem/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/pcem/template

diff --git a/srcpkgs/pcem/template b/srcpkgs/pcem/template
new file mode 100644
index 000000000000..a000fccb04d0
--- /dev/null
+++ b/srcpkgs/pcem/template
@@ -0,0 +1,16 @@
+# Template file for 'pcem'
+pkgname=pcem
+version=17
+revision=1
+archs="i686* x86_64* armv7l* aarch64*"
+create_wrksrc=yes
+build_style=gnu-configure
+configure_args="--enable-alsa --enable-release-build --enable-networking"
+hostmakedepends="autoconf automake pkg-config"
+makedepends="SDL2-devel alsa-lib-devel libopenal-devel wxWidgets-devel"
+short_desc="Emulator for old x86 PCs"
+maintainer="ajshell1 <ajshell1@protonmail.com>"
+license="GPL-2.0-only"
+homepage="https://pcem-emulator.co.uk/"
+distfiles="https://pcem-emulator.co.uk/files/PCemV${version}Linux.tar.gz"
+checksum=5b24cb5ce886ed53232385f46594146ba3f7d7eecda90f82892b2dce1cb2f1a4

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: New package: pcem-17
  2021-03-07  0:43 [PR PATCH] New package: pcem-17 ajshell1
                   ` (5 preceding siblings ...)
  2021-03-13 17:55 ` [PR PATCH] [Updated] " ajshell1
@ 2021-03-13 18:05 ` ajshell1
  2021-03-28 16:42 ` ScrelliCopter
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 12+ messages in thread
From: ajshell1 @ 2021-03-13 18:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

New comment by ajshell1 on void-packages repository

https://github.com/void-linux/void-packages/pull/29285#issuecomment-798716421

Comment:
I've just realized that this is a duplicate of  pull request  #22340

I'll admit to blatantly using some of his code to improve my own pull request. For example, I realized that the automake was unnecessary. Also, I dug through pcem's configure file and realized that it only accepts i386/i686, x86_64, armv7l, and aarch64 CPUs. For this reason, I thought it was appropriate to include those specific architectures in the template.

At this point, here are a list of substantial differences between our templates:

1. Mine thinks that the license is GPL2 only, he thinks it's GPL2 or later. I have no idea which is right.
2. Somewhat different method of assigning the distfiles variable
3. He uses do_extract() while I use create_wkspace, to the same effect.
4. He uses vdoc on the readme files and tested files.
5. Different short_desc
6. Different maintainer.

I don't particularly care which of us is selected, as long as one of us is.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: New package: pcem-17
  2021-03-07  0:43 [PR PATCH] New package: pcem-17 ajshell1
                   ` (6 preceding siblings ...)
  2021-03-13 18:05 ` ajshell1
@ 2021-03-28 16:42 ` ScrelliCopter
  2021-11-06 23:12 ` abenson
  2021-11-06 23:12 ` [PR PATCH] [Closed]: " abenson
  9 siblings, 0 replies; 12+ messages in thread
From: ScrelliCopter @ 2021-03-28 16:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

New comment by ScrelliCopter on void-packages repository

https://github.com/void-linux/void-packages/pull/29285#issuecomment-808922315

Comment:
Author of the first PR here, just saw this.

In my experience Void usually puts precedence on the first PR in the case of duplicates. I'm not precious about who gets to be maintainer but if you'd like to make sure any improvements over my template (touché on using create_wrksrc) make it in I'd be happy to take reviews on my PR.

It seems you already figured out the reasons behind everything I was doing but I'll elaborate on why I chose `GPL-2.0-or-later`:
Sarah never appeared to have included a copy of the GPL or attached any GPL text to her own code, grepping thru showed a lot of "version 2 (or at your option) any later version"; and actually I just looked thru v17 again and `src/f82c710_upc.c` and `src/sound_azt2316a.c` are version **3** or later, so it seems like the license field should actually be `GPL-3.0-or-later` 🤷.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: New package: pcem-17
  2021-03-07  0:43 [PR PATCH] New package: pcem-17 ajshell1
                   ` (7 preceding siblings ...)
  2021-03-28 16:42 ` ScrelliCopter
@ 2021-11-06 23:12 ` abenson
  2021-11-06 23:12 ` [PR PATCH] [Closed]: " abenson
  9 siblings, 0 replies; 12+ messages in thread
From: abenson @ 2021-11-06 23:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/29285#issuecomment-962522108

Comment:
Upstream is dead.  We can re-approach if there's a fork.

> **14th June 2021**
> Just a quick note to say that I (Sarah Walker) have decided to call it quits.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Closed]: New package: pcem-17
  2021-03-07  0:43 [PR PATCH] New package: pcem-17 ajshell1
                   ` (8 preceding siblings ...)
  2021-11-06 23:12 ` abenson
@ 2021-11-06 23:12 ` abenson
  9 siblings, 0 replies; 12+ messages in thread
From: abenson @ 2021-11-06 23:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]

There's a closed pull request on the void-packages repository

New package: pcem-17
https://github.com/void-linux/void-packages/pull/29285

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Closed]: New package: pcem-17
  2020-05-27  2:11 [PR PATCH] New package: pcem-16 ScrelliCopter
@ 2021-11-06 23:12 ` abenson
  0 siblings, 0 replies; 12+ messages in thread
From: abenson @ 2021-11-06 23:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

There's a closed pull request on the void-packages repository

New package: pcem-17
https://github.com/void-linux/void-packages/pull/22340

Description:
PCem ~~v16~~ v17
http://pcem-emulator.co.uk/

Real BIOS ROM images placed in `~/.pcem/roms/` are required to boot, some freebies are available at the Downloads section of the PCem homepage.

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-11-06 23:12 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-07  0:43 [PR PATCH] New package: pcem-17 ajshell1
2021-03-07  0:44 ` [PR PATCH] [Updated] " ajshell1
2021-03-07  3:19 ` ajshell1
2021-03-13 16:07 ` ajshell1
2021-03-13 17:25 ` ajshell1
2021-03-13 17:38 ` [PR REVIEW] " ajshell1
2021-03-13 17:55 ` [PR PATCH] [Updated] " ajshell1
2021-03-13 18:05 ` ajshell1
2021-03-28 16:42 ` ScrelliCopter
2021-11-06 23:12 ` abenson
2021-11-06 23:12 ` [PR PATCH] [Closed]: " abenson
  -- strict thread matches above, loose matches on Subject: below --
2020-05-27  2:11 [PR PATCH] New package: pcem-16 ScrelliCopter
2021-11-06 23:12 ` [PR PATCH] [Closed]: New package: pcem-17 abenson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).