[PR PATCH] New package: pcem-16

[PR PATCH] New package: pcem-16

[ScrelliCopter]

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

There is a new pull request by ScrelliCopter against master on the void-packages repository

https://github.com/ScrelliCopter/void-packages pcem
https://github.com/void-linux/void-packages/pull/22340

New package: pcem-16
PCem v16
http://pcem-emulator.co.uk/

Real BIOS ROM images placed in `~/.pcem/roms/` are required to boot, some freebies are available at the Downloads section of the PCem homepage.

A patch file from https://github.com/void-linux/void-packages/pull/22340.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pcem-22340.patch --]
[-- Type: text/x-diff, Size: 1376 bytes --]

From ab5e50efc9921f0bff0498870d9236c2d530ca05 Mon Sep 17 00:00:00 2001
From: a dinosaur <nick@a-dinosaur.com>
Date: Wed, 27 May 2020 11:58:50 +1000
Subject: [PATCH] New package: pcem-16

---
 srcpkgs/pcem/template | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 srcpkgs/pcem/template

diff --git a/srcpkgs/pcem/template b/srcpkgs/pcem/template
new file mode 100644
index 00000000000..8dded87aa5f
--- /dev/null
+++ b/srcpkgs/pcem/template
@@ -0,0 +1,29 @@
+# Template file for 'pcem'
+pkgname=pcem
+version=16
+revision=1
+archs="i686 x86_64 armv7l aarch64"
+build_style=gnu-configure
+configure_args="--enable-release-build --enable-networking --enable-alsa"
+hostmakedepends="autoconf automake pkgconf"
+makedepends="SDL2-devel wxWidgets-devel libopenal-devel alsa-lib-devel"
+short_desc="Low-level x86 emulator targeting various IBM PC compatibles"
+maintainer="a dinosaur <nick@a-dinosaur.com>"
+license="GPL-2.0-or-later"
+homepage="https://pcem-emulator.co.uk"
+_distfile="PCemV${version}Linux.tar.gz"
+distfiles="${homepage}/files/${_distfile}"
+checksum=45ae9321ee25375f0e685a49d84e8a5acba8ed33ccf597299edcf287cb3c8499
+
+do_extract() {
+	bsdtar -xf "${XBPS_SRCDISTDIR}/${pkgname}-${version}/${_distfile}" -C ${wrksrc}
+}
+
+pre_configure() {
+	autoreconf -if
+}
+
+post_install() {
+	vdoc readme.txt
+	vdoc Readme-LINUX.txt
+}

Re: [PR PATCH] [Updated] [WIP] New package: pcem-16

[ScrelliCopter]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

There is an updated pull request by ScrelliCopter against master on the void-packages repository

https://github.com/ScrelliCopter/void-packages pcem
https://github.com/void-linux/void-packages/pull/22340

[WIP] New package: pcem-16
PCem v16
http://pcem-emulator.co.uk/

Real BIOS ROM images placed in `~/.pcem/roms/` are required to boot, some freebies are available at the Downloads section of the PCem homepage.

A patch file from https://github.com/void-linux/void-packages/pull/22340.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pcem-22340.patch --]
[-- Type: text/x-diff, Size: 1380 bytes --]

From e7b7e9bd422950118a9926c95644a0da95f2e503 Mon Sep 17 00:00:00 2001
From: a dinosaur <nick@a-dinosaur.com>
Date: Wed, 27 May 2020 11:58:50 +1000
Subject: [PATCH] New package: pcem-16

---
 srcpkgs/pcem/template | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 srcpkgs/pcem/template

diff --git a/srcpkgs/pcem/template b/srcpkgs/pcem/template
new file mode 100644
index 00000000000..25831ac0f3e
--- /dev/null
+++ b/srcpkgs/pcem/template
@@ -0,0 +1,29 @@
+# Template file for 'pcem'
+pkgname=pcem
+version=16
+revision=1
+archs="i686* x86_64* armv7l* aarch64*"
+build_style=gnu-configure
+configure_args="--enable-release-build --enable-networking --enable-alsa"
+hostmakedepends="autoconf automake pkgconf"
+makedepends="SDL2-devel wxWidgets-devel libopenal-devel alsa-lib-devel"
+short_desc="Low-level x86 emulator targeting various IBM PC compatibles"
+maintainer="a dinosaur <nick@a-dinosaur.com>"
+license="GPL-2.0-or-later"
+homepage="https://pcem-emulator.co.uk"
+_distfile="PCemV${version}Linux.tar.gz"
+distfiles="${homepage}/files/${_distfile}"
+checksum=45ae9321ee25375f0e685a49d84e8a5acba8ed33ccf597299edcf287cb3c8499
+
+do_extract() {
+	bsdtar -xf "${XBPS_SRCDISTDIR}/${pkgname}-${version}/${_distfile}" -C ${wrksrc}
+}
+
+pre_configure() {
+	autoreconf -if
+}
+
+post_install() {
+	vdoc readme.txt
+	vdoc Readme-LINUX.txt
+}

Re: [PR PATCH] [Updated] [WIP] New package: pcem-16

[ScrelliCopter]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

There is an updated pull request by ScrelliCopter against master on the void-packages repository

https://github.com/ScrelliCopter/void-packages pcem
https://github.com/void-linux/void-packages/pull/22340

[WIP] New package: pcem-16
PCem v16
http://pcem-emulator.co.uk/

Real BIOS ROM images placed in `~/.pcem/roms/` are required to boot, some freebies are available at the Downloads section of the PCem homepage.

A patch file from https://github.com/void-linux/void-packages/pull/22340.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pcem-22340.patch --]
[-- Type: text/x-diff, Size: 1383 bytes --]

From f5a525297c472bad384ac703e405ec5c3ff9c388 Mon Sep 17 00:00:00 2001
From: a dinosaur <nick@a-dinosaur.com>
Date: Wed, 27 May 2020 11:58:50 +1000
Subject: [PATCH] New package: pcem-17

---
 srcpkgs/pcem/template | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 srcpkgs/pcem/template

diff --git a/srcpkgs/pcem/template b/srcpkgs/pcem/template
new file mode 100644
index 00000000000..6c16eee73aa
--- /dev/null
+++ b/srcpkgs/pcem/template
@@ -0,0 +1,27 @@
+# Template file for 'pcem'
+pkgname=pcem
+version=17
+revision=1
+archs="i686* x86_64* armv7l* aarch64*"
+build_style=gnu-configure
+configure_args="--enable-release-build --enable-networking --enable-alsa"
+hostmakedepends="autoconf automake pkgconf"
+makedepends="SDL2-devel wxWidgets-devel libopenal-devel alsa-lib-devel"
+short_desc="Low-level x86 emulator targeting various IBM PC compatibles"
+maintainer="a dinosaur <nick@a-dinosaur.com>"
+license="GPL-2.0-or-later"
+homepage="https://pcem-emulator.co.uk"
+_distfile="PCemV${version}Linux.tar.gz"
+distfiles="https://pcem-emulator.co.uk/files/${_distfile}"
+checksum=5b24cb5ce886ed53232385f46594146ba3f7d7eecda90f82892b2dce1cb2f1a4
+
+do_extract() {
+	bsdtar -xf "${XBPS_SRCDISTDIR}/${pkgname}-${version}/${_distfile}" -C ${wrksrc}
+}
+
+post_install() {
+	vdoc README.md
+	vdoc readme.html
+	vdoc TESTED.md
+	vdoc tested.html
+}

Re: [PR PATCH] [Closed]: New package: pcem-17

[abenson]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

There's a closed pull request on the void-packages repository

New package: pcem-17
https://github.com/void-linux/void-packages/pull/22340

Description:
PCem ~~v16~~ v17
http://pcem-emulator.co.uk/

Real BIOS ROM images placed in `~/.pcem/roms/` are required to boot, some freebies are available at the Downloads section of the PCem homepage.

Re: New package: pcem-17

[abenson]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/22340#issuecomment-962522110

Comment:
Upstream is dead.  We can re-approach if there's a fork.

> **14th June 2021**
> Just a quick note to say that I (Sarah Walker) have decided to call it quits.

Re: New package: pcem-17

[abenson]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/29285#issuecomment-962522108

Comment:
Upstream is dead.  We can re-approach if there's a fork.

> **14th June 2021**
> Just a quick note to say that I (Sarah Walker) have decided to call it quits.

Re: New package: pcem-17

[ScrelliCopter]

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

New comment by ScrelliCopter on void-packages repository

https://github.com/void-linux/void-packages/pull/29285#issuecomment-808922315

Comment:
Author of the first PR here, just saw this.

In my experience Void usually puts precedence on the first PR in the case of duplicates. I'm not precious about who gets to be maintainer but if you'd like to make sure any improvements over my template (touché on using create_wrksrc) make it in I'd be happy to take reviews on my PR.

It seems you already figured out the reasons behind everything I was doing but I'll elaborate on why I chose `GPL-2.0-or-later`:
Sarah never appeared to have included a copy of the GPL or attached any GPL text to her own code, grepping thru showed a lot of "version 2 (or at your option) any later version"; and actually I just looked thru v17 again and `src/f82c710_upc.c` and `src/sound_azt2316a.c` are version **3** or later, so it seems like the license field should actually be `GPL-3.0-or-later` 🤷.

Re: New package: pcem-17

[ajshell1]

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

New comment by ajshell1 on void-packages repository

https://github.com/void-linux/void-packages/pull/29285#issuecomment-798716421

Comment:
I've just realized that this is a duplicate of  pull request  #22340

I'll admit to blatantly using some of his code to improve my own pull request. For example, I realized that the automake was unnecessary. Also, I dug through pcem's configure file and realized that it only accepts i386/i686, x86_64, armv7l, and aarch64 CPUs. For this reason, I thought it was appropriate to include those specific architectures in the template.

At this point, here are a list of substantial differences between our templates:

1. Mine thinks that the license is GPL2 only, he thinks it's GPL2 or later. I have no idea which is right.
2. Somewhat different method of assigning the distfiles variable
3. He uses do_extract() while I use create_wkspace, to the same effect.
4. He uses vdoc on the readme files and tested files.
5. Different short_desc
6. Different maintainer.

I don't particularly care which of us is selected, as long as one of us is.