* [PR PATCH] google-chrome: adds missing gtk+3 dependency
@ 2022-03-02 10:06 yiz
2022-03-02 11:24 ` paper42
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: yiz @ 2022-03-02 10:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
There is a new pull request by yiz against master on the void-packages repository
https://github.com/yiz/void-packages google-chrome
https://github.com/void-linux/void-packages/pull/35916
google-chrome: adds missing gtk+3 dependency
Google Chrome would crash without gtk+3.
#### Testing the changes
- I tested the changes in this PR: **YES**
- I built this PR locally for my native architecture, x86_64
A patch file from https://github.com/void-linux/void-packages/pull/35916.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-google-chrome-35916.patch --]
[-- Type: text/x-diff, Size: 782 bytes --]
From 66fe3c2e11658f264e042a677871471a6535d31e Mon Sep 17 00:00:00 2001
From: Yi Zhang <github@yizhang.me>
Date: Tue, 1 Mar 2022 20:01:47 -0800
Subject: [PATCH] google-chrome: adds missing gtk+3 dependency
---
srcpkgs/google-chrome/template | 1 +
1 file changed, 1 insertion(+)
diff --git a/srcpkgs/google-chrome/template b/srcpkgs/google-chrome/template
index 51462abfebda..3cd70f7e92e7 100644
--- a/srcpkgs/google-chrome/template
+++ b/srcpkgs/google-chrome/template
@@ -5,6 +5,7 @@ revision=1
_channel=stable
archs="x86_64"
hostmakedepends="curl tar xz python3 python3-html2text python3-setuptools"
+depends="gtk+3"
short_desc="Attempt at creating a safer, faster, and more stable browser"
maintainer="Michael Aldridge <maldridge@voidlinux.org>"
license="custom:chrome"
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: google-chrome: adds missing gtk+3 dependency
2022-03-02 10:06 [PR PATCH] google-chrome: adds missing gtk+3 dependency yiz
@ 2022-03-02 11:24 ` paper42
2022-03-02 11:25 ` paper42
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2022-03-02 11:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 146 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35916#issuecomment-1056815840
Comment:
@atk
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: google-chrome: adds missing gtk+3 dependency
2022-03-02 10:06 [PR PATCH] google-chrome: adds missing gtk+3 dependency yiz
2022-03-02 11:24 ` paper42
@ 2022-03-02 11:25 ` paper42
2022-03-02 11:47 ` paper42
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2022-03-02 11:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 177 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35916#issuecomment-1056815840
Comment:
Please increase the revision.
@atk
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: google-chrome: adds missing gtk+3 dependency
2022-03-02 10:06 [PR PATCH] google-chrome: adds missing gtk+3 dependency yiz
2022-03-02 11:24 ` paper42
2022-03-02 11:25 ` paper42
@ 2022-03-02 11:47 ` paper42
2022-03-03 5:18 ` [PR PATCH] [Updated] google-chrome: add " yiz
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2022-03-02 11:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 396 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35916#issuecomment-1056839965
Comment:
also please:
* use imperative in the commit message: `google-chrome: add missing gtk+3 dependency`
* make sure the commit email is associated with your github profile, currently it isn't, so the commit isn't properly attributed to you in the GitHub UI.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR PATCH] [Updated] google-chrome: add missing gtk+3 dependency
2022-03-02 10:06 [PR PATCH] google-chrome: adds missing gtk+3 dependency yiz
` (2 preceding siblings ...)
2022-03-02 11:47 ` paper42
@ 2022-03-03 5:18 ` yiz
2022-03-03 5:19 ` yiz
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: yiz @ 2022-03-03 5:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
There is an updated pull request by yiz against master on the void-packages repository
https://github.com/yiz/void-packages google-chrome
https://github.com/void-linux/void-packages/pull/35916
google-chrome: add missing gtk+3 dependency
Google Chrome would crash without gtk+3.
#### Testing the changes
- I tested the changes in this PR: **YES**
- I built this PR locally for my native architecture, x86_64
A patch file from https://github.com/void-linux/void-packages/pull/35916.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-google-chrome-35916.patch --]
[-- Type: text/x-diff, Size: 917 bytes --]
From 227c51633b49aba78526998df4bf52f76c038a10 Mon Sep 17 00:00:00 2001
From: Yi Zhang <23587113+yiz@users.noreply.github.com>
Date: Tue, 1 Mar 2022 20:01:47 -0800
Subject: [PATCH] google-chrome: adds missing gtk+3 dependency
---
srcpkgs/google-chrome/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/google-chrome/template b/srcpkgs/google-chrome/template
index 51462abfebda..f50d9caa3464 100644
--- a/srcpkgs/google-chrome/template
+++ b/srcpkgs/google-chrome/template
@@ -1,10 +1,11 @@
# Template file for 'google-chrome'
pkgname=google-chrome
version=99.0.4844.51
-revision=1
+revision=2
_channel=stable
archs="x86_64"
hostmakedepends="curl tar xz python3 python3-html2text python3-setuptools"
+depends="gtk+3"
short_desc="Attempt at creating a safer, faster, and more stable browser"
maintainer="Michael Aldridge <maldridge@voidlinux.org>"
license="custom:chrome"
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: google-chrome: add missing gtk+3 dependency
2022-03-02 10:06 [PR PATCH] google-chrome: adds missing gtk+3 dependency yiz
` (3 preceding siblings ...)
2022-03-03 5:18 ` [PR PATCH] [Updated] google-chrome: add " yiz
@ 2022-03-03 5:19 ` yiz
2022-03-03 21:53 ` [PR PATCH] [Updated] " paper42
2022-03-03 21:53 ` [PR PATCH] [Merged]: " paper42
6 siblings, 0 replies; 8+ messages in thread
From: yiz @ 2022-03-03 5:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
New comment by yiz on void-packages repository
https://github.com/void-linux/void-packages/pull/35916#issuecomment-1057676284
Comment:
Thanks @paper42 . All updated.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR PATCH] [Updated] google-chrome: add missing gtk+3 dependency
2022-03-02 10:06 [PR PATCH] google-chrome: adds missing gtk+3 dependency yiz
` (4 preceding siblings ...)
2022-03-03 5:19 ` yiz
@ 2022-03-03 21:53 ` paper42
2022-03-03 21:53 ` [PR PATCH] [Merged]: " paper42
6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2022-03-03 21:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
There is an updated pull request by paper42 against master on the void-packages repository
https://github.com/yiz/void-packages google-chrome
https://github.com/void-linux/void-packages/pull/35916
google-chrome: add missing gtk+3 dependency
Google Chrome would crash without gtk+3.
#### Testing the changes
- I tested the changes in this PR: **YES**
- I built this PR locally for my native architecture, x86_64
A patch file from https://github.com/void-linux/void-packages/pull/35916.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-google-chrome-35916.patch --]
[-- Type: text/x-diff, Size: 916 bytes --]
From 5a406f0de18c0f54b7f2689bea8a23a18e64fb22 Mon Sep 17 00:00:00 2001
From: Yi Zhang <23587113+yiz@users.noreply.github.com>
Date: Tue, 1 Mar 2022 20:01:47 -0800
Subject: [PATCH] google-chrome: add missing gtk+3 dependency
---
srcpkgs/google-chrome/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/google-chrome/template b/srcpkgs/google-chrome/template
index 51462abfebda..f50d9caa3464 100644
--- a/srcpkgs/google-chrome/template
+++ b/srcpkgs/google-chrome/template
@@ -1,10 +1,11 @@
# Template file for 'google-chrome'
pkgname=google-chrome
version=99.0.4844.51
-revision=1
+revision=2
_channel=stable
archs="x86_64"
hostmakedepends="curl tar xz python3 python3-html2text python3-setuptools"
+depends="gtk+3"
short_desc="Attempt at creating a safer, faster, and more stable browser"
maintainer="Michael Aldridge <maldridge@voidlinux.org>"
license="custom:chrome"
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR PATCH] [Merged]: google-chrome: add missing gtk+3 dependency
2022-03-02 10:06 [PR PATCH] google-chrome: adds missing gtk+3 dependency yiz
` (5 preceding siblings ...)
2022-03-03 21:53 ` [PR PATCH] [Updated] " paper42
@ 2022-03-03 21:53 ` paper42
6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2022-03-03 21:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 351 bytes --]
There's a merged pull request on the void-packages repository
google-chrome: add missing gtk+3 dependency
https://github.com/void-linux/void-packages/pull/35916
Description:
Google Chrome would crash without gtk+3.
#### Testing the changes
- I tested the changes in this PR: **YES**
- I built this PR locally for my native architecture, x86_64
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-03-03 21:53 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-02 10:06 [PR PATCH] google-chrome: adds missing gtk+3 dependency yiz
2022-03-02 11:24 ` paper42
2022-03-02 11:25 ` paper42
2022-03-02 11:47 ` paper42
2022-03-03 5:18 ` [PR PATCH] [Updated] google-chrome: add " yiz
2022-03-03 5:19 ` yiz
2022-03-03 21:53 ` [PR PATCH] [Updated] " paper42
2022-03-03 21:53 ` [PR PATCH] [Merged]: " paper42
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).