[PR PATCH] google-chrome: adds missing gtk+3 dependency

[PR PATCH] google-chrome: adds missing gtk+3 dependency

[yiz]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

There is a new pull request by yiz against master on the void-packages repository

https://github.com/yiz/void-packages google-chrome
https://github.com/void-linux/void-packages/pull/35916

google-chrome: adds missing gtk+3 dependency
Google Chrome would crash without gtk+3.

#### Testing the changes
- I tested the changes in this PR: **YES**
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/35916.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-google-chrome-35916.patch --]
[-- Type: text/x-diff, Size: 782 bytes --]

From 66fe3c2e11658f264e042a677871471a6535d31e Mon Sep 17 00:00:00 2001
From: Yi Zhang <github@yizhang.me>
Date: Tue, 1 Mar 2022 20:01:47 -0800
Subject: [PATCH] google-chrome: adds missing gtk+3 dependency

---
 srcpkgs/google-chrome/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/google-chrome/template b/srcpkgs/google-chrome/template
index 51462abfebda..3cd70f7e92e7 100644
--- a/srcpkgs/google-chrome/template
+++ b/srcpkgs/google-chrome/template
@@ -5,6 +5,7 @@ revision=1
 _channel=stable
 archs="x86_64"
 hostmakedepends="curl tar xz python3 python3-html2text python3-setuptools"
+depends="gtk+3"
 short_desc="Attempt at creating a safer, faster, and more stable browser"
 maintainer="Michael Aldridge <maldridge@voidlinux.org>"
 license="custom:chrome"

Re: google-chrome: adds missing gtk+3 dependency

[paper42]

[-- Attachment #1: Type: text/plain, Size: 146 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/35916#issuecomment-1056815840

Comment:
@atk

Re: google-chrome: adds missing gtk+3 dependency

[paper42]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/35916#issuecomment-1056815840

Comment:
Please increase the revision.
@atk

Re: google-chrome: adds missing gtk+3 dependency

[paper42]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/35916#issuecomment-1056839965

Comment:
also please:
* use imperative in the commit message: `google-chrome: add missing gtk+3 dependency`
* make sure the commit email is associated with your github profile, currently it isn't, so the commit isn't properly attributed to you in the GitHub UI.

Re: [PR PATCH] [Updated] google-chrome: add missing gtk+3 dependency

[yiz]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

There is an updated pull request by yiz against master on the void-packages repository

https://github.com/yiz/void-packages google-chrome
https://github.com/void-linux/void-packages/pull/35916

google-chrome: add missing gtk+3 dependency
Google Chrome would crash without gtk+3.

#### Testing the changes
- I tested the changes in this PR: **YES**
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/35916.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-google-chrome-35916.patch --]
[-- Type: text/x-diff, Size: 917 bytes --]

From 227c51633b49aba78526998df4bf52f76c038a10 Mon Sep 17 00:00:00 2001
From: Yi Zhang <23587113+yiz@users.noreply.github.com>
Date: Tue, 1 Mar 2022 20:01:47 -0800
Subject: [PATCH] google-chrome: adds missing gtk+3 dependency

---
 srcpkgs/google-chrome/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/google-chrome/template b/srcpkgs/google-chrome/template
index 51462abfebda..f50d9caa3464 100644
--- a/srcpkgs/google-chrome/template
+++ b/srcpkgs/google-chrome/template
@@ -1,10 +1,11 @@
 # Template file for 'google-chrome'
 pkgname=google-chrome
 version=99.0.4844.51
-revision=1
+revision=2
 _channel=stable
 archs="x86_64"
 hostmakedepends="curl tar xz python3 python3-html2text python3-setuptools"
+depends="gtk+3"
 short_desc="Attempt at creating a safer, faster, and more stable browser"
 maintainer="Michael Aldridge <maldridge@voidlinux.org>"
 license="custom:chrome"

Re: google-chrome: add missing gtk+3 dependency

[yiz]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New comment by yiz on void-packages repository

https://github.com/void-linux/void-packages/pull/35916#issuecomment-1057676284

Comment:
Thanks @paper42 . All updated.

Re: [PR PATCH] [Updated] google-chrome: add missing gtk+3 dependency

[paper42]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/yiz/void-packages google-chrome
https://github.com/void-linux/void-packages/pull/35916

google-chrome: add missing gtk+3 dependency
Google Chrome would crash without gtk+3.

#### Testing the changes
- I tested the changes in this PR: **YES**
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/35916.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-google-chrome-35916.patch --]
[-- Type: text/x-diff, Size: 916 bytes --]

From 5a406f0de18c0f54b7f2689bea8a23a18e64fb22 Mon Sep 17 00:00:00 2001
From: Yi Zhang <23587113+yiz@users.noreply.github.com>
Date: Tue, 1 Mar 2022 20:01:47 -0800
Subject: [PATCH] google-chrome: add missing gtk+3 dependency

---
 srcpkgs/google-chrome/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/google-chrome/template b/srcpkgs/google-chrome/template
index 51462abfebda..f50d9caa3464 100644
--- a/srcpkgs/google-chrome/template
+++ b/srcpkgs/google-chrome/template
@@ -1,10 +1,11 @@
 # Template file for 'google-chrome'
 pkgname=google-chrome
 version=99.0.4844.51
-revision=1
+revision=2
 _channel=stable
 archs="x86_64"
 hostmakedepends="curl tar xz python3 python3-html2text python3-setuptools"
+depends="gtk+3"
 short_desc="Attempt at creating a safer, faster, and more stable browser"
 maintainer="Michael Aldridge <maldridge@voidlinux.org>"
 license="custom:chrome"

Re: [PR PATCH] [Merged]: google-chrome: add missing gtk+3 dependency

[paper42]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

There's a merged pull request on the void-packages repository

google-chrome: add missing gtk+3 dependency
https://github.com/void-linux/void-packages/pull/35916

Description:
Google Chrome would crash without gtk+3.

#### Testing the changes
- I tested the changes in this PR: **YES**
- I built this PR locally for my native architecture, x86_64