Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Manual.md: document the check functions
@ 2022-03-30  6:21 0x5c
  2022-03-30 18:17 ` [PR REVIEW] " Chocimier
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: 0x5c @ 2022-03-30  6:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1446 bytes --]

There is a new pull request by 0x5c against master on the void-packages repository

https://github.com/0x5c/void-packages manual-post-functions
https://github.com/void-linux/void-packages/pull/36412

Manual.md: document the check functions
The pre_/do_/post_check functions were not listed in the list of building
phase functions, and were not mentioned elsewhere (do_check was mentioned
once). This documents their existence.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36412.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-manual-post-functions-36412.patch --]
[-- Type: text/x-diff, Size: 1118 bytes --]

From ec69d48667280d7dc71aa6b42849b007a0b7a08f Mon Sep 17 00:00:00 2001
From: 0x5c <dev@0x5c.io>
Date: Wed, 30 Mar 2022 02:05:43 -0400
Subject: [PATCH] Manual.md: document the check functions

The pre_/do_/post_check functions were not listed in the list of building
phase functions, and were not mentioned elsewhere (do_check was mentioned
once). This documents their existence.
---
 Manual.md | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Manual.md b/Manual.md
index af5f698debae..d0d05da38025 100644
--- a/Manual.md
+++ b/Manual.md
@@ -1101,7 +1101,13 @@ still be passed in if it's a GNU configure script.
 
 - `post_build()` Actions to execute after `do_build()`.
 
-- `pre_install()` Actions to execute after `post_build()`.
+- `pre_check()` Actions to execute after `post_build()`.
+
+- `do_check()` Actions to execute to run checks for the package.
+
+- `post_check()` Actions to execute after `do_check()`.
+
+- `pre_install()` Actions to execute after `post_build()` or `post_check()`.
 
 - `do_install()` Actions to execute to install the package files into the `fake destdir`.
 

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-04-02 16:39 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-30  6:21 [PR PATCH] Manual.md: document the check functions 0x5c
2022-03-30 18:17 ` [PR REVIEW] " Chocimier
2022-03-30 23:13 ` 0x5c
2022-03-31 17:00 ` Chocimier
2022-03-31 18:22 ` 0x5c
2022-04-01  0:20 ` [PR PATCH] [Updated] " 0x5c
2022-04-02 16:39 ` Chocimier
2022-04-02 16:39 ` [PR PATCH] [Merged]: " Chocimier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).