[PR PATCH] New package: apcupsd-3.14.14

[PR PATCH] New package: apcupsd-3.14.14

[basploeger]

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

There is a new pull request by basploeger against master on the void-packages repository

https://github.com/basploeger/void-packages apcupsd-cont
https://github.com/void-linux/void-packages/pull/36654

New package: apcupsd-3.14.14
This PR is based on #13876.

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

A patch file from https://github.com/void-linux/void-packages/pull/36654.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-apcupsd-cont-36654.patch --]
[-- Type: text/x-diff, Size: 1922 bytes --]

From 82cadf1e1401aae4401b1d100dc6b3688ae01e66 Mon Sep 17 00:00:00 2001
From: Bas Ploeger <5904333+basploeger@users.noreply.github.com>
Date: Sat, 2 Apr 2022 22:00:49 +0200
Subject: [PATCH] New package: apcupsd-3.14.14

---
 srcpkgs/apcupsd/files/apcupsd/run |  3 +++
 srcpkgs/apcupsd/template          | 37 +++++++++++++++++++++++++++++++
 2 files changed, 40 insertions(+)
 create mode 100644 srcpkgs/apcupsd/files/apcupsd/run
 create mode 100644 srcpkgs/apcupsd/template

diff --git a/srcpkgs/apcupsd/files/apcupsd/run b/srcpkgs/apcupsd/files/apcupsd/run
new file mode 100644
index 000000000000..2c0b807da287
--- /dev/null
+++ b/srcpkgs/apcupsd/files/apcupsd/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+[ -r conf] && . ./conf
+exec apcupsd -b ${OPTS}
diff --git a/srcpkgs/apcupsd/template b/srcpkgs/apcupsd/template
new file mode 100644
index 000000000000..91e3306cf45a
--- /dev/null
+++ b/srcpkgs/apcupsd/template
@@ -0,0 +1,37 @@
+pkgname=apcupsd
+version=3.14.14
+revision=1
+build_style=gnu-configure
+configure_args="
+ --disable-install-distdir
+ --enable-modbus-usb
+ --enable-usb
+ --sysconfdir=/etc/apcupsd
+ --with-dev=
+ --with-halpolicydir=
+ --with-pwrfail-dir=/etc/apcupsd
+ --with-upscable=usb
+ --with-upstype=usb"
+hostmakedepends="autoconf automake pkg-config"
+makedepends="libusb-compat-devel net-snmp-devel"
+depends="libusb-compat net-snmp nullmailer"
+conf_files="/etc/apcupsd/*"
+short_desc="APC UPS daemon with integrated tcp/ip remote shutdown"
+maintainer="Bas Ploeger"
+license="GPL-2.0-only"
+homepage="http://www.apcupsd.org/"
+distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.gz"
+checksum="db7748559b6b4c3784f9856561ef6ac6199ef7bd019b3edcd7e0a647bf8f9867"
+
+make_install_args="STRIP="
+
+pre_configure() {
+  export SHUTDOWN=/usr/bin/shutdown
+  export WALL=/usr/bin/wall
+  export APCUPSD_MAIL=/usr/bin/mail
+}
+
+post_install() {
+  rm ${DESTDIR}/usr/bin/smtp
+  vsv apcupsd
+}

Re: [PR PATCH] [Updated] New package: apcupsd-3.14.14

[basploeger]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

There is an updated pull request by basploeger against master on the void-packages repository

https://github.com/basploeger/void-packages apcupsd-cont
https://github.com/void-linux/void-packages/pull/36654

New package: apcupsd-3.14.14
This PR is based on #13876.

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

A patch file from https://github.com/void-linux/void-packages/pull/36654.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-apcupsd-cont-36654.patch --]
[-- Type: text/x-diff, Size: 1974 bytes --]

From 89595555f481c9665eeb6d68a73add2abb974355 Mon Sep 17 00:00:00 2001
From: Bas Ploeger <5904333+basploeger@users.noreply.github.com>
Date: Sat, 2 Apr 2022 22:00:49 +0200
Subject: [PATCH] New package: apcupsd-3.14.14

---
 srcpkgs/apcupsd/files/apcupsd/run |  3 +++
 srcpkgs/apcupsd/template          | 38 +++++++++++++++++++++++++++++++
 2 files changed, 41 insertions(+)
 create mode 100644 srcpkgs/apcupsd/files/apcupsd/run
 create mode 100644 srcpkgs/apcupsd/template

diff --git a/srcpkgs/apcupsd/files/apcupsd/run b/srcpkgs/apcupsd/files/apcupsd/run
new file mode 100644
index 000000000000..2c0b807da287
--- /dev/null
+++ b/srcpkgs/apcupsd/files/apcupsd/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+[ -r conf] && . ./conf
+exec apcupsd -b ${OPTS}
diff --git a/srcpkgs/apcupsd/template b/srcpkgs/apcupsd/template
new file mode 100644
index 000000000000..cbea84f803a1
--- /dev/null
+++ b/srcpkgs/apcupsd/template
@@ -0,0 +1,38 @@
+# Template file for 'apcupsd'
+pkgname=apcupsd
+version=3.14.14
+revision=1
+build_style=gnu-configure
+configure_args="
+ --disable-install-distdir
+ --enable-modbus-usb
+ --enable-usb
+ --sysconfdir=/etc/apcupsd
+ --with-dev=
+ --with-halpolicydir=
+ --with-pwrfail-dir=/etc/apcupsd
+ --with-upscable=usb
+ --with-upstype=usb"
+hostmakedepends="autoconf automake pkg-config"
+makedepends="libusb-compat-devel net-snmp-devel"
+depends="libusb-compat net-snmp nullmailer"
+conf_files="/etc/apcupsd/*"
+short_desc="APC UPS daemon with integrated tcp/ip remote shutdown"
+maintainer="Bas Ploeger <s.c.w.ploeger@gmail.com>"
+license="GPL-2.0-only"
+homepage="http://www.apcupsd.org/"
+distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.gz"
+checksum="db7748559b6b4c3784f9856561ef6ac6199ef7bd019b3edcd7e0a647bf8f9867"
+
+make_install_args="STRIP="
+
+pre_configure() {
+	export SHUTDOWN=/usr/bin/shutdown
+	export WALL=/usr/bin/wall
+	export APCUPSD_MAIL=/usr/bin/mail
+}
+
+post_install() {
+	rm ${DESTDIR}/usr/bin/smtp
+	vsv apcupsd
+}

Re: [PR REVIEW] New package: apcupsd-3.14.14

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/36654#discussion_r848732622

Comment:
are the `=` needed here?

Re: [PR REVIEW] New package: apcupsd-3.14.14

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/36654#discussion_r848732260

Comment:
expand `$pkgname` to its value here please

Re: [PR PATCH] [Updated] New package: apcupsd-3.14.14

[basploeger]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

There is an updated pull request by basploeger against master on the void-packages repository

https://github.com/basploeger/void-packages apcupsd-cont
https://github.com/void-linux/void-packages/pull/36654

New package: apcupsd-3.14.14
This PR is based on #13876.

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

A patch file from https://github.com/void-linux/void-packages/pull/36654.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-apcupsd-cont-36654.patch --]
[-- Type: text/x-diff, Size: 1968 bytes --]

From baef01e60c24903b4afa35bcc06c371cebeb8c25 Mon Sep 17 00:00:00 2001
From: Bas Ploeger <5904333+basploeger@users.noreply.github.com>
Date: Sat, 2 Apr 2022 22:00:49 +0200
Subject: [PATCH] New package: apcupsd-3.14.14

---
 srcpkgs/apcupsd/files/apcupsd/run |  3 +++
 srcpkgs/apcupsd/template          | 38 +++++++++++++++++++++++++++++++
 2 files changed, 41 insertions(+)
 create mode 100644 srcpkgs/apcupsd/files/apcupsd/run
 create mode 100644 srcpkgs/apcupsd/template

diff --git a/srcpkgs/apcupsd/files/apcupsd/run b/srcpkgs/apcupsd/files/apcupsd/run
new file mode 100644
index 000000000000..2c0b807da287
--- /dev/null
+++ b/srcpkgs/apcupsd/files/apcupsd/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+[ -r conf] && . ./conf
+exec apcupsd -b ${OPTS}
diff --git a/srcpkgs/apcupsd/template b/srcpkgs/apcupsd/template
new file mode 100644
index 000000000000..fbd7594b8757
--- /dev/null
+++ b/srcpkgs/apcupsd/template
@@ -0,0 +1,38 @@
+# Template file for 'apcupsd'
+pkgname=apcupsd
+version=3.14.14
+revision=1
+build_style=gnu-configure
+configure_args="
+ --disable-install-distdir
+ --enable-modbus-usb
+ --enable-usb
+ --sysconfdir=/etc/apcupsd
+ --with-dev=
+ --with-halpolicydir=
+ --with-pwrfail-dir=/etc/apcupsd
+ --with-upscable=usb
+ --with-upstype=usb"
+hostmakedepends="autoconf automake pkg-config"
+makedepends="libusb-compat-devel net-snmp-devel"
+depends="libusb-compat net-snmp nullmailer"
+conf_files="/etc/apcupsd/*"
+short_desc="APC UPS daemon with integrated tcp/ip remote shutdown"
+maintainer="Bas Ploeger <s.c.w.ploeger@gmail.com>"
+license="GPL-2.0-only"
+homepage="http://www.apcupsd.org/"
+distfiles="${SOURCEFORGE_SITE}/apcupsd/apcupsd-${version}.tar.gz"
+checksum="db7748559b6b4c3784f9856561ef6ac6199ef7bd019b3edcd7e0a647bf8f9867"
+
+make_install_args="STRIP="
+
+pre_configure() {
+	export SHUTDOWN=/usr/bin/shutdown
+	export WALL=/usr/bin/wall
+	export APCUPSD_MAIL=/usr/bin/mail
+}
+
+post_install() {
+	rm ${DESTDIR}/usr/bin/smtp
+	vsv apcupsd
+}

Re: [PR REVIEW] New package: apcupsd-3.14.14

[basploeger]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New review comment by basploeger on void-packages repository

https://github.com/void-linux/void-packages/pull/36654#discussion_r848806371

Comment:
Yes. I tried both omitting them and setting them to `''`, but then they end up with non-empty values. And they need to be empty.

Re: [PR REVIEW] New package: apcupsd-3.14.14

[basploeger]

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New review comment by basploeger on void-packages repository

https://github.com/void-linux/void-packages/pull/36654#discussion_r848806511

Comment:
Done

Re: [PR REVIEW] New package: apcupsd-3.14.14

[basploeger]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

New review comment by basploeger on void-packages repository

https://github.com/void-linux/void-packages/pull/36654#discussion_r848806371

Comment:
Yes. I tried both omitting the `=` and replacing them by `=''`, but then they end up with non-empty values. And they need to be empty.

Re: [PR REVIEW] New package: apcupsd-3.14.14

[basploeger]

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

New review comment by basploeger on void-packages repository

https://github.com/void-linux/void-packages/pull/36654#discussion_r848806371

Comment:
Yes. I tried both omitting the `=` and replacing them by `=''`, but then the args end up with non-empty values. And they need to be empty.

Re: [PR PATCH] [Updated] New package: apcupsd-3.14.14

[basploeger]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

There is an updated pull request by basploeger against master on the void-packages repository

https://github.com/basploeger/void-packages apcupsd-cont
https://github.com/void-linux/void-packages/pull/36654

New package: apcupsd-3.14.14
This PR is based on #13876.

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

A patch file from https://github.com/void-linux/void-packages/pull/36654.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-apcupsd-cont-36654.patch --]
[-- Type: text/x-diff, Size: 2133 bytes --]

From e56ab77f9c0027be86c7ec44f5ba96862faa6969 Mon Sep 17 00:00:00 2001
From: Bas Ploeger <5904333+basploeger@users.noreply.github.com>
Date: Sat, 2 Apr 2022 22:00:49 +0200
Subject: [PATCH] New package: apcupsd-3.14.14

---
 srcpkgs/apcupsd/files/apcupsd/run |  3 +++
 srcpkgs/apcupsd/template          | 40 +++++++++++++++++++++++++++++++
 2 files changed, 43 insertions(+)
 create mode 100644 srcpkgs/apcupsd/files/apcupsd/run
 create mode 100644 srcpkgs/apcupsd/template

diff --git a/srcpkgs/apcupsd/files/apcupsd/run b/srcpkgs/apcupsd/files/apcupsd/run
new file mode 100644
index 000000000000..2c0b807da287
--- /dev/null
+++ b/srcpkgs/apcupsd/files/apcupsd/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+[ -r conf] && . ./conf
+exec apcupsd -b ${OPTS}
diff --git a/srcpkgs/apcupsd/template b/srcpkgs/apcupsd/template
new file mode 100644
index 000000000000..892c66c41c27
--- /dev/null
+++ b/srcpkgs/apcupsd/template
@@ -0,0 +1,40 @@
+# Template file for 'apcupsd'
+pkgname=apcupsd
+version=3.14.14
+revision=1
+build_style=gnu-configure
+configure_args="
+ --disable-install-distdir
+ --enable-modbus-usb
+ --enable-usb
+ --sysconfdir=/etc/apcupsd
+ --with-dev=''
+ --with-halpolicydir=
+ --with-pwrfail-dir=/etc/apcupsd
+ --with-upscable=usb
+ --with-upstype=usb"
+hostmakedepends="autoconf automake pkg-config"
+makedepends="libusb-compat-devel net-snmp-devel"
+depends="libusb-compat net-snmp nullmailer"
+conf_files="/etc/apcupsd/*"
+short_desc="APC UPS daemon with integrated tcp/ip remote shutdown"
+maintainer="Bas Ploeger <s.c.w.ploeger@gmail.com>"
+license="GPL-2.0-only"
+homepage="http://www.apcupsd.org/"
+distfiles="${SOURCEFORGE_SITE}/apcupsd/apcupsd-${version}.tar.gz"
+checksum="db7748559b6b4c3784f9856561ef6ac6199ef7bd019b3edcd7e0a647bf8f9867"
+
+# Avoid passing an invalid arg 'strip' to the install command for the binaries.
+make_install_args="STRIP="
+
+pre_configure() {
+	export SHUTDOWN=/usr/bin/shutdown
+	export WALL=/usr/bin/wall
+	export APCUPSD_MAIL=/usr/bin/mail
+}
+
+post_install() {
+  # This binary is not needed and conflicts with a binary from an other package.
+	rm ${DESTDIR}/usr/bin/smtp
+	vsv apcupsd
+}

Re: [PR PATCH] [Updated] New package: apcupsd-3.14.14

[basploeger]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

There is an updated pull request by basploeger against master on the void-packages repository

https://github.com/basploeger/void-packages apcupsd-cont
https://github.com/void-linux/void-packages/pull/36654

New package: apcupsd-3.14.14
This PR is based on #13876.

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

A patch file from https://github.com/void-linux/void-packages/pull/36654.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-apcupsd-cont-36654.patch --]
[-- Type: text/x-diff, Size: 2132 bytes --]

From 01eb78b4d27e70c12cb72cfc86592f24cc50d893 Mon Sep 17 00:00:00 2001
From: Bas Ploeger <5904333+basploeger@users.noreply.github.com>
Date: Sat, 2 Apr 2022 22:00:49 +0200
Subject: [PATCH] New package: apcupsd-3.14.14

---
 srcpkgs/apcupsd/files/apcupsd/run |  3 +++
 srcpkgs/apcupsd/template          | 40 +++++++++++++++++++++++++++++++
 2 files changed, 43 insertions(+)
 create mode 100644 srcpkgs/apcupsd/files/apcupsd/run
 create mode 100644 srcpkgs/apcupsd/template

diff --git a/srcpkgs/apcupsd/files/apcupsd/run b/srcpkgs/apcupsd/files/apcupsd/run
new file mode 100644
index 000000000000..2c0b807da287
--- /dev/null
+++ b/srcpkgs/apcupsd/files/apcupsd/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+[ -r conf] && . ./conf
+exec apcupsd -b ${OPTS}
diff --git a/srcpkgs/apcupsd/template b/srcpkgs/apcupsd/template
new file mode 100644
index 000000000000..1980eb8d81b4
--- /dev/null
+++ b/srcpkgs/apcupsd/template
@@ -0,0 +1,40 @@
+# Template file for 'apcupsd'
+pkgname=apcupsd
+version=3.14.14
+revision=1
+build_style=gnu-configure
+configure_args="
+ --disable-install-distdir
+ --enable-modbus-usb
+ --enable-usb
+ --sysconfdir=/etc/apcupsd
+ --with-dev=''
+ --with-halpolicydir=
+ --with-pwrfail-dir=/etc/apcupsd
+ --with-upscable=usb
+ --with-upstype=usb"
+hostmakedepends="autoconf automake pkg-config"
+makedepends="libusb-compat-devel net-snmp-devel"
+depends="libusb-compat net-snmp nullmailer"
+conf_files="/etc/apcupsd/*"
+short_desc="APC UPS daemon with integrated tcp/ip remote shutdown"
+maintainer="Bas Ploeger <s.c.w.ploeger@gmail.com>"
+license="GPL-2.0-only"
+homepage="http://www.apcupsd.org/"
+distfiles="${SOURCEFORGE_SITE}/apcupsd/apcupsd-${version}.tar.gz"
+checksum="db7748559b6b4c3784f9856561ef6ac6199ef7bd019b3edcd7e0a647bf8f9867"
+
+# Avoid passing an invalid arg 'strip' to the install command for the binaries.
+make_install_args="STRIP="
+
+pre_configure() {
+	export SHUTDOWN=/usr/bin/shutdown
+	export WALL=/usr/bin/wall
+	export APCUPSD_MAIL=/usr/bin/mail
+}
+
+post_install() {
+	# This binary is not needed and conflicts with a binary from an other package.
+	rm ${DESTDIR}/usr/bin/smtp
+	vsv apcupsd
+}

Re: [PR PATCH] [Updated] New package: apcupsd-3.14.14

[basploeger]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

There is an updated pull request by basploeger against master on the void-packages repository

https://github.com/basploeger/void-packages apcupsd-cont
https://github.com/void-linux/void-packages/pull/36654

New package: apcupsd-3.14.14
This PR is based on #13876.

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

A patch file from https://github.com/void-linux/void-packages/pull/36654.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-apcupsd-cont-36654.patch --]
[-- Type: text/x-diff, Size: 2130 bytes --]

From a7ecdd7047d55e3c82a28c47d39a287444e0ce36 Mon Sep 17 00:00:00 2001
From: Bas Ploeger <5904333+basploeger@users.noreply.github.com>
Date: Sat, 2 Apr 2022 22:00:49 +0200
Subject: [PATCH] New package: apcupsd-3.14.14

---
 srcpkgs/apcupsd/files/apcupsd/run |  3 +++
 srcpkgs/apcupsd/template          | 40 +++++++++++++++++++++++++++++++
 2 files changed, 43 insertions(+)
 create mode 100644 srcpkgs/apcupsd/files/apcupsd/run
 create mode 100644 srcpkgs/apcupsd/template

diff --git a/srcpkgs/apcupsd/files/apcupsd/run b/srcpkgs/apcupsd/files/apcupsd/run
new file mode 100644
index 000000000000..2c0b807da287
--- /dev/null
+++ b/srcpkgs/apcupsd/files/apcupsd/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+[ -r conf] && . ./conf
+exec apcupsd -b ${OPTS}
diff --git a/srcpkgs/apcupsd/template b/srcpkgs/apcupsd/template
new file mode 100644
index 000000000000..ba1394b2d9d0
--- /dev/null
+++ b/srcpkgs/apcupsd/template
@@ -0,0 +1,40 @@
+# Template file for 'apcupsd'
+pkgname=apcupsd
+version=3.14.14
+revision=1
+build_style=gnu-configure
+configure_args="
+ --disable-install-distdir
+ --enable-modbus-usb
+ --enable-usb
+ --sysconfdir=/etc/apcupsd
+ --with-dev=
+ --with-halpolicydir=
+ --with-pwrfail-dir=/etc/apcupsd
+ --with-upscable=usb
+ --with-upstype=usb"
+hostmakedepends="autoconf automake pkg-config"
+makedepends="libusb-compat-devel net-snmp-devel"
+depends="libusb-compat net-snmp nullmailer"
+conf_files="/etc/apcupsd/*"
+short_desc="APC UPS daemon with integrated tcp/ip remote shutdown"
+maintainer="Bas Ploeger <s.c.w.ploeger@gmail.com>"
+license="GPL-2.0-only"
+homepage="http://www.apcupsd.org/"
+distfiles="${SOURCEFORGE_SITE}/apcupsd/apcupsd-${version}.tar.gz"
+checksum="db7748559b6b4c3784f9856561ef6ac6199ef7bd019b3edcd7e0a647bf8f9867"
+
+# Avoid passing an invalid arg 'strip' to the install command for the binaries.
+make_install_args="STRIP="
+
+pre_configure() {
+	export SHUTDOWN=/usr/bin/shutdown
+	export WALL=/usr/bin/wall
+	export APCUPSD_MAIL=/usr/bin/mail
+}
+
+post_install() {
+	# This binary is not needed and conflicts with a binary from an other package.
+	rm ${DESTDIR}/usr/bin/smtp
+	vsv apcupsd
+}

Re: New package: apcupsd-3.14.14

[basploeger]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New comment by basploeger on void-packages repository

https://github.com/void-linux/void-packages/pull/36654#issuecomment-1113524883

Comment:
@classabbyamp PTAL

Re: [PR REVIEW] New package: apcupsd-3.14.14

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/36654#discussion_r861990729

Comment:
```suggestion
```

that message in the logs can just be ignored, it's just xbps-src's strip wrapper saying it's being called. It gets stripped properly in a later build phase.

Re: [PR REVIEW] New package: apcupsd-3.14.14

[basploeger]

[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]

New review comment by basploeger on void-packages repository

https://github.com/void-linux/void-packages/pull/36654#discussion_r862099852

Comment:
This line is needed to work around a problem in the package's configure/make setup. If I omit it, then `./xbps-src install apcupsd` fails with:

```
  COPY  apcupsd => /destdir//apcupsd-3.14.14/usr/bin/apcupsd
/usr/bin/install: target '/destdir//apcupsd-3.14.14/usr/bin/apcupsd' is not a directory
make[2]: *** [Makefile:49: install-base] Error 1
make[1]: *** [../autoconf/targets.mak:69: install] Error 2
make: *** [autoconf/targets.mak:111: src_DIR] Error 2
=> ERROR: apcupsd-3.14.14_1: do_install: '${make_cmd} DESTDIR=${DESTDIR} ${make_install_args} ${make_install_target}' exited with 2
=> ERROR:   in do_install() at common/build-style/gnu-configure.sh:40
```

The problem is that the `install` command that `make` is executing, gets an argument `strip` rather than `--strip` (I am not sure why, but this seems an error in the configure/make files). This wrong argument means `install` tries to copy files `strip` and `apcupsd` into a _directory_ `/usr/bin/apcupsd`, which is not the intention. The intention is to copy file `apcupsd` to file `/usr/bin/apcupsd`. 

The only way I found to work around this error, is by clearing the env var `STRIP`, which ensures the `strip` argument is not passed to `install`.

Re: New package: apcupsd-3.14.14

[basploeger]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New comment by basploeger on void-packages repository

https://github.com/void-linux/void-packages/pull/36654#issuecomment-1113665424

Comment:
@classabbyamp PTAL

Re: New package: apcupsd-3.14.14

[basploeger]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New comment by basploeger on void-packages repository

https://github.com/void-linux/void-packages/pull/36654#issuecomment-1117688665

Comment:
@classabbyamp Thanks for the review. Can this be approved and merged now?

Re: New package: apcupsd-3.14.14

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/36654#issuecomment-1118037658

Comment:
I don't have merge powers, you might want to ask [in irc](https://github.com/void-linux/void-packages/blob/master/Manual.md#help)

Re: [PR PATCH] [Merged]: New package: apcupsd-3.14.14

[abenson]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

There's a merged pull request on the void-packages repository

New package: apcupsd-3.14.14
https://github.com/void-linux/void-packages/pull/36654

Description:
This PR is based on #13876.

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

Re: New package: apcupsd-3.14.14

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/13876#issuecomment-1099786739

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.