* Re: [PR PATCH] [Updated] libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
@ 2022-06-05 19:19 ` chexum
2022-06-09 5:17 ` chexum
` (19 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: chexum @ 2022-06-05 19:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 2581 bytes --]
There is an updated pull request by chexum against master on the void-packages repository
https://github.com/chexum/void-packages guestfstools
https://github.com/void-linux/void-packages/pull/37416
libguestfs-tools 1.48.0
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
perl-Locale-TextDomain is only introduced for the script in perl.
libguestfs-tools is not technically now, some time ago it was part of libguestfs. Some tools were split into their own packages before libguestfs 1.45.2 and split into this package, see:
https://github.com/libguestfs/libguestfs/commit/733d2182b64df7abc5c5cd7d78177baa6079628c
Without this package, important tools like virt-sysprep were not provided at all.
The package is guestfs-tools but all other distributions align the package name with libguestfs.
Note that the test suite is very resource-intensive, needs to download 100+MB of images, and runs VMs for several of the tests for several minutes, which I don't think are reasonable for commit-time tests. They have been successful otherwise, apart from test-virt-sysprep-script.sh, which has been disabled.
Part of the test suite is downloading a test VM image, which is roughly the purpose of the `update-libguestfs-appliance` script in the base libguestfs package, however, it's not designed to run as a normal user in the chroot test pass.
(It also refers to an image which is no longer available, but I'm not sure what's the best approach to make it work, as it's only needed for the test suite, which is not nice at all to be run in a CI environment)
Perhaps to be coordinated with @Hoshpak (I don't insist staying the maintainer for these new entries, but don't mind it either)
---
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- Could not test any other archs, will check the CI
A patch file from https://github.com/void-linux/void-packages/pull/37416.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-guestfstools-37416.patch --]
[-- Type: text/x-diff, Size: 4643 bytes --]
From 21a7112c1c0c847ea7cfb53d724a076e41e6f4d0 Mon Sep 17 00:00:00 2001
From: J Farkas <chexum+git@gmail.com>
Date: Sun, 5 Jun 2022 18:55:52 +0000
Subject: [PATCH 1/2] New package: perl-Locale-TextDomain-0.32
libintl-perl 0.32, as a dependency for (lib)guestfs-tools.
---
srcpkgs/perl-Locale-TextDomain/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/perl-Locale-TextDomain/template
diff --git a/srcpkgs/perl-Locale-TextDomain/template b/srcpkgs/perl-Locale-TextDomain/template
new file mode 100644
index 000000000000..97e961ace0a2
--- /dev/null
+++ b/srcpkgs/perl-Locale-TextDomain/template
@@ -0,0 +1,16 @@
+# Template file for 'perl-Locale-TextDomain'
+pkgname=perl-Locale-TextDomain
+_pkg=libintl-perl
+version=1.32
+revision=1
+wrksrc="${_pkg}-${version}"
+build_style=perl-module
+hostmakedepends="perl"
+makedepends="${hostmakedepends}"
+depends="${makedepends}"
+short_desc="Perl Interface to Uniforum Message Translation"
+maintainer="J Farkas <chexum+git@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://metacpan.org/release/libintl-perl"
+distfiles="http://search.cpan.org/CPAN/authors/id/G/GU/GUIDO/${_pkg}-${version}.tar.gz"
+checksum=80108298f2564ecbfc7110a3042008e665ed00c2e155b36b0188e6c1135ceba5
From 518850a69a920988241daf2a05ad0c856031a727 Mon Sep 17 00:00:00 2001
From: J Farkas <chexum+git@gmail.com>
Date: Sun, 5 Jun 2022 18:56:06 +0000
Subject: [PATCH 2/2] New package: libguestfs-tools 1.48.0
Some tools were removed before libguestfs 1.45.2 and split into
another package, see commit:
733d2182b64df7abc5c5cd7d78177baa6079628c
in
https://github.com/libguestfs/libguestfs/
Without this package, important tools like virt-sysprep were not
provided at all.
The package is guestfs-tools but all other distributions align the
package name with libguestfs.
Note that the test suite is very resource-intensive, needs to
download 100+MB of images, and runs VMs for several of the tests
for several minutes, which I don't think are reasonable for
commit-time tests. They have been successful otherwise,
apart from test-virt-sysprep-script.sh, which has been disabled.
---
common/shlibs | 1 +
srcpkgs/libguestfs-tools/template | 40 +++++++++++++++++++++++++++++++
2 files changed, 41 insertions(+)
create mode 100644 srcpkgs/libguestfs-tools/template
diff --git a/common/shlibs b/common/shlibs
index 15d027bf9c20..543483bce7c2 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4165,3 +4165,4 @@ libTMVA.so root-6.24.06_1
libMathCore.so root-6.24.06_1
liblowdown.so lowdown-0.11.2_1
libjaylink.so.0 libjaylink-0.2.0_1
+libguestfs.so.0 libguestfs-tools-1.48.0_1
diff --git a/srcpkgs/libguestfs-tools/template b/srcpkgs/libguestfs-tools/template
new file mode 100644
index 000000000000..5f034e6e4f23
--- /dev/null
+++ b/srcpkgs/libguestfs-tools/template
@@ -0,0 +1,40 @@
+# Template file for 'libguestfs-tools'
+pkgname=libguestfs-tools
+_pkg=guestfs-tools
+version=1.48.0
+revision=1
+_version_short=${version%.*}
+wrksrc="${_pkg}-${version}"
+build_style=gnu-configure
+configure_args="ac_cv_prog_NCURSES_CONFIG=ncursesw6-config"
+hostmakedepends="flex pkg-config ncurses-devel gettext-devel pcre2-devel libvirt-devel
+ libxml2-devel jansson-devel ncurses-devel ocaml ocaml-findlib perl perl-Locale-TextDomain
+ hivex perl-Module-Build bash-completion qemu cpio"
+makedepends="cdrtools xz sqlite libguestfs-devel"
+depends="cdrtools xz sqlite"
+checkdepends="libguestfs libguestfs-devel curl wget tar procps-ng"
+short_desc="Additional tools for virtual machine disk image manipulation"
+maintainer="J Farkas <chexum+git@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/rwmjones/guestfs-tools"
+#changelog=""
+distfiles="https://download.libguestfs.org/${_pkg}/${_version_short}-stable/${_pkg}-${version}.tar.gz"
+checksum=7120ea2e939af8d4697015cc8e43acc5d19964fe894dee5bc27df80d48d24cb8
+
+do_check() {
+ # this is roughly what update-libguestfs-appliance does
+ # but with a newer version (1.40.0 does not even exist now)
+ # and does not require root
+# mkdir -p /var/cache/guestfs
+# mkdir -p /usr/lib/guestfs
+# wget --continue --quiet -O /var/cache/guestfs/appliance-1.46.0.tar.xz http://libguestfs.org/download/binaries/appliance/appliance-1.46.0.tar.xz
+# tar -xvf /var/cache/guestfs/appliance-1.46.0.tar.xz -C /usr/lib/guestfs --strip-components=1
+# chmod 644 /usr/lib/guestfs/*
+# export LIBGUESTFS_PATH=/usr/lib/guestfs
+
+ # test-virt-sysprep-script.sh does not work in chroot
+ # fusermount: mount failed: Operation not permitted
+# export SKIP_TEST_VIRT_SYSPREP_SCRIPT_SH=1
+# make check
+ exit 0
+}
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
2022-06-05 19:19 ` [PR PATCH] [Updated] " chexum
@ 2022-06-09 5:17 ` chexum
2022-06-26 16:59 ` [PR PATCH] [Updated] New package: " chexum
` (18 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: chexum @ 2022-06-09 5:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
New comment by chexum on void-packages repository
https://github.com/void-linux/void-packages/pull/37416#issuecomment-1150680058
Comment:
Just to reitarate, 22 of the packages documented on https://libguestfs.org/ are no longer actually part of the shipped void libguestfs package. libguestfs-tools may be "new" but all it contains is the remaining tools that were previously part of libguestfs.
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR PATCH] [Updated] New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
2022-06-05 19:19 ` [PR PATCH] [Updated] " chexum
2022-06-09 5:17 ` chexum
@ 2022-06-26 16:59 ` chexum
2022-06-27 11:28 ` chexum
` (17 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: chexum @ 2022-06-26 16:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 2594 bytes --]
There is an updated pull request by chexum against master on the void-packages repository
https://github.com/chexum/void-packages guestfstools
https://github.com/void-linux/void-packages/pull/37416
New package: libguestfs-tools 1.48.0
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
perl-Locale-TextDomain is only introduced for the script in perl.
libguestfs-tools is not technically now, some time ago it was part of libguestfs. Some tools were split into their own packages before libguestfs 1.45.2 and split into this package, see:
https://github.com/libguestfs/libguestfs/commit/733d2182b64df7abc5c5cd7d78177baa6079628c
Without this package, important tools like virt-sysprep were not provided at all.
The package is guestfs-tools but all other distributions align the package name with libguestfs.
Note that the test suite is very resource-intensive, needs to download 100+MB of images, and runs VMs for several of the tests for several minutes, which I don't think are reasonable for commit-time tests. They have been successful otherwise, apart from test-virt-sysprep-script.sh, which has been disabled.
Part of the test suite is downloading a test VM image, which is roughly the purpose of the `update-libguestfs-appliance` script in the base libguestfs package, however, it's not designed to run as a normal user in the chroot test pass.
(It also refers to an image which is no longer available, but I'm not sure what's the best approach to make it work, as it's only needed for the test suite, which is not nice at all to be run in a CI environment)
Perhaps to be coordinated with @Hoshpak (I don't insist staying the maintainer for these new entries, but don't mind it either)
---
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- Could not test any other archs, will check the CI
A patch file from https://github.com/void-linux/void-packages/pull/37416.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-guestfstools-37416.patch --]
[-- Type: text/x-diff, Size: 4643 bytes --]
From 21a7112c1c0c847ea7cfb53d724a076e41e6f4d0 Mon Sep 17 00:00:00 2001
From: J Farkas <chexum+git@gmail.com>
Date: Sun, 5 Jun 2022 18:55:52 +0000
Subject: [PATCH 1/2] New package: perl-Locale-TextDomain-0.32
libintl-perl 0.32, as a dependency for (lib)guestfs-tools.
---
srcpkgs/perl-Locale-TextDomain/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/perl-Locale-TextDomain/template
diff --git a/srcpkgs/perl-Locale-TextDomain/template b/srcpkgs/perl-Locale-TextDomain/template
new file mode 100644
index 000000000000..97e961ace0a2
--- /dev/null
+++ b/srcpkgs/perl-Locale-TextDomain/template
@@ -0,0 +1,16 @@
+# Template file for 'perl-Locale-TextDomain'
+pkgname=perl-Locale-TextDomain
+_pkg=libintl-perl
+version=1.32
+revision=1
+wrksrc="${_pkg}-${version}"
+build_style=perl-module
+hostmakedepends="perl"
+makedepends="${hostmakedepends}"
+depends="${makedepends}"
+short_desc="Perl Interface to Uniforum Message Translation"
+maintainer="J Farkas <chexum+git@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://metacpan.org/release/libintl-perl"
+distfiles="http://search.cpan.org/CPAN/authors/id/G/GU/GUIDO/${_pkg}-${version}.tar.gz"
+checksum=80108298f2564ecbfc7110a3042008e665ed00c2e155b36b0188e6c1135ceba5
From 518850a69a920988241daf2a05ad0c856031a727 Mon Sep 17 00:00:00 2001
From: J Farkas <chexum+git@gmail.com>
Date: Sun, 5 Jun 2022 18:56:06 +0000
Subject: [PATCH 2/2] New package: libguestfs-tools 1.48.0
Some tools were removed before libguestfs 1.45.2 and split into
another package, see commit:
733d2182b64df7abc5c5cd7d78177baa6079628c
in
https://github.com/libguestfs/libguestfs/
Without this package, important tools like virt-sysprep were not
provided at all.
The package is guestfs-tools but all other distributions align the
package name with libguestfs.
Note that the test suite is very resource-intensive, needs to
download 100+MB of images, and runs VMs for several of the tests
for several minutes, which I don't think are reasonable for
commit-time tests. They have been successful otherwise,
apart from test-virt-sysprep-script.sh, which has been disabled.
---
common/shlibs | 1 +
srcpkgs/libguestfs-tools/template | 40 +++++++++++++++++++++++++++++++
2 files changed, 41 insertions(+)
create mode 100644 srcpkgs/libguestfs-tools/template
diff --git a/common/shlibs b/common/shlibs
index 15d027bf9c20..543483bce7c2 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4165,3 +4165,4 @@ libTMVA.so root-6.24.06_1
libMathCore.so root-6.24.06_1
liblowdown.so lowdown-0.11.2_1
libjaylink.so.0 libjaylink-0.2.0_1
+libguestfs.so.0 libguestfs-tools-1.48.0_1
diff --git a/srcpkgs/libguestfs-tools/template b/srcpkgs/libguestfs-tools/template
new file mode 100644
index 000000000000..5f034e6e4f23
--- /dev/null
+++ b/srcpkgs/libguestfs-tools/template
@@ -0,0 +1,40 @@
+# Template file for 'libguestfs-tools'
+pkgname=libguestfs-tools
+_pkg=guestfs-tools
+version=1.48.0
+revision=1
+_version_short=${version%.*}
+wrksrc="${_pkg}-${version}"
+build_style=gnu-configure
+configure_args="ac_cv_prog_NCURSES_CONFIG=ncursesw6-config"
+hostmakedepends="flex pkg-config ncurses-devel gettext-devel pcre2-devel libvirt-devel
+ libxml2-devel jansson-devel ncurses-devel ocaml ocaml-findlib perl perl-Locale-TextDomain
+ hivex perl-Module-Build bash-completion qemu cpio"
+makedepends="cdrtools xz sqlite libguestfs-devel"
+depends="cdrtools xz sqlite"
+checkdepends="libguestfs libguestfs-devel curl wget tar procps-ng"
+short_desc="Additional tools for virtual machine disk image manipulation"
+maintainer="J Farkas <chexum+git@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/rwmjones/guestfs-tools"
+#changelog=""
+distfiles="https://download.libguestfs.org/${_pkg}/${_version_short}-stable/${_pkg}-${version}.tar.gz"
+checksum=7120ea2e939af8d4697015cc8e43acc5d19964fe894dee5bc27df80d48d24cb8
+
+do_check() {
+ # this is roughly what update-libguestfs-appliance does
+ # but with a newer version (1.40.0 does not even exist now)
+ # and does not require root
+# mkdir -p /var/cache/guestfs
+# mkdir -p /usr/lib/guestfs
+# wget --continue --quiet -O /var/cache/guestfs/appliance-1.46.0.tar.xz http://libguestfs.org/download/binaries/appliance/appliance-1.46.0.tar.xz
+# tar -xvf /var/cache/guestfs/appliance-1.46.0.tar.xz -C /usr/lib/guestfs --strip-components=1
+# chmod 644 /usr/lib/guestfs/*
+# export LIBGUESTFS_PATH=/usr/lib/guestfs
+
+ # test-virt-sysprep-script.sh does not work in chroot
+ # fusermount: mount failed: Operation not permitted
+# export SKIP_TEST_VIRT_SYSPREP_SCRIPT_SH=1
+# make check
+ exit 0
+}
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR PATCH] [Updated] New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (2 preceding siblings ...)
2022-06-26 16:59 ` [PR PATCH] [Updated] New package: " chexum
@ 2022-06-27 11:28 ` chexum
2022-06-27 22:22 ` Duncaen
` (16 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: chexum @ 2022-06-27 11:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 2594 bytes --]
There is an updated pull request by chexum against master on the void-packages repository
https://github.com/chexum/void-packages guestfstools
https://github.com/void-linux/void-packages/pull/37416
New package: libguestfs-tools 1.48.0
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
perl-Locale-TextDomain is only introduced for the script in perl.
libguestfs-tools is not technically now, some time ago it was part of libguestfs. Some tools were split into their own packages before libguestfs 1.45.2 and split into this package, see:
https://github.com/libguestfs/libguestfs/commit/733d2182b64df7abc5c5cd7d78177baa6079628c
Without this package, important tools like virt-sysprep were not provided at all.
The package is guestfs-tools but all other distributions align the package name with libguestfs.
Note that the test suite is very resource-intensive, needs to download 100+MB of images, and runs VMs for several of the tests for several minutes, which I don't think are reasonable for commit-time tests. They have been successful otherwise, apart from test-virt-sysprep-script.sh, which has been disabled.
Part of the test suite is downloading a test VM image, which is roughly the purpose of the `update-libguestfs-appliance` script in the base libguestfs package, however, it's not designed to run as a normal user in the chroot test pass.
(It also refers to an image which is no longer available, but I'm not sure what's the best approach to make it work, as it's only needed for the test suite, which is not nice at all to be run in a CI environment)
Perhaps to be coordinated with @Hoshpak (I don't insist staying the maintainer for these new entries, but don't mind it either)
---
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- Could not test any other archs, will check the CI
A patch file from https://github.com/void-linux/void-packages/pull/37416.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-guestfstools-37416.patch --]
[-- Type: text/x-diff, Size: 4698 bytes --]
From f88bd533832d20fe9cae2f09fc6072c1994da7e4 Mon Sep 17 00:00:00 2001
From: J Farkas <chexum+git@gmail.com>
Date: Sun, 5 Jun 2022 18:55:52 +0000
Subject: [PATCH 1/2] New package: perl-Locale-TextDomain-0.32
libintl-perl 0.32, as a dependency for (lib)guestfs-tools.
---
srcpkgs/perl-Locale-TextDomain/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/perl-Locale-TextDomain/template
diff --git a/srcpkgs/perl-Locale-TextDomain/template b/srcpkgs/perl-Locale-TextDomain/template
new file mode 100644
index 000000000000..97e961ace0a2
--- /dev/null
+++ b/srcpkgs/perl-Locale-TextDomain/template
@@ -0,0 +1,16 @@
+# Template file for 'perl-Locale-TextDomain'
+pkgname=perl-Locale-TextDomain
+_pkg=libintl-perl
+version=1.32
+revision=1
+wrksrc="${_pkg}-${version}"
+build_style=perl-module
+hostmakedepends="perl"
+makedepends="${hostmakedepends}"
+depends="${makedepends}"
+short_desc="Perl Interface to Uniforum Message Translation"
+maintainer="J Farkas <chexum+git@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://metacpan.org/release/libintl-perl"
+distfiles="http://search.cpan.org/CPAN/authors/id/G/GU/GUIDO/${_pkg}-${version}.tar.gz"
+checksum=80108298f2564ecbfc7110a3042008e665ed00c2e155b36b0188e6c1135ceba5
From da4348180cca91787b8af875aa103bb759948e7b Mon Sep 17 00:00:00 2001
From: J Farkas <chexum+git@gmail.com>
Date: Sun, 5 Jun 2022 18:56:06 +0000
Subject: [PATCH 2/2] New package: libguestfs-tools 1.48.0
Some tools were removed before libguestfs 1.45.2 and split into
another package, see commit:
733d2182b64df7abc5c5cd7d78177baa6079628c
in
https://github.com/libguestfs/libguestfs/
Without this package, important tools like virt-sysprep were not
provided at all.
The package is guestfs-tools but all other distributions align the
package name with libguestfs.
Note that the test suite is very resource-intensive, needs to
download 100+MB of images, and runs VMs for several of the tests
for several minutes, which I don't think are reasonable for
commit-time tests. They have been successful otherwise,
apart from test-virt-sysprep-script.sh, which has been disabled.
---
common/shlibs | 1 +
srcpkgs/libguestfs-tools/template | 40 +++++++++++++++++++++++++++++++
2 files changed, 41 insertions(+)
create mode 100644 srcpkgs/libguestfs-tools/template
diff --git a/common/shlibs b/common/shlibs
index a7540ef7b2db..8085a1a17bf5 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4164,3 +4164,4 @@ liblowdown.so lowdown-0.11.2_1
libjaylink.so.0 libjaylink-0.2.0_1
libnvidia-container.so.1 libnvidia-container-1.10.0_1
libnvidia-container-go.so.1 libnvidia-container-1.10.0_1
+libguestfs.so.0 libguestfs-tools-1.48.0_1
diff --git a/srcpkgs/libguestfs-tools/template b/srcpkgs/libguestfs-tools/template
new file mode 100644
index 000000000000..5f034e6e4f23
--- /dev/null
+++ b/srcpkgs/libguestfs-tools/template
@@ -0,0 +1,40 @@
+# Template file for 'libguestfs-tools'
+pkgname=libguestfs-tools
+_pkg=guestfs-tools
+version=1.48.0
+revision=1
+_version_short=${version%.*}
+wrksrc="${_pkg}-${version}"
+build_style=gnu-configure
+configure_args="ac_cv_prog_NCURSES_CONFIG=ncursesw6-config"
+hostmakedepends="flex pkg-config ncurses-devel gettext-devel pcre2-devel libvirt-devel
+ libxml2-devel jansson-devel ncurses-devel ocaml ocaml-findlib perl perl-Locale-TextDomain
+ hivex perl-Module-Build bash-completion qemu cpio"
+makedepends="cdrtools xz sqlite libguestfs-devel"
+depends="cdrtools xz sqlite"
+checkdepends="libguestfs libguestfs-devel curl wget tar procps-ng"
+short_desc="Additional tools for virtual machine disk image manipulation"
+maintainer="J Farkas <chexum+git@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/rwmjones/guestfs-tools"
+#changelog=""
+distfiles="https://download.libguestfs.org/${_pkg}/${_version_short}-stable/${_pkg}-${version}.tar.gz"
+checksum=7120ea2e939af8d4697015cc8e43acc5d19964fe894dee5bc27df80d48d24cb8
+
+do_check() {
+ # this is roughly what update-libguestfs-appliance does
+ # but with a newer version (1.40.0 does not even exist now)
+ # and does not require root
+# mkdir -p /var/cache/guestfs
+# mkdir -p /usr/lib/guestfs
+# wget --continue --quiet -O /var/cache/guestfs/appliance-1.46.0.tar.xz http://libguestfs.org/download/binaries/appliance/appliance-1.46.0.tar.xz
+# tar -xvf /var/cache/guestfs/appliance-1.46.0.tar.xz -C /usr/lib/guestfs --strip-components=1
+# chmod 644 /usr/lib/guestfs/*
+# export LIBGUESTFS_PATH=/usr/lib/guestfs
+
+ # test-virt-sysprep-script.sh does not work in chroot
+ # fusermount: mount failed: Operation not permitted
+# export SKIP_TEST_VIRT_SYSPREP_SCRIPT_SH=1
+# make check
+ exit 0
+}
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (3 preceding siblings ...)
2022-06-27 11:28 ` chexum
@ 2022-06-27 22:22 ` Duncaen
2022-06-27 22:45 ` [PR REVIEW] " Duncaen
` (15 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: Duncaen @ 2022-06-27 22:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/37416#issuecomment-1167982364
Comment:
We generally use upstream names, anything wrong with using `guestfs-tools`?
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR REVIEW] New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (4 preceding siblings ...)
2022-06-27 22:22 ` Duncaen
@ 2022-06-27 22:45 ` Duncaen
2022-06-27 22:46 ` Duncaen
` (14 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: Duncaen @ 2022-06-27 22:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/37416#discussion_r907858678
Comment:
```suggestion
distfiles="https://download.libguestfs.org/guestfs-tools/${version%.*}-stable/${_pkg}-${version}.tar.gz"
```
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR REVIEW] New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (5 preceding siblings ...)
2022-06-27 22:45 ` [PR REVIEW] " Duncaen
@ 2022-06-27 22:46 ` Duncaen
2022-06-27 22:46 ` Duncaen
` (13 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: Duncaen @ 2022-06-27 22:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 208 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/37416#discussion_r907859351
Comment:
This conflicts with the `libguestfs` package, is that correct
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR REVIEW] New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (6 preceding siblings ...)
2022-06-27 22:46 ` Duncaen
@ 2022-06-27 22:46 ` Duncaen
2022-06-27 22:48 ` Duncaen
` (12 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: Duncaen @ 2022-06-27 22:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 209 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/37416#discussion_r907859351
Comment:
This conflicts with the `libguestfs` package, is that correct?
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR REVIEW] New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (7 preceding siblings ...)
2022-06-27 22:46 ` Duncaen
@ 2022-06-27 22:48 ` Duncaen
2022-06-29 16:04 ` chexum
` (11 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: Duncaen @ 2022-06-27 22:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/37416#discussion_r907859351
Comment:
This conflicts with the `libguestfs` package, is that correct?
Edit: it doesn't exist, did you want to add `libguestfs.so.0 libguestfs-1.48.0_1`?
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (8 preceding siblings ...)
2022-06-27 22:48 ` Duncaen
@ 2022-06-29 16:04 ` chexum
2022-06-29 16:27 ` [PR REVIEW] " chexum
` (10 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: chexum @ 2022-06-29 16:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
New comment by chexum on void-packages repository
https://github.com/void-linux/void-packages/pull/37416#issuecomment-1170175736
Comment:
> We generally use upstream names, anything wrong with using `guestfs-tools`?
Even the internal library common to `libguestfs` and `guestfs-tools` is residing in `libguestfs-common`. Perhaps the vendor name was chosen to only have a name that's shorter to type, but it's all still for the libguestfs family. Both the two major distributions use the name `libguestfs-tools` as well. This way it could reduce the confusion of both new users, to learn about the package, and users from other distributions, to find the package they know.
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR REVIEW] New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (9 preceding siblings ...)
2022-06-29 16:04 ` chexum
@ 2022-06-29 16:27 ` chexum
2022-06-29 16:50 ` [PR PATCH] [Updated] " chexum
` (9 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: chexum @ 2022-06-29 16:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
New review comment by chexum on void-packages repository
https://github.com/void-linux/void-packages/pull/37416#discussion_r910175312
Comment:
> This conflicts with the `libguestfs` package, is that correct?
That seems to be a fault of mine, but there is some weirdness here. There is no `libguestfs.so.*` in this package. I mindlessly added it, because the build (the pkg phase) complained about it(!) It looks the source of the complaint is that makedepends pulls `libguestfs-devel` in, with this library:
SONAME: libguestfs.so.0 <-> UNKNOWN PKG PLEASE FIX!
So it would seem the complaint is about the lack of package mapping for the library, to let xbps know where the library comes from, right? It's just weird to point to another package which is not in this change.
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR PATCH] [Updated] New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (10 preceding siblings ...)
2022-06-29 16:27 ` [PR REVIEW] " chexum
@ 2022-06-29 16:50 ` chexum
2022-06-29 16:51 ` [PR REVIEW] " chexum
` (8 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: chexum @ 2022-06-29 16:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 2594 bytes --]
There is an updated pull request by chexum against master on the void-packages repository
https://github.com/chexum/void-packages guestfstools
https://github.com/void-linux/void-packages/pull/37416
New package: libguestfs-tools 1.48.0
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
perl-Locale-TextDomain is only introduced for the script in perl.
libguestfs-tools is not technically now, some time ago it was part of libguestfs. Some tools were split into their own packages before libguestfs 1.45.2 and split into this package, see:
https://github.com/libguestfs/libguestfs/commit/733d2182b64df7abc5c5cd7d78177baa6079628c
Without this package, important tools like virt-sysprep were not provided at all.
The package is guestfs-tools but all other distributions align the package name with libguestfs.
Note that the test suite is very resource-intensive, needs to download 100+MB of images, and runs VMs for several of the tests for several minutes, which I don't think are reasonable for commit-time tests. They have been successful otherwise, apart from test-virt-sysprep-script.sh, which has been disabled.
Part of the test suite is downloading a test VM image, which is roughly the purpose of the `update-libguestfs-appliance` script in the base libguestfs package, however, it's not designed to run as a normal user in the chroot test pass.
(It also refers to an image which is no longer available, but I'm not sure what's the best approach to make it work, as it's only needed for the test suite, which is not nice at all to be run in a CI environment)
Perhaps to be coordinated with @Hoshpak (I don't insist staying the maintainer for these new entries, but don't mind it either)
---
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- Could not test any other archs, will check the CI
A patch file from https://github.com/void-linux/void-packages/pull/37416.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-guestfstools-37416.patch --]
[-- Type: text/x-diff, Size: 4644 bytes --]
From b9b7707f3ddcaea1f8b27db20a03842122e731ab Mon Sep 17 00:00:00 2001
From: J Farkas <chexum+git@gmail.com>
Date: Sun, 5 Jun 2022 18:55:52 +0000
Subject: [PATCH 1/2] New package: perl-Locale-TextDomain-0.32
libintl-perl 0.32, as a dependency for (lib)guestfs-tools.
---
srcpkgs/perl-Locale-TextDomain/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/perl-Locale-TextDomain/template
diff --git a/srcpkgs/perl-Locale-TextDomain/template b/srcpkgs/perl-Locale-TextDomain/template
new file mode 100644
index 000000000000..97e961ace0a2
--- /dev/null
+++ b/srcpkgs/perl-Locale-TextDomain/template
@@ -0,0 +1,16 @@
+# Template file for 'perl-Locale-TextDomain'
+pkgname=perl-Locale-TextDomain
+_pkg=libintl-perl
+version=1.32
+revision=1
+wrksrc="${_pkg}-${version}"
+build_style=perl-module
+hostmakedepends="perl"
+makedepends="${hostmakedepends}"
+depends="${makedepends}"
+short_desc="Perl Interface to Uniforum Message Translation"
+maintainer="J Farkas <chexum+git@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://metacpan.org/release/libintl-perl"
+distfiles="http://search.cpan.org/CPAN/authors/id/G/GU/GUIDO/${_pkg}-${version}.tar.gz"
+checksum=80108298f2564ecbfc7110a3042008e665ed00c2e155b36b0188e6c1135ceba5
From dd584c82892d9045d95bbfb7e7458826a7679675 Mon Sep 17 00:00:00 2001
From: J Farkas <chexum+git@gmail.com>
Date: Mon, 27 Jun 2022 20:28:14 +0000
Subject: [PATCH 2/2] New package: libguestfs-tools 1.48.0
Some tools were removed before libguestfs 1.45.2 and split into
another package, see commit:
733d2182b64df7abc5c5cd7d78177baa6079628c
in
https://github.com/libguestfs/libguestfs/
Without this package, important tools like virt-sysprep were not
provided at all.
The package is guestfs-tools but all other distributions align the
package name with libguestfs.
Note that the test suite is very resource-intensive, needs to
download 100+MB of images, and runs VMs for several of the tests
for several minutes, which I don't think are reasonable for
commit-time tests. They have been successful otherwise,
apart from test-virt-sysprep-script.sh, which has been disabled.
---
common/shlibs | 1 +
srcpkgs/libguestfs-tools/template | 38 +++++++++++++++++++++++++++++++
2 files changed, 39 insertions(+)
create mode 100644 srcpkgs/libguestfs-tools/template
diff --git a/common/shlibs b/common/shlibs
index a7540ef7b2db..2a5d82699874 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4164,3 +4164,4 @@ liblowdown.so lowdown-0.11.2_1
libjaylink.so.0 libjaylink-0.2.0_1
libnvidia-container.so.1 libnvidia-container-1.10.0_1
libnvidia-container-go.so.1 libnvidia-container-1.10.0_1
+libguestfs.so.0 libguestfs-1.48.1_1
diff --git a/srcpkgs/libguestfs-tools/template b/srcpkgs/libguestfs-tools/template
new file mode 100644
index 000000000000..2e1518fd5293
--- /dev/null
+++ b/srcpkgs/libguestfs-tools/template
@@ -0,0 +1,38 @@
+# Template file for 'libguestfs-tools'
+pkgname=libguestfs-tools
+_pkg=guestfs-tools
+version=1.48.0
+revision=1
+wrksrc="${_pkg}-${version}"
+build_style=gnu-configure
+configure_args="ac_cv_prog_NCURSES_CONFIG=ncursesw6-config"
+hostmakedepends="flex pkg-config ncurses-devel gettext-devel pcre2-devel libvirt-devel
+ libxml2-devel jansson-devel ncurses-devel ocaml ocaml-findlib perl perl-Locale-TextDomain
+ hivex perl-Module-Build bash-completion qemu cpio"
+makedepends="cdrtools xz sqlite libguestfs-devel"
+depends="cdrtools xz sqlite"
+checkdepends="libguestfs libguestfs-devel curl wget tar procps-ng"
+short_desc="Additional tools for virtual machine disk image manipulation"
+maintainer="J Farkas <chexum+git@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/rwmjones/guestfs-tools"
+distfiles="https://download.libguestfs.org/${_pkg}/${version%.*}-stable/${_pkg}-${version}.tar.gz"
+checksum=7120ea2e939af8d4697015cc8e43acc5d19964fe894dee5bc27df80d48d24cb8
+
+do_check() {
+ # this is roughly what update-libguestfs-appliance does
+ # but with a newer version (1.40.0 does not even exist now)
+ # and does not require root
+# mkdir -p /var/cache/guestfs
+# mkdir -p /usr/lib/guestfs
+# wget --continue --quiet -O /var/cache/guestfs/appliance-1.46.0.tar.xz http://libguestfs.org/download/binaries/appliance/appliance-1.46.0.tar.xz
+# tar -xvf /var/cache/guestfs/appliance-1.46.0.tar.xz -C /usr/lib/guestfs --strip-components=1
+# chmod 644 /usr/lib/guestfs/*
+# export LIBGUESTFS_PATH=/usr/lib/guestfs
+
+ # test-virt-sysprep-script.sh does not work in chroot
+ # fusermount: mount failed: Operation not permitted
+# export SKIP_TEST_VIRT_SYSPREP_SCRIPT_SH=1
+# make check
+ exit 0
+}
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR REVIEW] New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (11 preceding siblings ...)
2022-06-29 16:50 ` [PR PATCH] [Updated] " chexum
@ 2022-06-29 16:51 ` chexum
2022-06-29 17:02 ` Duncaen
` (7 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: chexum @ 2022-06-29 16:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 318 bytes --]
New review comment by chexum on void-packages repository
https://github.com/void-linux/void-packages/pull/37416#discussion_r910196821
Comment:
_version_short is indeed just overengineering, however _pkg (if the package is meant to have a different name), is needed in more places. I have pushed the amended commit.
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR REVIEW] New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (12 preceding siblings ...)
2022-06-29 16:51 ` [PR REVIEW] " chexum
@ 2022-06-29 17:02 ` Duncaen
2022-07-03 14:51 ` chexum
` (6 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: Duncaen @ 2022-06-29 17:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/37416#discussion_r910207006
Comment:
The url and wrksrc will always be what upstream uses, there is no point in using `$pkgname` or `$_pkg` in it, the only variable that make sense is `$version` since that is supposed to change.
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (13 preceding siblings ...)
2022-06-29 17:02 ` Duncaen
@ 2022-07-03 14:51 ` chexum
2022-10-02 2:15 ` github-actions
` (5 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: chexum @ 2022-07-03 14:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]
New comment by chexum on void-packages repository
https://github.com/void-linux/void-packages/pull/37416#issuecomment-1173105494
Comment:
Of course I'm not quite sure if the choice of the non-upstream package name `libguestfs-tools` is correct. However, when trying to find out where did `virt-sysprep` (for example) has gone from `libguestfs`, it took a nontrivial amount of time to see that it's now in a package that's not yet shipping. If void were to use the name established by the deb and rpm folks, it at least smooths the transition for people using documentation written with those distributions in mind. Perhaps surprisingly, this includes the upstream web site, so I have a fair point that this is actually the upstream name:
https://libguestfs.org/
```
sudo yum install libguestfs-tools # Fedora/RHEL/CentOS
sudo apt-get install libguestfs-tools # Debian/Ubuntu
```
Furthermore, it should also make it easier to find it by `xbps-query -Rs libguestfs`. Would any user think that they need to use `xbps-query -Rs guestfs` instead? If these points still don't make sense over the upstream naming rule, I'd be happy to oblige, and change the name.
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (14 preceding siblings ...)
2022-07-03 14:51 ` chexum
@ 2022-10-02 2:15 ` github-actions
2022-10-09 18:56 ` chexum
` (4 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: github-actions @ 2022-10-02 2:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/37416#issuecomment-1264529171
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (15 preceding siblings ...)
2022-10-02 2:15 ` github-actions
@ 2022-10-09 18:56 ` chexum
2023-01-09 1:58 ` github-actions
` (3 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: chexum @ 2022-10-09 18:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
New comment by chexum on void-packages repository
https://github.com/void-linux/void-packages/pull/37416#issuecomment-1272606830
Comment:
Yes, I'd still like to have this merged - give me some time to review recent changes
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (16 preceding siblings ...)
2022-10-09 18:56 ` chexum
@ 2023-01-09 1:58 ` github-actions
2023-01-18 18:09 ` chexum
` (2 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: github-actions @ 2023-01-09 1:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/37416#issuecomment-1375016062
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (17 preceding siblings ...)
2023-01-09 1:58 ` github-actions
@ 2023-01-18 18:09 ` chexum
2023-04-20 1:51 ` github-actions
2023-05-05 1:49 ` [PR PATCH] [Closed]: " github-actions
20 siblings, 0 replies; 22+ messages in thread
From: chexum @ 2023-01-18 18:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 233 bytes --]
New comment by chexum on void-packages repository
https://github.com/void-linux/void-packages/pull/37416#issuecomment-1387498552
Comment:
still working on getting back on my feet and retesting this package, appreciate the patience
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (18 preceding siblings ...)
2023-01-18 18:09 ` chexum
@ 2023-04-20 1:51 ` github-actions
2023-05-05 1:49 ` [PR PATCH] [Closed]: " github-actions
20 siblings, 0 replies; 22+ messages in thread
From: github-actions @ 2023-04-20 1:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/37416#issuecomment-1515600385
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PR PATCH] [Closed]: New package: libguestfs-tools 1.48.0
2022-06-05 19:14 [PR PATCH] libguestfs-tools 1.48.0 chexum
` (19 preceding siblings ...)
2023-04-20 1:51 ` github-actions
@ 2023-05-05 1:49 ` github-actions
20 siblings, 0 replies; 22+ messages in thread
From: github-actions @ 2023-05-05 1:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 2435 bytes --]
There's a closed pull request on the void-packages repository
New package: libguestfs-tools 1.48.0
https://github.com/void-linux/void-packages/pull/37416
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
perl-Locale-TextDomain is only introduced for the script in perl.
libguestfs-tools is not technically now, some time ago it was part of libguestfs. Some tools were split into their own packages before libguestfs 1.45.2 and split into this package, see:
https://github.com/libguestfs/libguestfs/commit/733d2182b64df7abc5c5cd7d78177baa6079628c
Without this package, important tools like virt-sysprep were not provided at all.
The package is guestfs-tools but all other distributions align the package name with libguestfs.
Note that the test suite is very resource-intensive, needs to download 100+MB of images, and runs VMs for several of the tests for several minutes, which I don't think are reasonable for commit-time tests. They have been successful otherwise, apart from test-virt-sysprep-script.sh, which has been disabled.
Part of the test suite is downloading a test VM image, which is roughly the purpose of the `update-libguestfs-appliance` script in the base libguestfs package, however, it's not designed to run as a normal user in the chroot test pass.
(It also refers to an image which is no longer available, but I'm not sure what's the best approach to make it work, as it's only needed for the test suite, which is not nice at all to be run in a CI environment)
Perhaps to be coordinated with @Hoshpak (I don't insist staying the maintainer for these new entries, but don't mind it either)
---
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- Could not test any other archs, will check the CI
^ permalink raw reply [flat|nested] 22+ messages in thread