From: nyanpasu64 <nyanpasu64@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] godot: update to 3.5.1 and enable PulseAudio backend
Date: Fri, 14 Oct 2022 23:49:02 +0200 [thread overview]
Message-ID: <20221014214902.Zs7jnVtYLGRL3nNrA9dHovwK2C6q5bAL8k6Rc8tKSeU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39957@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
New review comment by nyanpasu64 on void-packages repository
https://github.com/void-linux/void-packages/pull/39957#discussion_r996180797
Comment:
Godot has multiple audio drivers selected at runtime, and `pulseaudio=yes` *enables* the Pulse backend as a runtime *option* without turning off ALSA as an option if Pulse is absent:
```
godot --audio-driver test
Unknown audio driver 'test', aborting.
Valid options are 'PulseAudio', 'ALSA' and 'Dummy'.
```
And I think `pulseaudio=yes` is set by default: https://github.com/godotengine/godot/blob/3.5.1-stable/platform/x11/detect.py#L77
Should I add `pulseaudio=yes` or omit it altogether (which the flatpak build does, and enables PulseAudio)?
next prev parent reply other threads:[~2022-10-14 21:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 17:28 [PR PATCH] " nyanpasu64
2022-10-14 21:05 ` paper42
2022-10-14 21:06 ` [PR REVIEW] " paper42
2022-10-14 21:07 ` paper42
2022-10-14 21:23 ` nyanpasu64
2022-10-14 21:42 ` paper42
2022-10-14 21:47 ` paper42
2022-10-14 21:49 ` nyanpasu64 [this message]
2022-10-14 22:08 ` paper42
2022-10-14 22:11 ` [PR PATCH] [Updated] " nyanpasu64
2022-10-15 6:53 ` nyanpasu64
2022-11-06 20:14 ` nyanpasu64
2022-11-10 19:41 ` paper42
2022-11-13 14:20 ` [PR PATCH] [Updated] " nyanpasu64
2022-11-13 15:54 ` [PR PATCH] [Merged]: " Johnnynator
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014214902.Zs7jnVtYLGRL3nNrA9dHovwK2C6q5bAL8k6Rc8tKSeU@z \
--to=nyanpasu64@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).