Github messages for voidlinux
 help / color / mirror / Atom feed
From: nyanpasu64 <nyanpasu64@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] godot: update to 3.5.1 and enable PulseAudio backend
Date: Sat, 15 Oct 2022 00:11:26 +0200	[thread overview]
Message-ID: <20221014221126.5gBNwE5UfgXHYgPyr-szZB5pE4rTYk38nFZxVKv8nQY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39957@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

There is an updated pull request by nyanpasu64 against master on the void-packages repository

https://github.com/nyanpasu64/void-packages godot-update-pulse
https://github.com/void-linux/void-packages/pull/39957

godot: update to 3.5.1 and enable PulseAudio backend
Enabling Godot's PulseAudio driver fixes audio playback on PipeWire. Previously, the package's only enabled audio driver was ALSA, but Godot on alsa-pipewire stutters, and Godot on HW ALSA devices prevents PipeWire apps from playing audio.

#### Testing the changes
- I tested the changes in this PR: **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - none, `./xbps-src -a armv6l pkg godot` claims godot can't cross-compile and I didn't try native building

Fixes #39936.

A patch file from https://github.com/void-linux/void-packages/pull/39957.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-godot-update-pulse-39957.patch --]
[-- Type: text/x-diff, Size: 2399 bytes --]

From 2f11cd73c4dcd8f18ee1da4e544aece0f3e36e92 Mon Sep 17 00:00:00 2001
From: nyanpasu64 <nyanpasu64@tuta.io>
Date: Fri, 14 Oct 2022 05:30:24 -0700
Subject: [PATCH] godot: update to 3.5.1.

Also enable the PulseAudio audio backend to fix audio playback on
PipeWire. Previously, the package's only enabled audio driver was ALSA,
but Godot on alsa-pipewire stutters, and Godot on HW ALSA devices
prevents PipeWire apps from playing audio.
---
 srcpkgs/godot/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/godot/template b/srcpkgs/godot/template
index 67f591a4924b..c7d7640a1894 100644
--- a/srcpkgs/godot/template
+++ b/srcpkgs/godot/template
@@ -1,6 +1,6 @@
 # Template file for 'godot'
 pkgname=godot
-version=3.5
+version=3.5.1
 revision=1
 archs="x86_64* i686* aarch64* armv7* ppc64*"
 wrksrc="${pkgname}-${version}-stable"
@@ -10,7 +10,7 @@ build_style=scons
 # Use builtin bullet for now as it's too old in repos (needs 2.89)
 # Toggle to not use builtin once bullet has been updated
 make_build_args="platform=x11 tools=yes target=release_debug dev=no progress=no
- pulseaudio=no builtin_bullet=false builtin_libpng=false builtin_libvpx=false
+ builtin_bullet=false builtin_libpng=false builtin_libvpx=false
  builtin_libwebp=false builtin_libogg=false builtin_libtheora=false
  builtin_opus=false builtin_libvorbis=false builtin_enet=false
  builtin_zlib=false builtin_freetype=false builtin_mbedtls=false
@@ -21,13 +21,13 @@ makedepends="
  libXinerama-devel libXrender-devel libXrandr-devel libX11-devel
  bullet-devel libpng-devel libvpx-devel libwebp-devel libogg-devel libtheora-devel
  opus-devel opusfile-devel libvorbis-devel libenet-devel zlib-devel mbedtls-devel
- miniupnpc-devel pcre2-devel"
+ miniupnpc-devel pcre2-devel pulseaudio-devel"
 short_desc="Multiplatform 2D and 3D engine"
 maintainer="Nick Hahn <nick.hahn@hotmail.de>"
 license="MIT"
 homepage="https://www.godotengine.org/"
-distfiles="https://github.com/godotengine/${pkgname}/archive/${version}-stable.tar.gz"
-checksum=c65425e1d56a7097990f231c27c9271b7159f763dc59f0eaba9273633e59da36
+distfiles="https://github.com/godotengine/godot/archive/${version}-stable.tar.gz"
+checksum=164523c1c8aef0b69b135645794f5bece3f63788556a56aa293c118cde457023
 nocross=https://build.voidlinux.org/builders/armv7l_builder/builds/6342/steps/shell_3/logs/stdio
 
 CFLAGS+=" -fPIE -fPIC"

  parent reply	other threads:[~2022-10-14 22:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14 17:28 [PR PATCH] " nyanpasu64
2022-10-14 21:05 ` paper42
2022-10-14 21:06 ` [PR REVIEW] " paper42
2022-10-14 21:07 ` paper42
2022-10-14 21:23 ` nyanpasu64
2022-10-14 21:42 ` paper42
2022-10-14 21:47 ` paper42
2022-10-14 21:49 ` nyanpasu64
2022-10-14 22:08 ` paper42
2022-10-14 22:11 ` nyanpasu64 [this message]
2022-10-15  6:53 ` nyanpasu64
2022-11-06 20:14 ` nyanpasu64
2022-11-10 19:41 ` paper42
2022-11-13 14:20 ` [PR PATCH] [Updated] " nyanpasu64
2022-11-13 15:54 ` [PR PATCH] [Merged]: " Johnnynator

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221014221126.5gBNwE5UfgXHYgPyr-szZB5pE4rTYk38nFZxVKv8nQY@z \
    --to=nyanpasu64@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).