* [PR PATCH] sioyek: don't depend on mupdf
@ 2023-02-21 22:43 classabbyamp
2023-02-22 16:40 ` dkwo
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: classabbyamp @ 2023-02-21 22:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 593 bytes --]
There is a new pull request by classabbyamp against master on the void-packages repository
https://github.com/classabbyamp/void-packages fix/sioyek-no-mupdf
https://github.com/void-linux/void-packages/pull/42386
sioyek: don't depend on mupdf
doesn't seem to be needed, as mupdf only available as a statically linkable library
cc maintainer @dkwo
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/42386.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/sioyek-no-mupdf-42386.patch --]
[-- Type: text/x-diff, Size: 1108 bytes --]
From 85ec56c8ee78201e0a11ce6fb76e228a1cf40848 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Tue, 21 Feb 2023 17:41:31 -0500
Subject: [PATCH] sioyek: don't depend on mupdf
doesn't seem to be needed, as mupdf only available as a statically
linkable library
---
srcpkgs/sioyek/template | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/srcpkgs/sioyek/template b/srcpkgs/sioyek/template
index 3d96eb044aa6..c2bb5ba5682e 100644
--- a/srcpkgs/sioyek/template
+++ b/srcpkgs/sioyek/template
@@ -1,14 +1,13 @@
# Template file for 'sioyek'
pkgname=sioyek
version=2.0.0
-revision=2
+revision=3
build_style=qmake
hostmakedepends="qt5-qmake qt5-host-tools
qt5-opengl qt5-gui qt5-widgets qt5-network"
makedepends="zlib-devel qt5-3d-devel qt5-gamepad-devel mupdf-devel
gumbo-parser-devel harfbuzz-devel qt5-opengl mujs-devel freetype-devel
libjbig2dec libjpeg-turbo-devel libopenjpeg2-devel"
-depends="mupdf"
short_desc="PDF viewer designed for reading research papers and technical books"
maintainer="dkwo <npiazza@disroot.org>"
license="GPL-3.0-or-later"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: sioyek: don't depend on mupdf
2023-02-21 22:43 [PR PATCH] sioyek: don't depend on mupdf classabbyamp
@ 2023-02-22 16:40 ` dkwo
2023-02-22 20:34 ` [PR PATCH] [Updated] " classabbyamp
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: dkwo @ 2023-02-22 16:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/42386#issuecomment-1440393971
Comment:
Looks good to me, thanks. Moreover, it seems it crosscompiles (at least for aarc64) with
```
diff --git a/srcpkgs/sioyek/template b/srcpkgs/sioyek/template
index 3d96eb044a..8500bdf8e4 100644
--- a/srcpkgs/sioyek/template
+++ b/srcpkgs/sioyek/template
@@ -1,26 +1,20 @@
# Template file for 'sioyek'
pkgname=sioyek
version=2.0.0
-revision=2
+revision=3
build_style=qmake
+configure_args="pdf_viewer_build_config.pro"
hostmakedepends="qt5-qmake qt5-host-tools
qt5-opengl qt5-gui qt5-widgets qt5-network"
makedepends="zlib-devel qt5-3d-devel qt5-gamepad-devel mupdf-devel
gumbo-parser-devel harfbuzz-devel qt5-opengl mujs-devel freetype-devel
libjbig2dec libjpeg-turbo-devel libopenjpeg2-devel"
-depends="mupdf"
short_desc="PDF viewer designed for reading research papers and technical books"
maintainer="dkwo <npiazza@disroot.org>"
license="GPL-3.0-or-later"
homepage="https://sioyek.info/"
distfiles="https://github.com/ahrm/sioyek/archive/refs/tags/v${version}.tar.gz"
checksum=92398b6da5e297c59f22cd3c6b562194846f28bc17bb4ae9432869aafeb5df17
-nocross=yes
-
-do_build() {
- qmake pdf_viewer_build_config.pro
- make ${makejobs} CC="$CC" CXX="$CXX" LINK="$CXX"
-}
do_install() {
vbin sioyek
```
Can you change that as well?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Updated] sioyek: don't depend on mupdf
2023-02-21 22:43 [PR PATCH] sioyek: don't depend on mupdf classabbyamp
2023-02-22 16:40 ` dkwo
@ 2023-02-22 20:34 ` classabbyamp
2023-02-22 20:34 ` classabbyamp
2023-02-22 20:40 ` [PR PATCH] [Merged]: sioyek: don't depend on mupdf, fix cross classabbyamp
3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2023-02-22 20:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 598 bytes --]
There is an updated pull request by classabbyamp against master on the void-packages repository
https://github.com/classabbyamp/void-packages fix/sioyek-no-mupdf
https://github.com/void-linux/void-packages/pull/42386
sioyek: don't depend on mupdf
doesn't seem to be needed, as mupdf only available as a statically linkable library
cc maintainer @dkwo
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/42386.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/sioyek-no-mupdf-42386.patch --]
[-- Type: text/x-diff, Size: 1514 bytes --]
From f894172e5e0888f2cbeb484361022c54d8d71dc2 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Tue, 21 Feb 2023 17:41:31 -0500
Subject: [PATCH] sioyek: don't depend on mupdf, fix cross
doesn't seem to be needed, as mupdf only available as a statically
linkable library
---
srcpkgs/sioyek/template | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/srcpkgs/sioyek/template b/srcpkgs/sioyek/template
index 3d96eb044aa6..8500bdf8e43b 100644
--- a/srcpkgs/sioyek/template
+++ b/srcpkgs/sioyek/template
@@ -1,26 +1,20 @@
# Template file for 'sioyek'
pkgname=sioyek
version=2.0.0
-revision=2
+revision=3
build_style=qmake
+configure_args="pdf_viewer_build_config.pro"
hostmakedepends="qt5-qmake qt5-host-tools
qt5-opengl qt5-gui qt5-widgets qt5-network"
makedepends="zlib-devel qt5-3d-devel qt5-gamepad-devel mupdf-devel
gumbo-parser-devel harfbuzz-devel qt5-opengl mujs-devel freetype-devel
libjbig2dec libjpeg-turbo-devel libopenjpeg2-devel"
-depends="mupdf"
short_desc="PDF viewer designed for reading research papers and technical books"
maintainer="dkwo <npiazza@disroot.org>"
license="GPL-3.0-or-later"
homepage="https://sioyek.info/"
distfiles="https://github.com/ahrm/sioyek/archive/refs/tags/v${version}.tar.gz"
checksum=92398b6da5e297c59f22cd3c6b562194846f28bc17bb4ae9432869aafeb5df17
-nocross=yes
-
-do_build() {
- qmake pdf_viewer_build_config.pro
- make ${makejobs} CC="$CC" CXX="$CXX" LINK="$CXX"
-}
do_install() {
vbin sioyek
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: sioyek: don't depend on mupdf
2023-02-21 22:43 [PR PATCH] sioyek: don't depend on mupdf classabbyamp
2023-02-22 16:40 ` dkwo
2023-02-22 20:34 ` [PR PATCH] [Updated] " classabbyamp
@ 2023-02-22 20:34 ` classabbyamp
2023-02-22 20:40 ` [PR PATCH] [Merged]: sioyek: don't depend on mupdf, fix cross classabbyamp
3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2023-02-22 20:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 153 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/42386#issuecomment-1440761937
Comment:
thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Merged]: sioyek: don't depend on mupdf, fix cross
2023-02-21 22:43 [PR PATCH] sioyek: don't depend on mupdf classabbyamp
` (2 preceding siblings ...)
2023-02-22 20:34 ` classabbyamp
@ 2023-02-22 20:40 ` classabbyamp
3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2023-02-22 20:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 431 bytes --]
There's a merged pull request on the void-packages repository
sioyek: don't depend on mupdf, fix cross
https://github.com/void-linux/void-packages/pull/42386
Description:
doesn't seem to be needed, as mupdf only available as a statically linkable library
cc maintainer @dkwo
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-22 20:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-21 22:43 [PR PATCH] sioyek: don't depend on mupdf classabbyamp
2023-02-22 16:40 ` dkwo
2023-02-22 20:34 ` [PR PATCH] [Updated] " classabbyamp
2023-02-22 20:34 ` classabbyamp
2023-02-22 20:40 ` [PR PATCH] [Merged]: sioyek: don't depend on mupdf, fix cross classabbyamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).