Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: linux-wifi-hotspot-4.5.0
@ 2023-06-01 13:00 Bnyro
  2023-06-01 13:05 ` [PR PATCH] [Updated] " Bnyro
                   ` (16 more replies)
  0 siblings, 17 replies; 18+ messages in thread
From: Bnyro @ 2023-06-01 13:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 998 bytes --]

There is a new pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages linux-wifi-hotspot
https://github.com/void-linux/void-packages/pull/44210

New package: linux-wifi-hotspot-4.5.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`linux-wifi-hotspot` is the successor of `create_ap`, which got discontinued in 2021.
`linux-wifi-hotspot` additionally provides a gtk interface for creating hotspots, but it does contain a more updated version of `create_ap` too.


A patch file from https://github.com/void-linux/void-packages/pull/44210.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-linux-wifi-hotspot-44210.patch --]
[-- Type: text/x-diff, Size: 1322 bytes --]

From 6335aa6c84b1efc2243cc5d1c42c71b69712ced4 Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Thu, 1 Jun 2023 14:57:06 +0200
Subject: [PATCH] New package: linux-wifi-hotspot-4.5.0

---
 srcpkgs/linux-wifi-hotspot/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/linux-wifi-hotspot/template

diff --git a/srcpkgs/linux-wifi-hotspot/template b/srcpkgs/linux-wifi-hotspot/template
new file mode 100644
index 000000000000..6bc407c54c6b
--- /dev/null
+++ b/srcpkgs/linux-wifi-hotspot/template
@@ -0,0 +1,23 @@
+# Template file for 'linux-wifi-hotspot'
+pkgname=linux-wifi-hotspot
+version=4.5.0
+revision=1
+build_style=gnu-configure
+hostmakedepends="pkg-config which glib-devel"
+makedepends="gtk+3-devel libpng-devel qrencode-devel"
+depends="gtk+3 bash dnsmasq hostapd iproute2 iptables iw procps-ng util-linux"
+short_desc="Feature-rich wifi hotspot creator"
+maintainer="Bnyro <bnyro@tutanota.com>"
+license="BSD-2-Clause"
+homepage="https://github.com/lakinduakash/linux-wifi-hotspot"
+distfiles="https://github.com/lakinduakash/linux-wifi-hotspot/archive/refs/tags/v${version}.tar.gz"
+checksum=9e4222b7d3129347b01eef711911ec87c9a04e20efd12d88565f682a14eb91da
+conflicts="create_ap"
+
+do_configure() {
+	:
+}
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Updated] New package: linux-wifi-hotspot-4.5.0
  2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
@ 2023-06-01 13:05 ` Bnyro
  2023-06-01 13:07 ` Bnyro
                   ` (15 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Bnyro @ 2023-06-01 13:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

There is an updated pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages linux-wifi-hotspot
https://github.com/void-linux/void-packages/pull/44210

New package: linux-wifi-hotspot-4.5.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`linux-wifi-hotspot` is the successor of `create_ap`, which got discontinued in 2021.
`linux-wifi-hotspot` additionally provides a gtk interface for creating hotspots, but it does contain a more updated version of `create_ap` too.


A patch file from https://github.com/void-linux/void-packages/pull/44210.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-linux-wifi-hotspot-44210.patch --]
[-- Type: text/x-diff, Size: 1344 bytes --]

From fefcc8a42a444be276898b4d2d2504b27dbf88c6 Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Thu, 1 Jun 2023 15:05:32 +0200
Subject: [PATCH] New package: linux-wifi-hotspot-4.5.0

---
 srcpkgs/linux-wifi-hotspot/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/linux-wifi-hotspot/template

diff --git a/srcpkgs/linux-wifi-hotspot/template b/srcpkgs/linux-wifi-hotspot/template
new file mode 100644
index 000000000000..6649fafa4411
--- /dev/null
+++ b/srcpkgs/linux-wifi-hotspot/template
@@ -0,0 +1,24 @@
+# Template file for 'linux-wifi-hotspot'
+pkgname=linux-wifi-hotspot
+version=4.5.0
+revision=1
+archs="i686 x86_64"
+build_style=gnu-configure
+hostmakedepends="pkg-config which glib-devel"
+makedepends="gtk+3-devel libpng-devel qrencode-devel"
+depends="gtk+3 bash dnsmasq hostapd iproute2 iptables iw procps-ng util-linux"
+short_desc="Feature-rich wifi hotspot creator"
+maintainer="Bnyro <bnyro@tutanota.com>"
+license="BSD-2-Clause"
+homepage="https://github.com/lakinduakash/linux-wifi-hotspot"
+distfiles="https://github.com/lakinduakash/linux-wifi-hotspot/archive/refs/tags/v${version}.tar.gz"
+checksum=9e4222b7d3129347b01eef711911ec87c9a04e20efd12d88565f682a14eb91da
+conflicts="create_ap"
+
+do_configure() {
+	:
+}
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Updated] New package: linux-wifi-hotspot-4.5.0
  2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
  2023-06-01 13:05 ` [PR PATCH] [Updated] " Bnyro
@ 2023-06-01 13:07 ` Bnyro
  2023-06-01 13:36 ` [PR REVIEW] " Duncaen
                   ` (14 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Bnyro @ 2023-06-01 13:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

There is an updated pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages linux-wifi-hotspot
https://github.com/void-linux/void-packages/pull/44210

New package: linux-wifi-hotspot-4.5.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`linux-wifi-hotspot` is the successor of `create_ap`, which got discontinued in 2021.
`linux-wifi-hotspot` additionally provides a gtk interface for creating hotspots, but it does contain a more updated version of `create_ap` too.


A patch file from https://github.com/void-linux/void-packages/pull/44210.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-linux-wifi-hotspot-44210.patch --]
[-- Type: text/x-diff, Size: 1356 bytes --]

From ce4eb01486e1aa23f8974abd72847e72377d2f2a Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Thu, 1 Jun 2023 15:08:06 +0200
Subject: [PATCH] New package: linux-wifi-hotspot-4.5.0

---
 srcpkgs/linux-wifi-hotspot/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/linux-wifi-hotspot/template

diff --git a/srcpkgs/linux-wifi-hotspot/template b/srcpkgs/linux-wifi-hotspot/template
new file mode 100644
index 000000000000..990ff83a7bbd
--- /dev/null
+++ b/srcpkgs/linux-wifi-hotspot/template
@@ -0,0 +1,24 @@
+# Template file for 'linux-wifi-hotspot'
+pkgname=linux-wifi-hotspot
+version=4.5.0
+revision=1
+archs="i686 x86_64 x86_64-musl"
+build_style=gnu-configure
+hostmakedepends="pkg-config which glib-devel"
+makedepends="gtk+3-devel libpng-devel qrencode-devel"
+depends="gtk+3 bash dnsmasq hostapd iproute2 iptables iw procps-ng util-linux"
+short_desc="Feature-rich wifi hotspot creator"
+maintainer="Bnyro <bnyro@tutanota.com>"
+license="BSD-2-Clause"
+homepage="https://github.com/lakinduakash/linux-wifi-hotspot"
+distfiles="https://github.com/lakinduakash/linux-wifi-hotspot/archive/refs/tags/v${version}.tar.gz"
+checksum=9e4222b7d3129347b01eef711911ec87c9a04e20efd12d88565f682a14eb91da
+conflicts="create_ap"
+
+do_configure() {
+	:
+}
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: linux-wifi-hotspot-4.5.0
  2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
  2023-06-01 13:05 ` [PR PATCH] [Updated] " Bnyro
  2023-06-01 13:07 ` Bnyro
@ 2023-06-01 13:36 ` Duncaen
  2023-06-01 13:38 ` Duncaen
                   ` (13 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Duncaen @ 2023-06-01 13:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44210#discussion_r1213169236

Comment:
This probably shouldn't restrict the architectures, what is the reason?

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: linux-wifi-hotspot-4.5.0
  2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
                   ` (2 preceding siblings ...)
  2023-06-01 13:36 ` [PR REVIEW] " Duncaen
@ 2023-06-01 13:38 ` Duncaen
  2023-06-01 13:53 ` Bnyro
                   ` (12 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Duncaen @ 2023-06-01 13:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44210#discussion_r1213170921

Comment:
Not sure why you use the `gnu-configure` build style and set an empty `do_configure`. This should probably use `build_style=gnu-makefile` instead.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: linux-wifi-hotspot-4.5.0
  2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
                   ` (3 preceding siblings ...)
  2023-06-01 13:38 ` Duncaen
@ 2023-06-01 13:53 ` Bnyro
  2023-06-01 13:54 ` Bnyro
                   ` (11 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Bnyro @ 2023-06-01 13:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/44210#discussion_r1213194116

Comment:
When using gnu-makefile as build style, the builds failed with the reason that <gtk/gtk.h> wasn't found. Somehow it works with gnu-configure.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: linux-wifi-hotspot-4.5.0
  2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
                   ` (4 preceding siblings ...)
  2023-06-01 13:53 ` Bnyro
@ 2023-06-01 13:54 ` Bnyro
  2023-06-01 14:21 ` Duncaen
                   ` (10 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Bnyro @ 2023-06-01 13:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/44210#discussion_r1213195557

Comment:
The CI failed for the other architectures, I think it was something that an X11 C library wasn't found

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: linux-wifi-hotspot-4.5.0
  2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
                   ` (5 preceding siblings ...)
  2023-06-01 13:54 ` Bnyro
@ 2023-06-01 14:21 ` Duncaen
  2023-06-01 14:34 ` Duncaen
                   ` (9 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Duncaen @ 2023-06-01 14:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44210#discussion_r1213237106

Comment:
Then its most like an issue with cross compiling which should be expressed with `nocross="reason"` and not by restricting architectures, but the letting the CI fail so other can look at it and suggest a change can be helpful.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: New package: linux-wifi-hotspot-4.5.0
  2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
                   ` (6 preceding siblings ...)
  2023-06-01 14:21 ` Duncaen
@ 2023-06-01 14:34 ` Duncaen
  2023-06-01 14:34 ` Duncaen
                   ` (8 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Duncaen @ 2023-06-01 14:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2239 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44210#issuecomment-1572173879

Comment:
With this patch everything including cross builds work, the `gtk+3` dependency is added automatically since it links libgtk. 
```
diff --git a/srcpkgs/linux-wifi-hotspot/patches/makefile.patch b/srcpkgs/linux-wifi-hotspot/patches/makefile.patch
new file mode 100644
index 0000000000..aab21f83ce
--- /dev/null
+++ b/srcpkgs/linux-wifi-hotspot/patches/makefile.patch
@@ -0,0 +1,24 @@
+--- a/src/Makefile
++++ b/src/Makefile
+@@ -1,7 +1,7 @@
+ CC=gcc
+ PKGCONFIG = $(shell which pkg-config)
+
+-CFLAGS=`pkg-config --cflags gtk+-3.0`
++CFLAGS_PKGCONF=`pkg-config --cflags gtk+-3.0`
+ LIBS=`pkg-config --libs gtk+-3.0 --libs x11` -lstdc++ -lpng -lqrencode
+
+ APP_NAME="wihotspot"
+@@ -32,10 +32,10 @@
+       @$(MAKE) -f $(THIS_FILE) wihotspot-gui
+
+ $(ODIR)/%.o: ui/%.c
+-      $(CC) -c -o $@ $< $(CFLAGS)
++      $(CC) -c -o $@ $< $(CFLAGS) $(CFLAGS_PKGCONF)
+
+ $(ODIR)/%.o: ui/%.cpp
+-      g++ -c -o $@ $<
++      $(CXX) -c -o $@ $< $(CFLAGS)
+
+ wihotspot-gui: $(OBJ)
+       $(CC) -o $(ODIR)/$@ $^ $(CFLAGS) $(LIBS)
diff --git a/srcpkgs/linux-wifi-hotspot/template b/srcpkgs/linux-wifi-hotspot/template
index 990ff83a7b..a2c03b2682 100644
--- a/srcpkgs/linux-wifi-hotspot/template
+++ b/srcpkgs/linux-wifi-hotspot/template
@@ -2,11 +2,10 @@
 pkgname=linux-wifi-hotspot
 version=4.5.0
 revision=1
-archs="i686 x86_64 x86_64-musl"
-build_style=gnu-configure
+build_style=gnu-makefile
 hostmakedepends="pkg-config which glib-devel"
 makedepends="gtk+3-devel libpng-devel qrencode-devel"
-depends="gtk+3 bash dnsmasq hostapd iproute2 iptables iw procps-ng util-linux"
+depends="bash dnsmasq hostapd iproute2 iptables iw procps-ng util-linux"
 short_desc="Feature-rich wifi hotspot creator"
 maintainer="Bnyro <bnyro@tutanota.com>"
 license="BSD-2-Clause"
@@ -15,10 +14,6 @@ distfiles="https://github.com/lakinduakash/linux-wifi-hotspot/archive/refs/tags/
 checksum=9e4222b7d3129347b01eef711911ec87c9a04e20efd12d88565f682a14eb91da
 conflicts="create_ap"

-do_configure() {
-       :
-}
-
 post_install() {
        vlicense LICENSE
 }
```

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: New package: linux-wifi-hotspot-4.5.0
  2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
                   ` (7 preceding siblings ...)
  2023-06-01 14:34 ` Duncaen
@ 2023-06-01 14:34 ` Duncaen
  2023-06-01 15:42 ` [PR PATCH] [Updated] " Bnyro
                   ` (7 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Duncaen @ 2023-06-01 14:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2243 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44210#issuecomment-1572173879

Comment:
With this patch everything including cross builds work, the `gtk+3` dependency is added automatically since it links libgtk. 
```diff
diff --git a/srcpkgs/linux-wifi-hotspot/patches/makefile.patch b/srcpkgs/linux-wifi-hotspot/patches/makefile.patch
new file mode 100644
index 0000000000..aab21f83ce
--- /dev/null
+++ b/srcpkgs/linux-wifi-hotspot/patches/makefile.patch
@@ -0,0 +1,24 @@
+--- a/src/Makefile
++++ b/src/Makefile
+@@ -1,7 +1,7 @@
+ CC=gcc
+ PKGCONFIG = $(shell which pkg-config)
+
+-CFLAGS=`pkg-config --cflags gtk+-3.0`
++CFLAGS_PKGCONF=`pkg-config --cflags gtk+-3.0`
+ LIBS=`pkg-config --libs gtk+-3.0 --libs x11` -lstdc++ -lpng -lqrencode
+
+ APP_NAME="wihotspot"
+@@ -32,10 +32,10 @@
+       @$(MAKE) -f $(THIS_FILE) wihotspot-gui
+
+ $(ODIR)/%.o: ui/%.c
+-      $(CC) -c -o $@ $< $(CFLAGS)
++      $(CC) -c -o $@ $< $(CFLAGS) $(CFLAGS_PKGCONF)
+
+ $(ODIR)/%.o: ui/%.cpp
+-      g++ -c -o $@ $<
++      $(CXX) -c -o $@ $< $(CFLAGS)
+
+ wihotspot-gui: $(OBJ)
+       $(CC) -o $(ODIR)/$@ $^ $(CFLAGS) $(LIBS)
diff --git a/srcpkgs/linux-wifi-hotspot/template b/srcpkgs/linux-wifi-hotspot/template
index 990ff83a7b..a2c03b2682 100644
--- a/srcpkgs/linux-wifi-hotspot/template
+++ b/srcpkgs/linux-wifi-hotspot/template
@@ -2,11 +2,10 @@
 pkgname=linux-wifi-hotspot
 version=4.5.0
 revision=1
-archs="i686 x86_64 x86_64-musl"
-build_style=gnu-configure
+build_style=gnu-makefile
 hostmakedepends="pkg-config which glib-devel"
 makedepends="gtk+3-devel libpng-devel qrencode-devel"
-depends="gtk+3 bash dnsmasq hostapd iproute2 iptables iw procps-ng util-linux"
+depends="bash dnsmasq hostapd iproute2 iptables iw procps-ng util-linux"
 short_desc="Feature-rich wifi hotspot creator"
 maintainer="Bnyro <bnyro@tutanota.com>"
 license="BSD-2-Clause"
@@ -15,10 +14,6 @@ distfiles="https://github.com/lakinduakash/linux-wifi-hotspot/archive/refs/tags/
 checksum=9e4222b7d3129347b01eef711911ec87c9a04e20efd12d88565f682a14eb91da
 conflicts="create_ap"

-do_configure() {
-       :
-}
-
 post_install() {
        vlicense LICENSE
 }
```

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Updated] New package: linux-wifi-hotspot-4.5.0
  2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
                   ` (8 preceding siblings ...)
  2023-06-01 14:34 ` Duncaen
@ 2023-06-01 15:42 ` Bnyro
  2023-06-01 15:43 ` Bnyro
                   ` (6 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Bnyro @ 2023-06-01 15:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

There is an updated pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages linux-wifi-hotspot
https://github.com/void-linux/void-packages/pull/44210

New package: linux-wifi-hotspot-4.5.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`linux-wifi-hotspot` is the successor of `create_ap`, which got discontinued in 2021.
`linux-wifi-hotspot` additionally provides a gtk interface for creating hotspots, but it does contain a more updated version of `create_ap` too.


A patch file from https://github.com/void-linux/void-packages/pull/44210.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-linux-wifi-hotspot-44210.patch --]
[-- Type: text/x-diff, Size: 2385 bytes --]

From 812da012d47c8236464377474331d4177d2514c9 Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Thu, 1 Jun 2023 17:42:52 +0200
Subject: [PATCH] New package: linux-wifi-hotspot-4.5.0

---
 .../linux-wifi-hotspot/patches/makefile.patch | 24 +++++++++++++++++++
 srcpkgs/linux-wifi-hotspot/template           | 19 +++++++++++++++
 2 files changed, 43 insertions(+)
 create mode 100644 srcpkgs/linux-wifi-hotspot/patches/makefile.patch
 create mode 100644 srcpkgs/linux-wifi-hotspot/template

diff --git a/srcpkgs/linux-wifi-hotspot/patches/makefile.patch b/srcpkgs/linux-wifi-hotspot/patches/makefile.patch
new file mode 100644
index 000000000000..9391043aae17
--- /dev/null
+++ b/srcpkgs/linux-wifi-hotspot/patches/makefile.patch
@@ -0,0 +1,24 @@
+--- a/src/Makefile
++++ b/src/Makefile
+@@ -1,7 +1,7 @@
+ CC=gcc
+ PKGCONFIG = $(shell which pkg-config)
+
+-CFLAGS=`pkg-config --cflags gtk+-3.0`
++CFLAGS_PKGCONF=`pkg-config --cflags gtk+-3.0`
+ LIBS=`pkg-config --libs gtk+-3.0 --libs x11` -lstdc++ -lpng -lqrencode
+
+ APP_NAME="wihotspot"
+@@ -32,10 +32,10 @@ resources.c: ui/glade/wifih.gresource.xml ui/glade/wifih.ui
+ 	@$(MAKE) -f $(THIS_FILE) wihotspot-gui
+
+ $(ODIR)/%.o: ui/%.c
+-	$(CC) -c -o $@ $< $(CFLAGS)
++	$(CC) -c -o $@ $< $(CFLAGS) $(CFLAGS_PKGCONF)
+
+ $(ODIR)/%.o: ui/%.cpp
+-	g++ -c -o $@ $<
++	$(CXX) -c -o $@ $< $(CFLAGS)
+
+ wihotspot-gui: $(OBJ)
+ 	$(CC) -o $(ODIR)/$@ $^ $(CFLAGS) $(LIBS)
\ No newline at end of file
diff --git a/srcpkgs/linux-wifi-hotspot/template b/srcpkgs/linux-wifi-hotspot/template
new file mode 100644
index 000000000000..a2c03b268264
--- /dev/null
+++ b/srcpkgs/linux-wifi-hotspot/template
@@ -0,0 +1,19 @@
+# Template file for 'linux-wifi-hotspot'
+pkgname=linux-wifi-hotspot
+version=4.5.0
+revision=1
+build_style=gnu-makefile
+hostmakedepends="pkg-config which glib-devel"
+makedepends="gtk+3-devel libpng-devel qrencode-devel"
+depends="bash dnsmasq hostapd iproute2 iptables iw procps-ng util-linux"
+short_desc="Feature-rich wifi hotspot creator"
+maintainer="Bnyro <bnyro@tutanota.com>"
+license="BSD-2-Clause"
+homepage="https://github.com/lakinduakash/linux-wifi-hotspot"
+distfiles="https://github.com/lakinduakash/linux-wifi-hotspot/archive/refs/tags/v${version}.tar.gz"
+checksum=9e4222b7d3129347b01eef711911ec87c9a04e20efd12d88565f682a14eb91da
+conflicts="create_ap"
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: New package: linux-wifi-hotspot-4.5.0
  2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
                   ` (9 preceding siblings ...)
  2023-06-01 15:42 ` [PR PATCH] [Updated] " Bnyro
@ 2023-06-01 15:43 ` Bnyro
  2023-06-08 14:43 ` unrealjo
                   ` (5 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Bnyro @ 2023-06-01 15:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/44210#issuecomment-1572296809

Comment:
You're awesome, thank you!

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: New package: linux-wifi-hotspot-4.5.0
  2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
                   ` (10 preceding siblings ...)
  2023-06-01 15:43 ` Bnyro
@ 2023-06-08 14:43 ` unrealjo
  2023-06-08 15:35 ` [PR REVIEW] " Duncaen
                   ` (4 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: unrealjo @ 2023-06-08 14:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New comment by unrealjo on void-packages repository

https://github.com/void-linux/void-packages/pull/44210#issuecomment-1582722643

Comment:
@Duncaen , I've tested the changes locally on (x86_64-glibc) and everything is working as intended. Ready for merge. Great job!

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: linux-wifi-hotspot-4.5.0
  2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
                   ` (11 preceding siblings ...)
  2023-06-08 14:43 ` unrealjo
@ 2023-06-08 15:35 ` Duncaen
  2023-06-08 15:40 ` [PR PATCH] [Updated] " Bnyro
                   ` (3 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Duncaen @ 2023-06-08 15:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44210#discussion_r1223222658

Comment:
My bad could you please change this `CFLAGS` to `CXXFLAGS`.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Updated] New package: linux-wifi-hotspot-4.5.0
  2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
                   ` (12 preceding siblings ...)
  2023-06-08 15:35 ` [PR REVIEW] " Duncaen
@ 2023-06-08 15:40 ` Bnyro
  2023-06-08 20:16 ` [PR REVIEW] " unrealjo
                   ` (2 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Bnyro @ 2023-06-08 15:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

There is an updated pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages linux-wifi-hotspot
https://github.com/void-linux/void-packages/pull/44210

New package: linux-wifi-hotspot-4.5.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`linux-wifi-hotspot` is the successor of `create_ap`, which got discontinued in 2021.
`linux-wifi-hotspot` additionally provides a gtk interface for creating hotspots, but it does contain a more updated version of `create_ap` too.


A patch file from https://github.com/void-linux/void-packages/pull/44210.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-linux-wifi-hotspot-44210.patch --]
[-- Type: text/x-diff, Size: 2387 bytes --]

From 35ec57a79b9a2285008bd24fbb892794c0b7e90a Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Thu, 8 Jun 2023 17:41:04 +0200
Subject: [PATCH] New package: linux-wifi-hotspot-4.5.0

---
 .../linux-wifi-hotspot/patches/makefile.patch | 24 +++++++++++++++++++
 srcpkgs/linux-wifi-hotspot/template           | 19 +++++++++++++++
 2 files changed, 43 insertions(+)
 create mode 100644 srcpkgs/linux-wifi-hotspot/patches/makefile.patch
 create mode 100644 srcpkgs/linux-wifi-hotspot/template

diff --git a/srcpkgs/linux-wifi-hotspot/patches/makefile.patch b/srcpkgs/linux-wifi-hotspot/patches/makefile.patch
new file mode 100644
index 000000000000..7f1eecea7b75
--- /dev/null
+++ b/srcpkgs/linux-wifi-hotspot/patches/makefile.patch
@@ -0,0 +1,24 @@
+--- a/src/Makefile
++++ b/src/Makefile
+@@ -1,7 +1,7 @@
+ CC=gcc
+ PKGCONFIG = $(shell which pkg-config)
+
+-CFLAGS=`pkg-config --cflags gtk+-3.0`
++CFLAGS_PKGCONF=`pkg-config --cflags gtk+-3.0`
+ LIBS=`pkg-config --libs gtk+-3.0 --libs x11` -lstdc++ -lpng -lqrencode
+
+ APP_NAME="wihotspot"
+@@ -32,10 +32,10 @@ resources.c: ui/glade/wifih.gresource.xml ui/glade/wifih.ui
+ 	@$(MAKE) -f $(THIS_FILE) wihotspot-gui
+
+ $(ODIR)/%.o: ui/%.c
+-	$(CC) -c -o $@ $< $(CFLAGS)
++	$(CC) -c -o $@ $< $(CFLAGS) $(CFLAGS_PKGCONF)
+
+ $(ODIR)/%.o: ui/%.cpp
+-	g++ -c -o $@ $<
++	$(CXX) -c -o $@ $< $(CXXFLAGS)
+
+ wihotspot-gui: $(OBJ)
+ 	$(CC) -o $(ODIR)/$@ $^ $(CFLAGS) $(LIBS)
\ No newline at end of file
diff --git a/srcpkgs/linux-wifi-hotspot/template b/srcpkgs/linux-wifi-hotspot/template
new file mode 100644
index 000000000000..a2c03b268264
--- /dev/null
+++ b/srcpkgs/linux-wifi-hotspot/template
@@ -0,0 +1,19 @@
+# Template file for 'linux-wifi-hotspot'
+pkgname=linux-wifi-hotspot
+version=4.5.0
+revision=1
+build_style=gnu-makefile
+hostmakedepends="pkg-config which glib-devel"
+makedepends="gtk+3-devel libpng-devel qrencode-devel"
+depends="bash dnsmasq hostapd iproute2 iptables iw procps-ng util-linux"
+short_desc="Feature-rich wifi hotspot creator"
+maintainer="Bnyro <bnyro@tutanota.com>"
+license="BSD-2-Clause"
+homepage="https://github.com/lakinduakash/linux-wifi-hotspot"
+distfiles="https://github.com/lakinduakash/linux-wifi-hotspot/archive/refs/tags/v${version}.tar.gz"
+checksum=9e4222b7d3129347b01eef711911ec87c9a04e20efd12d88565f682a14eb91da
+conflicts="create_ap"
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: linux-wifi-hotspot-4.5.0
  2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
                   ` (13 preceding siblings ...)
  2023-06-08 15:40 ` [PR PATCH] [Updated] " Bnyro
@ 2023-06-08 20:16 ` unrealjo
  2023-06-08 20:26 ` unrealjo
  2023-06-15 18:35 ` [PR PATCH] [Merged]: " Duncaen
  16 siblings, 0 replies; 18+ messages in thread
From: unrealjo @ 2023-06-08 20:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

New review comment by unrealjo on void-packages repository

https://github.com/void-linux/void-packages/pull/44210#discussion_r1223506246

Comment:
After testing those changes It compiles just fine, but after creating an access point it failed to start .
I would suggest reverting back to previous flags .

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] New package: linux-wifi-hotspot-4.5.0
  2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
                   ` (14 preceding siblings ...)
  2023-06-08 20:16 ` [PR REVIEW] " unrealjo
@ 2023-06-08 20:26 ` unrealjo
  2023-06-15 18:35 ` [PR PATCH] [Merged]: " Duncaen
  16 siblings, 0 replies; 18+ messages in thread
From: unrealjo @ 2023-06-08 20:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

New review comment by unrealjo on void-packages repository

https://github.com/void-linux/void-packages/pull/44210#discussion_r1223506246

Comment:
After testing those changes It compiles just fine, but after creating an access point it failed to start .
I would suggest reverting back to previous flags .

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Merged]: New package: linux-wifi-hotspot-4.5.0
  2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
                   ` (15 preceding siblings ...)
  2023-06-08 20:26 ` unrealjo
@ 2023-06-15 18:35 ` Duncaen
  16 siblings, 0 replies; 18+ messages in thread
From: Duncaen @ 2023-06-15 18:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 840 bytes --]

There's a merged pull request on the void-packages repository

New package: linux-wifi-hotspot-4.5.0
https://github.com/void-linux/void-packages/pull/44210

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

`linux-wifi-hotspot` is the successor of `create_ap`, which got discontinued in 2021.
`linux-wifi-hotspot` additionally provides a gtk interface for creating hotspots, but it does contain a more updated version of `create_ap` too.


^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2023-06-15 18:35 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-01 13:00 [PR PATCH] New package: linux-wifi-hotspot-4.5.0 Bnyro
2023-06-01 13:05 ` [PR PATCH] [Updated] " Bnyro
2023-06-01 13:07 ` Bnyro
2023-06-01 13:36 ` [PR REVIEW] " Duncaen
2023-06-01 13:38 ` Duncaen
2023-06-01 13:53 ` Bnyro
2023-06-01 13:54 ` Bnyro
2023-06-01 14:21 ` Duncaen
2023-06-01 14:34 ` Duncaen
2023-06-01 14:34 ` Duncaen
2023-06-01 15:42 ` [PR PATCH] [Updated] " Bnyro
2023-06-01 15:43 ` Bnyro
2023-06-08 14:43 ` unrealjo
2023-06-08 15:35 ` [PR REVIEW] " Duncaen
2023-06-08 15:40 ` [PR PATCH] [Updated] " Bnyro
2023-06-08 20:16 ` [PR REVIEW] " unrealjo
2023-06-08 20:26 ` unrealjo
2023-06-15 18:35 ` [PR PATCH] [Merged]: " Duncaen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).