* Re: [PR REVIEW] jamulus: update to 3.9.1
2023-03-10 9:49 [PR PATCH] jamulus: update to 3.9.1 astralchan
@ 2023-03-10 19:54 ` paper42
2023-03-10 19:54 ` paper42
` (13 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: paper42 @ 2023-03-10 19:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/42687#discussion_r1132818160
Comment:
```suggestion
homepage="https://jamulus.io"
changelog="https://raw.githubusercontent.com/jamulussoftware/jamulus/main/ChangeLog"
```
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] jamulus: update to 3.9.1
2023-03-10 9:49 [PR PATCH] jamulus: update to 3.9.1 astralchan
2023-03-10 19:54 ` [PR REVIEW] " paper42
@ 2023-03-10 19:54 ` paper42
2023-03-11 1:20 ` astralchan
` (12 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: paper42 @ 2023-03-10 19:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 269 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/42687#discussion_r1132817986
Comment:
and remove $_version
```suggestion
distfiles="https://github.com/corrados/jamulus/archive/r${version//./_}.tar.gz"
```
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] jamulus: update to 3.9.1
2023-03-10 9:49 [PR PATCH] jamulus: update to 3.9.1 astralchan
2023-03-10 19:54 ` [PR REVIEW] " paper42
2023-03-10 19:54 ` paper42
@ 2023-03-11 1:20 ` astralchan
2023-03-11 1:26 ` [PR PATCH] [Updated] " astralchan
` (11 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: astralchan @ 2023-03-11 1:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 174 bytes --]
New review comment by astralchan on void-packages repository
https://github.com/void-linux/void-packages/pull/42687#discussion_r1133002609
Comment:
Why remove `$_version`?
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Updated] jamulus: update to 3.9.1
2023-03-10 9:49 [PR PATCH] jamulus: update to 3.9.1 astralchan
` (2 preceding siblings ...)
2023-03-11 1:20 ` astralchan
@ 2023-03-11 1:26 ` astralchan
2023-03-11 1:27 ` [PR REVIEW] " astralchan
` (10 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: astralchan @ 2023-03-11 1:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
There is an updated pull request by astralchan against master on the void-packages repository
https://github.com/astralchan/void-packages jamulus
https://github.com/void-linux/void-packages/pull/42687
jamulus: update to 3.9.1
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
supersedes [#40204](https://github.com/void-linux/void-packages/pull/40204)
A patch file from https://github.com/void-linux/void-packages/pull/42687.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jamulus-42687.patch --]
[-- Type: text/x-diff, Size: 1176 bytes --]
From cbd1f5cb733a9d79a911d7f15e387e24d31c48fb Mon Sep 17 00:00:00 2001
From: astral <astral@astralchan.xyz>
Date: Fri, 10 Mar 2023 02:47:30 -0700
Subject: [PATCH] jamulus: update to 3.9.1
---
srcpkgs/jamulus/template | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/jamulus/template b/srcpkgs/jamulus/template
index db577f6dd83a..452d9d6f513d 100644
--- a/srcpkgs/jamulus/template
+++ b/srcpkgs/jamulus/template
@@ -1,6 +1,6 @@
# Template file for 'jamulus'
pkgname=jamulus
-version=3.9.0
+version=3.9.1
revision=1
_version=r${version//./_}
build_style=qmake
@@ -11,5 +11,6 @@ short_desc="Play music online. With friends. For free"
maintainer="astralchan <astral@astralchan.xyz>"
license="GPL-2.0-or-later"
homepage="https://jamulus.io"
-distfiles="https://github.com/corrados/jamulus/archive/${_version}.tar.gz"
-checksum=742b1954111c55b39ea7b2863c762d6731359e2b4793ef2409b150096fb196a5
+changelog="https://raw.githubusercontent.com/jamulussoftware/jamulus/main/ChangeLog"
+distfiles="https://github.com/jamulussoftware/jamulus/archive/${_version}.tar.gz"
+checksum=758381a92ff7b264534773b71b6bf8e098bbeb6d693efdc2916609f2ff842889
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] jamulus: update to 3.9.1
2023-03-10 9:49 [PR PATCH] jamulus: update to 3.9.1 astralchan
` (3 preceding siblings ...)
2023-03-11 1:26 ` [PR PATCH] [Updated] " astralchan
@ 2023-03-11 1:27 ` astralchan
2023-03-11 6:28 ` classabbyamp
` (9 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: astralchan @ 2023-03-11 1:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 185 bytes --]
New review comment by astralchan on void-packages repository
https://github.com/void-linux/void-packages/pull/42687#discussion_r1133004090
Comment:
Added changelog in ammended commit
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] jamulus: update to 3.9.1
2023-03-10 9:49 [PR PATCH] jamulus: update to 3.9.1 astralchan
` (4 preceding siblings ...)
2023-03-11 1:27 ` [PR REVIEW] " astralchan
@ 2023-03-11 6:28 ` classabbyamp
2023-03-11 8:26 ` astralchan
` (8 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: classabbyamp @ 2023-03-11 6:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/42687#discussion_r1133040684
Comment:
it's only used in one place
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] jamulus: update to 3.9.1
2023-03-10 9:49 [PR PATCH] jamulus: update to 3.9.1 astralchan
` (5 preceding siblings ...)
2023-03-11 6:28 ` classabbyamp
@ 2023-03-11 8:26 ` astralchan
2023-03-11 8:27 ` astralchan
` (7 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: astralchan @ 2023-03-11 8:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 250 bytes --]
New review comment by astralchan on void-packages repository
https://github.com/void-linux/void-packages/pull/42687#discussion_r1133052950
Comment:
It helps me mentally manage to expand it - even if it's just in one place. It helps me maintain it.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] jamulus: update to 3.9.1
2023-03-10 9:49 [PR PATCH] jamulus: update to 3.9.1 astralchan
` (6 preceding siblings ...)
2023-03-11 8:26 ` astralchan
@ 2023-03-11 8:27 ` astralchan
2023-03-11 8:29 ` paper42
` (6 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: astralchan @ 2023-03-11 8:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
New review comment by astralchan on void-packages repository
https://github.com/void-linux/void-packages/pull/42687#discussion_r1133052950
Comment:
It helps me mentally manage to expand it - even if it's just in one place. It helps me maintain it. It shouldn't affect package quality - it's arguably a style thing.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] jamulus: update to 3.9.1
2023-03-10 9:49 [PR PATCH] jamulus: update to 3.9.1 astralchan
` (7 preceding siblings ...)
2023-03-11 8:27 ` astralchan
@ 2023-03-11 8:29 ` paper42
2023-03-12 2:13 ` astralchan
` (5 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: paper42 @ 2023-03-11 8:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/42687#discussion_r1133053200
Comment:
It's a simple expression and it's only used in one place, when someone not familiar with the template reads it, it's not immediately obvious what $_version is, but it would be obvious if the expression was directly in $distfiles.
I am not sure how having separate $_version makes this more maintainable for you, could you explain that?
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] jamulus: update to 3.9.1
2023-03-10 9:49 [PR PATCH] jamulus: update to 3.9.1 astralchan
` (8 preceding siblings ...)
2023-03-11 8:29 ` paper42
@ 2023-03-12 2:13 ` astralchan
2023-03-12 2:19 ` astralchan
` (4 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: astralchan @ 2023-03-12 2:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 244 bytes --]
New review comment by astralchan on void-packages repository
https://github.com/void-linux/void-packages/pull/42687#discussion_r1133174298
Comment:
I like evaluating expressions then substituting them. It makes it simpler for me to maintain.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] jamulus: update to 3.9.1
2023-03-10 9:49 [PR PATCH] jamulus: update to 3.9.1 astralchan
` (9 preceding siblings ...)
2023-03-12 2:13 ` astralchan
@ 2023-03-12 2:19 ` astralchan
2023-03-12 2:21 ` astralchan
` (3 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: astralchan @ 2023-03-12 2:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 523 bytes --]
New review comment by astralchan on void-packages repository
https://github.com/void-linux/void-packages/pull/42687#discussion_r1133174298
Comment:
I like evaluating expressions then substituting them. It makes it simpler for me to maintain. Specifically, if I see a substitution inside expanded in `distfiles`, I would need to mentally expand `/./_` in the middle of a URL. This visually is confusing to me, the maintainer. If I see `_version`, I can expand to see that it would expand to `r3_9_1` then substitute that.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] jamulus: update to 3.9.1
2023-03-10 9:49 [PR PATCH] jamulus: update to 3.9.1 astralchan
` (10 preceding siblings ...)
2023-03-12 2:19 ` astralchan
@ 2023-03-12 2:21 ` astralchan
2023-06-11 2:09 ` github-actions
` (2 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: astralchan @ 2023-03-12 2:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
New review comment by astralchan on void-packages repository
https://github.com/void-linux/void-packages/pull/42687#discussion_r1133174298
Comment:
I like evaluating expressions then substituting them. It makes it simpler for me to maintain. Specifically, if I see a substitution inside expanded in `distfiles`, I would need to mentally expand `/./_` in the middle of a URL. This visually is confusing to me, the maintainer. If I see `_version`, I can expand to see that it would expand to `r3_9_1` then substitute that. Those are the mechanisms by which it makes it more maintainable for me.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: jamulus: update to 3.9.1
2023-03-10 9:49 [PR PATCH] jamulus: update to 3.9.1 astralchan
` (11 preceding siblings ...)
2023-03-12 2:21 ` astralchan
@ 2023-06-11 2:09 ` github-actions
2023-06-11 11:25 ` [PR PATCH] [Updated] " classabbyamp
2023-06-11 11:31 ` [PR PATCH] [Merged]: " classabbyamp
14 siblings, 0 replies; 22+ messages in thread
From: github-actions @ 2023-06-11 2:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/42687#issuecomment-1585973984
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Updated] jamulus: update to 3.9.1
2023-03-10 9:49 [PR PATCH] jamulus: update to 3.9.1 astralchan
` (12 preceding siblings ...)
2023-06-11 2:09 ` github-actions
@ 2023-06-11 11:25 ` classabbyamp
2023-06-11 11:31 ` [PR PATCH] [Merged]: " classabbyamp
14 siblings, 0 replies; 22+ messages in thread
From: classabbyamp @ 2023-06-11 11:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
There is an updated pull request by classabbyamp against master on the void-packages repository
https://github.com/astralchan/void-packages jamulus
https://github.com/void-linux/void-packages/pull/42687
jamulus: update to 3.9.1
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
supersedes [#40204](https://github.com/void-linux/void-packages/pull/40204)
A patch file from https://github.com/void-linux/void-packages/pull/42687.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jamulus-42687.patch --]
[-- Type: text/x-diff, Size: 1176 bytes --]
From 7eec685e28a4c06897a433a6a638378b7bb52203 Mon Sep 17 00:00:00 2001
From: astral <astral@astralchan.xyz>
Date: Fri, 10 Mar 2023 02:47:30 -0700
Subject: [PATCH] jamulus: update to 3.9.1
---
srcpkgs/jamulus/template | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/jamulus/template b/srcpkgs/jamulus/template
index db577f6dd83a..452d9d6f513d 100644
--- a/srcpkgs/jamulus/template
+++ b/srcpkgs/jamulus/template
@@ -1,6 +1,6 @@
# Template file for 'jamulus'
pkgname=jamulus
-version=3.9.0
+version=3.9.1
revision=1
_version=r${version//./_}
build_style=qmake
@@ -11,5 +11,6 @@ short_desc="Play music online. With friends. For free"
maintainer="astralchan <astral@astralchan.xyz>"
license="GPL-2.0-or-later"
homepage="https://jamulus.io"
-distfiles="https://github.com/corrados/jamulus/archive/${_version}.tar.gz"
-checksum=742b1954111c55b39ea7b2863c762d6731359e2b4793ef2409b150096fb196a5
+changelog="https://raw.githubusercontent.com/jamulussoftware/jamulus/main/ChangeLog"
+distfiles="https://github.com/jamulussoftware/jamulus/archive/${_version}.tar.gz"
+checksum=758381a92ff7b264534773b71b6bf8e098bbeb6d693efdc2916609f2ff842889
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Merged]: jamulus: update to 3.9.1
2023-03-10 9:49 [PR PATCH] jamulus: update to 3.9.1 astralchan
` (13 preceding siblings ...)
2023-06-11 11:25 ` [PR PATCH] [Updated] " classabbyamp
@ 2023-06-11 11:31 ` classabbyamp
14 siblings, 0 replies; 22+ messages in thread
From: classabbyamp @ 2023-06-11 11:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
There's a merged pull request on the void-packages repository
jamulus: update to 3.9.1
https://github.com/void-linux/void-packages/pull/42687
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
supersedes [#40204](https://github.com/void-linux/void-packages/pull/40204)
^ permalink raw reply [flat|nested] 22+ messages in thread