[PR PATCH] jamulus: update to 3.9.1

[PR PATCH] jamulus: update to 3.9.1

[astralchan]

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

There is a new pull request by astralchan against master on the void-packages repository

https://github.com/astralchan/void-packages jamulus
https://github.com/void-linux/void-packages/pull/42687

jamulus: update to 3.9.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

supersedes [#40204](https://github.com/void-linux/void-packages/pull/40204)


A patch file from https://github.com/void-linux/void-packages/pull/42687.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jamulus-42687.patch --]
[-- Type: text/x-diff, Size: 948 bytes --]

From 44a94f1d0efb10e00e2049a3e04c780a77c514a1 Mon Sep 17 00:00:00 2001
From: astral <astral@astralchan.xyz>
Date: Fri, 10 Mar 2023 02:47:30 -0700
Subject: [PATCH] jamulus: update to 3.9.1

---
 srcpkgs/jamulus/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/jamulus/template b/srcpkgs/jamulus/template
index db577f6dd83a..7e6e8289b87f 100644
--- a/srcpkgs/jamulus/template
+++ b/srcpkgs/jamulus/template
@@ -1,6 +1,6 @@
 # Template file for 'jamulus'
 pkgname=jamulus
-version=3.9.0
+version=3.9.1
 revision=1
 _version=r${version//./_}
 build_style=qmake
@@ -12,4 +12,4 @@ maintainer="astralchan <astral@astralchan.xyz>"
 license="GPL-2.0-or-later"
 homepage="https://jamulus.io"
 distfiles="https://github.com/corrados/jamulus/archive/${_version}.tar.gz"
-checksum=742b1954111c55b39ea7b2863c762d6731359e2b4793ef2409b150096fb196a5
+checksum=758381a92ff7b264534773b71b6bf8e098bbeb6d693efdc2916609f2ff842889

Re: [PR REVIEW] jamulus: update to 3.9.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42687#discussion_r1132817986

Comment:
and remove $_version
```suggestion
distfiles="https://github.com/corrados/jamulus/archive/r${version//./_}.tar.gz"
```

Re: [PR REVIEW] jamulus: update to 3.9.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42687#discussion_r1132818160

Comment:
```suggestion
homepage="https://jamulus.io"
changelog="https://raw.githubusercontent.com/jamulussoftware/jamulus/main/ChangeLog"
```

Re: [PR REVIEW] jamulus: update to 3.9.1

[astralchan]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by astralchan on void-packages repository

https://github.com/void-linux/void-packages/pull/42687#discussion_r1133002609

Comment:
Why remove `$_version`?

Re: [PR PATCH] [Updated] jamulus: update to 3.9.1

[astralchan]

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

There is an updated pull request by astralchan against master on the void-packages repository

https://github.com/astralchan/void-packages jamulus
https://github.com/void-linux/void-packages/pull/42687

jamulus: update to 3.9.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

supersedes [#40204](https://github.com/void-linux/void-packages/pull/40204)


A patch file from https://github.com/void-linux/void-packages/pull/42687.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jamulus-42687.patch --]
[-- Type: text/x-diff, Size: 1176 bytes --]

From cbd1f5cb733a9d79a911d7f15e387e24d31c48fb Mon Sep 17 00:00:00 2001
From: astral <astral@astralchan.xyz>
Date: Fri, 10 Mar 2023 02:47:30 -0700
Subject: [PATCH] jamulus: update to 3.9.1

---
 srcpkgs/jamulus/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/jamulus/template b/srcpkgs/jamulus/template
index db577f6dd83a..452d9d6f513d 100644
--- a/srcpkgs/jamulus/template
+++ b/srcpkgs/jamulus/template
@@ -1,6 +1,6 @@
 # Template file for 'jamulus'
 pkgname=jamulus
-version=3.9.0
+version=3.9.1
 revision=1
 _version=r${version//./_}
 build_style=qmake
@@ -11,5 +11,6 @@ short_desc="Play music online. With friends. For free"
 maintainer="astralchan <astral@astralchan.xyz>"
 license="GPL-2.0-or-later"
 homepage="https://jamulus.io"
-distfiles="https://github.com/corrados/jamulus/archive/${_version}.tar.gz"
-checksum=742b1954111c55b39ea7b2863c762d6731359e2b4793ef2409b150096fb196a5
+changelog="https://raw.githubusercontent.com/jamulussoftware/jamulus/main/ChangeLog"
+distfiles="https://github.com/jamulussoftware/jamulus/archive/${_version}.tar.gz"
+checksum=758381a92ff7b264534773b71b6bf8e098bbeb6d693efdc2916609f2ff842889

Re: [PR REVIEW] jamulus: update to 3.9.1

[astralchan]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New review comment by astralchan on void-packages repository

https://github.com/void-linux/void-packages/pull/42687#discussion_r1133004090

Comment:
Added changelog in ammended commit

Re: [PR REVIEW] jamulus: update to 3.9.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/42687#discussion_r1133040684

Comment:
it's only used in one place

Re: [PR REVIEW] jamulus: update to 3.9.1

[astralchan]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

New review comment by astralchan on void-packages repository

https://github.com/void-linux/void-packages/pull/42687#discussion_r1133052950

Comment:
It helps me mentally manage to expand it - even if it's just in one place. It helps me maintain it.

Re: [PR REVIEW] jamulus: update to 3.9.1

[astralchan]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

New review comment by astralchan on void-packages repository

https://github.com/void-linux/void-packages/pull/42687#discussion_r1133052950

Comment:
It helps me mentally manage to expand it - even if it's just in one place. It helps me maintain it. It shouldn't affect package quality - it's arguably a style thing.

Re: [PR REVIEW] jamulus: update to 3.9.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/42687#discussion_r1133053200

Comment:
It's a simple expression and it's only used in one place, when someone not familiar with the template reads it, it's not immediately obvious what $_version is, but it would be obvious if the expression was directly in $distfiles.
I am not sure how having separate $_version makes this more maintainable for you, could you explain that?

Re: [PR REVIEW] jamulus: update to 3.9.1

[astralchan]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New review comment by astralchan on void-packages repository

https://github.com/void-linux/void-packages/pull/42687#discussion_r1133174298

Comment:
I like evaluating expressions then substituting them. It makes it simpler for me to maintain.

Re: [PR REVIEW] jamulus: update to 3.9.1

[astralchan]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

New review comment by astralchan on void-packages repository

https://github.com/void-linux/void-packages/pull/42687#discussion_r1133174298

Comment:
I like evaluating expressions then substituting them. It makes it simpler for me to maintain. Specifically, if I see a substitution inside expanded in `distfiles`, I would need to mentally expand `/./_` in the middle of a URL. This visually is confusing to me, the maintainer. If I see `_version`, I can expand to see that it would expand to `r3_9_1` then substitute that.

Re: [PR REVIEW] jamulus: update to 3.9.1

[astralchan]

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

New review comment by astralchan on void-packages repository

https://github.com/void-linux/void-packages/pull/42687#discussion_r1133174298

Comment:
I like evaluating expressions then substituting them. It makes it simpler for me to maintain. Specifically, if I see a substitution inside expanded in `distfiles`, I would need to mentally expand `/./_` in the middle of a URL. This visually is confusing to me, the maintainer. If I see `_version`, I can expand to see that it would expand to `r3_9_1` then substitute that. Those are the mechanisms by which it makes it more maintainable for me.

Re: jamulus: update to 3.9.1

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/42687#issuecomment-1585973984

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Updated] jamulus: update to 3.9.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/astralchan/void-packages jamulus
https://github.com/void-linux/void-packages/pull/42687

jamulus: update to 3.9.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

supersedes [#40204](https://github.com/void-linux/void-packages/pull/40204)


A patch file from https://github.com/void-linux/void-packages/pull/42687.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jamulus-42687.patch --]
[-- Type: text/x-diff, Size: 1176 bytes --]

From 7eec685e28a4c06897a433a6a638378b7bb52203 Mon Sep 17 00:00:00 2001
From: astral <astral@astralchan.xyz>
Date: Fri, 10 Mar 2023 02:47:30 -0700
Subject: [PATCH] jamulus: update to 3.9.1

---
 srcpkgs/jamulus/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/jamulus/template b/srcpkgs/jamulus/template
index db577f6dd83a..452d9d6f513d 100644
--- a/srcpkgs/jamulus/template
+++ b/srcpkgs/jamulus/template
@@ -1,6 +1,6 @@
 # Template file for 'jamulus'
 pkgname=jamulus
-version=3.9.0
+version=3.9.1
 revision=1
 _version=r${version//./_}
 build_style=qmake
@@ -11,5 +11,6 @@ short_desc="Play music online. With friends. For free"
 maintainer="astralchan <astral@astralchan.xyz>"
 license="GPL-2.0-or-later"
 homepage="https://jamulus.io"
-distfiles="https://github.com/corrados/jamulus/archive/${_version}.tar.gz"
-checksum=742b1954111c55b39ea7b2863c762d6731359e2b4793ef2409b150096fb196a5
+changelog="https://raw.githubusercontent.com/jamulussoftware/jamulus/main/ChangeLog"
+distfiles="https://github.com/jamulussoftware/jamulus/archive/${_version}.tar.gz"
+checksum=758381a92ff7b264534773b71b6bf8e098bbeb6d693efdc2916609f2ff842889

Re: [PR PATCH] [Merged]: jamulus: update to 3.9.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

There's a merged pull request on the void-packages repository

jamulus: update to 3.9.1
https://github.com/void-linux/void-packages/pull/42687

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

supersedes [#40204](https://github.com/void-linux/void-packages/pull/40204)