[PR PATCH] gdm: fix language selection by ensuring LANG=GDM_LANG

[PR PATCH] gdm: fix language selection by ensuring LANG=GDM_LANG

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

There is a new pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages gdm
https://github.com/void-linux/void-packages/pull/44545

gdm: fix language selection by ensuring LANG=GDM_LANG
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44545.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gdm-44545.patch --]
[-- Type: text/x-diff, Size: 1017 bytes --]

From 4479ae617dd2a1c66aad2132448652df68cacc88 Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Tue, 20 Jun 2023 14:19:39 -0700
Subject: [PATCH] gdm: fix language selection by ensuring LANG=GDM_LANG

---
 srcpkgs/gdm/files/zz-gdm.sh | 5 +++++
 srcpkgs/gdm/template        | 2 ++
 2 files changed, 7 insertions(+)
 create mode 100644 srcpkgs/gdm/files/zz-gdm.sh

diff --git a/srcpkgs/gdm/files/zz-gdm.sh b/srcpkgs/gdm/files/zz-gdm.sh
new file mode 100644
index 000000000000..bd9b995e3f11
--- /dev/null
+++ b/srcpkgs/gdm/files/zz-gdm.sh
@@ -0,0 +1,5 @@
+# This must run after locale.sh
+
+if [ -n "$GDM_LANG" ]; then
+	export LANG="$GDM_LANG"
+fi
diff --git a/srcpkgs/gdm/template b/srcpkgs/gdm/template
index 5cdcf618cb83..d02bc3442ed8 100644
--- a/srcpkgs/gdm/template
+++ b/srcpkgs/gdm/template
@@ -56,6 +56,8 @@ post_install() {
 			vsed -i "s/pam_systemd\.so/pam_elogind.so/" "$f"
 		fi
 	done
+	vmkdir etc/profile.d
+	vinstall ${FILESDIR}/zz-gdm.sh 644 etc/profile.d
 
 	# runit service
 	vsv gdm

Re: [PR PATCH] [Updated] gdm: fix language selection by ensuring LANG=GDM_LANG

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages gdm
https://github.com/void-linux/void-packages/pull/44545

gdm: fix language selection by ensuring LANG=GDM_LANG
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44545.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gdm-44545.patch --]
[-- Type: text/x-diff, Size: 1024 bytes --]

From a3be9e9d1885891266bbc6a774ea3e04e07326b1 Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Tue, 20 Jun 2023 14:19:39 -0700
Subject: [PATCH] gdm: fix language selection by ensuring LANG equals GDM_LANG

---
 srcpkgs/gdm/files/zz-gdm.sh | 5 +++++
 srcpkgs/gdm/template        | 2 ++
 2 files changed, 7 insertions(+)
 create mode 100644 srcpkgs/gdm/files/zz-gdm.sh

diff --git a/srcpkgs/gdm/files/zz-gdm.sh b/srcpkgs/gdm/files/zz-gdm.sh
new file mode 100644
index 000000000000..bd9b995e3f11
--- /dev/null
+++ b/srcpkgs/gdm/files/zz-gdm.sh
@@ -0,0 +1,5 @@
+# This must run after locale.sh
+
+if [ -n "$GDM_LANG" ]; then
+	export LANG="$GDM_LANG"
+fi
diff --git a/srcpkgs/gdm/template b/srcpkgs/gdm/template
index 5cdcf618cb83..d02bc3442ed8 100644
--- a/srcpkgs/gdm/template
+++ b/srcpkgs/gdm/template
@@ -56,6 +56,8 @@ post_install() {
 			vsed -i "s/pam_systemd\.so/pam_elogind.so/" "$f"
 		fi
 	done
+	vmkdir etc/profile.d
+	vinstall ${FILESDIR}/zz-gdm.sh 644 etc/profile.d
 
 	# runit service
 	vsv gdm

Re: gdm: fix language selection by ensuring LANG equals GDM_LANG

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/44545#issuecomment-1724709554

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: gdm: fix language selection by ensuring LANG equals GDM_LANG

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 146 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/44545#issuecomment-1724720380

Comment:
bump

Re: [PR REVIEW] gdm: fix language selection by ensuring LANG equals GDM_LANG

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/44545#discussion_r1334799755

Comment:
```suggestion
## This must run after locale.sh ##
# GDM expects that the shell will respect what it sets in LANG, but login 
# shells will overwrite any locale information based on the contents of
# /etc/locale.conf. Because GDM also sets GDM_LANG to its desired language, we
# can just force the value here after locale.conf has been parsed.
```

Re: [PR REVIEW] gdm: fix language selection by ensuring LANG equals GDM_LANG

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/44545#discussion_r1334800192

Comment:
Maybe call this `zz-gdm-lang.sh` to make it a bit more obvious from the name what it's doing?

Re: gdm: fix language selection by ensuring LANG equals GDM_LANG

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/44545#issuecomment-1867128024

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Updated] gdm: fix language selection by ensuring LANG equals GDM_LANG

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages gdm
https://github.com/void-linux/void-packages/pull/44545

gdm: fix language selection by ensuring LANG equals GDM_LANG
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44545.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gdm-44545.patch --]
[-- Type: text/x-diff, Size: 1063 bytes --]

From 324bb586e00ad12c21e670819ea6a6b372bd125e Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Tue, 20 Jun 2023 14:19:39 -0700
Subject: [PATCH] gdm: fix language selection by ensuring LANG equals GDM_LANG

---
 srcpkgs/gdm/files/zz-gdm-lang.sh | 5 +++++
 srcpkgs/gdm/template             | 2 ++
 2 files changed, 7 insertions(+)
 create mode 100644 srcpkgs/gdm/files/zz-gdm-lang.sh

diff --git a/srcpkgs/gdm/files/zz-gdm-lang.sh b/srcpkgs/gdm/files/zz-gdm-lang.sh
new file mode 100644
index 0000000000000..bd9b995e3f117
--- /dev/null
+++ b/srcpkgs/gdm/files/zz-gdm-lang.sh
@@ -0,0 +1,5 @@
+# This must run after locale.sh
+
+if [ -n "$GDM_LANG" ]; then
+	export LANG="$GDM_LANG"
+fi
diff --git a/srcpkgs/gdm/template b/srcpkgs/gdm/template
index f8990839198a2..7d13c16e4b97f 100644
--- a/srcpkgs/gdm/template
+++ b/srcpkgs/gdm/template
@@ -57,6 +57,8 @@ post_install() {
 			vsed -i "s/pam_systemd\.so/pam_elogind.so/" "$f"
 		fi
 	done
+	vmkdir etc/profile.d
+	vinstall ${FILESDIR}/zz-gdm-lang.sh 644 etc/profile.d
 
 	# runit service
 	vsv gdm

Re: [PR PATCH] [Updated] gdm: fix language selection by ensuring LANG equals GDM_LANG

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages gdm
https://github.com/void-linux/void-packages/pull/44545

gdm: fix language selection by ensuring LANG equals GDM_LANG
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44545.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gdm-44545.patch --]
[-- Type: text/x-diff, Size: 1230 bytes --]

From 4a0602520c44fff54baf102060b6d18468ab756c Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Tue, 20 Jun 2023 14:19:39 -0700
Subject: [PATCH] dm: fix language selection by ensuring LANG equals GDM_LANG

---
 srcpkgs/gdm/files/zz-gdm-lang.sh | 5 +++++
 srcpkgs/gdm/template             | 4 +++-
 2 files changed, 8 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/gdm/files/zz-gdm-lang.sh

diff --git a/srcpkgs/gdm/files/zz-gdm-lang.sh b/srcpkgs/gdm/files/zz-gdm-lang.sh
new file mode 100644
index 0000000000000..bd9b995e3f117
--- /dev/null
+++ b/srcpkgs/gdm/files/zz-gdm-lang.sh
@@ -0,0 +1,5 @@
+# This must run after locale.sh
+
+if [ -n "$GDM_LANG" ]; then
+	export LANG="$GDM_LANG"
+fi
diff --git a/srcpkgs/gdm/template b/srcpkgs/gdm/template
index f8990839198a2..d5cecc755b77c 100644
--- a/srcpkgs/gdm/template
+++ b/srcpkgs/gdm/template
@@ -1,7 +1,7 @@
 # Template file for 'gdm'
 pkgname=gdm
 version=44.1
-revision=2
+revision=3
 build_helper="gir"
 build_style=meson
 configure_args="
@@ -57,6 +57,8 @@ post_install() {
 			vsed -i "s/pam_systemd\.so/pam_elogind.so/" "$f"
 		fi
 	done
+	vmkdir etc/profile.d
+	vinstall ${FILESDIR}/zz-gdm-lang.sh 644 etc/profile.d
 
 	# runit service
 	vsv gdm

Re: gdm: fix language selection by ensuring LANG equals GDM_LANG

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/44545#issuecomment-2016293797

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: gdm: fix language selection by ensuring LANG equals GDM_LANG

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

There's a closed pull request on the void-packages repository

gdm: fix language selection by ensuring LANG equals GDM_LANG
https://github.com/void-linux/void-packages/pull/44545

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->