* Re: [PR PATCH] [Updated] gdm: fix language selection by ensuring LANG=GDM_LANG
2023-06-20 21:21 [PR PATCH] gdm: fix language selection by ensuring LANG=GDM_LANG oreo639
@ 2023-06-20 21:33 ` oreo639
2023-09-19 1:45 ` gdm: fix language selection by ensuring LANG equals GDM_LANG github-actions
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: oreo639 @ 2023-06-20 21:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]
There is an updated pull request by oreo639 against master on the void-packages repository
https://github.com/oreo639/void-packages gdm
https://github.com/void-linux/void-packages/pull/44545
gdm: fix language selection by ensuring LANG=GDM_LANG
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/44545.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gdm-44545.patch --]
[-- Type: text/x-diff, Size: 1024 bytes --]
From a3be9e9d1885891266bbc6a774ea3e04e07326b1 Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Tue, 20 Jun 2023 14:19:39 -0700
Subject: [PATCH] gdm: fix language selection by ensuring LANG equals GDM_LANG
---
srcpkgs/gdm/files/zz-gdm.sh | 5 +++++
srcpkgs/gdm/template | 2 ++
2 files changed, 7 insertions(+)
create mode 100644 srcpkgs/gdm/files/zz-gdm.sh
diff --git a/srcpkgs/gdm/files/zz-gdm.sh b/srcpkgs/gdm/files/zz-gdm.sh
new file mode 100644
index 000000000000..bd9b995e3f11
--- /dev/null
+++ b/srcpkgs/gdm/files/zz-gdm.sh
@@ -0,0 +1,5 @@
+# This must run after locale.sh
+
+if [ -n "$GDM_LANG" ]; then
+ export LANG="$GDM_LANG"
+fi
diff --git a/srcpkgs/gdm/template b/srcpkgs/gdm/template
index 5cdcf618cb83..d02bc3442ed8 100644
--- a/srcpkgs/gdm/template
+++ b/srcpkgs/gdm/template
@@ -56,6 +56,8 @@ post_install() {
vsed -i "s/pam_systemd\.so/pam_elogind.so/" "$f"
fi
done
+ vmkdir etc/profile.d
+ vinstall ${FILESDIR}/zz-gdm.sh 644 etc/profile.d
# runit service
vsv gdm
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: gdm: fix language selection by ensuring LANG equals GDM_LANG
2023-06-20 21:21 [PR PATCH] gdm: fix language selection by ensuring LANG=GDM_LANG oreo639
2023-06-20 21:33 ` [PR PATCH] [Updated] " oreo639
@ 2023-09-19 1:45 ` github-actions
2023-09-19 2:00 ` oreo639
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: github-actions @ 2023-09-19 1:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/44545#issuecomment-1724709554
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: gdm: fix language selection by ensuring LANG equals GDM_LANG
2023-06-20 21:21 [PR PATCH] gdm: fix language selection by ensuring LANG=GDM_LANG oreo639
2023-06-20 21:33 ` [PR PATCH] [Updated] " oreo639
2023-09-19 1:45 ` gdm: fix language selection by ensuring LANG equals GDM_LANG github-actions
@ 2023-09-19 2:00 ` oreo639
2023-09-22 20:42 ` [PR REVIEW] " ahesford
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: oreo639 @ 2023-09-19 2:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 146 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/44545#issuecomment-1724720380
Comment:
bump
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] gdm: fix language selection by ensuring LANG equals GDM_LANG
2023-06-20 21:21 [PR PATCH] gdm: fix language selection by ensuring LANG=GDM_LANG oreo639
` (2 preceding siblings ...)
2023-09-19 2:00 ` oreo639
@ 2023-09-22 20:42 ` ahesford
2023-09-22 20:42 ` ahesford
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ahesford @ 2023-09-22 20:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 242 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/44545#discussion_r1334800192
Comment:
Maybe call this `zz-gdm-lang.sh` to make it a bit more obvious from the name what it's doing?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] gdm: fix language selection by ensuring LANG equals GDM_LANG
2023-06-20 21:21 [PR PATCH] gdm: fix language selection by ensuring LANG=GDM_LANG oreo639
` (3 preceding siblings ...)
2023-09-22 20:42 ` [PR REVIEW] " ahesford
@ 2023-09-22 20:42 ` ahesford
2023-12-22 1:46 ` github-actions
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ahesford @ 2023-09-22 20:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/44545#discussion_r1334799755
Comment:
```suggestion
## This must run after locale.sh ##
# GDM expects that the shell will respect what it sets in LANG, but login
# shells will overwrite any locale information based on the contents of
# /etc/locale.conf. Because GDM also sets GDM_LANG to its desired language, we
# can just force the value here after locale.conf has been parsed.
```
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: gdm: fix language selection by ensuring LANG equals GDM_LANG
2023-06-20 21:21 [PR PATCH] gdm: fix language selection by ensuring LANG=GDM_LANG oreo639
` (4 preceding siblings ...)
2023-09-22 20:42 ` ahesford
@ 2023-12-22 1:46 ` github-actions
2023-12-22 2:17 ` [PR PATCH] [Updated] " oreo639
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: github-actions @ 2023-12-22 1:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/44545#issuecomment-1867128024
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Updated] gdm: fix language selection by ensuring LANG equals GDM_LANG
2023-06-20 21:21 [PR PATCH] gdm: fix language selection by ensuring LANG=GDM_LANG oreo639
` (5 preceding siblings ...)
2023-12-22 1:46 ` github-actions
@ 2023-12-22 2:17 ` oreo639
2023-12-22 2:26 ` oreo639
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: oreo639 @ 2023-12-22 2:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]
There is an updated pull request by oreo639 against master on the void-packages repository
https://github.com/oreo639/void-packages gdm
https://github.com/void-linux/void-packages/pull/44545
gdm: fix language selection by ensuring LANG equals GDM_LANG
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/44545.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gdm-44545.patch --]
[-- Type: text/x-diff, Size: 1063 bytes --]
From 324bb586e00ad12c21e670819ea6a6b372bd125e Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Tue, 20 Jun 2023 14:19:39 -0700
Subject: [PATCH] gdm: fix language selection by ensuring LANG equals GDM_LANG
---
srcpkgs/gdm/files/zz-gdm-lang.sh | 5 +++++
srcpkgs/gdm/template | 2 ++
2 files changed, 7 insertions(+)
create mode 100644 srcpkgs/gdm/files/zz-gdm-lang.sh
diff --git a/srcpkgs/gdm/files/zz-gdm-lang.sh b/srcpkgs/gdm/files/zz-gdm-lang.sh
new file mode 100644
index 0000000000000..bd9b995e3f117
--- /dev/null
+++ b/srcpkgs/gdm/files/zz-gdm-lang.sh
@@ -0,0 +1,5 @@
+# This must run after locale.sh
+
+if [ -n "$GDM_LANG" ]; then
+ export LANG="$GDM_LANG"
+fi
diff --git a/srcpkgs/gdm/template b/srcpkgs/gdm/template
index f8990839198a2..7d13c16e4b97f 100644
--- a/srcpkgs/gdm/template
+++ b/srcpkgs/gdm/template
@@ -57,6 +57,8 @@ post_install() {
vsed -i "s/pam_systemd\.so/pam_elogind.so/" "$f"
fi
done
+ vmkdir etc/profile.d
+ vinstall ${FILESDIR}/zz-gdm-lang.sh 644 etc/profile.d
# runit service
vsv gdm
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Updated] gdm: fix language selection by ensuring LANG equals GDM_LANG
2023-06-20 21:21 [PR PATCH] gdm: fix language selection by ensuring LANG=GDM_LANG oreo639
` (6 preceding siblings ...)
2023-12-22 2:17 ` [PR PATCH] [Updated] " oreo639
@ 2023-12-22 2:26 ` oreo639
2024-03-23 1:44 ` github-actions
2024-04-07 1:46 ` [PR PATCH] [Closed]: " github-actions
9 siblings, 0 replies; 11+ messages in thread
From: oreo639 @ 2023-12-22 2:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]
There is an updated pull request by oreo639 against master on the void-packages repository
https://github.com/oreo639/void-packages gdm
https://github.com/void-linux/void-packages/pull/44545
gdm: fix language selection by ensuring LANG equals GDM_LANG
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/44545.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gdm-44545.patch --]
[-- Type: text/x-diff, Size: 1230 bytes --]
From 4a0602520c44fff54baf102060b6d18468ab756c Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Tue, 20 Jun 2023 14:19:39 -0700
Subject: [PATCH] dm: fix language selection by ensuring LANG equals GDM_LANG
---
srcpkgs/gdm/files/zz-gdm-lang.sh | 5 +++++
srcpkgs/gdm/template | 4 +++-
2 files changed, 8 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/gdm/files/zz-gdm-lang.sh
diff --git a/srcpkgs/gdm/files/zz-gdm-lang.sh b/srcpkgs/gdm/files/zz-gdm-lang.sh
new file mode 100644
index 0000000000000..bd9b995e3f117
--- /dev/null
+++ b/srcpkgs/gdm/files/zz-gdm-lang.sh
@@ -0,0 +1,5 @@
+# This must run after locale.sh
+
+if [ -n "$GDM_LANG" ]; then
+ export LANG="$GDM_LANG"
+fi
diff --git a/srcpkgs/gdm/template b/srcpkgs/gdm/template
index f8990839198a2..d5cecc755b77c 100644
--- a/srcpkgs/gdm/template
+++ b/srcpkgs/gdm/template
@@ -1,7 +1,7 @@
# Template file for 'gdm'
pkgname=gdm
version=44.1
-revision=2
+revision=3
build_helper="gir"
build_style=meson
configure_args="
@@ -57,6 +57,8 @@ post_install() {
vsed -i "s/pam_systemd\.so/pam_elogind.so/" "$f"
fi
done
+ vmkdir etc/profile.d
+ vinstall ${FILESDIR}/zz-gdm-lang.sh 644 etc/profile.d
# runit service
vsv gdm
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: gdm: fix language selection by ensuring LANG equals GDM_LANG
2023-06-20 21:21 [PR PATCH] gdm: fix language selection by ensuring LANG=GDM_LANG oreo639
` (7 preceding siblings ...)
2023-12-22 2:26 ` oreo639
@ 2024-03-23 1:44 ` github-actions
2024-04-07 1:46 ` [PR PATCH] [Closed]: " github-actions
9 siblings, 0 replies; 11+ messages in thread
From: github-actions @ 2024-03-23 1:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/44545#issuecomment-2016293797
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Closed]: gdm: fix language selection by ensuring LANG equals GDM_LANG
2023-06-20 21:21 [PR PATCH] gdm: fix language selection by ensuring LANG=GDM_LANG oreo639
` (8 preceding siblings ...)
2024-03-23 1:44 ` github-actions
@ 2024-04-07 1:46 ` github-actions
9 siblings, 0 replies; 11+ messages in thread
From: github-actions @ 2024-04-07 1:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]
There's a closed pull request on the void-packages repository
gdm: fix language selection by ensuring LANG equals GDM_LANG
https://github.com/void-linux/void-packages/pull/44545
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 11+ messages in thread