[PR PATCH] libspnav: update to 1.1, minor fixes

[PR PATCH] libspnav: update to 1.1, minor fixes

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 1484 bytes --]

There is a new pull request by CtrlC-Root against master on the void-packages repository

https://github.com/CtrlC-Root/void-packages update-libspnav
https://github.com/void-linux/void-packages/pull/44552

libspnav: update to 1.1, minor fixes
#### Testing the changes
- I tested the changes in this PR: **YES**

Using a SpaceMouse Pro Wireless with the latest upstream versions of `spacenavd`, `spnavcfg`, and the latest version of FreeCAD in the repository.

![libspnav-1 1-test-spacemouse-pro-wireless](https://github.com/void-linux/void-packages/assets/4819590/652ba122-021a-4f17-954d-7243073f1f2e)

#### Local build testing
- I built this PR locally for my native architecture, x86_64

#### Notes

* The upstream sources are not accessible on GitHub (for all three related packages). The 1.1 version is not on SourceForge so I switched the `distfiles` to GitHub.
* I dropped the `do_build()` section as it doesn't seem to be necessary when using the `gnu-configure` build style. If there's something I missed here for why this should be kept in please let me know.
* The library supports a non-X11 build but I'm not sure how to expose that. Does XBPS support variants like that? If it matters to someone and you can point me to the relevant documentation I would be willing to add it.
* I plan to package `spacenavd` and `spnavcfg` next which will depend on this library.


A patch file from https://github.com/void-linux/void-packages/pull/44552.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-libspnav-44552.patch --]
[-- Type: text/x-diff, Size: 1444 bytes --]

From 623d6da9024b8103ebab7b428f5f28c6c0465c5e Mon Sep 17 00:00:00 2001
From: Alexandru Barbur <alex@ctrlc.name>
Date: Wed, 21 Jun 2023 13:34:50 -0400
Subject: [PATCH] libspnav: update to 1.1, minor fixes

---
 srcpkgs/libspnav/template | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/srcpkgs/libspnav/template b/srcpkgs/libspnav/template
index 059d254e17b7..88a5c8d803a8 100644
--- a/srcpkgs/libspnav/template
+++ b/srcpkgs/libspnav/template
@@ -1,24 +1,20 @@
 # Template file for 'libspnav'
 pkgname=libspnav
-version=1.0
-revision=2
+version=1.1
+revision=1
 build_style=gnu-configure
-configure_args="--disable-opt"
 makedepends="libX11-devel"
 short_desc="Open source alternative to 3DConnextion drivers"
-maintainer="yopito <pierre.bourgin@free.fr>"
+maintainer="Alexandru Barbur <alex@ctrlc.name>"
 license="BSD-3-Clause"
 homepage="http://spacenav.sourceforge.net/"
-distfiles="${SOURCEFORGE_SITE}/spacenav/${pkgname}-${version}.tar.gz"
-checksum=8849b7f7826d750f6956cf8f4f53937f2359ab6da97d6c834c71d5f771212e7c
-
-do_build() {
-	make CC="${CC}" AR="${AR}"
-}
+distfiles="https://github.com/FreeSpacenav/libspnav/archive/refs/tags/v${version}.tar.gz"
+checksum=04b297f68a10db4fa40edf68d7f823ba7b9d0442f2b665181889abe2cea42759
 
 post_install() {
 	vlicense LICENSE
 }
+
 libspnav-devel_package() {
 	short_desc+=" - development files"
 	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"

Re: libspnav: update to 1.1, minor fixes

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44552#issuecomment-1601307430

Comment:
Should I also update this line in `common/shlibs`: https://github.com/void-linux/void-packages/blob/master/common/shlibs#L2756 ?

Re: [PR PATCH] [Updated] libspnav: update to 1.1, minor fixes

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]

There is an updated pull request by CtrlC-Root against master on the void-packages repository

https://github.com/CtrlC-Root/void-packages update-libspnav
https://github.com/void-linux/void-packages/pull/44552

libspnav: update to 1.1, minor fixes
#### Testing the changes
- I tested the changes in this PR: **YES**

Using a SpaceMouse Pro Wireless with the latest upstream versions of `spacenavd`, `spnavcfg`, and the latest version of FreeCAD in the repository.

![libspnav-1 1-test-spacemouse-pro-wireless](https://github.com/void-linux/void-packages/assets/4819590/652ba122-021a-4f17-954d-7243073f1f2e)

#### Local build testing
- I built this PR locally for my native architecture, x86_64

#### Notes

* The upstream sources are now accessible on GitHub (for all three related packages). The 1.1 version is not on SourceForge so I switched the `distfiles` to GitHub.
* I dropped the `do_build()` section as it doesn't seem to be necessary when using the `gnu-configure` build style. If there's something I missed here for why this should be kept in please let me know.
* The library supports a non-X11 build but I'm not sure how to expose that. Does XBPS support variants like that? If it matters to someone and you can point me to the relevant documentation I would be willing to add it.
* I plan to package `spacenavd` and `spnavcfg` next which will depend on this library.


A patch file from https://github.com/void-linux/void-packages/pull/44552.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-libspnav-44552.patch --]
[-- Type: text/x-diff, Size: 1438 bytes --]

From 42500af7a8a47d44c7880cc75a1bda8c94d61a2d Mon Sep 17 00:00:00 2001
From: Alexandru Barbur <alex@ctrlc.name>
Date: Wed, 21 Jun 2023 13:34:50 -0400
Subject: [PATCH] libspnav: update to 1.1, adopt

---
 srcpkgs/libspnav/template | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/srcpkgs/libspnav/template b/srcpkgs/libspnav/template
index 059d254e17b7..88a5c8d803a8 100644
--- a/srcpkgs/libspnav/template
+++ b/srcpkgs/libspnav/template
@@ -1,24 +1,20 @@
 # Template file for 'libspnav'
 pkgname=libspnav
-version=1.0
-revision=2
+version=1.1
+revision=1
 build_style=gnu-configure
-configure_args="--disable-opt"
 makedepends="libX11-devel"
 short_desc="Open source alternative to 3DConnextion drivers"
-maintainer="yopito <pierre.bourgin@free.fr>"
+maintainer="Alexandru Barbur <alex@ctrlc.name>"
 license="BSD-3-Clause"
 homepage="http://spacenav.sourceforge.net/"
-distfiles="${SOURCEFORGE_SITE}/spacenav/${pkgname}-${version}.tar.gz"
-checksum=8849b7f7826d750f6956cf8f4f53937f2359ab6da97d6c834c71d5f771212e7c
-
-do_build() {
-	make CC="${CC}" AR="${AR}"
-}
+distfiles="https://github.com/FreeSpacenav/libspnav/archive/refs/tags/v${version}.tar.gz"
+checksum=04b297f68a10db4fa40edf68d7f823ba7b9d0442f2b665181889abe2cea42759
 
 post_install() {
 	vlicense LICENSE
 }
+
 libspnav-devel_package() {
 	short_desc+=" - development files"
 	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"

Re: libspnav: update to 1.1, minor fixes

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44552#issuecomment-1601425966

Comment:
Force pushed to append `, adopt` to the commit message.

Re: [PR REVIEW] libspnav: update to 1.1, minor fixes

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44552#discussion_r1240925356

Comment:
don't adopt non-orphaned packages without asking the current maintainer (cc @yopito)

also, I'd prefer to see more contributions to the package before adopting it

Re: [PR REVIEW] libspnav: update to 1.1, minor fixes

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

New review comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44552#discussion_r1241178734

Comment:
I tried to discuss this in an issue (https://github.com/void-linux/void-packages/issues/44550) which you closed without feedback. Granted I used the wrong issue template it seems but we're talking about a few lines here so absent any guidance from you I figured we could discuss it in a PR.

I'll force push this branch in a minute to revert this. I tried to guess based on PRs you reviewed whether I'd have to adopt it for this PR to be approved and I was aiming for approval on the first review :).

Re: [PR PATCH] [Updated] libspnav: update to 1.1, minor fixes

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]

There is an updated pull request by CtrlC-Root against master on the void-packages repository

https://github.com/CtrlC-Root/void-packages update-libspnav
https://github.com/void-linux/void-packages/pull/44552

libspnav: update to 1.1, minor fixes
#### Testing the changes
- I tested the changes in this PR: **YES**

Using a SpaceMouse Pro Wireless with the latest upstream versions of `spacenavd`, `spnavcfg`, and the latest version of FreeCAD in the repository.

![libspnav-1 1-test-spacemouse-pro-wireless](https://github.com/void-linux/void-packages/assets/4819590/652ba122-021a-4f17-954d-7243073f1f2e)

#### Local build testing
- I built this PR locally for my native architecture, x86_64

#### Notes

* The upstream sources are now accessible on GitHub (for all three related packages). The 1.1 version is not on SourceForge so I switched the `distfiles` to GitHub.
* I dropped the `do_build()` section as it doesn't seem to be necessary when using the `gnu-configure` build style. If there's something I missed here for why this should be kept in please let me know.
* The library supports a non-X11 build but I'm not sure how to expose that. Does XBPS support variants like that? If it matters to someone and you can point me to the relevant documentation I would be willing to add it.
* I plan to package `spacenavd` and `spnavcfg` next which will depend on this library.


A patch file from https://github.com/void-linux/void-packages/pull/44552.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-libspnav-44552.patch --]
[-- Type: text/x-diff, Size: 1458 bytes --]

From 40656499e6869801d70e022b3e040c1b7ebe8cef Mon Sep 17 00:00:00 2001
From: Alexandru Barbur <alex@ctrlc.name>
Date: Wed, 21 Jun 2023 13:34:50 -0400
Subject: [PATCH] libspnav: update to 1.1, switch upstream to github

---
 srcpkgs/libspnav/template | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/srcpkgs/libspnav/template b/srcpkgs/libspnav/template
index 059d254e17b7..88a5c8d803a8 100644
--- a/srcpkgs/libspnav/template
+++ b/srcpkgs/libspnav/template
@@ -1,24 +1,20 @@
 # Template file for 'libspnav'
 pkgname=libspnav
-version=1.0
-revision=2
+version=1.1
+revision=1
 build_style=gnu-configure
-configure_args="--disable-opt"
 makedepends="libX11-devel"
 short_desc="Open source alternative to 3DConnextion drivers"
-maintainer="yopito <pierre.bourgin@free.fr>"
+maintainer="Alexandru Barbur <alex@ctrlc.name>"
 license="BSD-3-Clause"
 homepage="http://spacenav.sourceforge.net/"
-distfiles="${SOURCEFORGE_SITE}/spacenav/${pkgname}-${version}.tar.gz"
-checksum=8849b7f7826d750f6956cf8f4f53937f2359ab6da97d6c834c71d5f771212e7c
-
-do_build() {
-	make CC="${CC}" AR="${AR}"
-}
+distfiles="https://github.com/FreeSpacenav/libspnav/archive/refs/tags/v${version}.tar.gz"
+checksum=04b297f68a10db4fa40edf68d7f823ba7b9d0442f2b665181889abe2cea42759
 
 post_install() {
 	vlicense LICENSE
 }
+
 libspnav-devel_package() {
 	short_desc+=" - development files"
 	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"

Re: [PR REVIEW] libspnav: update to 1.1, minor fixes

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New review comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44552#discussion_r1241179279

Comment:
Reverted maintainer in https://github.com/void-linux/void-packages/commit/40656499e6869801d70e022b3e040c1b7ebe8cef

Re: libspnav: update to 1.1, minor fixes

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44552#issuecomment-1601425966

Comment:
~~Force pushed to append `, adopt` to the commit message.~~ (Reverted below).

Re: [PR PATCH] [Updated] libspnav: update to 1.1, minor fixes

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]

There is an updated pull request by CtrlC-Root against master on the void-packages repository

https://github.com/CtrlC-Root/void-packages update-libspnav
https://github.com/void-linux/void-packages/pull/44552

libspnav: update to 1.1, minor fixes
#### Testing the changes
- I tested the changes in this PR: **YES**

Using a SpaceMouse Pro Wireless with the latest upstream versions of `spacenavd`, `spnavcfg`, and the latest version of FreeCAD in the repository.

![libspnav-1 1-test-spacemouse-pro-wireless](https://github.com/void-linux/void-packages/assets/4819590/652ba122-021a-4f17-954d-7243073f1f2e)

#### Local build testing
- I built this PR locally for my native architecture, x86_64

#### Notes

* The upstream sources are now accessible on GitHub (for all three related packages). The 1.1 version is not on SourceForge so I switched the `distfiles` to GitHub.
* I dropped the `do_build()` section as it doesn't seem to be necessary when using the `gnu-configure` build style. If there's something I missed here for why this should be kept in please let me know.
* The library supports a non-X11 build but I'm not sure how to expose that. Does XBPS support variants like that? If it matters to someone and you can point me to the relevant documentation I would be willing to add it.
* I plan to package `spacenavd` and `spnavcfg` next which will depend on this library.


A patch file from https://github.com/void-linux/void-packages/pull/44552.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-libspnav-44552.patch --]
[-- Type: text/x-diff, Size: 1406 bytes --]

From e12ba9a9e6cc180f038eb1506dd2d9a1b16220eb Mon Sep 17 00:00:00 2001
From: Alexandru Barbur <alex@ctrlc.name>
Date: Wed, 21 Jun 2023 13:34:50 -0400
Subject: [PATCH] libspnav: update to 1.1, switch upstream to github

---
 srcpkgs/libspnav/template | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/srcpkgs/libspnav/template b/srcpkgs/libspnav/template
index 059d254e17b7..170a840ad618 100644
--- a/srcpkgs/libspnav/template
+++ b/srcpkgs/libspnav/template
@@ -1,24 +1,20 @@
 # Template file for 'libspnav'
 pkgname=libspnav
-version=1.0
-revision=2
+version=1.1
+revision=1
 build_style=gnu-configure
-configure_args="--disable-opt"
 makedepends="libX11-devel"
 short_desc="Open source alternative to 3DConnextion drivers"
 maintainer="yopito <pierre.bourgin@free.fr>"
 license="BSD-3-Clause"
 homepage="http://spacenav.sourceforge.net/"
-distfiles="${SOURCEFORGE_SITE}/spacenav/${pkgname}-${version}.tar.gz"
-checksum=8849b7f7826d750f6956cf8f4f53937f2359ab6da97d6c834c71d5f771212e7c
-
-do_build() {
-	make CC="${CC}" AR="${AR}"
-}
+distfiles="https://github.com/FreeSpacenav/libspnav/archive/refs/tags/v${version}.tar.gz"
+checksum=04b297f68a10db4fa40edf68d7f823ba7b9d0442f2b665181889abe2cea42759
 
 post_install() {
 	vlicense LICENSE
 }
+
 libspnav-devel_package() {
 	short_desc+=" - development files"
 	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"

Re: [PR REVIEW] libspnav: update to 1.1, minor fixes

[CtrlC-Root]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New review comment by CtrlC-Root on void-packages repository

https://github.com/void-linux/void-packages/pull/44552#discussion_r1241179279

Comment:
Reverted maintainer in https://github.com/void-linux/void-packages/commit/e12ba9a9e6cc180f038eb1506dd2d9a1b16220eb

Re: [PR PATCH] [Merged]: libspnav: update to 1.1, minor fixes

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

There's a merged pull request on the void-packages repository

libspnav: update to 1.1, minor fixes
https://github.com/void-linux/void-packages/pull/44552

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

Using a SpaceMouse Pro Wireless with the latest upstream versions of `spacenavd`, `spnavcfg`, and the latest version of FreeCAD in the repository.

![libspnav-1 1-test-spacemouse-pro-wireless](https://github.com/void-linux/void-packages/assets/4819590/652ba122-021a-4f17-954d-7243073f1f2e)

#### Local build testing
- I built this PR locally for my native architecture, x86_64

#### Notes

* The upstream sources are now accessible on GitHub (for all three related packages). The 1.1 version is not on SourceForge so I switched the `distfiles` to GitHub.
* I dropped the `do_build()` section as it doesn't seem to be necessary when using the `gnu-configure` build style. If there's something I missed here for why this should be kept in please let me know.
* The library supports a non-X11 build but I'm not sure how to expose that. Does XBPS support variants like that? If it matters to someone and you can point me to the relevant documentation I would be willing to add it.
* I plan to package `spacenavd` and `spnavcfg` next which will depend on this library.