[PR PATCH] Fix solaar udev rules

[PR PATCH] Fix solaar udev rules

[im-apbecker]

[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]

There is a new pull request by im-apbecker against master on the void-packages repository

https://github.com/im-apbecker/void-packages solaar-udev-rules
https://github.com/void-linux/void-packages/pull/49674

Fix solaar udev rules
This PR adds back in a missing udev rules file that is required for solaar to function.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


A patch file from https://github.com/void-linux/void-packages/pull/49674.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-solaar-udev-rules-49674.patch --]
[-- Type: text/x-diff, Size: 669 bytes --]

From 013f0e20576bacc5c2222f20fb5e514c89f1b192 Mon Sep 17 00:00:00 2001
From: apbecker <apbecker@protonmail.com>
Date: Tue, 2 Apr 2024 12:13:17 -0600
Subject: [PATCH] Fix solaar udev rules

---
 srcpkgs/Solaar/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/Solaar/template b/srcpkgs/Solaar/template
index 922c658f3abe86..01bb9154bd176e 100644
--- a/srcpkgs/Solaar/template
+++ b/srcpkgs/Solaar/template
@@ -17,4 +17,5 @@ checksum=2b292da8923e19a4a7a459d6fcd1119ce157cb579fd00077f87633c0dedfbba5
 
 post_install() {
 	vdoc "${FILESDIR}/README.voidlinux"
+	vinstall "rules.d/42-logitech-unify-permissions.rules" 644 /usr/share/solaar/udev-rules.d
 }

Re: [PR REVIEW] Fix solaar udev rules

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/49674#discussion_r1548614467

Comment:
why do they need to be installed to `/usr/share/solaar`? udev doesn't read that, and they are in `/usr/lib/udev/rules.d` (the proper place) already

Re: [PR REVIEW] Fix solaar udev rules

[im-apbecker]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

New review comment by im-apbecker on void-packages repository

https://github.com/void-linux/void-packages/pull/49674#discussion_r1548617298

Comment:
The included `README.voidlinux` file mentions copying (or symlinking) the file from that location.

Re: [PR REVIEW] Fix solaar udev rules

[im-apbecker]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

New review comment by im-apbecker on void-packages repository

https://github.com/void-linux/void-packages/pull/49674#discussion_r1548617298

Comment:
The included `README.voidlinux` file mentions copying (or symlinking) the file from that location. I had to get the file into `/etc/udev/rules.d` for them to be properly utilized.

Re: [PR REVIEW] Fix solaar udev rules

[im-apbecker]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

New review comment by im-apbecker on void-packages repository

https://github.com/void-linux/void-packages/pull/49674#discussion_r1548624464

Comment:
I believe I see what happened now. An earlier version of the package _did_ need a symlink or copy from `/usr/share/solaar`, and a newer version broke the link for me which caused udev to misbehave. Having removed the link entirely and reloaded the rules, things appear to be okay. Should I instead update the README to reflect the current state of the package?

Re: [PR REVIEW] Fix solaar udev rules

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/49674#discussion_r1548628052

Comment:
yes, update the README please

Re: [PR PATCH] [Updated] Fix solaar udev rules

[im-apbecker]

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

There is an updated pull request by im-apbecker against master on the void-packages repository

https://github.com/im-apbecker/void-packages solaar-udev-rules
https://github.com/void-linux/void-packages/pull/49674

Fix solaar udev rules
This PR adds back in a missing udev rules file that is required for solaar to function.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


A patch file from https://github.com/void-linux/void-packages/pull/49674.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-solaar-udev-rules-49674.patch --]
[-- Type: text/x-diff, Size: 2057 bytes --]

From 013f0e20576bacc5c2222f20fb5e514c89f1b192 Mon Sep 17 00:00:00 2001
From: apbecker <apbecker@protonmail.com>
Date: Tue, 2 Apr 2024 12:13:17 -0600
Subject: [PATCH 1/2] Fix solaar udev rules

---
 srcpkgs/Solaar/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/Solaar/template b/srcpkgs/Solaar/template
index 922c658f3abe86..01bb9154bd176e 100644
--- a/srcpkgs/Solaar/template
+++ b/srcpkgs/Solaar/template
@@ -17,4 +17,5 @@ checksum=2b292da8923e19a4a7a459d6fcd1119ce157cb579fd00077f87633c0dedfbba5
 
 post_install() {
 	vdoc "${FILESDIR}/README.voidlinux"
+	vinstall "rules.d/42-logitech-unify-permissions.rules" 644 /usr/share/solaar/udev-rules.d
 }

From cbab68e59e9328d5f88970c275a75ae6dfbe5595 Mon Sep 17 00:00:00 2001
From: apbecker <apbecker@protonmail.com>
Date: Tue, 2 Apr 2024 15:31:06 -0600
Subject: [PATCH 2/2] Update solaar's README.voidlinux

---
 srcpkgs/Solaar/files/README.voidlinux | 5 +++--
 srcpkgs/Solaar/template               | 1 -
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/Solaar/files/README.voidlinux b/srcpkgs/Solaar/files/README.voidlinux
index 7596828f668ad4..87ac51ef863e74 100644
--- a/srcpkgs/Solaar/files/README.voidlinux
+++ b/srcpkgs/Solaar/files/README.voidlinux
@@ -1,3 +1,4 @@
-To use Solaar without root privileges, copy the file
-    /usr/share/solaar/udev-rules.d/42-logitech-unify-permissions.rules
+To use Solaar without root privileges, nothing special should be required.
+If issues are encountered, try copying the file at
+    /usr/lib/udev/rules.d/42-logitech-unify-permissions.rules
 into the directory /etc/udev/rules.d/ and reload udev rules.
diff --git a/srcpkgs/Solaar/template b/srcpkgs/Solaar/template
index 01bb9154bd176e..922c658f3abe86 100644
--- a/srcpkgs/Solaar/template
+++ b/srcpkgs/Solaar/template
@@ -17,5 +17,4 @@ checksum=2b292da8923e19a4a7a459d6fcd1119ce157cb579fd00077f87633c0dedfbba5
 
 post_install() {
 	vdoc "${FILESDIR}/README.voidlinux"
-	vinstall "rules.d/42-logitech-unify-permissions.rules" 644 /usr/share/solaar/udev-rules.d
 }

Re: [PR REVIEW] Fix solaar udev rules

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/49674#discussion_r1548639429

Comment:
actually, seeing what the readme says now, I would remove that, and add an [INSTALL.msg](https://github.com/void-linux/void-packages/blob/master/Manual.md#install_remove_files_msg) that says something like:

> Previous versions of solaar required copying or symlinking udev rules to /etc/udev/rules.d.
> If this was done previously, it is recommended to remove that file or symlink.

Re: [PR PATCH] [Updated] Fix solaar udev rules

[im-apbecker]

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

There is an updated pull request by im-apbecker against master on the void-packages repository

https://github.com/im-apbecker/void-packages solaar-udev-rules
https://github.com/void-linux/void-packages/pull/49674

Fix solaar udev rules
This PR adds back in a missing udev rules file that is required for solaar to function.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


A patch file from https://github.com/void-linux/void-packages/pull/49674.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-solaar-udev-rules-49674.patch --]
[-- Type: text/x-diff, Size: 1815 bytes --]

From b88a2eeb12760dcf89d45178d10b5c274b090721 Mon Sep 17 00:00:00 2001
From: apbecker <apbecker@protonmail.com>
Date: Tue, 2 Apr 2024 12:13:17 -0600
Subject: [PATCH] Add INSTALL.msg for solaar

---
 srcpkgs/Solaar/INSTALL.msg            | 3 +++
 srcpkgs/Solaar/files/README.voidlinux | 3 ---
 srcpkgs/Solaar/template               | 4 ----
 3 files changed, 3 insertions(+), 7 deletions(-)
 create mode 100644 srcpkgs/Solaar/INSTALL.msg
 delete mode 100644 srcpkgs/Solaar/files/README.voidlinux

diff --git a/srcpkgs/Solaar/INSTALL.msg b/srcpkgs/Solaar/INSTALL.msg
new file mode 100644
index 00000000000000..139cb3af3982a0
--- /dev/null
+++ b/srcpkgs/Solaar/INSTALL.msg
@@ -0,0 +1,3 @@
+Previous versions of solaar required copying or symlinking udev rules to
+	/etc/udev/rules.d
+If this was done previously, it is recommended to remove that file or symlink.
diff --git a/srcpkgs/Solaar/files/README.voidlinux b/srcpkgs/Solaar/files/README.voidlinux
deleted file mode 100644
index 7596828f668ad4..00000000000000
--- a/srcpkgs/Solaar/files/README.voidlinux
+++ /dev/null
@@ -1,3 +0,0 @@
-To use Solaar without root privileges, copy the file
-    /usr/share/solaar/udev-rules.d/42-logitech-unify-permissions.rules
-into the directory /etc/udev/rules.d/ and reload udev rules.
diff --git a/srcpkgs/Solaar/template b/srcpkgs/Solaar/template
index 922c658f3abe86..79ad7f5e4c2e9c 100644
--- a/srcpkgs/Solaar/template
+++ b/srcpkgs/Solaar/template
@@ -14,7 +14,3 @@ homepage="https://pwr-solaar.github.io/Solaar/"
 changelog="https://raw.githubusercontent.com/pwr-Solaar/Solaar/master/ChangeLog.md"
 distfiles="https://github.com/pwr-Solaar/Solaar/archive/refs/tags/${version}.tar.gz"
 checksum=2b292da8923e19a4a7a459d6fcd1119ce157cb579fd00077f87633c0dedfbba5
-
-post_install() {
-	vdoc "${FILESDIR}/README.voidlinux"
-}

Re: [PR REVIEW] Fix solaar udev rules

[im-apbecker]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New review comment by im-apbecker on void-packages repository

https://github.com/void-linux/void-packages/pull/49674#discussion_r1548689364

Comment:
Added the verbiage almost verbatim (attempted to honor the 80 character limit mentioned in the link). I also squashed the commits to remove the obsolete ones.

Re: [PR PATCH] [Closed]: Fix solaar udev rules

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]

There's a closed pull request on the void-packages repository

Fix solaar udev rules
https://github.com/void-linux/void-packages/pull/49674

Description:
This PR adds back in a missing udev rules file that is required for solaar to function.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)

Re: Fix solaar udev rules

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/49674#issuecomment-2041036404

Comment:
I deleted the copied file but now it doesn't work for non-root users 
![image](https://github.com/void-linux/void-packages/assets/15713555/ca9a14fe-78a6-440b-9616-dd66e9cf3d03)

Re: Fix solaar udev rules

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/49674#issuecomment-2041039690

Comment:
are you in the plugdev group or using elogind? might need to `udevadm trigger` too

Re: Fix solaar udev rules

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/49674#issuecomment-2041083992

Comment:
Yeah I'm in plugdev but if you see L29 in `/usr/lib/udev/rules.d/42-logitech-unify-permissions.rules` it's commented out.

Re: Fix solaar udev rules

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/49674#issuecomment-2041167104

Comment:
good catch

Re: Fix solaar udev rules

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/49674#issuecomment-2041187962

Comment:
fixed c9b59cfc13069d40511aad4121df32d5c7ef7c9a