Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] emacs: Add tar to hostmakedepends
@ 2020-01-20  1:00 voidlinux-github
  2020-01-20  9:29 ` voidlinux-github
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: voidlinux-github @ 2020-01-20  1:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

There is a new pull request by nilium against master on the void-packages repository

https://github.com/nilium/ecks-bops-packages emacs
https://github.com/void-linux/void-packages/pull/18411

emacs: Add tar to hostmakedepends
Fails to build from without tar. This may not have been noticed
previously because a dependency likely requires tar during build, so it
just ends up being present.

A patch file from https://github.com/void-linux/void-packages/pull/18411.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-emacs-18411.patch --]
[-- Type: text/x-diff, Size: 1141 bytes --]

From 5f6bf0da155e7527061c245cae60ab9eb257df52 Mon Sep 17 00:00:00 2001
From: Noel Cower <ncower@nil.dev>
Date: Sun, 19 Jan 2020 16:46:54 -0800
Subject: [PATCH] emacs: Add tar to hostmakedepends

Fails to build from without tar. This may not have been noticed
previously because a dependency likely requires tar during build, so it
just ends up being present.
---
 srcpkgs/emacs/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/emacs/template b/srcpkgs/emacs/template
index e255cc26494..93807166e66 100644
--- a/srcpkgs/emacs/template
+++ b/srcpkgs/emacs/template
@@ -7,7 +7,7 @@ configure_args="--with-file-notification=inotify --with-modules
  $(vopt_with jpeg) $(vopt_with tiff) $(vopt_with gif) $(vopt_with png)
  $(vopt_with xpm) $(vopt_with svg rsvg) $(vopt_with imagemagick)
  $(vopt_with xml xml2) $(vopt_with gnutls) $(vopt_with sound) $(vopt_with m17n m17n-flt)"
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config tar"
 makedepends="ncurses-devel libXaw-devel gtk+-devel gtk+3-devel webkit2gtk-devel
  dbus-devel acl-devel
  $(vopt_if jpeg libjpeg-turbo-devel) $(vopt_if tiff tiff-devel)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: emacs: Add tar to hostmakedepends
  2020-01-20  1:00 [PR PATCH] emacs: Add tar to hostmakedepends voidlinux-github
@ 2020-01-20  9:29 ` voidlinux-github
  2020-01-20  9:35 ` voidlinux-github
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: voidlinux-github @ 2020-01-20  9:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/18411#issuecomment-576185752

Comment:
(Gnu) tar was just a part of base-chroot. It is not anymore, since https://github.com/void-linux/void-packages/commit/75eca1b03e453d9e643b809550d5157717e46738#diff-db30b0bca2c8618d826fe67b20327411

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: emacs: Add tar to hostmakedepends
  2020-01-20  1:00 [PR PATCH] emacs: Add tar to hostmakedepends voidlinux-github
  2020-01-20  9:29 ` voidlinux-github
@ 2020-01-20  9:35 ` voidlinux-github
  2020-01-20  9:39 ` voidlinux-github
  2020-01-21 14:59 ` [PR PATCH] [Merged]: " voidlinux-github
  3 siblings, 0 replies; 5+ messages in thread
From: voidlinux-github @ 2020-01-20  9:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New comment by nilium on void-packages repository

https://github.com/void-linux/void-packages/pull/18411#issuecomment-576187808

Comment:
 That explains that. Not really a problem anyway — might be a few more cases like this down the road, though.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: emacs: Add tar to hostmakedepends
  2020-01-20  1:00 [PR PATCH] emacs: Add tar to hostmakedepends voidlinux-github
  2020-01-20  9:29 ` voidlinux-github
  2020-01-20  9:35 ` voidlinux-github
@ 2020-01-20  9:39 ` voidlinux-github
  2020-01-21 14:59 ` [PR PATCH] [Merged]: " voidlinux-github
  3 siblings, 0 replies; 5+ messages in thread
From: voidlinux-github @ 2020-01-20  9:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/18411#issuecomment-576189678

Comment:
There are - there is also a case of bsdtar not being in the [c-i musl builders](https://github.com/void-linux/void-packages/pull/18372#issuecomment-575928754), but I suppose that is logical in a transition...
I do not know if having bsdtar and gnu tar as alternatives (similar to awk) is possible...

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: emacs: Add tar to hostmakedepends
  2020-01-20  1:00 [PR PATCH] emacs: Add tar to hostmakedepends voidlinux-github
                   ` (2 preceding siblings ...)
  2020-01-20  9:39 ` voidlinux-github
@ 2020-01-21 14:59 ` voidlinux-github
  3 siblings, 0 replies; 5+ messages in thread
From: voidlinux-github @ 2020-01-21 14:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

There's a merged pull request on the void-packages repository

emacs: Add tar to hostmakedepends
https://github.com/void-linux/void-packages/pull/18411

Description:
Fails to build from without tar. This may not have been noticed
previously because a dependency likely requires tar during build, so it
just ends up being present.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-01-21 14:59 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-20  1:00 [PR PATCH] emacs: Add tar to hostmakedepends voidlinux-github
2020-01-20  9:29 ` voidlinux-github
2020-01-20  9:35 ` voidlinux-github
2020-01-20  9:39 ` voidlinux-github
2020-01-21 14:59 ` [PR PATCH] [Merged]: " voidlinux-github

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).