* Re: fish-shell: update to 3.4.0.
2022-03-13 11:04 [PR PATCH] fish-shell: update to 3.4.0 mhmdanas
@ 2022-03-14 23:15 ` zen0bit
2022-03-14 23:15 ` zen0bit
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: zen0bit @ 2022-03-14 23:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 456 bytes --]
New comment by zen0bit on void-packages repository
https://github.com/void-linux/void-packages/pull/36121#issuecomment-1067392671
Comment:
Looks like I found [solution](https://github.com/fish-shell/fish-shell/blob/master/share/functions/fish_title.fish)
Maybe add patch for it?
Never do that ...
change
"[$(prompt_hostname | string sub -l 10)]"
to
"["(prompt_hostname | string sub -l 10 | string collect)"]"
no error for me after change...
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: fish-shell: update to 3.4.0.
2022-03-13 11:04 [PR PATCH] fish-shell: update to 3.4.0 mhmdanas
2022-03-14 23:15 ` zen0bit
@ 2022-03-14 23:15 ` zen0bit
2022-03-14 23:31 ` mhmdanas
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: zen0bit @ 2022-03-14 23:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
New comment by zen0bit on void-packages repository
https://github.com/void-linux/void-packages/pull/36121#issuecomment-1067392671
Comment:
Looks like I found [solution](https://github.com/fish-shell/fish-shell/blob/master/share/functions/fish_title.fish)
Maybe add patch for it?
Never do that ...
change
`"[$(prompt_hostname | string sub -l 10)]"`
to
`"["(prompt_hostname | string sub -l 10 | string collect)"]"`
no error for me after change...
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: fish-shell: update to 3.4.0.
2022-03-13 11:04 [PR PATCH] fish-shell: update to 3.4.0 mhmdanas
2022-03-14 23:15 ` zen0bit
2022-03-14 23:15 ` zen0bit
@ 2022-03-14 23:31 ` mhmdanas
2022-03-14 23:31 ` mhmdanas
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: mhmdanas @ 2022-03-14 23:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 410 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/36121#issuecomment-1067409478
Comment:
The error only occurs because Fish 3.4.0 introduces a new syntax that the script in question was modified to use in Fish 3.4.0, and older Fish versions error out on that syntax. I think applying such a patch is not a good idea, but I'll leave that to the maintainers.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: fish-shell: update to 3.4.0.
2022-03-13 11:04 [PR PATCH] fish-shell: update to 3.4.0 mhmdanas
` (2 preceding siblings ...)
2022-03-14 23:31 ` mhmdanas
@ 2022-03-14 23:31 ` mhmdanas
2022-03-15 16:37 ` mhmdanas
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: mhmdanas @ 2022-03-14 23:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/36121#issuecomment-1067409478
Comment:
The error only occurs because Fish 3.4.0 introduces a new syntax that the script in question was modified to use in Fish 3.4.0, and older Fish versions error out on that syntax. I think applying such a patch is not a good idea, but I'll leave that choice to the maintainers.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: fish-shell: update to 3.4.0.
2022-03-13 11:04 [PR PATCH] fish-shell: update to 3.4.0 mhmdanas
` (3 preceding siblings ...)
2022-03-14 23:31 ` mhmdanas
@ 2022-03-15 16:37 ` mhmdanas
2022-03-19 16:59 ` Vistaus
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: mhmdanas @ 2022-03-15 16:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/36121#issuecomment-1067409478
Comment:
The error only occurs because Fish 3.4.0 introduces a new syntax that the script in question was modified to use in Fish 3.4.0, and older Fish versions don't recognize that syntax. Thus, any Fish sessions started after the update will not be affected. I think applying such a patch is not a good idea, but I'll leave that choice to the maintainers.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: fish-shell: update to 3.4.0.
2022-03-13 11:04 [PR PATCH] fish-shell: update to 3.4.0 mhmdanas
` (4 preceding siblings ...)
2022-03-15 16:37 ` mhmdanas
@ 2022-03-19 16:59 ` Vistaus
2022-03-20 22:26 ` paper42
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Vistaus @ 2022-03-19 16:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 228 bytes --]
New comment by Vistaus on void-packages repository
https://github.com/void-linux/void-packages/pull/36121#issuecomment-1073044266
Comment:
I also don't think applying such a patch is a good idea. Just restart your fish shell.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: fish-shell: update to 3.4.0.
2022-03-13 11:04 [PR PATCH] fish-shell: update to 3.4.0 mhmdanas
` (5 preceding siblings ...)
2022-03-19 16:59 ` Vistaus
@ 2022-03-20 22:26 ` paper42
2022-03-21 14:07 ` mhmdanas
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: paper42 @ 2022-03-20 22:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/36121#issuecomment-1073361157
Comment:
Is this something that will happen only in specific circumstances or for all users? If this would happen to all users, we could add an install message.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: fish-shell: update to 3.4.0.
2022-03-13 11:04 [PR PATCH] fish-shell: update to 3.4.0 mhmdanas
` (6 preceding siblings ...)
2022-03-20 22:26 ` paper42
@ 2022-03-21 14:07 ` mhmdanas
2022-03-21 14:12 ` paper42
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: mhmdanas @ 2022-03-21 14:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/36121#issuecomment-1073942094
Comment:
@paper42 well, not strictly all users it seems. From https://fishshell.com/docs/current/cmds/fish_title.html:
> This requires that your terminal supports programmable titles and the feature is turned on.
I'm not sure about this, but it probably also wouldn't affect those who have a custom `fish_title` function (as shown in the example in the URL above). However, it's not like we know how many Fish users aren't affected, so it may be safe to assume that the majority _will_ face that error.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: fish-shell: update to 3.4.0.
2022-03-13 11:04 [PR PATCH] fish-shell: update to 3.4.0 mhmdanas
` (7 preceding siblings ...)
2022-03-21 14:07 ` mhmdanas
@ 2022-03-21 14:12 ` paper42
2022-03-24 19:12 ` Chocimier
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: paper42 @ 2022-03-21 14:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/36121#issuecomment-1073947817
Comment:
> However, it's not like we know how many Fish users aren't affected, so it may be safe to assume that the majority _will_ face that error.
In that case let's add an install message, we can remove it with the next update.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: fish-shell: update to 3.4.0.
2022-03-13 11:04 [PR PATCH] fish-shell: update to 3.4.0 mhmdanas
` (8 preceding siblings ...)
2022-03-21 14:12 ` paper42
@ 2022-03-24 19:12 ` Chocimier
2022-03-24 19:15 ` mhmdanas
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Chocimier @ 2022-03-24 19:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/36121#issuecomment-1077966399
Comment:
Upsteam patched out new syntax, i would prefer to import that.
https://github.com/fish-shell/fish-shell/commit/c5a8764db1c94f386f0546bd9a25ea3520eb15b8
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: fish-shell: update to 3.4.0.
2022-03-13 11:04 [PR PATCH] fish-shell: update to 3.4.0 mhmdanas
` (9 preceding siblings ...)
2022-03-24 19:12 ` Chocimier
@ 2022-03-24 19:15 ` mhmdanas
2022-03-26 10:36 ` [PR PATCH] [Updated] " mhmdanas
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: mhmdanas @ 2022-03-24 19:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/36121#issuecomment-1077975495
Comment:
@Chocimier guess I'll do that.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] fish-shell: update to 3.4.0.
2022-03-13 11:04 [PR PATCH] fish-shell: update to 3.4.0 mhmdanas
` (10 preceding siblings ...)
2022-03-24 19:15 ` mhmdanas
@ 2022-03-26 10:36 ` mhmdanas
2022-03-26 10:37 ` fish-shell: update to 3.4.1 mhmdanas
2022-03-29 17:42 ` [PR PATCH] [Merged]: " Chocimier
13 siblings, 0 replies; 15+ messages in thread
From: mhmdanas @ 2022-03-26 10:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1776 bytes --]
There is an updated pull request by mhmdanas against master on the void-packages repository
https://github.com/mhmdanas/void-packages fish-3.4.0
https://github.com/void-linux/void-packages/pull/36121
fish-shell: update to 3.4.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
If you use an older Fish version as your shell and update to 3.4.0, you'll get the following (I believe harmless) error after the upgrade command finishes running and in some other instances:
```
/usr/share/fish/functions/fish_title.fish (line 7): $(...) is not supported. In fish, please use '(prompt_hostname)'.
and set ssh "[$(prompt_hostname | string sub -l 10)]"
^
from sourcing file /usr/share/fish/functions/fish_title.fish
in command substitution
source: Error while reading file “/usr/share/fish/functions/fish_title.fish”
```
(To be clear this does not happen when running the updated Fish 3.4.0)
Am I supposed to handle that somehow?
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/36121.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fish-3.4.0-36121.patch --]
[-- Type: text/x-diff, Size: 1124 bytes --]
From d40549620418ce35c25f0bf354f0d5a1efd0dfec Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Sun, 13 Mar 2022 13:53:20 +0300
Subject: [PATCH] fish-shell: update to 3.4.1.
---
srcpkgs/fish-shell/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/fish-shell/template b/srcpkgs/fish-shell/template
index 657e5604c3d6..0fc86db7e7b0 100644
--- a/srcpkgs/fish-shell/template
+++ b/srcpkgs/fish-shell/template
@@ -1,6 +1,6 @@
# Template file for 'fish-shell'
pkgname=fish-shell
-version=3.3.1
+version=3.4.1
revision=1
wrksrc="fish-${version}"
build_style=cmake
@@ -14,7 +14,7 @@ license="GPL-2.0-only"
homepage="https://fishshell.com/"
changelog="https://github.com/fish-shell/fish-shell/raw/master/CHANGELOG.rst"
distfiles="https://github.com/fish-shell/fish-shell/releases/download/${version}/fish-${version}.tar.xz"
-checksum=b5b4ee1a5269762cbbe993a4bd6507e675e4100ce9bbe84214a5eeb2b19fae89
+checksum=b6f23b3843b04db6b0a90fea1f6f0d0e40cc027b4a732098200863f2864a94ea
register_shell="/bin/fish /usr/bin/fish"
# tests don't work as root
make_check=ci-skip
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: fish-shell: update to 3.4.1.
2022-03-13 11:04 [PR PATCH] fish-shell: update to 3.4.0 mhmdanas
` (11 preceding siblings ...)
2022-03-26 10:36 ` [PR PATCH] [Updated] " mhmdanas
@ 2022-03-26 10:37 ` mhmdanas
2022-03-29 17:42 ` [PR PATCH] [Merged]: " Chocimier
13 siblings, 0 replies; 15+ messages in thread
From: mhmdanas @ 2022-03-26 10:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 264 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/36121#issuecomment-1079658929
Comment:
I updated the PR to Fish 3.4.1, which fixes that issue (see https://github.com/fish-shell/fish-shell/releases/tag/3.4.1).
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Merged]: fish-shell: update to 3.4.1.
2022-03-13 11:04 [PR PATCH] fish-shell: update to 3.4.0 mhmdanas
` (12 preceding siblings ...)
2022-03-26 10:37 ` fish-shell: update to 3.4.1 mhmdanas
@ 2022-03-29 17:42 ` Chocimier
13 siblings, 0 replies; 15+ messages in thread
From: Chocimier @ 2022-03-29 17:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1664 bytes --]
There's a merged pull request on the void-packages repository
fish-shell: update to 3.4.1.
https://github.com/void-linux/void-packages/pull/36121
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<strike>If you use an older Fish version as your shell and update to 3.4.0, you'll get the following (I believe harmless) error after the upgrade command finishes running and in some other instances:</strike>
```
/usr/share/fish/functions/fish_title.fish (line 7): $(...) is not supported. In fish, please use '(prompt_hostname)'.
and set ssh "[$(prompt_hostname | string sub -l 10)]"
^
from sourcing file /usr/share/fish/functions/fish_title.fish
in command substitution
source: Error while reading file “/usr/share/fish/functions/fish_title.fish”
```
<strike>
To be clear this does not happen when running the updated Fish 3.4.0)
Am I supposed to handle that somehow?</strike> Fixed in 3.4.1.
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
^ permalink raw reply [flat|nested] 15+ messages in thread