[ISSUE] Add a service for iscsid (open-iscsi)

[ISSUE] Add a service for iscsid (open-iscsi)

[thetredev]

[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]

New issue by thetredev on void-packages repository

https://github.com/void-linux/void-packages/issues/40861

Description:
When the `open-iscsi` package is installed on Arch Linux, a systemd service is created which essentially calls `/usr/bin/iscsid -f` when started:
```shell
$ cat /etc/systemd/system/multi-user.target.wants/iscsid.service
[Unit]
Description=Open-iSCSI
Documentation=man:iscsid(8) man:iscsiuio(8) man:iscsiadm(8)
DefaultDependencies=no
After=network-online.target iscsiuio.service iscsi-init.service
Before=remote-fs-pre.target
Wants=remote-fs-pre.target
Requires=iscsi-init.service

[Service]
Type=notify
NotifyAccess=main
ExecStart=/usr/bin/iscsid -f  <-----
KillMode=mixed
Restart=on-failure

[Install]
WantedBy=multi-user.target
Also=iscsid.socket
```

I wanted to run Void as a server for testing purposes and I need `iscsid` to run on there. I've created the following service file as a first:
```shell
$ cat /etc/sv/iscsid/run 
#!/bin/sh
[ -r conf ] && . ./conf
exec iscsid -f

$ sv status /var/service/iscsid
run: /var/service/iscsid: (pid 825) 311s
```

`iscsiuio` doesn't start for me for some reason, but `iscsid` is happy as far as I can tell. I'm quite sure that `iscsi-init.service` is NOT needed, since that only creates a `/etc/iscsi/initiatorname.iscsi` file which the XBPS package installation already does AFAIK.

My question/request: Do we need that service? If so, is my `/etc/sv/iscsid/run` enough? :)
Thank you!

Re: open-iscsi: Add a runit service (iscsid)

[kruceter]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

New comment by kruceter on void-packages repository

https://github.com/void-linux/void-packages/issues/40861#issuecomment-1333763951

Comment:
systemd unit files are placed for reference purpose only.

> `iscsiuio` doesn't start for me for some reason

It has to be started separately as a separate service, according to `After=network-online.target iscsiuio.service iscsi-init.service` containing `iscsiuio.service`.

I do not know if iscsiuio has to be started before iscsid or not, though.

Re: open-iscsi: Add a runit service (iscsid)

[kruceter]

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

New comment by kruceter on void-packages repository

https://github.com/void-linux/void-packages/issues/40861#issuecomment-1333763951

Comment:
systemd unit files are placed for reference purpose only.

> `iscsiuio` doesn't start for me for some reason

It has to be started as a separate service, according to `After=network-online.target iscsiuio.service iscsi-init.service` containing `iscsiuio.service`.

I do not know if iscsiuio has to be started before iscsid or not, though.

Re: open-iscsi: Add a runit service (iscsid)

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/issues/40861#issuecomment-1335063736

Comment:
Your topic and issue description are asking two different things. It seems your primary goal is finding out if you've handled the daemon properly in your service. That question is probably better addressed on Reddit or some support forum for open-iscsi.

Re: open-iscsi: Add a runit service (iscsid)

[thetredev]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

New comment by thetredev on void-packages repository

https://github.com/void-linux/void-packages/issues/40861#issuecomment-1335104803

Comment:
Ummm no? I figured that no `iscsid` service comes with the XBPS package and I proposed a fix (which I'm not quite sure is enough).

Re: open-iscsi: Add a runit service (iscsid)

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/issues/40861#issuecomment-1452856100

Comment:
Issues become stale 90 days after last activity and are closed 14 days after that.  If this issue is still relevant bump it or assign it.

Re: open-iscsi: Add a runit service (iscsid)

[thetredev]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New comment by thetredev on void-packages repository

https://github.com/void-linux/void-packages/issues/40861#issuecomment-1454102163

Comment:
bump :)

Re: open-iscsi: Add a runit service (iscsid)

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/issues/40861#issuecomment-1465246590

Comment:
sgtm, please make a PR.

Re: open-iscsi: Add a runit service (iscsid)

[thetredev]

[-- Attachment #1: Type: text/plain, Size: 2029 bytes --]

New comment by thetredev on void-packages repository

https://github.com/void-linux/void-packages/issues/40861#issuecomment-1475255237

Comment:
@leahneukirchen I'm having trouble installing the service via `vsv`. What I did:
```shell
$ cat srcpkgs/open-iscsi/files/iscsid/run
#!/bin/sh
exec 2>&1
[ -r conf ] && . ./conf
exec iscsid -f
```
```shell
$ stat -c '%a' srcpkgs/open-iscsi/files/iscsid/run
755
```
```shell
$ cat srcpkgs/open-iscsi/template
....
post_install() {
        vsv iscsid
}
....
```
```shell
$ ./xbps-src binary-bootstrap
$ ./xbps-src pkg open-iscsi > build.open-iscsi.log
```
[build.open-iscsi.log](https://github.com/void-linux/void-packages/files/11011132/build.open-iscsi.log)
```shell
$ sudo xbps-install --repository hostdir/binpkgs open-iscsi

Name       Action    Version           New version            Download size
libisns    install   -                 0.102_1                - 
open-iscsi install   -                 2.1.8_1                - 

Size required on disk:        2103KB
Space available on disk:       634GB

Do you want to continue? [Y/n] 

[*] Verifying package integrity
libisns-0.102_1: verifying RSA signature...
open-iscsi-2.1.8_1: verifying RSA signature...

[*] Collecting package files
libisns-0.102_1: collecting files...
open-iscsi-2.1.8_1: collecting files...

[*] Unpacking packages
libisns-0.102_1: unpacking ...
open-iscsi-2.1.8_1: unpacking ...
File `./etc/iscsi/initiatorname.iscsi' exists, installing configuration file to `./etc/iscsi/initiatorname.iscsi.new-2.1.8_1'.

[*] Configuring unpacked packages
libisns-0.102_1: configuring ...
libisns-0.102_1: installed successfully.
open-iscsi-2.1.8_1: configuring ...
open-iscsi-2.1.8_1: installed successfully.

0 downloaded, 2 installed, 0 updated, 2 configured, 0 removed.
```
```shell
$ ls /etc/sv/iscsid
ls: cannot access '/etc/sv/iscsid': No such file or directory
```
`vsv` doesn't install `iscsid` for some reason. Can you help me with this? Thanks!

Re: open-iscsi: Add a runit service (iscsid)

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/issues/40861#issuecomment-1475292774

Comment:
works for me... but you want to add it to do_install here anyway.

Re: open-iscsi: Add a runit service (iscsid)

[thetredev]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

New comment by thetredev on void-packages repository

https://github.com/void-linux/void-packages/issues/40861#issuecomment-1475314292

Comment:
Thanks I'll try that.

Re: open-iscsi: Add a runit service (iscsid)

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/issues/40861#issuecomment-1595925238

Comment:
Issues become stale 90 days after last activity and are closed 14 days after that.  If this issue is still relevant bump it or assign it.

Re: open-iscsi: Add a runit service (iscsid)

[thetredev]

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New comment by thetredev on void-packages repository

https://github.com/void-linux/void-packages/issues/40861#issuecomment-1596166139

Comment:
bump

Re: open-iscsi: Add a runit service (iscsid)

[thetredev]

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New comment by thetredev on void-packages repository

https://github.com/void-linux/void-packages/issues/40861#issuecomment-1596166139

Comment:
bump

Re: [ISSUE] [CLOSED] open-iscsi: Add a runit service (iscsid)

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]

Closed issue by thetredev on void-packages repository

https://github.com/void-linux/void-packages/issues/40861

Description:
When the `open-iscsi` package is installed on Arch Linux, a systemd service is created which essentially calls `/usr/bin/iscsid -f` when started:
```shell
$ cat /etc/systemd/system/multi-user.target.wants/iscsid.service
[Unit]
Description=Open-iSCSI
Documentation=man:iscsid(8) man:iscsiuio(8) man:iscsiadm(8)
DefaultDependencies=no
After=network-online.target iscsiuio.service iscsi-init.service
Before=remote-fs-pre.target
Wants=remote-fs-pre.target
Requires=iscsi-init.service

[Service]
Type=notify
NotifyAccess=main
ExecStart=/usr/bin/iscsid -f  <-----
KillMode=mixed
Restart=on-failure

[Install]
WantedBy=multi-user.target
Also=iscsid.socket
```

I wanted to run Void as a server for testing purposes and I need `iscsid` to run on there. I've created the following service file as a first:
```shell
$ cat /etc/sv/iscsid/run 
#!/bin/sh
[ -r conf ] && . ./conf
exec iscsid -f

$ sv status /var/service/iscsid
run: /var/service/iscsid: (pid 825) 311s
```

`iscsiuio` doesn't start for me for some reason, but `iscsid` is happy as far as I can tell. I'm quite sure that `iscsi-init.service` is NOT needed, since that only creates a `/etc/iscsi/initiatorname.iscsi` file which either the XBPS package installation or `iscsid` already does (it was already present after I started `iscsid` manually when testing).

My question/request: Do we need that service? If so, is my `/etc/sv/iscsid/run` enough? :)
Thank you!