[PR PATCH] [RFC] do not install checkdepends when check is not going to run

[PR PATCH] [RFC] do not install checkdepends when check is not going to run

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 1958 bytes --]

There is a new pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages checkdepends
https://github.com/void-linux/void-packages/pull/46207

[RFC] do not install checkdepends when check is not going to run
This is useful e.g. to break build <-> check cycles.

For instance, one can set `make_check=extended` so check doesn't run on CI or -Q (maybe the check depencies are updated at the same time), but it's still easy to run check using -K after dependencies have been built.

I'm working on jupyter notebook packages, and there are a few build <-> check cycles. I want to try to arrange checks so that `-Q` will check as much as possible without cycles, and `-K` will do full check (assuming all dependencies are already packaged).

Without this patch one needs to add packages to `checkdepends` conditionally on `$XBPS_CHECK_PKGS`, but it seems simpler this way.


<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/46207.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-checkdepends-46207.patch --]
[-- Type: text/x-diff, Size: 1523 bytes --]

From 1a4fb60dbb75747921effb89aa4c7cc7a64cb23a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Sat, 23 Sep 2023 15:56:21 -0300
Subject: [PATCH] common/xbps-src/shutils/build_dependencies.sh: do not install
 checkdepends when check is not going to run

---
 common/xbps-src/shutils/build_dependencies.sh | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/common/xbps-src/shutils/build_dependencies.sh b/common/xbps-src/shutils/build_dependencies.sh
index 20f61528d14c2..a49b485a97631 100644
--- a/common/xbps-src/shutils/build_dependencies.sh
+++ b/common/xbps-src/shutils/build_dependencies.sh
@@ -137,7 +137,11 @@ install_pkg_deps() {
     local -a host_missing_deps missing_deps missing_rdeps
 
     [ -z "$pkgname" ] && return 2
-    [ -z "$XBPS_CHECK_PKGS" ] && unset checkdepends
+    [ -z "$XBPS_CHECK_PKGS" ] ||
+        [ "$XBPS_CROSS_BUILD" ] ||
+        [ "$make_check" = ci-skip  -a "$XBPS_BUILD_ENVIRONMENT" = void-packages-ci ] ||
+        [ "$make_check" = extended -a "$XBPS_CHECK_PKGS" != full ] ||
+        [ "$make_check" = no ] && unset checkdepends
 
     if [[ $build_style ]] || [[ $build_helper ]]; then
         style=" with"
@@ -208,7 +212,7 @@ install_pkg_deps() {
     #
     # Host check dependencies.
     #
-    if [[ ${checkdepends} ]] && [[ $XBPS_CHECK_PKGS ]] && [ -z "$XBPS_CROSS_BUILD" ]; then
+    if [[ ${checkdepends} ]]; then
         templates=""
         # check validity
         for f in ${checkdepends}; do

Re: [RFC] do not install checkdepends when check is not going to run

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/46207#issuecomment-1868167817

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [RFC] do not install checkdepends when check is not going to run

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 147 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/46207#issuecomment-1868328669

Comment:
ping

Re: [PR PATCH] [Closed]: [RFC] do not install checkdepends when check is not going to run

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 1800 bytes --]

There's a closed pull request on the void-packages repository

[RFC] do not install checkdepends when check is not going to run
https://github.com/void-linux/void-packages/pull/46207

Description:
This is useful e.g. to break build <-> check cycles.

For instance, one can set `make_check=extended` so check doesn't run on CI or -Q (maybe the check depencies are updated at the same time), but it's still easy to run check using -K after dependencies have been built.

I'm working on jupyter notebook packages, and there are a few build <-> check cycles. I want to try to arrange checks so that `-Q` will check as much as possible without cycles, and `-K` will do full check (assuming all dependencies are already packaged).

Without this patch one needs to add packages to `checkdepends` conditionally on `$XBPS_CHECK_PKGS`, but it seems simpler this way.


<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Re: [RFC] do not install checkdepends when check is not going to run

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/46207#issuecomment-1869632758

Comment:
Closing  in favor of #47888