* Re: [PR PATCH] [Updated] godot: add correct build name
2023-10-11 9:49 [PR PATCH] godot: add correct build name dataCobra
@ 2023-10-11 10:20 ` dataCobra
2023-10-16 11:17 ` dataCobra
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: dataCobra @ 2023-10-11 10:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
There is an updated pull request by dataCobra against master on the void-packages repository
https://github.com/dataCobra/void-packages godot
https://github.com/void-linux/void-packages/pull/46589
godot: add correct build name
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
It's a minor change that makes debugging and reporting issues for our package easier.
Instead of ".custom_build" the suffix is ".voidlinux".
A patch file from https://github.com/void-linux/void-packages/pull/46589.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-godot-46589.patch --]
[-- Type: text/x-diff, Size: 1050 bytes --]
From 95292d7b7ac33dc2ff5ac388bc69c9f280680a7a Mon Sep 17 00:00:00 2001
From: dataCobra <datacobra@thinkbot.de>
Date: Wed, 11 Oct 2023 12:20:39 +0200
Subject: [PATCH] godot: add correct build name
---
srcpkgs/godot/template | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/godot/template b/srcpkgs/godot/template
index fdcebd1017566..9a7446b403835 100644
--- a/srcpkgs/godot/template
+++ b/srcpkgs/godot/template
@@ -1,7 +1,7 @@
# Template file for 'godot'
pkgname=godot
version=4.1.2
-revision=1
+revision=2
archs="x86_64* i686* aarch64* armv7* ppc64*"
build_style=scons
# Build currently fails with embree-4.X
@@ -30,6 +30,7 @@ nocross=https://build.voidlinux.org/builders/armv7l_builder/builds/6342/steps/sh
CFLAGS+=" -fPIE -fPIC"
LDFLAGS+=" -pie"
+
if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
makedepends+=" libexecinfo-devel"
depends+=" libexecinfo"
@@ -47,6 +48,7 @@ make_build_args+=" arch=$arch"
pre_build() {
export CXXFLAGS=" $CXXFLAGS "
+ export BUILD_NAME="voidlinux"
}
post_patch() {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PR PATCH] [Updated] godot: add correct build name
2023-10-11 9:49 [PR PATCH] godot: add correct build name dataCobra
2023-10-11 10:20 ` [PR PATCH] [Updated] " dataCobra
@ 2023-10-16 11:17 ` dataCobra
2023-10-16 12:46 ` dataCobra
2023-10-16 21:05 ` [PR PATCH] [Merged]: " Piraty
3 siblings, 0 replies; 5+ messages in thread
From: dataCobra @ 2023-10-16 11:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
There is an updated pull request by dataCobra against master on the void-packages repository
https://github.com/dataCobra/void-packages godot
https://github.com/void-linux/void-packages/pull/46589
godot: add correct build name
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
It's a minor change that makes debugging and reporting issues for our package easier.
Instead of ".custom_build" the suffix is ".voidlinux".
A patch file from https://github.com/void-linux/void-packages/pull/46589.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-godot-46589.patch --]
[-- Type: text/x-diff, Size: 1050 bytes --]
From 9869c4bdf54220f3ec9cab03307d7f90091e5ecf Mon Sep 17 00:00:00 2001
From: dataCobra <datacobra@thinkbot.de>
Date: Wed, 11 Oct 2023 12:20:39 +0200
Subject: [PATCH] godot: add correct build name
---
srcpkgs/godot/template | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/godot/template b/srcpkgs/godot/template
index fdcebd1017566..9a7446b403835 100644
--- a/srcpkgs/godot/template
+++ b/srcpkgs/godot/template
@@ -1,7 +1,7 @@
# Template file for 'godot'
pkgname=godot
version=4.1.2
-revision=1
+revision=2
archs="x86_64* i686* aarch64* armv7* ppc64*"
build_style=scons
# Build currently fails with embree-4.X
@@ -30,6 +30,7 @@ nocross=https://build.voidlinux.org/builders/armv7l_builder/builds/6342/steps/sh
CFLAGS+=" -fPIE -fPIC"
LDFLAGS+=" -pie"
+
if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
makedepends+=" libexecinfo-devel"
depends+=" libexecinfo"
@@ -47,6 +48,7 @@ make_build_args+=" arch=$arch"
pre_build() {
export CXXFLAGS=" $CXXFLAGS "
+ export BUILD_NAME="voidlinux"
}
post_patch() {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PR PATCH] [Updated] godot: add correct build name
2023-10-11 9:49 [PR PATCH] godot: add correct build name dataCobra
2023-10-11 10:20 ` [PR PATCH] [Updated] " dataCobra
2023-10-16 11:17 ` dataCobra
@ 2023-10-16 12:46 ` dataCobra
2023-10-16 21:05 ` [PR PATCH] [Merged]: " Piraty
3 siblings, 0 replies; 5+ messages in thread
From: dataCobra @ 2023-10-16 12:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
There is an updated pull request by dataCobra against master on the void-packages repository
https://github.com/dataCobra/void-packages godot
https://github.com/void-linux/void-packages/pull/46589
godot: add correct build name
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
It's a minor change that makes debugging and reporting issues for our package easier.
Instead of ".custom_build" the suffix is ".voidlinux".
A patch file from https://github.com/void-linux/void-packages/pull/46589.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-godot-46589.patch --]
[-- Type: text/x-diff, Size: 799 bytes --]
From 65d198bab56526054fc2086a19020403df8fc915 Mon Sep 17 00:00:00 2001
From: dataCobra <datacobra@thinkbot.de>
Date: Mon, 16 Oct 2023 14:46:18 +0200
Subject: [PATCH] godot: add correct build name
---
srcpkgs/godot/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/godot/template b/srcpkgs/godot/template
index fdcebd1017566..e57051ab29d35 100644
--- a/srcpkgs/godot/template
+++ b/srcpkgs/godot/template
@@ -1,7 +1,7 @@
# Template file for 'godot'
pkgname=godot
version=4.1.2
-revision=1
+revision=2
archs="x86_64* i686* aarch64* armv7* ppc64*"
build_style=scons
# Build currently fails with embree-4.X
@@ -47,6 +47,7 @@ make_build_args+=" arch=$arch"
pre_build() {
export CXXFLAGS=" $CXXFLAGS "
+ export BUILD_NAME="voidlinux"
}
post_patch() {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PR PATCH] [Merged]: godot: add correct build name
2023-10-11 9:49 [PR PATCH] godot: add correct build name dataCobra
` (2 preceding siblings ...)
2023-10-16 12:46 ` dataCobra
@ 2023-10-16 21:05 ` Piraty
3 siblings, 0 replies; 5+ messages in thread
From: Piraty @ 2023-10-16 21:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
There's a merged pull request on the void-packages repository
godot: add correct build name
https://github.com/void-linux/void-packages/pull/46589
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
It's a minor change that makes debugging and reporting issues for our package easier.
Instead of ".custom_build" the suffix is ".voidlinux".
^ permalink raw reply [flat|nested] 5+ messages in thread