[PR PATCH] catch2: fix deceiving description

[PR PATCH] catch2: fix deceiving description

[meator]

[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]

There is a new pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages catch2
https://github.com/void-linux/void-packages/pull/46800

catch2: fix deceiving description
The `catch2` package is really weird by the way. It ships a _static_ library. It also doesn't have `catch2-devel`
 because of this. I guess this is for developers only. I know Catch2 doesn't really like to be packaged, it prefers to be managed by the project's build system, but it still isn't standard to ship static libraries like this. Correct me if I'm wrong.
<!-- Uncomment relevant sections and delete options which are not applicable -->
ping @DBLouis 

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/46800.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-catch2-46800.patch --]
[-- Type: text/x-diff, Size: 969 bytes --]

From 9e077b84a21c15e70f4429b0dacc89c5327cbc70 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Fri, 20 Oct 2023 20:02:50 +0200
Subject: [PATCH] catch2: fix deceiving description

Catch2 isn't header only since version v3.0.0.
---
 srcpkgs/catch2/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/catch2/template b/srcpkgs/catch2/template
index 92f07bd8029e8..feddfed76b9df 100644
--- a/srcpkgs/catch2/template
+++ b/srcpkgs/catch2/template
@@ -8,7 +8,7 @@ configure_args="-DCATCH_USE_VALGRIND=OFF -DCATCH_BUILD_TESTING=ON
  -DCATCH_ENABLE_COVERAGE=OFF -DCATCH_ENABLE_WERROR=OFF
  -DCATCH_INSTALL_DOCS=ON -DCATCH_INSTALL_HELPERS=ON"
 hostmakedepends="python3"
-short_desc="C++ header-only test framework for unit-tests, TDD and BDD"
+short_desc="C++ test framework for unit-tests, TDD and BDD"
 maintainer="Louis Dupré Bertoni <contact@louisdb.xyz>"
 license="BSL-1.0"
 homepage="https://github.com/catchorg/Catch2"

Re: catch2: fix deceiving description

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/46800#issuecomment-1899505371

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: catch2: fix deceiving description

[meator]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/46800#issuecomment-1913506834

Comment:
I believe this PR is still valid.

Re: [PR PATCH] [Updated] catch2: fix deceiving description

[meator]

[-- Attachment #1: Type: text/plain, Size: 1633 bytes --]

There is an updated pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages catch2
https://github.com/void-linux/void-packages/pull/46800

catch2: fix deceiving description
The `catch2` package is really weird by the way. It ships a _static_ library. It also doesn't have `catch2-devel`
 because of this. I guess this is for developers only. I know Catch2 doesn't really like to be packaged, it prefers to be managed by the project's build system, but it still isn't standard to ship static libraries like this. Correct me if I'm wrong.
<!-- Uncomment relevant sections and delete options which are not applicable -->
ping @DBLouis 

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/46800.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-catch2-46800.patch --]
[-- Type: text/x-diff, Size: 969 bytes --]

From e79c4d8c38b48a48760620e9a6314a9642e9c766 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Fri, 20 Oct 2023 20:02:50 +0200
Subject: [PATCH] catch2: fix deceiving description

Catch2 isn't header only since version v3.0.0.
---
 srcpkgs/catch2/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/catch2/template b/srcpkgs/catch2/template
index 92f07bd8029e8..feddfed76b9df 100644
--- a/srcpkgs/catch2/template
+++ b/srcpkgs/catch2/template
@@ -8,7 +8,7 @@ configure_args="-DCATCH_USE_VALGRIND=OFF -DCATCH_BUILD_TESTING=ON
  -DCATCH_ENABLE_COVERAGE=OFF -DCATCH_ENABLE_WERROR=OFF
  -DCATCH_INSTALL_DOCS=ON -DCATCH_INSTALL_HELPERS=ON"
 hostmakedepends="python3"
-short_desc="C++ header-only test framework for unit-tests, TDD and BDD"
+short_desc="C++ test framework for unit-tests, TDD and BDD"
 maintainer="Louis Dupré Bertoni <contact@louisdb.xyz>"
 license="BSL-1.0"
 homepage="https://github.com/catchorg/Catch2"

Re: catch2: fix deceiving description

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/46800#issuecomment-2081285630

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: catch2: fix deceiving description

[meator]

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/46800#issuecomment-2081554192

Comment:
It ain't stale.

Re: [PR PATCH] [Updated] catch2: fix deceiving description

[meator]

[-- Attachment #1: Type: text/plain, Size: 1633 bytes --]

There is an updated pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages catch2
https://github.com/void-linux/void-packages/pull/46800

catch2: fix deceiving description
The `catch2` package is really weird by the way. It ships a _static_ library. It also doesn't have `catch2-devel`
 because of this. I guess this is for developers only. I know Catch2 doesn't really like to be packaged, it prefers to be managed by the project's build system, but it still isn't standard to ship static libraries like this. Correct me if I'm wrong.
<!-- Uncomment relevant sections and delete options which are not applicable -->
ping @DBLouis 

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/46800.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-catch2-46800.patch --]
[-- Type: text/x-diff, Size: 971 bytes --]

From 65f9d2b9b5e7e7ec4ea7644acc0317260a32eea0 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Fri, 20 Oct 2023 20:02:50 +0200
Subject: [PATCH] catch2: fix deceiving description

Catch2 isn't header only since version v3.0.0.
---
 srcpkgs/catch2/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/catch2/template b/srcpkgs/catch2/template
index 92f07bd8029e8f..feddfed76b9df8 100644
--- a/srcpkgs/catch2/template
+++ b/srcpkgs/catch2/template
@@ -8,7 +8,7 @@ configure_args="-DCATCH_USE_VALGRIND=OFF -DCATCH_BUILD_TESTING=ON
  -DCATCH_ENABLE_COVERAGE=OFF -DCATCH_ENABLE_WERROR=OFF
  -DCATCH_INSTALL_DOCS=ON -DCATCH_INSTALL_HELPERS=ON"
 hostmakedepends="python3"
-short_desc="C++ header-only test framework for unit-tests, TDD and BDD"
+short_desc="C++ test framework for unit-tests, TDD and BDD"
 maintainer="Louis Dupré Bertoni <contact@louisdb.xyz>"
 license="BSL-1.0"
 homepage="https://github.com/catchorg/Catch2"

Re: catch2: fix deceiving description

[meator]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/46800#issuecomment-2081554192

Comment:
It ain't stale. Bumping.

Re: [PR PATCH] [Merged]: catch2: fix deceiving description

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]

There's a merged pull request on the void-packages repository

catch2: fix deceiving description
https://github.com/void-linux/void-packages/pull/46800

Description:
The `catch2` package is really weird by the way. It ships a _static_ library. It also doesn't have `catch2-devel`
 because of this. I guess this is for developers only. I know Catch2 doesn't really like to be packaged, it prefers to be managed by the project's build system, but it still isn't standard to ship static libraries like this. Correct me if I'm wrong.
<!-- Uncomment relevant sections and delete options which are not applicable -->
ping @DBLouis 

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->