Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] catch2: fix deceiving description
@ 2023-10-20 18:10 meator
  2024-01-19  1:47 ` github-actions
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: meator @ 2023-10-20 18:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]

There is a new pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages catch2
https://github.com/void-linux/void-packages/pull/46800

catch2: fix deceiving description
The `catch2` package is really weird by the way. It ships a _static_ library. It also doesn't have `catch2-devel`
 because of this. I guess this is for developers only. I know Catch2 doesn't really like to be packaged, it prefers to be managed by the project's build system, but it still isn't standard to ship static libraries like this. Correct me if I'm wrong.
<!-- Uncomment relevant sections and delete options which are not applicable -->
ping @DBLouis 

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/46800.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-catch2-46800.patch --]
[-- Type: text/x-diff, Size: 969 bytes --]

From 9e077b84a21c15e70f4429b0dacc89c5327cbc70 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Fri, 20 Oct 2023 20:02:50 +0200
Subject: [PATCH] catch2: fix deceiving description

Catch2 isn't header only since version v3.0.0.
---
 srcpkgs/catch2/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/catch2/template b/srcpkgs/catch2/template
index 92f07bd8029e8..feddfed76b9df 100644
--- a/srcpkgs/catch2/template
+++ b/srcpkgs/catch2/template
@@ -8,7 +8,7 @@ configure_args="-DCATCH_USE_VALGRIND=OFF -DCATCH_BUILD_TESTING=ON
  -DCATCH_ENABLE_COVERAGE=OFF -DCATCH_ENABLE_WERROR=OFF
  -DCATCH_INSTALL_DOCS=ON -DCATCH_INSTALL_HELPERS=ON"
 hostmakedepends="python3"
-short_desc="C++ header-only test framework for unit-tests, TDD and BDD"
+short_desc="C++ test framework for unit-tests, TDD and BDD"
 maintainer="Louis Dupré Bertoni <contact@louisdb.xyz>"
 license="BSL-1.0"
 homepage="https://github.com/catchorg/Catch2"

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-05-06 19:51 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-20 18:10 [PR PATCH] catch2: fix deceiving description meator
2024-01-19  1:47 ` github-actions
2024-01-28  8:01 ` meator
2024-01-28  8:08 ` [PR PATCH] [Updated] " meator
2024-04-28  1:46 ` github-actions
2024-04-28 16:54 ` meator
2024-04-28 16:55 ` [PR PATCH] [Updated] " meator
2024-04-28 16:57 ` meator
2024-05-06 19:51 ` [PR PATCH] [Merged]: " cinerea0

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).