* [PR PATCH] New package: distrobox-1.6.0.1-1
@ 2023-11-22 3:46 klardotsh
2023-11-22 3:47 ` [PR PATCH] [Updated] " klardotsh
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: klardotsh @ 2023-11-22 3:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 2050 bytes --]
There is a new pull request by klardotsh against master on the void-packages repository
https://github.com/klardotsh/void-packages klardotsh/distrobox
https://github.com/void-linux/void-packages/pull/47347
New package: distrobox-1.6.0.1-1
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES** (I am currently using this `distrobox` package to manage my Discord, Zoom, and Steam containers on x86_64-musl)
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
Rationale for inclusion despite being all shell scripts:
- A reasonable, casual bystander would expect to be able to "just install distrobox", it's not intuitive to require someone who wants their container management to Just Work to have to clone a Git repo that runs a shell script to install to sometimes the homedir, sometimes `/usr/local`
- This project updates at a reasonable cadence with real version numbers and is not just a "toss it in a contrib folder in your `PATH` and forget about it" type of script
- With some USE flag tinkering, we could make this auto-depend on `docker` or `podman` (or the recently supported [`lilipod`](https://github.com/89luca89/lilipod) written by the same author), perhaps with subpackages to create the dependency links
I very much don't like the `short_desc` here but it's what upstream provides for a description, and I can't think of a clearer, short/terse wording right now to encompass the broader usecase for the tool (for example, I don't really use any CLI tools with this thing: I'm managing Steam and Discord through it, which I launch via exported `.desktop` files and my launcher...)
---
This is a continuation of work done by another packager in #42123 earlier this year.
Resolves #36341.
A patch file from https://github.com/void-linux/void-packages/pull/47347.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-klardotsh/distrobox-47347.patch --]
[-- Type: text/x-diff, Size: 1724 bytes --]
From 3d02cbd533e3df2533addfe88a5a22276866bd57 Mon Sep 17 00:00:00 2001
From: Josh Klar <josh@klar.sh>
Date: Tue, 21 Nov 2023 19:37:33 -0800
Subject: [PATCH] New package: distrobox-1.6.0.1-1
---
srcpkgs/distrobox/INSTALL.msg | 1 +
srcpkgs/distrobox/template | 24 ++++++++++++++++++++++++
2 files changed, 25 insertions(+)
create mode 100644 srcpkgs/distrobox/INSTALL.msg
create mode 100644 srcpkgs/distrobox/template
diff --git a/srcpkgs/distrobox/INSTALL.msg b/srcpkgs/distrobox/INSTALL.msg
new file mode 100644
index 0000000000000..4f970e831ea81
--- /dev/null
+++ b/srcpkgs/distrobox/INSTALL.msg
@@ -0,0 +1 @@
+Distrobox requires one of 'docker' or 'podman' to be installed.
diff --git a/srcpkgs/distrobox/template b/srcpkgs/distrobox/template
new file mode 100644
index 0000000000000..10edbf166cad4
--- /dev/null
+++ b/srcpkgs/distrobox/template
@@ -0,0 +1,24 @@
+# Template file for 'distrobox'
+pkgname=distrobox
+version=1.6.0.1
+revision=1
+short_desc="Podman/Docker wrapper to use any linux distribution in your terminal"
+maintainer="klardotsh <josh@klar.sh>"
+depends=(curl)
+license="GPL-3.0-or-later"
+homepage="https://distrobox.privatedns.org"
+distfiles="https://github.com/89luca89/${pkgname}/archive/${version}.tar.gz"
+checksum=d6b1330b56f6a1bf844c26a27d87f39efd8ae088ed3063f6513d48cf9c18f57e
+
+do_install() {
+ ./install --prefix "${DESTDIR}/usr"
+ vdoc docs/README.md
+ vdoc docs/compatibility.md
+ vdoc docs/featured_articles.md
+ vdoc docs/useful_tips.md
+ vdoc docs/posts/distrobox_custom.md
+ vdoc docs/posts/execute_commands_on_host.md
+ vdoc docs/posts/integrate_vscode_distrobox.md
+ vdoc docs/posts/run_latest_gnome_kde_on_distrobox.md
+ vdoc docs/posts/run_libvirt_in_distrobox.md
+}
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Updated] New package: distrobox-1.6.0.1-1
2023-11-22 3:46 [PR PATCH] New package: distrobox-1.6.0.1-1 klardotsh
@ 2023-11-22 3:47 ` klardotsh
2023-11-22 3:51 ` klardotsh
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: klardotsh @ 2023-11-22 3:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 2049 bytes --]
There is an updated pull request by klardotsh against master on the void-packages repository
https://github.com/klardotsh/void-packages klardotsh/distrobox
https://github.com/void-linux/void-packages/pull/47347
New package: distrobox-1.6.0.1-1
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES** (I am currently using this `distrobox` package to manage my Discord, Zoom, and Steam containers on x86_64-musl)
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
Rationale for inclusion despite being all shell scripts:
- A reasonable, casual bystander would expect to be able to "just install distrobox", it's not intuitive to require someone who wants their container management to Just Work to have to clone a Git repo that runs a shell script to install to sometimes the homedir, sometimes `/usr/local`
- This project updates at a reasonable cadence with real version numbers and is not just a "toss it in a contrib folder in your `PATH` and forget about it" type of script
- With some USE flag tinkering, we could make this auto-depend on `docker` or `podman` (or the recently supported [`lilipod`](https://github.com/89luca89/lilipod) written by the same author), perhaps with subpackages to create the dependency links
I very much don't like the `short_desc` here but it's what upstream provides for a description, and I can't think of a clearer, short/terse wording right now to encompass the broader usecase for the tool (for example, I don't really use any CLI tools with this thing: I'm managing Steam and Discord through it, which I launch via exported `.desktop` files and my launcher...)
---
This is a continuation of work done by another packager in #42123 earlier this year.
Resolves #36341.
A patch file from https://github.com/void-linux/void-packages/pull/47347.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-klardotsh/distrobox-47347.patch --]
[-- Type: text/x-diff, Size: 1712 bytes --]
From f0f79b72d16c84b284e79f6e60c5b258dc2b25b8 Mon Sep 17 00:00:00 2001
From: Josh Klar <josh@klar.sh>
Date: Tue, 21 Nov 2023 19:37:33 -0800
Subject: [PATCH] New package: distrobox-1.6.0.1-1
---
srcpkgs/distrobox/INSTALL.msg | 1 +
srcpkgs/distrobox/template | 24 ++++++++++++++++++++++++
2 files changed, 25 insertions(+)
create mode 100644 srcpkgs/distrobox/INSTALL.msg
create mode 100644 srcpkgs/distrobox/template
diff --git a/srcpkgs/distrobox/INSTALL.msg b/srcpkgs/distrobox/INSTALL.msg
new file mode 100644
index 0000000000000..4f970e831ea81
--- /dev/null
+++ b/srcpkgs/distrobox/INSTALL.msg
@@ -0,0 +1 @@
+Distrobox requires one of 'docker' or 'podman' to be installed.
diff --git a/srcpkgs/distrobox/template b/srcpkgs/distrobox/template
new file mode 100644
index 0000000000000..39b70b1ef2dbe
--- /dev/null
+++ b/srcpkgs/distrobox/template
@@ -0,0 +1,24 @@
+# Template file for 'distrobox'
+pkgname=distrobox
+version=1.6.0.1
+revision=1
+short_desc="Podman/Docker wrapper to use any linux distribution in your terminal"
+depends=(curl)
+maintainer="klardotsh <josh@klar.sh>"
+license="GPL-3.0-or-later"
+homepage="https://distrobox.it"
+distfiles="https://github.com/89luca89/${pkgname}/archive/${version}.tar.gz"
+checksum=d6b1330b56f6a1bf844c26a27d87f39efd8ae088ed3063f6513d48cf9c18f57e
+
+do_install() {
+ ./install --prefix "${DESTDIR}/usr"
+ vdoc docs/README.md
+ vdoc docs/compatibility.md
+ vdoc docs/featured_articles.md
+ vdoc docs/useful_tips.md
+ vdoc docs/posts/distrobox_custom.md
+ vdoc docs/posts/execute_commands_on_host.md
+ vdoc docs/posts/integrate_vscode_distrobox.md
+ vdoc docs/posts/run_latest_gnome_kde_on_distrobox.md
+ vdoc docs/posts/run_libvirt_in_distrobox.md
+}
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Updated] New package: distrobox-1.6.0.1-1
2023-11-22 3:46 [PR PATCH] New package: distrobox-1.6.0.1-1 klardotsh
2023-11-22 3:47 ` [PR PATCH] [Updated] " klardotsh
@ 2023-11-22 3:51 ` klardotsh
2023-11-28 4:17 ` [PR REVIEW] " 0x5c
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: klardotsh @ 2023-11-22 3:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 2049 bytes --]
There is an updated pull request by klardotsh against master on the void-packages repository
https://github.com/klardotsh/void-packages klardotsh/distrobox
https://github.com/void-linux/void-packages/pull/47347
New package: distrobox-1.6.0.1-1
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES** (I am currently using this `distrobox` package to manage my Discord, Zoom, and Steam containers on x86_64-musl)
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
Rationale for inclusion despite being all shell scripts:
- A reasonable, casual bystander would expect to be able to "just install distrobox", it's not intuitive to require someone who wants their container management to Just Work to have to clone a Git repo that runs a shell script to install to sometimes the homedir, sometimes `/usr/local`
- This project updates at a reasonable cadence with real version numbers and is not just a "toss it in a contrib folder in your `PATH` and forget about it" type of script
- With some USE flag tinkering, we could make this auto-depend on `docker` or `podman` (or the recently supported [`lilipod`](https://github.com/89luca89/lilipod) written by the same author), perhaps with subpackages to create the dependency links
I very much don't like the `short_desc` here but it's what upstream provides for a description, and I can't think of a clearer, short/terse wording right now to encompass the broader usecase for the tool (for example, I don't really use any CLI tools with this thing: I'm managing Steam and Discord through it, which I launch via exported `.desktop` files and my launcher...)
---
This is a continuation of work done by another packager in #42123 earlier this year.
Resolves #36341.
A patch file from https://github.com/void-linux/void-packages/pull/47347.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-klardotsh/distrobox-47347.patch --]
[-- Type: text/x-diff, Size: 1695 bytes --]
From 654c3fa1f4d606e84281dc16f48c22c8023358ee Mon Sep 17 00:00:00 2001
From: Josh Klar <josh@klar.sh>
Date: Tue, 21 Nov 2023 19:37:33 -0800
Subject: [PATCH] New package: distrobox-1.6.0.1-1
---
srcpkgs/distrobox/INSTALL.msg | 1 +
srcpkgs/distrobox/template | 23 +++++++++++++++++++++++
2 files changed, 24 insertions(+)
create mode 100644 srcpkgs/distrobox/INSTALL.msg
create mode 100644 srcpkgs/distrobox/template
diff --git a/srcpkgs/distrobox/INSTALL.msg b/srcpkgs/distrobox/INSTALL.msg
new file mode 100644
index 0000000000000..4f970e831ea81
--- /dev/null
+++ b/srcpkgs/distrobox/INSTALL.msg
@@ -0,0 +1 @@
+Distrobox requires one of 'docker' or 'podman' to be installed.
diff --git a/srcpkgs/distrobox/template b/srcpkgs/distrobox/template
new file mode 100644
index 0000000000000..377b78985c949
--- /dev/null
+++ b/srcpkgs/distrobox/template
@@ -0,0 +1,23 @@
+# Template file for 'distrobox'
+pkgname=distrobox
+version=1.6.0.1
+revision=1
+short_desc="Podman/Docker wrapper to use any linux distribution in your terminal"
+maintainer="klardotsh <josh@klar.sh>"
+license="GPL-3.0-or-later"
+homepage="https://distrobox.it"
+distfiles="https://github.com/89luca89/${pkgname}/archive/${version}.tar.gz"
+checksum=d6b1330b56f6a1bf844c26a27d87f39efd8ae088ed3063f6513d48cf9c18f57e
+
+do_install() {
+ ./install --prefix "${DESTDIR}/usr"
+ vdoc docs/README.md
+ vdoc docs/compatibility.md
+ vdoc docs/featured_articles.md
+ vdoc docs/useful_tips.md
+ vdoc docs/posts/distrobox_custom.md
+ vdoc docs/posts/execute_commands_on_host.md
+ vdoc docs/posts/integrate_vscode_distrobox.md
+ vdoc docs/posts/run_latest_gnome_kde_on_distrobox.md
+ vdoc docs/posts/run_libvirt_in_distrobox.md
+}
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] New package: distrobox-1.6.0.1-1
2023-11-22 3:46 [PR PATCH] New package: distrobox-1.6.0.1-1 klardotsh
2023-11-22 3:47 ` [PR PATCH] [Updated] " klardotsh
2023-11-22 3:51 ` klardotsh
@ 2023-11-28 4:17 ` 0x5c
2023-11-28 4:17 ` 0x5c
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: 0x5c @ 2023-11-28 4:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
New review comment by 0x5c on void-packages repository
https://github.com/void-linux/void-packages/pull/47347#discussion_r1407056577
Comment:
The policy on void for things like that is to not have an INSTALL message nor a `README.voidlinux` file, and instead rely on upstream documentation.
The install message is only for breaking changes, and the readme is only for void-specific information.
Distrobox provides clear documentation that one of these container runtimes is needed (including on the homepage), and clear [error messages](https://github.com/89luca89/distrobox/blob/main/distrobox-create#L472-L480) when none is available.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] New package: distrobox-1.6.0.1-1
2023-11-22 3:46 [PR PATCH] New package: distrobox-1.6.0.1-1 klardotsh
` (2 preceding siblings ...)
2023-11-28 4:17 ` [PR REVIEW] " 0x5c
@ 2023-11-28 4:17 ` 0x5c
2024-03-02 1:43 ` github-actions
2024-03-16 1:44 ` [PR PATCH] [Closed]: " github-actions
5 siblings, 0 replies; 7+ messages in thread
From: 0x5c @ 2023-11-28 4:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
New review comment by 0x5c on void-packages repository
https://github.com/void-linux/void-packages/pull/47347#discussion_r1407061333
Comment:
Don't use a variable for the package name in the URLs
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: New package: distrobox-1.6.0.1-1
2023-11-22 3:46 [PR PATCH] New package: distrobox-1.6.0.1-1 klardotsh
` (3 preceding siblings ...)
2023-11-28 4:17 ` 0x5c
@ 2024-03-02 1:43 ` github-actions
2024-03-16 1:44 ` [PR PATCH] [Closed]: " github-actions
5 siblings, 0 replies; 7+ messages in thread
From: github-actions @ 2024-03-02 1:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/47347#issuecomment-1974177549
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Closed]: New package: distrobox-1.6.0.1-1
2023-11-22 3:46 [PR PATCH] New package: distrobox-1.6.0.1-1 klardotsh
` (4 preceding siblings ...)
2024-03-02 1:43 ` github-actions
@ 2024-03-16 1:44 ` github-actions
5 siblings, 0 replies; 7+ messages in thread
From: github-actions @ 2024-03-16 1:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1877 bytes --]
There's a closed pull request on the void-packages repository
New package: distrobox-1.6.0.1-1
https://github.com/void-linux/void-packages/pull/47347
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES** (I am currently using this `distrobox` package to manage my Discord, Zoom, and Steam containers on x86_64-musl)
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
Rationale for inclusion despite being all shell scripts:
- A reasonable, casual bystander would expect to be able to "just install distrobox", it's not intuitive to require someone who wants their container management to Just Work to have to clone a Git repo that runs a shell script to install to sometimes the homedir, sometimes `/usr/local`
- This project updates at a reasonable cadence with real version numbers and is not just a "toss it in a contrib folder in your `PATH` and forget about it" type of script
- With some USE flag tinkering, we could make this auto-depend on `docker` or `podman` (or the recently supported [`lilipod`](https://github.com/89luca89/lilipod) written by the same author), perhaps with subpackages to create the dependency links
I very much don't like the `short_desc` here but it's what upstream provides for a description, and I can't think of a clearer, short/terse wording right now to encompass the broader usecase for the tool (for example, I don't really use any CLI tools with this thing: I'm managing Steam and Discord through it, which I launch via exported `.desktop` files and my launcher...)
---
This is a continuation of work done by another packager in #42123 earlier this year.
Resolves #36341.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-03-16 1:44 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-22 3:46 [PR PATCH] New package: distrobox-1.6.0.1-1 klardotsh
2023-11-22 3:47 ` [PR PATCH] [Updated] " klardotsh
2023-11-22 3:51 ` klardotsh
2023-11-28 4:17 ` [PR REVIEW] " 0x5c
2023-11-28 4:17 ` 0x5c
2024-03-02 1:43 ` github-actions
2024-03-16 1:44 ` [PR PATCH] [Closed]: " github-actions
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).