Re: No fsync on history file? I lost my history

[lilydjwg <lilydjwg@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

On Sun, Sep 23, 2018 at 08:02:44PM +0200, Mikael Magnusson wrote:
> Please only do this for the tmpfile case, or interactive usage is
> going to be unbearable under load with incappendhistory.

Yes, indeeded. Updated.

-- 
Best regards,
lilydjwg

[-- Attachment #2: 0001-Call-fsync-after-writing-out-new-histfile.patch --]
[-- Type: text/plain, Size: 813 bytes --]

From 19cfeacfb8338f06577ac8f1d546f5b196903d4c Mon Sep 17 00:00:00 2001
From: lilydjwg <lilydjwg@gmail.com>
Date: Sun, 23 Sep 2018 22:12:56 +0800
Subject: [PATCH] Call fsync after writing out new histfile

to ensure the data is on disk before the rename in case of a system crash.
---
 Src/hist.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Src/hist.c b/Src/hist.c
index dbdc1e4e5..64e5b4766 100644
--- a/Src/hist.c
+++ b/Src/hist.c
@@ -2933,6 +2933,12 @@ savehistfile(char *fn, int err, int writeflags)
 		lasthist.text = ztrdup(start);
 	    }
 	}
+	if (tmpfile) {
+	    if (ret >= 0)
+	        ret = fflush(out); /* need to flush before fsync */
+	    if (ret >= 0 && fsync(fileno(out)) < 0)
+	        ret = -1;
+	}
 	if (fclose(out) < 0 && ret >= 0)
 	    ret = -1;
 	if (ret >= 0) {
-- 
2.19.0