PATCH: Remove _message call from _mkdir

PATCH: Remove _message call from _mkdir

[Bart Schaefer]

On Apr 12, 10:18am, Bart Schaefer wrote:
}
} > It works perfectly with all 
} > commands but mkdir, which simply refuses to offer hidden files, ever.
} 
} Which turns out to be that _mkdir calls _message which breaks out of the
} loop over _completers in _main_complete, so the _ignored completer in your
} style is never reached.
} 
} _message really ought to be called only when there is no possibility of
} other completions being generated, not merely to suggest what ought to
} be typed at that point.


Unless someone has a better suggestion?


diff --git a/Completion/Unix/Command/_mkdir b/Completion/Unix/Command/_mkdir
index b5f7519..58d6c74 100644
--- a/Completion/Unix/Command/_mkdir
+++ b/Completion/Unix/Command/_mkdir
@@ -61,7 +61,7 @@ case "$state" in
       [[ $variant == zsh && ${#${${words[2,-1]}:#-*}} -gt 0 ]]; then
       _wanted directories expl \
         'parent directory (alternatively specify name of directory)' \
-        _path_files -/ && ret=0 || _message 'name of directory'
+        _path_files -/ && ret=0
     fi
     ;;
 esac

Re: PATCH: Remove _message call from _mkdir

[Peter Stephenson]

On Sun, 12 Apr 2015 12:46:28 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> Unless someone has a better suggestion?
> 
> diff --git a/Completion/Unix/Command/_mkdir b/Completion/Unix/Command/_mkdir
> index b5f7519..58d6c74 100644
> --- a/Completion/Unix/Command/_mkdir
> +++ b/Completion/Unix/Command/_mkdir
> @@ -61,7 +61,7 @@ case "$state" in
>        [[ $variant == zsh && ${#${${words[2,-1]}:#-*}} -gt 0 ]]; then
>        _wanted directories expl \
>          'parent directory (alternatively specify name of directory)' \
> -        _path_files -/ && ret=0 || _message 'name of directory'
> +        _path_files -/ && ret=0
>      fi
>      ;;
>  esac

I'm not really sure what that was doing there in this one case, anyway.

pws

Re: PATCH: Remove _message call from _mkdir

[Bart Schaefer]

On Apr 12,  8:54pm, Peter Stephenson wrote:
}
} >        _wanted directories expl \
} >          'parent directory (alternatively specify name of directory)' \
} > -        _path_files -/ && ret=0 || _message 'name of directory'
} 
} I'm not really sure what that was doing there in this one case, anyway.

In the event that there really are no path prefixes to complete, it is
intended to change this:

torch% mkdir
No matches for `parent directory (alternatively specify name of directory)'

Into this:

torch% mkdir
name of directory

Trouble is there's no simple way to determine on the first call to _mkdir
whether there might be other paths suggested by later completers.

Hence my other suggestion from zsh-users:

> ...  Either that or it needs some option (the inverse
> of "_message -e"?) that tells _main_complete to continue even though a
> message is pending.

This is actually not too hard, just do not set _comp_mesg=yes, though the
option parsing for _message is unnecessarily ugly.  The doc for _message
says:

     ... the resulting string will
     always be shown whether or not matches were generated.

So with _comp_mesg not set, we'd potentially end up with:

torch% mkdir
name of directory
Completing parent directory (alternatively specify name of directory)
[list of the ignored files here]