zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH 3/3] Constify two local variables.
Date: Mon, 30 Nov 2015 12:39:37 -0800	[thread overview]
Message-ID: <151130123937.ZM28961@torch.brasslantern.com> (raw)
In-Reply-To: <20151130164210.56d36bfe@pwslap01u.europe.root.pri>

On Nov 30,  4:42pm, Peter Stephenson wrote:
}
} As Bart says, setfn() expects a permanently allocated values; if it
} doesn't neeed it, it's up to the setfn in question to convert the value
} and then free what's passed in.

Thinking about it, it is quite likely that this makes it impossible to
optimize in the way Daniel wants.  At a very low level, we can't swap
values into an existing (char**) representing an array parameter.  All
the setfn() implementations would have to be updated to notice when
the pointer passed in is the same as the pointer already in the param
struct and skip the free, or something like that.


  reply	other threads:[~2015-11-30 20:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30  3:21 Daniel Shahaf
2015-11-30  9:38 ` Peter Stephenson
2015-11-30 15:59   ` Daniel Shahaf
2015-11-30 16:28     ` Bart Schaefer
2015-11-30 16:42     ` Peter Stephenson
2015-11-30 20:39       ` Bart Schaefer [this message]
2015-11-30 21:36         ` Bart Schaefer
2015-12-02  0:36         ` Daniel Shahaf
2015-12-02  1:11           ` Bart Schaefer
2015-12-03 23:37             ` Daniel Shahaf
2015-12-04  0:36               ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151130123937.ZM28961@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).